Commit Graph

9308 Commits

Author SHA1 Message Date
Jagrut Desai
a6a71d5ace Merge "Suspend immersive mode autohide while pending transient taskbar timeout" into udc-dev am: 5e9203e737 am: 72bd10ee95
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23544158

Change-Id: Ie67e22aa72f251eb608f8b7f8f4be929adc53cd3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-09 20:25:07 +00:00
Jagrut Desai
5e9203e737 Merge "Suspend immersive mode autohide while pending transient taskbar timeout" into udc-dev 2023-06-09 18:50:52 +00:00
Tony Wickham
0a074648c2 Suspend immersive mode autohide while pending transient taskbar timeout
Test: open Youtube fullscreen video, swipe up on taskbar; ensure taskbar autostashes before immersive mode autohides
Fixes: 260765455
Flag: none

Change-Id: I05c61de911f1bf326962d84c4f7c3e12135f23cf
2023-06-09 10:08:45 -07:00
Sunny Goyal
6e1e11bb5c Merge "Fising launcher stuck on blur" into udc-dev am: ef6fbb5be8 am: 81b856468e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23621509

Change-Id: I5eb5546f2df74bf236b70b38ed3e0f8d032faf6d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-09 07:39:16 +00:00
Sunny Goyal
ef6fbb5be8 Merge "Fising launcher stuck on blur" into udc-dev 2023-06-09 06:07:31 +00:00
Jon Miranda
cc51c84a46 Merge "Update taskbar paddings/sizes to match spec." into udc-dev am: 10b3e64d51 am: b6e38fb23f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23597945

Change-Id: Ib7fa92acf0049fae35b9dbb1c5b2676dc204556a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-09 01:33:29 +00:00
Jon Miranda
10b3e64d51 Merge "Update taskbar paddings/sizes to match spec." into udc-dev 2023-06-08 23:55:06 +00:00
Ats Jenk
5ed3a64974 Merge "Remove obsolete todo" into udc-qpr-dev 2023-06-08 22:42:52 +00:00
Andy Wickham
e769a86dc5 Merge "Enable returning to the previous app after Overview -> All Apps." into udc-qpr-dev 2023-06-08 22:22:06 +00:00
Sunny Goyal
521c2a038b Fising launcher stuck on blur
The same surface can become invalid, in which case we need to wait
until the next draw to apply blur

Bug: 284411563
Test: Verified on device
Change-Id: Ifb6be94756fd00c5925e11a6b7d57f206e063a17
2023-06-08 13:18:34 -07:00
TreeHugger Robot
435ab92b46 Merge "Check pendingIntent for intent fullscreen launch type" into udc-dev am: a11802c486 am: 7d17d40b2c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23571512

Change-Id: I76dbd4b0c33f382f7967007a4b8fe016280d8d29
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-08 19:51:02 +00:00
TreeHugger Robot
8b6758e009 Merge "Fix null-pointer in AbsSwipeUpHandler.buildAnimationController" into udc-dev am: 737c7f21ec am: 0f8401c721
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23603592

Change-Id: Id12062a8e38a150644a0420c58ebbb0a009fe28d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-08 19:50:57 +00:00
Schneider Victor-tulias
1c7f97916e Merge "Fix layout issues in suw all set page" into udc-dev am: 8ee4ad6604 am: 32a14e59bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23502666

Change-Id: I0896653b0faaf647c850be3a8af9bb34b80ddb5d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-08 19:50:37 +00:00
TreeHugger Robot
a11802c486 Merge "Check pendingIntent for intent fullscreen launch type" into udc-dev 2023-06-08 18:48:55 +00:00
TreeHugger Robot
737c7f21ec Merge "Fix null-pointer in AbsSwipeUpHandler.buildAnimationController" into udc-dev 2023-06-08 18:42:53 +00:00
Vinit Nayak
f05d39ca4d Merge "Include assistant in RemoteTargetGluer" into udc-dev am: 76ad67a07a am: 229d56ae95
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23574112

Change-Id: I9781b90ed4f310bd6bd0ef25a6cbdccfd42b89ee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-08 18:23:00 +00:00
Randy Pfohl
d5e938af10 Merge "Cleaning up liveview in overview while returning home for visual fix" into udc-dev am: f2d46812f8 am: 95a6047a84
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23595177

Change-Id: I9f75c6b7a3edf6798efbe7302f17edf1d9643839
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-08 18:22:37 +00:00
Schneider Victor-tulias
8ee4ad6604 Merge "Fix layout issues in suw all set page" into udc-dev 2023-06-08 18:15:34 +00:00
Vinit Nayak
76ad67a07a Merge "Include assistant in RemoteTargetGluer" into udc-dev 2023-06-08 16:54:31 +00:00
Randy Pfohl
f2d46812f8 Merge "Cleaning up liveview in overview while returning home for visual fix" into udc-dev 2023-06-08 16:48:36 +00:00
Liran Binyamin
42076f4645 Merge "Crash fix in BubbleStachedHandleViewController." into udc-qpr-dev 2023-06-08 16:24:06 +00:00
Jagrut Desai
a8aefb6e14 Merge "Remove Hotseat Education from Large Screens" into udc-dev am: 0704595a99 am: c457d85fec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590297

Change-Id: Ic1c06094e140e8e6e1aaf6fafd1bde84f8c31281
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-08 00:31:12 +00:00
randypfohl
680b8de0c9 Cleaning up liveview in overview while returning home for visual fix
Test: built and tested locally, verified bug doesn't occur during 3 button nav nor gesture nav animations. video in bug.

Bug: 245750127
Change-Id: I6e52722e73ff64e81686ee2ef3f7b2f7f5b1daa9
2023-06-07 23:55:41 +00:00
Ats Jenk
9f79d35ce2 Remove obsolete todo
Removing the todo. We may explore adding a desktop tile to alt+tab
quickswitch at some point in the future. But the design is not final
yet.

Flag: not requred, removing comment
Bug: 280468885
Test: m -j
Change-Id: I2c5293b336c6ba5ba8656bccc9439697dfcbbd27
2023-06-07 15:56:48 -07:00
Treehugger Robot
936722a71f Merge "Adds an overflow bubble to the bubble bar." into udc-qpr-dev 2023-06-07 22:09:31 +00:00
Sunny Goyal
cda1842e7a Merge "Removing all usage of LauncherProvider" into udc-qpr-dev 2023-06-07 22:03:48 +00:00
Vadim Tryshev
544dff52af Merge "Switch ScrimView to use view alpha" into udc-qpr-dev 2023-06-07 21:47:59 +00:00
Sunny Goyal
7b9e28f152 Removing all usage of LauncherProvider
Also fixing a race condition in model when an item update/delete task
gets queued and executed after the model has reloaded (making the old
data obsolete)

Bug: 277345535
Bug: 263079498
Test: Presubmit
Flag: N/A
Change-Id: Ibd4bdbb3eece05b38b73a22a4be5f368df3754f0
2023-06-07 12:57:13 -07:00
Treehugger Robot
9c9764c28b Merge "Moved TISBinder lifecycle handling to TISBinderHelper" into udc-qpr-dev 2023-06-07 19:37:13 +00:00
Vinit Nayak
5fa247fd43 Include assistant in RemoteTargetGluer
* The UI isn't terribly great, but this fixes the crashes

Bug: 285781761
Change-Id: Ie3376a98b16c19bbdb4e39e7a0a436ddae200c4a
2023-06-07 12:05:00 -07:00
Schneider Victor-tulias
19d085107a Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851 am: 396bb7c262
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: Ifd444206ac34ba591bf2f6033bf6961fadb5425f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 18:21:17 +00:00
Jon Miranda
95f4472ba9 Update taskbar paddings/sizes to match spec.
Bug: 282798528
Test: manual with screenshots
Change-Id: I00c646d9cd11a9015e14f8311ba2ff233d8321ac
2023-06-07 11:19:50 -07:00
Jagrut Desai
d94017474f Remove Hotseat Education from Large Screens
Currently there is an taskbar icon unstashing animation that happens on top of hotseat education. Hotseat education is redudunt for large screens(Tablets, Foldable-unfolded). To solve this we will remove this reduntdant feature for large screens

Test: Manual
Bug: 282617747
Flag: not needed
Change-Id: Ia5e2c51f7ef927a59cb6efa195c1cdfc627205d9
2023-06-07 10:52:39 -07:00
Schneider Victor-tulias
1834581bc0 Fix null-pointer in AbsSwipeUpHandler.buildAnimationController
Flag: not needed
Fixes: 271248485
Test: ran launcher
Change-Id: Ia9e0e68b9ee9273d82ed791b421a10ccb1fcdef2
2023-06-07 10:39:25 -07:00
Ats Jenk
71f6dbece4 Merge "Dismiss all task ids from TaskView" into udc-qpr-dev 2023-06-07 17:17:42 +00:00
Schneider Victor-tulias
871d7fc351 Moved TISBinder lifecycle handling to TISBinderHelper
- All instances where we used TISBinder will now use TISBinderHelper#getBinder. This will allow TISBinderHelper to handle its lifecycle
- Moved all instance of TaskbarManager and OverviewCommandHelper as well since TIS and TISBinder handle their lifecycles
- Cleaning up launcher instance from TaskbarManager when TISBinder is being destroyed

Flag: not needed
Bug: 283490010
Test: ran launcher and performed gestures
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:248794e698417b1156bf911adb31682186fe2e34)
Change-Id: I8415a6b2c1dba0776e7c0e1ee32ad3c683100bde
2023-06-07 17:15:18 +00:00
Schneider Victor-tulias
bfa0fae851 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev 2023-06-07 16:49:20 +00:00
Liran Binyamin
2f1b547a4b Crash fix in BubbleStachedHandleViewController.
Switching between gesture nav and 3 button nav may lead to a state where
the RegionSamplingHelper is unexpectedly null.

Bug: 269670598
Test: In Settings switch navigation modes until launcher crashes.
Change-Id: I56d6eea81070f367db292c1ded9866452f6e2650
2023-06-07 11:55:02 -04:00
Andy Wickham
adce95394e Enable returning to the previous app after Overview -> All Apps.
Back gesture from All Apps (history for state):
If previous state was background, use quick switch state to return
to the previous app.

Swipe down from All Apps:
Return to previous state (which will be Normal or Quick Switch).

This animates from All Apps overview scale/translation to full
screen of the previous task. In this case we are animating from
0.5x Overview scale and 0 translation (centered).

Video: https://drive.google.com/file/d/1cpQjtFemtJ4zu9aWu7IiUftWWVGFrbtM/view?usp=drive_link&resourcekey=0-1zuMEvYNsk81YBxv8o10hA

Note: This is mostly for the gesture/state handling but it would
be nice to polish this transition in the future.

Bug: 283336332
Test: Manual
Flag: ENABLE_ALL_APPS_FROM_OVERVIEW
Change-Id: Iec92df933ce6522f181d3d5ca889b6a6469f4cc6
2023-06-06 17:13:59 -07:00
Ats Jenk
7a48f57043 Dismiss all task ids from TaskView
In recents we were hardcoding that only two task ids can be dismissed
when dismissing a TaskView. Update the logic to dismiss arbitrary
number of task ids that are returned from TaskView.

Fixes task dismissal logic for desktop where there can be more than 2
tasks represented by one taskview.

Flag: not needed, trivial change
Bug: 280830106
Test: Add chrome, files and calculator to desktop. Dismiss the desktop
  tile with 3 apps from overview. Open youtube and move it to desktop.
  Observe that desktop only contains youtube. None of the 3 previous
  apps are added back.
Test: Move 2 apps to split screen, dismiss the split tile from overview.
  Observe both apps are dismissed.
Test: Dismiss a single app from overview.
Change-Id: I139943f5d678d63f449116de26debae9be122b21
2023-06-06 22:38:39 +00:00
Fengjiang Li
7d6a8b1c3a Merge "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test" into udc-dev am: 3dca7b3c6a am: 69a9a4cd52
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23300979

Change-Id: If1ffa619e26ab7b76d6e0b946bcd29d121cd7219
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 19:43:54 +00:00
Fengjiang Li
3dca7b3c6a Merge "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test" into udc-dev 2023-06-06 18:19:38 +00:00
Schneider Victor-tulias
ab51f2110a Add null-check to findLastActiveTaskAndRunCallback
ItemInfo.getTargetComponent is nullable, so we can't always create a ComponentKey. Added a null-check and proper creation of ComponentKeys

Flag: not needed
Fixes: 286053950
Test: started and completed splitscreen selection from home, taskbar and overview
Change-Id: Ifa30f194ae064fab8aad79c5116f8c859dfd8cf1
2023-06-06 11:02:09 -07:00
Ats Jenk
826b28d703 Merge "Animate in desktop app select toast" into udc-qpr-dev 2023-06-06 16:49:27 +00:00
Schneider Victor-tulias
b5c7086323 Fix layout issues in suw all set page
putting contents of the suw all set page in a scroll view to fix layout issues in large display/font sizes

Flag: not needed
Fixes: 275018092
Test: launched all set page on smallest and largest display/font sizes on handheld, tablet and foldable
Change-Id: I921b1becfc0627e9b77e467efe309613aa3ca9d0
2023-06-06 09:42:36 -07:00
TreeHugger Robot
8704476235 Merge "Don't allow Taskbar unstash during Assistant gesture" into udc-dev am: e2a6113e93 am: 39748f8883
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23565985

Change-Id: I26e34597aa96c2eb304ef40404b4492faf7f1074
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 03:03:33 +00:00
TreeHugger Robot
9bf69ea28d Merge "Prevent initiating split with task excluded from recents" into udc-dev am: 0d3edbfeb6 am: 4418ade8ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23495351

Change-Id: Ib86e56e308adf538911531dc8296d2d0dd865c9e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 00:27:11 +00:00
Ats Jenk
a37f3f2c2c Animate in desktop app select toast
Add an animation for the desktop app select toast.
Played when the toast is added to the screen.

Bug: 261234402
Test: have an app on desktop, swipe up to home, verify that the toast
  has an appear animation, per the spec
Test: when toast is visible, tap on cancel button, observe toast fades
  out
Test: when toast is visible, launch an app, verify toast fades out
Change-Id: I593d6c326d6d638f1bc06e8c6add31b0244e4cb5
2023-06-05 16:39:29 -07:00
Tony Wickham
97bada6339 Don't allow Taskbar unstash during Assistant gesture
Test: manual with "swipe to invoke assistant" enabled
Flag: none
Fixes: 282060498
Change-Id: I317d01dbbb59d020338b17d424c853a00ef03cce
2023-06-05 23:23:40 +00:00
TreeHugger Robot
859d0d87e2 Merge "Simplifying some test utility methods" into udc-qpr-dev 2023-06-05 23:10:06 +00:00