Commit Graph

552 Commits

Author SHA1 Message Date
Thales Lima
3a6193517d Fix TaskView cropping for transient taskbar
TaskView clipping is not necessary anymore because task in Overview will always be the same aspect ratio as the app when in fullscreen.

Fix: 268211636
Test: manual trigger of Overview (landscape, portrait, split screen)
Change-Id: Ib4faeda6f0cccef3b23fcbacb89c6d2832c0df59
Merged-In: Ib4faeda6f0cccef3b23fcbacb89c6d2832c0df59
2023-03-09 20:24:53 +00:00
TreeHugger Robot
d8478f7019 Merge "Revert "Create TAPL test suite for splitscreen"" into tm-qpr-dev am: 19c0877745 am: 9fbd4b9c4e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21806280

Change-Id: I91f799236b02142e2a9c94ef56105bbd20e669f3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 20:57:24 +00:00
TreeHugger Robot
19c0877745 Merge "Revert "Create TAPL test suite for splitscreen"" into tm-qpr-dev 2023-03-08 20:04:50 +00:00
Jeremy Sim
6d506a8622 Merge "Create TAPL test suite for splitscreen" into tm-qpr-dev am: ad9bdcfd2d am: 2a81b79a3c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21221178

Change-Id: I5dc5ccacaddfbe437ff44dd067ba8127b2fb7e40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 03:19:44 +00:00
Vinit Nayak
313a44039f Revert "Create TAPL test suite for splitscreen"
This reverts commit 03815e6c79.

Reason for revert: b/271852893

Change-Id: I165a15b29e41ce1114f6b7d92d22cdd8e0dfb5b0
2023-03-06 23:47:20 +00:00
Jeremy Sim
ad9bdcfd2d Merge "Create TAPL test suite for splitscreen" into tm-qpr-dev 2023-03-04 01:10:47 +00:00
Jeremy Sim
03815e6c79 Create TAPL test suite for splitscreen
This patch creates a new file, TaplTestsSplitscreen.java, containing one TAPL test sequence.

testSplitAppFromHomeWithItself() tests the user flow of splitting from home using an app that is already running, and then selecting the app itself again as a split target from the Taskbar. The expected result is that Launcher shows an error message gracefully and does not crash.

Fixes: 267554450
Test: Ran test file locally and verified that it passes.
Change-Id: I98a1e3a4143d10a6572175711059b3a77aa5dcd0
2023-03-02 16:35:54 -08:00
Jeremy Sim
86e4f02035 Merge "Fix bug with Taskbar not differentiating between user profiles" into tm-qpr-dev am: 24b1890c4b am: 0027186ea2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21566360

Change-Id: Ic90db4ff687565109c3644cede0f7c50f9f66f4a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-02 04:10:00 +00:00
Fengjiang Li
0785970ae6 Merge "[Predictive Back] Turn on feature for udc" into udc-dev 2023-03-01 20:56:53 +00:00
Jeremy Sim
e35d112693 Fix bug with Taskbar not differentiating between user profiles
This patch fixes a bug where Taskbar would not differentiate between user profiles when selecting an app to launch from Overview.

The bug occurred because findLastActiveTaskAndRunCallback(), which checks for already-running tasks when launching an app from the Taskbar, only checks for a ComponentName match and not a userId match.

Fixed by making the findLastActiveTaskAndRunCallback() also check for a userId match.

Fixes: 270456926
Test: Manual
Change-Id: I43ff06083a5dce775fdbd0b0ed951beaae34c0ab
2023-03-01 10:57:41 -08:00
Fengjiang Li
f533ff350c [Predictive Back] Turn on feature for udc
Add feature flag and turn it on for U

Test: manual
Bug: b/264920023
Change-Id: I43d9c04b13b91ce0b0e53402a5c3b2f0e81272ff
2023-03-01 18:41:32 +00:00
Jordan Demeulenaere
51132f7f86 Format files with the upcoming version of ktfmt am: be82bc661c am: 652ec4997a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21565649

Change-Id: I06342a9bb4b91dd00196b76dec1dd2daaf4ee2e4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-01 15:55:10 +00:00
Jordan Demeulenaere
be82bc661c Format files with the upcoming version of ktfmt
This CL was generated automatically from the following command:

$ external/ktfmt/prepare_upgrade.py --repo=packages/apps/Launcher3/ --build_id=9645412 --bug_id=266197805

This CL formats all files already correctly formatted with the upcoming
version of ktfmt.

Bug: 266197805
Test: Presubmits
Change-Id: Ide7d63a75fed98aabe348821355356c77f00a9ec
Merged-In: Ide7d63a75fed98aabe348821355356c77f00a9ec
2023-03-01 09:11:48 +00:00
Alibek Manabayev
e2f33d2f38 Merge "Extend tests to check Transient Taskbar Autohide" into tm-qpr-dev am: 4424f6636e am: b60e6b0e60
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21445185

Change-Id: I882804ff6a06c7e64c872bf4c2fdc91180664bd2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-24 15:54:27 +00:00
Alibek Manabayev
3b61863ba8 Extend tests to check Transient Taskbar Autohide
Bug: 260589084
Test: ab/I67000010134246487 on local device

Change-Id: Iad141fcbac54770810009e41082ab583cc3d260e
2023-02-23 14:26:44 +00:00
Vinit Nayak
26016622c1 Merge "Refactor SplitSelectStateController to add testing" into tm-qpr-dev am: c9120521ff am: 2fea4c6f1b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21487925

Change-Id: I418fa47df9af8c94a31d3c30124c96cc78e6d758
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-23 00:53:05 +00:00
Vinit Nayak
4e3636e8d0 Refactor SplitSelectStateController to add testing
Bug: 266482558
Change-Id: I2d62a3a310043710d66a26bc533df2309084b81e
2023-02-22 10:51:49 -08:00
Vinit Nayak
ec5759b509 Merge "Add overview taskbar split support for 3P launcher" into tm-qpr-dev am: 0a9056502b am: 5c64c1dcb7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21311163

Change-Id: I1a3433b8b327abf466f0149a8747a67a01c799f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-16 02:25:03 +00:00
Vinit Nayak
0a9056502b Merge "Add overview taskbar split support for 3P launcher" into tm-qpr-dev 2023-02-16 00:33:46 +00:00
Vinit Nayak
f4e7e5aaf4 Add overview taskbar split support for 3P launcher
* Created b/268120202 to track other states of split
selection that are unhandled on 3P launchers

Test: Able to initiate split in overview with 3P launcher
Fixes: 264576761
Change-Id: I0311fe83380bf914fa79956b2565b61cc5eab916
2023-02-15 11:26:06 -08:00
Schneider Victor-tulias
79855e7cb8 Merge "Add the KeyboardQuickSwitchView (2/2)" into tm-qpr-dev am: 25656568e3 am: 74ffb0ba89
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21087436

Change-Id: Ie6f0b30af20e5905fc10105bbf2fcf8a0db028b0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-15 06:15:48 +00:00
Schneider Victor-tulias
de7ceba80b Add the KeyboardQuickSwitchView (2/2)
Adding KeyboardQuickSwitchView and associated flows.

Test: Manually tested alt-tab and alt-shift-tab in and out of overview on a tablet and phone
Bug: 258854035
Change-Id: Ifb48b005067b3a9c66acfd5ecdbae144b359d3be
2023-02-14 13:34:37 -08:00
Thales Lima
bb056c6001 Merge "Create an XML parser for WorkspaceSpecs" into tm-qpr-dev am: 5d5aad3024 am: 0ebaf3a46c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20643018

Change-Id: I471bb3ccd04a0598a309e53038976fbccb638ce1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-09 13:01:28 +00:00
Thales Lima
5d5aad3024 Merge "Create an XML parser for WorkspaceSpecs" into tm-qpr-dev 2023-02-09 11:19:59 +00:00
Jeremy Sim
c1237eb5e8 Merge "Improve resilience of testSplitFromOverview()" into tm-qpr-dev am: 5c5797d9bb am: b340f1401f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21314098

Change-Id: Ib1c5502717e5b956f65bdd6385655a211db51863
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-09 05:09:34 +00:00
Thales Lima
1a2d4bd6f4 Create an XML parser for WorkspaceSpecs
Extract DeviceProfileTest to Launcher3 so it can be used in other tests as well, and change name of previous base test to be more descriptive.

Bug: 241386436
Test: WorkspaceSpecsTest
Change-Id: I64613bb5a23c374ed15fb6d936192236a541ab9b
2023-02-08 11:20:14 +00:00
Jeremy Sim
5edd864c8d Improve resilience of testSplitFromOverview()
This patch makes it so that TaplTestsQuickstep#testSplitFromOverview() is less flaky.

Previously, this test worked by tapping the center of a Overview tile to confirm split select. However, sometimes the tile would be halfway offscreen, so it would accidentally tap an overlapping UI element (the staged first app) instead, causing the test to fail.

Fixed by using getCurrentTask() to always select an Overview tile that is fully onscreen.

Fixes: 267794149
Test: Manual on phone, confirmed test passing
Change-Id: I8b89509bb53a16e45aea4545562989e2e964de2d
2023-02-07 13:47:47 +08:00
Pat Manning
39ed8eecfd Merge "Make showing back for bouncer only rely on back disable status, not home and recents as well." into tm-qpr-dev am: f667823a8e am: 23aa4f8022
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21136526

Change-Id: Iec722d8821b90e3cb7021ba7d0a8d4076782f88a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-31 22:13:26 +00:00
Pat Manning
f667823a8e Merge "Make showing back for bouncer only rely on back disable status, not home and recents as well." into tm-qpr-dev 2023-01-31 21:13:46 +00:00
Pat Manning
7462c2ab62 Make showing back for bouncer only rely on back disable status, not home and recents as well.
Fix: 260655218
Test: manual. Create second user, switch to three button nav, set lockscreen password, lock and show IME on lockscreen.
Change-Id: I1d874196afc24d5bae86d525a81ae199152fc750
2023-01-31 14:57:26 +00:00
Schneider Victor-tulias
360f6d0130 Merge "Revert "Revert^2 "Cancel gestures on launcher destroy""" into tm-qpr-dev am: 7d346bf90b am: 030ba11d8c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21100567

Change-Id: Ib3d7981a93d9647a3599df12e8093d31941550fa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-30 22:45:51 +00:00
Schneider Victor-tulias
7d346bf90b Merge "Revert "Revert^2 "Cancel gestures on launcher destroy""" into tm-qpr-dev 2023-01-30 21:39:50 +00:00
Schneider Victor-tulias
ece659d11a Revert "Revert^2 "Cancel gestures on launcher destroy""
This reverts commit 377eb40985.

Reason for revert: failing tests
Fixes: 266606727
Fixes: 266621449

Change-Id: I61094be02fb73c5ad65ee65be5ed93a3364f37ef
2023-01-27 14:38:19 -08:00
Jon Miranda
55dd83a3d6 Merge "Split taskbar test methods by persistent/transient" into tm-qpr-dev am: 6f53364c14 am: bcf6b13ac5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21120291

Change-Id: I6be4f5deb9511e03a9e7dac1bb3de0147d6e3b5f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-27 22:21:36 +00:00
Jon Miranda
6f53364c14 Merge "Split taskbar test methods by persistent/transient" into tm-qpr-dev 2023-01-27 21:27:01 +00:00
Jon Miranda
7acd32cf16 Split taskbar test methods by persistent/transient
Test: TaplTestsTaskbar
Bug: 266861780
Change-Id: I0fc0ef58aa4bc087248ab223c4716992bc0cd692
2023-01-26 16:08:23 -08:00
Evan Rosky
1d2abb366d Merge "Revert^8 "Enable Shell Transitions"" 2023-01-25 00:08:16 +00:00
Schneider Victor-tulias
cd09b276c5 Merge "Revert^2 "Cancel gestures on launcher destroy"" into tm-qpr-dev am: 74484f4a99 am: 86fbe3c7ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20680308

Change-Id: I8c6e5b7431631ce5577dc6ba8435d607fc3bc883
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 19:32:52 +00:00
Schneider Victor-tulias
74484f4a99 Merge "Revert^2 "Cancel gestures on launcher destroy"" into tm-qpr-dev 2023-01-24 17:55:54 +00:00
TreeHugger Robot
2cd37fb6fe Merge "Implement initial transient Taskbar EDU tooltips." into tm-qpr-dev am: 654f714718 am: 4d7e4c4a8e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20795522

Change-Id: I70307a411262909945f44e7e3b58ff721ccc10d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-21 09:02:06 +00:00
Evan Rosky
e0cfbc3475 Revert^8 "Enable Shell Transitions"
d9cc7d1eb1

Change-Id: Ic59c027f05e47eb9939c0c65d19892451fd4ae50
2023-01-21 02:20:39 +00:00
Evan Rosky
feedb575b8 Merge "Revert^7 "Enable Shell Transitions"" 2023-01-21 02:18:16 +00:00
Brian Isganitis
b21ad2da8c Implement initial transient Taskbar EDU tooltips.
Since this tooltip looks and behaves differently than the existing EDU
sheet, it has its own view and controller implementations (I also may
have wanted to write some Kotlin).

To keep transient taskbar open while on the second EDU step, another
autohide suspend flag is defined. Additionally, special casing is added
to avoid hiding transient taskbar if autohiding is currently suspended.

Tooltips use the same assets as the bottom sheet for now, and are scaled
down to fit the tooltip dimensions.

Reset `Taskbar Education` in Developer Options to try EDU again.

[Demos]
- First: https://screenshot.googleplex.com/ASBeGvrb2EA5wEF.png
- Second: https://screenshot.googleplex.com/7fnfcTh9bMYezDc.png

Test: Manual
Test: Open app, see swipe-up tooltip.
Test: Swipe up to show transient taskbar, see features tooltip.
Bug: 263157739
Fix: 258460203
Change-Id: I473f5fccbae279db0614763b640da0a120b6b7f7
2023-01-20 15:16:12 -08:00
Evan Rosky
d9cc7d1eb1 Revert^7 "Enable Shell Transitions"
039217e518

Change-Id: Id82874ee3c209bb024b131b4a427eba25a84cd20
2023-01-20 23:14:47 +00:00
Evan Rosky
f805d1ee93 Merge "Revert^6 "Enable Shell Transitions"" 2023-01-20 18:27:11 +00:00
Vinit Nayak
1b6c2b7f54 Merge "Add unit tests for TaskbarKeyguardController" into tm-qpr-dev am: 8d98dd2905 am: b069336a7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21021735

Change-Id: I7591a0a13b438998abfaf84d8c647dd56a92f2a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-20 01:16:11 +00:00
Vinit Nayak
b1c47227b1 Add unit tests for TaskbarKeyguardController
* Remove setting back button tint for SUW as that
is now done in ag/20953768

Bug: 230027385
Change-Id: I2c157ed67487cab9ba721fa659973351780509bb
2023-01-18 10:42:45 -08:00
Christophe Pinelli
2acf5a8492 Merge "Make mutable PendingIntent explicit" into tm-qpr-dev am: 3cd6cbe6b4 am: ab2c2d9576
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953789

Change-Id: Iafef3bf70a5dfb0c5a72bf814d23d952cfd7f2f9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 20:02:04 +00:00
Christophe Pinelli
9d46bca1b9 Make mutable PendingIntent explicit
Starting from target SDK U, we will block creation of mutable
PendingIntents with implicit Intents because attackers can mutate the
Intent object within and launch altered behavior on behalf of victim
apps. For more details on the vulnerability, see go/pendingintent-rca.

From a quick analysis, we concluded that the PendingIntent here was only
destined to the test app/to the app, so it was made explicit. Reviewers,
please call out if this is not the case.

Bug: 236704164
Test: atest NexusLauncherTests:com.android.quickstep.DigitalWellBeingToastTest
Test: atest RequestPinItemTest
Change-Id: I81311b0588b7b712c97de6cb016a62bb91c7a77c
2023-01-12 01:51:44 +00:00
Thales Lima
bdfc07f1f0 Merge "Check kotlin format before uploading" into tm-qpr-dev 2023-01-10 16:41:58 +00:00