Commit Graph

9941 Commits

Author SHA1 Message Date
Brian Isganitis
a5cdbe5d4e Merge "Fix Taskbar AllApps touch interception when above EDU." into main 2023-09-28 21:17:55 +00:00
Jagrut Desai
f39c5099a8 Gesture Error Detection - Improvements Part 3
- Adding Gesture Event to log when detected invalid velocity in AbsSwipeUpHandler.

Bug: 288462574
Test: Presubmit
Flag: not needed
Change-Id: I5656e2eaaba3b2ae6c2143cb2a5752c106f5fd6f
2023-09-27 18:55:57 -07:00
Jagrut Desai
257b5cade6 Merge "Gesture Error Detection - Improvements Part 2" into main 2023-09-28 01:52:06 +00:00
Helen Cheuk
5ab9a57ec0 Merge "Fixed delay of thumbnail loading when going to overview from home" into main 2023-09-27 20:29:00 +00:00
Jagrut Desai
883ea7c72b Gesture Error Detection - Improvements Part 2
- Adding gesture error detection for ON_START_RECENTS_ANIMATION for to be getting callabck within time limit.

Bug: 293379641
Bug: 290266108
Test: Presubmit
Flag: not needed
Change-Id: I7d0f70c55dc44749218ff8d8427e71cd512d083c
2023-09-27 13:24:09 -07:00
Holly Jiuyu Sun
01088a4001 Merge "Log toggle status for LPNH and LPH in Settings." into udc-qpr-dev am: 6c3cd3c092 am: 564a0acda7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24856663

Change-Id: I0ec7ee12bf09f7b7902915c28e22b5e923f5ac55
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-27 19:44:28 +00:00
Holly Jiuyu Sun
564a0acda7 Merge "Log toggle status for LPNH and LPH in Settings." into udc-qpr-dev am: 6c3cd3c092
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24856663

Change-Id: If4a73bc64242feec4786705603c5c128fc2cecba
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-27 17:49:29 +00:00
Holly Jiuyu Sun
6c3cd3c092 Merge "Log toggle status for LPNH and LPH in Settings." into udc-qpr-dev 2023-09-27 16:05:41 +00:00
helencheuk
9e142d3998 Fixed delay of thumbnail loading when going to overview from home
Some thumbnail snapshots show up slowly when GRID_ONLY_OVERVIEW is enabled because more thumbnails are displayed than before and some cache related code needs to be changed. This issue should be fixed for smooth user experience so all thumbnails could be shown quickly and at the same time.
Root causes and corresponding solution are as below:
1. No high resolution thumbnails are in cache when entering overview. It is either no cache at all or just low resolution cache
Solution: Preload when high resolution is enabled
2. The cache size is 3 which is not enough for tablet
Solution: Update cache size to 8 when it is tablet, and preload more if cache size increases. Remove least recent ones when cache size decreases

Fix: 271570416
Test: RecentsModelTest
Test: TaskKeyByLastActiveTimeCache
Test: TaskThumbnailCacheTest
Change-Id: I60003ca20942c256a0a1047678ea4368cd2520eb
2023-09-27 16:57:27 +01:00
Liran Binyamin
44bd688301 Merge "Let the bubble bar handle gestures over the bubble bar." into main 2023-09-27 15:39:16 +00:00
Tracy Zhou
aa366d03cd Merge "Fix wrong 3 button order in landscape mode sometimes" into main 2023-09-26 23:58:47 +00:00
Ats Jenk
a54772832b Merge "Animate launching desktop from overview" into main 2023-09-26 23:20:46 +00:00
Brandon Dayauon
cd460094ba Merge "Do a vertical check for two line text, if it clips dont show two line." into main 2023-09-26 22:16:37 +00:00
Ats Jenk
a24b63d644 Animate launching desktop from overview
Create a new controller that handles launching desktop from recents. It
creates a remote transition runner. Then notifies wmshell to show
desktop apps and use this remote runner to run the animation.

TODO:
- there are flickers in the animation

Bug: 297590571
Test: open an app on desktop, swipe up to overview, click on desktop
      tile
      open multiple apps on desktop, swipe up to overview, click on
      desktop tile

Change-Id: Ie8c9189bace77ba80e6be90222b3f786dfe5bb15
2023-09-26 10:39:49 -07:00
Schneider Victor-tulias
eaa495a864 Remove string concatenation uses with ActiveGestureLog
Flag: ENABLE_LONG_PRESS_NAV_HANDLE
Bug: 301953713
Test: checked logs
Change-Id: Id5c3bdf170fdb56305c585f1c34ec9a5310256b8
2023-09-26 16:12:32 +00:00
Liran Binyamin
d7f1942d4a Let the bubble bar handle gestures over the bubble bar.
This change introduces a motion event flag to signal that the gesture
is being originated over the bubble bar (similar to the nav bar gesture flag). Downstream consumers use this flag to ignore the event in order
to allow the bubble bar to handle it.

The black screen in b/293348900 seemed to be related to the recents
shell transition closing the app that was in the foreground before
swiping on the bubble bar handle. Not sure why it ended up with a black
screen, but this change avoids starting the recents transition entirely.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/BSxLROoflr1i2yy0v6Y4G

Fixes: 294421126
Bug: 293348900
Test: Manual:
      - Add bubble to the bubble bar
      - Swipe up over the bubble bar
      - Observe that the bubble bar expands

      - Launch application
      - Swipe up on the bubble bar handle
      - Observe that the bubble bar expands

Change-Id: Iea15829de97edb6bfbfb7007388865230faaf736
2023-09-26 12:02:27 -04:00
Brandon Dayauon
3cdb32cc1f Do a vertical check for two line text, if it clips dont show two line.
Added extra 16dp to the cell height in DeviceProfile as per spec: https://docs.google.com/presentation/d/1dSt-zY_wRrOmd9a9nsQG458CIK0RUqVJsHJxLHP_0Nc/edit#slide=id.g237e909075a_2_6
Updated tests andincluded vertical check to see if two line can be fully rendered without being clipped. Otherwise just show one line.
Since existing cell height is 104dp, we add 16dp to be up to spec (120dp)
- Clean up FeatureFlag ENABLE_TWOLINE_ALLAPPS and now use aconfig flag

bug: 270390937
Test: manually - photos
Regular font: https://screenshot.googleplex.com/ArUcgZgHqR4ZWBQ
Bigger font than regular that makes text to one line because it wouldve truncate: https://screenshot.googleplex.com/6s8EdMAbBLsYhLi
Bigger font than regular with predicted app row (twoline):
https://screenshot.googleplex.com/38TEQei5GvPiCc7
Super big font: https://screenshot.googleplex.com/3JUYYprJRQ32Hsq
big display and regular font: https://screenshot.googleplex.com/55rBKVQ8htSe9Vc
big display and bigger than regular font: https://screenshot.googleplex.com/3atzKzJUbfM7YQW
flag: is off

Change-Id: I6998ea5da35d3e00ac75327d16b5ca676fb11c1a
2023-09-26 02:38:16 +00:00
Andy Wickham
136bdf80b3 Merge "Add some gesture logs" into udc-qpr-dev am: 66072ca559 am: c18764fce1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24755061

Change-Id: I02949308dda86a905029fdcc21dcfb80dd91e3b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-26 01:27:39 +00:00
Holly Sun
e292642489 Log toggle status for LPNH and LPH in Settings.
Bug: 295039461
Test: manual
Flag: PRESS_HOLD_NAV_HANDLE_TO_SEARCH. LONG_PRESS_HOME_BUTTON_TO_SEARCH
Change-Id: I380dd6f62378098edf063f29d10305b8c404f38d
2023-09-26 00:36:44 +00:00
Andy Wickham
c18764fce1 Merge "Add some gesture logs" into udc-qpr-dev am: 66072ca559
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24755061

Change-Id: Iabb40a2aaf81ac23121ec356b55c012da92348a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-26 00:31:56 +00:00
Andy Wickham
66072ca559 Merge "Add some gesture logs" into udc-qpr-dev 2023-09-25 23:54:20 +00:00
Jagrut Desai
adf9c428db Merge "Adding gesture error detection to RecentsAnimationCallback" into main 2023-09-25 17:03:34 +00:00
Becky Qiu
42a06b0476 [Omnient] Creates an AOSP AssistStateManager to dump in TouchInteractionService in AOSP. am: 86b6a887d1 am: f545328f56
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24828699

Change-Id: Ic62100a1f4ca6aa2a0a0c1a1962cedff070f7e70
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-23 07:45:25 +00:00
Becky Qiu
f545328f56 [Omnient] Creates an AOSP AssistStateManager to dump in TouchInteractionService in AOSP. am: 86b6a887d1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24828699

Change-Id: Ifd35410d27765efc7896dac8e002ce3f1690a8c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-23 06:48:19 +00:00
Becky Qiu
86b6a887d1 [Omnient] Creates an AOSP AssistStateManager to dump in TouchInteractionService in AOSP.
Bug: 300101221
Test: manually tested dump, see the NL change for samples.
Flag: INVOKE_OMNI_LPH, DISABLED; ENABLE_LONG_PRESS_NAV_HANDLE, TEAMFOOD.
Change-Id: I1fb03779775cd0c9353abd4f796e9cc7c42f0f96
2023-09-23 02:29:54 +00:00
Brian Isganitis
4749dc8db1 Fix Taskbar AllApps touch interception when above EDU.
Test: Manual
Fix: 301643091
Flag: No
Change-Id: I804031a0cfc4620b39551fb5badab7ac7008fb5f
2023-09-22 16:45:17 -04:00
Felix Stern
c4edad6814 Merge "Use stashedTaskbarHeight for IME insets override" into udc-qpr-dev am: 795dc83c72 am: db1028ea85
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24834321

Change-Id: I69f30281881fc6ec5631f0ec3b5495434567ed2a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 19:06:08 +00:00
Schneider Victor-tulias
5fc26f3861 Merge "Update KeyboardQuickSwitch for TAPL testing" into main 2023-09-22 18:26:48 +00:00
Felix Stern
db1028ea85 Merge "Use stashedTaskbarHeight for IME insets override" into udc-qpr-dev am: 795dc83c72
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24834321

Change-Id: Iec4d3327d606cf5d607b8b68d7c640e737199d72
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 18:07:44 +00:00
Felix Stern
795dc83c72 Merge "Use stashedTaskbarHeight for IME insets override" into udc-qpr-dev 2023-09-22 17:04:19 +00:00
Jagrut Desai
3a3bf97518 Adding gesture error detection to RecentsAnimationCallback
Bug: 289600801
Bug: 285636175
Bug: 290266108
Test: Presubmit
Flag: not needed
Change-Id: I16ec3347b273ba80eadd766dccdcf012bc0872ae
2023-09-22 10:01:13 -07:00
Brandon Dayauon
8e24505d09 Merge "Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW" into udc-qpr-dev am: 28ae77df37 am: f9a203c586
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24724750

Change-Id: I4e955f635773b5084b315282d373b16cff6988e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 16:22:21 +00:00
Brandon Dayauon
f9a203c586 Merge "Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW" into udc-qpr-dev am: 28ae77df37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24724750

Change-Id: Ibbefedc8e85690aa7a389b0e106476d56d0d768b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 15:25:17 +00:00
Schneider Victor-tulias
e95326dfdd Update KeyboardQuickSwitch for TAPL testing
- Added a res id to KeyboardQuickSwitchView for TAPL testing
- Updated KeyboardQuickSwitch focus and scroll initialization
- Logging KeyEvents for TAPL testing
- Updated scrolling logic to wait for initial layout
- Fixed activity leak in KeyboardQuickSwitchViewController

Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Bug: 267520665
Test: TaplTestsKeyboardQuickSwitch
Change-Id: I1d45d948c0e185504d994f7ef1d34f173c2243a9
2023-09-22 11:04:43 -04:00
Brandon Dayauon
28ae77df37 Merge "Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW" into udc-qpr-dev 2023-09-22 14:36:45 +00:00
Cosmin Băieș
df2ceac06c Use stashedTaskbarHeight for IME insets override
Previously [1] we removed the explicit insetsSizeOverride from the
Taskbar for the IME window, as we now [2] enable hiding the IME nav bar.
This would now send the normal insets the taskbar reports. When running
on pre/postsubmit, with test harness setup, the non-transient taskbar
would show, which is bigger than the IME's navigation bar height.

Due to the current logic in InsetsSource#calculateInsets, this leads to
the IME window receiving top navigation bar insets instead of bottom.
As the IME nav bar is now treated as a (fixed on bottom) caption bar,
the two would no longer overlap, and thus lead to a double insets
dispatch, and also a (temporarily) bigger IME window, for IMEs that set
their decorView height to WRAP_CONTENT (e.g. MockIME used in testing).

This instead keeps the previous insetsSizeOverride for IME, and uses the
stashedTasbarHeight when in gesture nav, which should account for both
transient and normal taskbars.

 [1]: I86079cb6670a2ae3b6fa883694f8af81df212408
 [2]: I8793db69fb846046300d5a56b3b0060138ef4cd5

Bug: 297000797
Test: atest WindowInsetsControllerTests#testDispatchApplyWindowInsetsCount_ime
Change-Id: I102a8bc1f8869ebbce9f8f1fefa651d49a9538ec
2023-09-22 14:16:03 +00:00
Jeremy Sim
dcb6f5736e Merge "Request split launches using a new enum, snapPosition, rather than a float splitRatio" into main 2023-09-21 23:50:38 +00:00
Andy Wickham
3582efc2f1 Merge "Adds SystemActionConstants" into main 2023-09-21 22:31:10 +00:00
Garfield Tan
21e8204798 Merge "Show freeform button only when dev option is on" into main 2023-09-21 21:54:15 +00:00
Jeremy Sim
da230cf526 Request split launches using a new enum, snapPosition, rather than a float splitRatio
Split ratios are now stored as an int enum rather than float values. Previously, split ratios were stored as floats, which needed to be recalculated frequently and differed depending on device screen size. Now Shell to store and launch split screen setups using an enum rather than floats.

Bug: 274835596
Bug: 182839788
Test: Existing tests still pass
Change-Id: Iebb8d3c7e8f9d597a59b677e48072300ddea458f
2023-09-21 11:34:07 -07:00
randypfohl
2cf90775d7 Setting recentsView orientation to match recents activity orientation am: 03d29305ca am: 1c76ccfd6c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24804147

Change-Id: I408f74745a6f4e5714f6ef54857982c9cfc56066
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-21 17:47:45 +00:00
randypfohl
1c76ccfd6c Setting recentsView orientation to match recents activity orientation am: 03d29305ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24804147

Change-Id: I12f07376447009d58ee7519b9cd7433ac544191a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-21 16:51:04 +00:00
Schneider Victor-tulias
195fc85d73 Merge "Add error detection for missing recent tasks list in SystemUiProxy" into main 2023-09-21 14:48:34 +00:00
Mady Mellor
b604e71fe8 Merge "Fix bubbles taskbar scrim showing when notification panel is shown" into main 2023-09-21 01:25:07 +00:00
Garfield Tan
d4018909e3 Show freeform button only when dev option is on
Now some Android tablets have desktop mode, which shouldn't be
entered by clicking the freeform button in Overview. Therefore still
keep it hidden when the device claims the support of freeform window
management, but the user didn't enable the freeform dev options
explicitly.

This button should also be hidden when desktop mode is enabled.

Bug: 299362754
Test: The button is hidden when the dev option is disabled.
Change-Id: Id919af4fd1a027da0bb335c4c4b7303d15d689f8
2023-09-20 18:05:20 -07:00
Randy Pfohl
bd585e4d42 Merge "Remove logs for bug investigation" into main 2023-09-20 23:14:33 +00:00
randypfohl
03d29305ca Setting recentsView orientation to match recents activity orientation
Test: can no longer repro incorrect orientation when launching apps from all apps
      added logs to verify recents activity -> view were the same while rotating
      turned off auto rotate and verified state matched

Bug: 288984663
Bug: 301024104

Change-Id: I7fc3b47bff0a99756aaf877bf634e2d162838d6f
2023-09-20 15:04:55 -07:00
Brandon Dayauon
47000ae6e6 Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW
- Create another icon, "all_apps_predicted_row_icon" that will be the mDisplay for the predicted app row
in AllAppsList

Bug:299171695
Test: video
Before: https://drive.google.com/file/d/1HxNW0015nQHCc7eQiySf-gwsHrLs_JjR/view?usp=sharing
after: https://drive.google.com/file/d/1HyEwKI-yumILTCjglKcqovhTlRVjNGxg/view?usp=sharing - making sure that QL is fine and dragging regular Toast results are normal
Flag: N/a
Change-Id: Ie002cacb168396dbea39f79679bd6a04b80e374b
2023-09-20 14:21:10 -07:00
Treehugger Robot
e745dda409 Merge "Use default taskbar stash duration when opening/closing all apps from taskbar." into main 2023-09-20 17:54:36 +00:00
Schneider Victor-tulias
c6d3ea678f Add error detection for missing recent tasks list in SystemUiProxy
There are ways for launcher to lose the recent tasks reference, in which case SystemUiProxy will quietly fail to start the recents activity.

Flag: not needed
Fixes: 301257750
Test: programmatically forced the error condition and checked the logs
Change-Id: I1cad6a3dfd2605f275672d1dcd8c83bdb965d73f
2023-09-20 15:46:00 +00:00