aixan/lawnchair
1
0
Fork 0
mirror of https://github.com/LawnchairLauncher/lawnchair.git synced 2026-03-03 09:26:51 +00:00
Code Issues Packages Projects Releases Wiki Activity
71,408 Commits 36 Branches 1,370 Tags
a366e454d303bae23924d4309b35c0b7ec00e9b1
Commit Graph

17016 Commits

Author SHA1 Message Date
Andy Wickham
43da2dc409 Merge "Add tests for LPH override for 3 button mode Taskbar." into udc-qpr-dev am: 3289e4fa35 am: 294a40b1be 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24607784

Change-Id: Id8ba2e642aad256612f21e6026adbf5c2e756123
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-08 23:49:12 +00:00
Brian Isganitis
648d917a29 Merge "Add All Apps search icon variant behind flag." into main 2023-09-08 23:39:23 +00:00
Vinit Nayak
7f184f82ac Merge "Ignore non-running app-pair tests" into main 2023-09-08 22:42:49 +00:00
Vinit Nayak
8e0e56475a Ignore non-running app-pair tests 
* For reasons unclear, having these tests enabled cause
a memory leak even though they are flag guarded
Need to investigate further.
* For now disable to get tests back to green

Bug: 297135374
Test: Passes locally
Change-Id: I0f1a6abbd0bd6c0f6d8823ac8d6c72d49837121b
 2023-09-08 11:46:07 -07:00
Andy Wickham
294a40b1be Merge "Add tests for LPH override for 3 button mode Taskbar." into udc-qpr-dev am: 3289e4fa35 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24607784

Change-Id: I87cd79905c5febcd0391d75b9756522ad3d1ba34
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-08 16:44:53 +00:00
Brian Isganitis
46cabfebdc Register OnAttachStateChangeListener before attaching to container. am: 503f04f86d am: a62d85752e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24681979

Change-Id: I18e1ee9b5c46affdf90f3fbbb9327db4bbe178e2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-07 23:44:35 +00:00
Andy Wickham
3289e4fa35 Merge "Add tests for LPH override for 3 button mode Taskbar." into udc-qpr-dev 2023-09-07 23:43:42 +00:00
Bill Yi
1c38d648c8 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-qpr-dev 2023-09-07 22:56:08 +00:00
Brian Isganitis
a62d85752e Register OnAttachStateChangeListener before attaching to container. am: 503f04f86d 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24681979

Change-Id: Iae9abea705e1f379cb605ed286de6ee4e6df8168
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-07 22:54:25 +00:00
Brian Isganitis
503f04f86d Register OnAttachStateChangeListener before attaching to container. 
If we do the reverse, there is a change onAttach will occur before the
callback is registered and invokable (e.g. overlay window already exists
for EDU).

Test: Manual
Fix: 299335210
Flag: None
Change-Id: Ic4befe900c9582e1b01c2bc4699b431f95efa617
 2023-09-07 19:15:10 +00:00
Brian Isganitis
0b9c0589b7 Add All Apps search icon variant behind flag. 
Bug: 265170176
Test: https://b.corp.google.com/issues/265170176#comment15
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I0f5fa4fbbab687d92435d299656b9c27d93525b4
 2023-09-07 18:29:46 +00:00
Vinit Nayak
e6747e4caa Merge "Revert "Revert "Revert "Hold WeakReference to split callback"""" into main 2023-09-07 18:29:40 +00:00
Vinit Nayak
8248585a0c Revert "Revert "Revert "Hold WeakReference to split callback""" 
This reverts commit bb9fe16254.

Reason for revert: b/299403672

Change-Id: I8107bc69c033cb70333d5920cfee0700fe1f63a6
 2023-09-07 18:15:17 +00:00
Brian Isganitis
c9420c3561 Merge "Close IME on Taskbar drag." into main 2023-09-07 17:41:51 +00:00
Schneider Victor-tulias
f573abadb7 Merge "Add error handling to prevent IllegalArgumentException" into main 2023-09-07 16:03:17 +00:00
Bill Yi
fce9627f8b Import translations. DO NOT MERGE ANYWHERE 
Auto-generated-cl: translation import
Change-Id: I98ba3bc9e380b26b739f8ff7f8ba8f33df4a92fc
 2023-09-07 04:01:55 -07:00
Vinit Nayak
6fe9c3e555 Merge "Revert "Revert "Hold WeakReference to split callback""" into main 2023-09-07 04:55:33 +00:00
Sebastián Franco
8a21ec65e4 Merge "Moving TaplTestsLauncher3 to it's own class" into main 2023-09-06 23:27:33 +00:00
Brian Isganitis
1219d69625 Close IME on Taskbar drag. 
Matches LauncherDragController#startDrag impl.

Test: Manual
Fix: 299167809
Flag: No
Change-Id: If6552b0c9cf7bfcdd01f1802eaf895bde4f357d8
 2023-09-06 22:06:54 +00:00
Sebastian Franco
1a02891d66 Moving TaplTestsLauncher3 to it's own class 
Bug: 298234173
Test: atest TAPLOpenCloseAllApps
Change-Id: If827c5962e258ec5fe930b0d71e183e0191f2b11
 2023-09-06 13:29:02 -07:00
Jagrut Desai
cd667ed4ad Clear TaskbarDividerPopupView callback upon closing 
- Breakout CL part 4
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist of clearing callbacks after calling close once, so that we don't run into scenario where user is able to close popup multiple times leading to crash.

Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: Ie4cd95c69a559a17b7c19a64a71ccf6ac20542d7
 2023-09-06 17:53:34 +00:00
Schneider Victor-tulias
df3043aa46 Merge "Revert "Add screen recording to flaky test"" into main 2023-09-06 15:09:35 +00:00
Brandon Dayauon
cc9a529293 Merge "Add nullable annotation" into udc-qpr-dev am: 31679166a7 am: b33d906d87 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24544468

Change-Id: I21f2072984d2620a0012180ea8ef0ffc1f78c110
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-05 18:59:17 +00:00
Brandon Dayauon
b33d906d87 Merge "Add nullable annotation" into udc-qpr-dev am: 31679166a7 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24544468

Change-Id: Ifd6ac159f610f6a9a3a0f409778a6084f411949f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-05 18:09:33 +00:00
Brandon Dayauon
31679166a7 Merge "Add nullable annotation" into udc-qpr-dev 2023-09-05 16:50:38 +00:00
Schneider Victor-tulias
0fb4b268e5 Add error handling to prevent IllegalArgumentException 
ActivityLaunchAnimator.Controller.fromView requires an instance of LaunchableView, however findViewWithBackground had no checks to return one. updated the check to make the exception less likely.

Flag: not needed
Fixes: 297564681
Test: ran launcher and launched apps
Change-Id: Iddbe55c1ff66b067f8456d058cbc60a2a698c4ae
 2023-09-05 13:57:11 +00:00
Schneider Victor-tulias
a96f29e28d Revert "Add screen recording to flaky test" 
This reverts commit 543857f496.

Reason for revert: closing b/242163205
Fixes: 242163205

Change-Id: Ia1279984f58366051101d650d095ae1e4a632654
 2023-09-05 13:53:23 +00:00
Saumya Prakash
53b19f1b6a Merge "Ensure Gesture Nav Edu animation scales to fit different screen sizes" into udc-qpr-dev am: 15b0c9ea54 am: a2c965726e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24623620

Change-Id: Ice6431407e0a6cf6f69eb9440f79c38badbcaa81
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-02 01:44:51 +00:00
Sunny Goyal
175ad05a06 Merge "Fixes broken callbacks in RecentsAnimationCallbacks" into udc-qpr-dev am: a6f089c5fc am: aee84be4b6 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24589979

Change-Id: I7139b62fe6985e407880966c434d621da3af508c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-02 01:43:11 +00:00
Saumya Prakash
a2c965726e Merge "Ensure Gesture Nav Edu animation scales to fit different screen sizes" into udc-qpr-dev am: 15b0c9ea54 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24623620

Change-Id: I76dcb5ab590f458fdebb2b171e3faf58d7d919f7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-02 00:48:43 +00:00
Sunny Goyal
aee84be4b6 Merge "Fixes broken callbacks in RecentsAnimationCallbacks" into udc-qpr-dev am: a6f089c5fc 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24589979

Change-Id: I790f16e73181bd299e9e229401015784588bd245
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-02 00:48:15 +00:00
Tony Wickham
7bbc5a3c01 Merge "Update TaskView corner radius dynamically" into udc-qpr-dev am: 2677e04510 am: 0eb2b24d68 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24627246

Change-Id: Ib3fb4c43fd651a017746e2ff8cff17dec3eab057
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-02 00:04:10 +00:00
Saumya Prakash
15b0c9ea54 Merge "Ensure Gesture Nav Edu animation scales to fit different screen sizes" into udc-qpr-dev 2023-09-01 23:49:30 +00:00
Sunny Goyal
a6f089c5fc Merge "Fixes broken callbacks in RecentsAnimationCallbacks" into udc-qpr-dev 2023-09-01 23:46:02 +00:00
Tony Wickham
0eb2b24d68 Merge "Update TaskView corner radius dynamically" into udc-qpr-dev am: 2677e04510 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24627246

Change-Id: I59ba22e210e592dff73e0a1ac73b6fba4762e610
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-09-01 23:05:41 +00:00
Ats Jenk
6ea1072a15 Merge "Update scale logic for desktop tasks in recents animation" into main 2023-09-01 22:50:16 +00:00
Tony Wickham
2677e04510 Merge "Update TaskView corner radius dynamically" into udc-qpr-dev 2023-09-01 22:41:18 +00:00
Treehugger Robot
1c14e5e80b Merge "Removing unused screen records" into udc-qpr-dev am: 4c735b9b94 am: 42b325c808 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24612767

Change-Id: I015903edfddb95b22d7b0acd1f5a9e896c7222df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-31 23:52:54 +00:00
Saumya Prakash
3ca10a1325 Ensure Gesture Nav Edu animation scales to fit different screen sizes 
The lottie animation in the gesture nav tutorial wasn't scaling correctly for certain devices
leading to gaps around the animation. This change uses animation's scale transformation to ensure it fits the
dimensions of the device.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 295809541
Test: Went through the tutorial on different types of devices and ensure
the animation takes up the entire screen.

Change-Id: Iadee0d0389a11aa38c9e947b4b40466acd8f4422
 2023-08-31 23:08:54 +00:00
Treehugger Robot
42b325c808 Merge "Removing unused screen records" into udc-qpr-dev am: 4c735b9b94 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24612767

Change-Id: Id5eaf1d38bef85aeebdfbd684a7564724a89a0f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-31 23:00:46 +00:00
Tony Wickham
5d20ad6500 Update TaskView corner radius dynamically 
Previously we set the corner radius just once when TaskView is
constructed, but this doesn't work when reusing the TaskView on a
different display that has a different corner radius.

Flag: none
Test: FullScreenDrawParamsTest
Test: kill launcher, open Overview on one display, then switch to
another display with different corner radii and ensure task radii
have updated while quick switching
Fixes: 293224095

Change-Id: I5f0697a4697400ec0e003c116774d74a945ee59e
 2023-08-31 22:41:53 +00:00
Treehugger Robot
4c735b9b94 Merge "Removing unused screen records" into udc-qpr-dev 2023-08-31 22:15:26 +00:00
Brandon Dayauon
75d8994e6f Add nullable annotation 
It looks like from the stack trace that there is an NPE during the setApps() call. So adding nullable and null checking
to make sure mApps is not null.

bug: 296920692
test: presubmit
flag: n/a
Change-Id: If402c0b68db159f7a698e8e2e139d9bd5041b1c1
 2023-08-31 13:59:13 -07:00
Alex Chau
d9e3b8e254 Merge "Revert "Add detailed exception for snappedIndex == -1 when dismissing tasks"" into main 2023-08-31 16:50:34 +00:00
Fengjiang Li
f096f3ebe3 Merge "Fix memory leak of Launcher activityfrom QuickstepTransitionManager and LauncherBackAnimationController" into main 2023-08-31 16:11:39 +00:00
Charlie Anderson
d48f89be9d Merge "Remove ENABLE_MATERIAL_U_POPUP flag and cleanup dead code" into main 2023-08-31 15:09:25 +00:00
Fengjiang Li
e180de6b20 Fix memory leak of Launcher activityfrom QuickstepTransitionManager and LauncherBackAnimationController 
We should also avoid using non-static inner class that extends IOnBackInvokedCallback.Stub and IRemoteAnimationRunner.Stub inside LauncherBackAnimationController, which references the entire LauncherBackAnimationController object.

1. When launcher is created, a Runnable is posted to ShellExecutor to call BackAnimationController#registerAnimation
2. When launcher is later destroyed, another Runnable is posted to same ShellExecturo to call BackAnimationController#unregisterAnimation
3. If the execturo queued the 1st runnable, then we have leaked LauncherBackAnimationController object, including Launcher activity.

This CL fixes the leak by making the Stub static inner classes, and use weak reference hold reference to launcher activity.

Bug: 297806573
Test: Grab a heap dump and this reference no longer exist
Flag: N/A
Change-Id: I78853e900a98399b02682ba2d9179e544a4030d5
 2023-08-30 23:43:20 -07:00
Vadim Tryshev
f7193e1469 Removing unused screen records 
Bug: 187761685, 195673272
Test: presubmit
Flag: N/A
Change-Id: I87711d246660d917cf7e09ac4ffd714149563e52
 2023-08-31 02:00:28 +00:00
Jeremy Sim
29428d406e Merge "Add a fail string for app pair menu tests" into main 2023-08-30 23:29:40 +00:00
Saumya Prakash
a698652981 Merge "Remove extraneous transition from Overview to Home screen" into udc-qpr-dev am: dbd47e9f75 am: e5b09cd7f1 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24587641

Change-Id: I6c3c15584cf07e88748e020356bcf1fed30c9314
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-30 23:27:26 +00:00