Commit Graph

18321 Commits

Author SHA1 Message Date
Shamali Patwa
b257ac4289 Merge "Fix close animation issue during predictive back / swipe up" into main 2024-05-07 18:07:28 +00:00
Schneider Victor-tulias
c6c8a22daf Merge "Add debug logs for b/319168409" into main 2024-05-07 13:56:56 +00:00
Shamali P
ac5c6c775b Fix close animation issue during predictive back / swipe up
Bug: 333714698
Test: Manual
Flag: N/A
Change-Id: I07859bc0a3783356cc27358bb23a0d6555aa1492
2024-05-07 13:47:24 +00:00
Shamali Patwa
4f8ef8f54b Merge "Readjust the available size for the recommendations in 2-pane sheet" into main 2024-05-06 22:53:19 +00:00
Brandon Dayauon
9fa457e876 Merge "Update private space animation timings" into main 2024-05-06 18:15:05 +00:00
Schneider Victor-tulias
8288819aa6 Add debug logs for b/319168409
Flag: N/A
Bug: 319168409
Test: TaplDragTest#testDragAppIcon

Change-Id: I96d26cc78af0a3f4145fc3486c4b6adfbd110c9e
2024-05-06 16:22:03 +00:00
Shamali P
c0e4dcf238 Readjust the available size for the recommendations in 2-pane sheet
Now that we exclude the space taken by size string and description,
offsetting the size provided to the recommendation table to keep the
widgets within non-scrollable view as much possible.

Bug: N/A
Test: Screenshot
Flag: N/A

Change-Id: I0193cd1ba5de0b0ff98dab9aeb352264afd3ff3a
2024-05-06 15:50:42 +00:00
Charlie Anderson
496198ac4a Merge "Fixes padding for app icons in Launcher preview for Foldable devices in unfolded state." into main 2024-05-03 18:46:00 +00:00
Charlie Anderson
0920311107 Fixes padding for app icons in Launcher preview for Foldable devices in unfolded state.
Also adds unit tests for the padding.

Bug: 332566064
Test: manually verify
Flag: N/A
Change-Id: Ic9227086b4025b4f266f2f2305159f032c21556b
2024-05-03 16:07:24 +00:00
Holly Jiuyu Sun
6b85675657 Merge "[reset] Clean up ActivityAllAppsContainerView#reset." into main 2024-05-03 00:49:26 +00:00
Anushree Ganjam
c1adbe3b4b Merge "Revert "When AllAppsSearchBarController's mInput edit text focus is false, we should hidekeyboard."" into main 2024-05-03 00:34:32 +00:00
Willie Koomson
a6f1bd55d4 Merge changes from topic "update-widget-font" into main
* changes:
  Fix resize frame corner radius for widgets added with button
  Hide add button text if cell is too narrow
  Update font settings to match POR
2024-05-02 23:07:40 +00:00
Holly Sun
d7b532afcb [reset] Clean up ActivityAllAppsContainerView#reset.
Digged into the history of this part, some code is duplicated and thus removed. See https://docs.google.com/document/d/1mp1HwLhkLE_o0o_InhntFz3oIGsg94b9XucAal0IgOE/edit?tab=t.0#bookmark=id.130cyqeojzrk

ag/24198780 introduced the `MAIN_EXECUTOR.getHandler().post` part, which is still needed for logging purpose.

Bug: 328505782
Test: manual
Flag: NA
Change-Id: Ie7622c497b803f722fd734d30c4c3d9692d152c6
2024-05-02 15:38:49 -07:00
Anushree Ganjam
bc2acdaf5c Revert "When AllAppsSearchBarController's mInput edit text focus is false, we should hidekeyboard."
This reverts commit d169cb3667.

Reason for revert: Probably causes jank regression. See b/336280300 for details.

Bug: b/336280300

Change-Id: I82918a33b04c58f0778d584d57e418d7dbb1e672
2024-05-02 22:29:15 +00:00
Willie Koomson
14c321de31 Fix resize frame corner radius for widgets added with button
Before this CL, the resize frame showed a mismatched corner radius
for widgets that have a non-default corner radius, when using the
add button. This is because widgets added with the button may not have
had `onLayout` called before the resize frame is set up.

This change adds a layout listener to the widget view, so that the frame
can set its corner radius once the view has been laid out.

Bug: none
Test: manual test
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: Ia9c37ae595be48e4ecab7930e17efca9a27ed05d
2024-05-02 19:55:41 +00:00
Willie Koomson
1156e8419a Hide add button text if cell is too narrow
If the WidgetCell is not wide enough, hide the add button text and show
an icon-only plus button.

Bug: 333735974
Test: manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: Ieb0b2e679bd4a5785a0f7f01e177ad412a355ce7
2024-05-02 19:55:41 +00:00
Willie Koomson
61dc97ecb2 Update font settings to match POR
Updates font color, size, weight, and line height for text in the widget
picker to match POR and pass a11y test.

Bug: 317948371
Flag: NONE
Test: Accessibility Scanner contrast test
Change-Id: I3c7676c507b81a616876206681972ebb9fefd0c3
2024-05-02 19:55:33 +00:00
Treehugger Robot
03cd176277 Merge "Add support for animating non-running tasks" into main 2024-05-02 18:24:56 +00:00
Sunny Goyal
93221e00a5 Merge "Converting ModelTask to an interface instead of an abstract class" into main 2024-05-02 17:41:09 +00:00
Sunny Goyal
f4b51c603f Merge "Fixing StatsLogger not getting activityContext" into main 2024-05-02 17:36:21 +00:00
Jagrut Desai
0fd34b783c Merge "Taskbar in Desktop Windowing Mode" into main 2024-05-01 22:49:48 +00:00
Sunny Goyal
993893895c Converting ModelTask to an interface instead of an abstract class
This allows extensibility and better use of lambdas

Bug: 338282246
Test: Presubmit
Flag: None

Change-Id: Ia41067f0068b3b631eeb4faf877dc77f8587e1f6
2024-05-01 15:43:26 -07:00
Schneider Victor-tulias
65ae550a92 Add support for animating non-running tasks
It is possible to animate a non-running task to home mid-quick switch, which was not properly supported, causing a janky animation. Added custom animations to handle this more smoothly.

Flag:  ACONFIG com.android.launcher3.enable_additional_home_animations DISABLED
Fixes: 237638627
Test: swipe to home mid-quick switch on handheld/large screen in portrait/landscape from an app present/missing on the workscape in RTL/LTR
Change-Id: I89c9cf1ed1c0b88ff6c3ce71a663cb16e69d5843
2024-05-01 20:06:34 +00:00
Sunny Goyal
a5438a3cfc Fixing StatsLogger not getting activityContext
Bug: 338254085
Test: Verified on device
Flag: None
Change-Id: I5a821a89df80ce43b73092db43af3dd8d53d81f4
2024-05-01 12:59:58 -07:00
Brandon Dayauon
ecc04b9f39 Update private space animation timings
The entire animation is 800ms where there are differences between lock/unlock.
Unlock 1.0:
   app Opacity: time = 400 -> 800ms Linear
   text opacity: time = 500 -> 800ms Linear
   settingsAndLockGroup "size": time = 400 -> 800ms Standard
   settingsGear: time = 400 -> 800ms Linear
Lock 2.0:
   app Opacity: time = 0 -> 400ms Linear
   text opacity: time = 0 -> 50ms Linear
   settingsAndLockGroup "size": time = 0 -> 400ms Standard
   settingsGear: time = 0 -> 400 Linear

bug:299294792
Test manually video:
after: https://drive.google.com/file/d/1_Y5I7vQhDHPX8DLM_rSM3mV9DrVN0v-q/view?usp=sharing
after 10x: https://drive.google.com/file/d/1_WLz2ijLs19qE1vYA9zdXF9YZB_CqMns/view?usp=sharing

Flag: aconfig com.android.launcher3.enable_private_space nextfood
Change-Id: I8a578e70bb834f403075824785fa9b4d8825858c
2024-05-01 11:48:50 -07:00
Alex Chau
6a44889c99 Merge "Add additional StateManager log to track cancelAnimation" into main 2024-05-01 18:26:20 +00:00
Jagrut Desai
2e8ca87c21 Taskbar in Desktop Windowing Mode
Test: presubmit
Bug: 330146462
Flag: NONE
Change-Id: Ib33f90704c3010df6a52e2a1c420960b11dbd0d4
2024-05-01 09:29:24 -07:00
Alex Chau
d840e6270b Add additional StateManager log to track cancelAnimation
Bug: 325463989
Test: Manual
Flag: NONE
Change-Id: I4f9eb13eb460e0bae0582992d18b8b81250f8eaa
2024-05-01 15:08:42 +01:00
Holly Jiuyu Sun
2737373f6e Merge "[reset] Remove redundant calls in resetAndScrollToPrivateSpaceHeader." into main 2024-04-30 21:20:39 +00:00
Holly Jiuyu Sun
477d70f92e Merge "[reset] Call SearchUiManager#resetSearch instead of reset." into main 2024-04-30 21:20:22 +00:00
Sunny Goyal
15949163a6 Merge "Removing disabled color extractor from Widgets" into main 2024-04-30 03:51:37 +00:00
Federico Baron
c113ce9f9f Merge "Migrate smartspace as a widget and smartspace removal toggle flags to aconfig" into main 2024-04-29 21:46:03 +00:00
Fengjiang Li
dd2b47350e Merge "[Launcher Jank] Avoid lock contention on AssetManager in all apps preinflate thread" into main 2024-04-29 17:05:36 +00:00
Gustav Sennton
56f9df0620 Merge "[Desktop Mode] Show indicators under Taskbar app icons for running apps" into main 2024-04-29 08:28:28 +00:00
Fengjiang Li
b2d0845a29 [Launcher Jank] Avoid lock contention on AssetManager in all apps preinflate thread
Create a separate context with a separate AssetManager obj.

Bug: 337056120
Flag: NONE
Test: presubmit
Change-Id: Ic6765f7f19b649605aec6a889f8382ee10f929b0
2024-04-29 04:43:25 +00:00
Sunny Goyal
277ef4868c Removing disabled color extractor from Widgets
Bug: 266941872
Flag: None
Test: Presubmit (removed dead code)
Change-Id: Ie45cf08c694652266af6c95dab0eac5b9dd138f6
2024-04-26 15:46:04 -07:00
Holly Sun
7bb9247bf6 [reset] Call SearchUiManager#resetSearch instead of reset.
This is a follow-up of ag/26362927.
When it's in searching state, we only need to reset search instead of resetting everything.

Test: search something and scroll in AA+. Trigger AA+ by filing an intent (adb shell am start -n com.google.android.apps.nexuslauncher/.NexusLauncherActivity -a android.intent.action.ALL_APPS). Notice the search RV is reset and scroll to top.
Bug: 328505782
Flag: aconfig com.android.launcher3.enable_private_space nextfood
Change-Id: I9d1d4386077433a676c1f3b8e3614fb848284a88
2024-04-26 14:25:16 -07:00
Willie Koomson
21379bfbbc Merge "Remove widget education tip dialog" into main 2024-04-26 20:23:21 +00:00
Holly Sun
4e203b2826 [reset] Remove redundant calls in resetAndScrollToPrivateSpaceHeader.
1. When a user clicks a PS tile, fast scrolling is already end.
2. When a user clicks a PS tile, it should be in the search RV, so no need to handle header.
3. We need the `animateToSearchState` with 0 time because the one inside `resetSearch` with 300ms delay will conflict with the following scrolling to bottom. When `resetSearch` is called after `animateToSearchState(0)` finishes, the inside `animateToSearchState(300)` is just a no-op and return early, so we won't have redundant call.

Bug: 328505782
Test: manual
Flag: aconfig com.google.android.apps.nexuslauncher.enable_inject_private_space_tile nextfood
Change-Id: Ied9f96c276c8f7707c672425bebe81e72e0d3bae
2024-04-26 11:41:50 -07:00
Holly Jiuyu Sun
782d506330 Merge "[a11y] Change all apps screen name to All Apps instead of reusing Home." into main 2024-04-26 18:28:29 +00:00
Willie Koomson
5fb9b1595e Merge "Fix Add button animations" into main 2024-04-26 18:24:13 +00:00
Treehugger Robot
d62a3aefc0 Merge "Converting IconShape to mainThreadInitializedObject instead of keeping it a process static" into main 2024-04-26 16:17:52 +00:00
Gustav Sennton
52a8b7e24b [Desktop Mode] Show indicators under Taskbar app icons for running apps
In Desktop Mode we show running Desktop apps in the Taskbar. With this
change we also show an indicator under the app icon for each such
running app.

Bug: 332504528
Test: manual
Test: DesktopTaskbarRunningAppsControllerTest
Flag: ACONFIG com.android.window.flags.Flags.enableDesktopWindowingTaskbarRunningApps DEVELOPMENT
Change-Id: If0906dab8ad0bd8a78d93a4e99db47550e763bed
2024-04-26 15:29:00 +00:00
Willie Koomson
d731ba2ff1 Remove widget education tip dialog
This change removes the widget education tip dialog, and the arrow
tip view. These are no longer needed now that taps are handled by
showing an add button.

Bug: 335318980
Test: `pm clear com.google.android.apps.nexuslauncher` and open widget
 picker
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: I9b24a41604880f5f94939c02b94f1a9f6a6c83d5
2024-04-25 22:56:36 +00:00
Sunny Goyal
638a687fc8 Converting IconShape to mainThreadInitializedObject instead of
keeping it a process static

Bug: 297950111
Flag: None
Test: Presubmit
Change-Id: Id66100e0cb300659c6017c287eb38ab04290477b
2024-04-25 15:56:30 -07:00
Holly Sun
47b9cb8436 [a11y] Change all apps screen name to All Apps instead of reusing Home.
Now even when we enter the All Apps page, talkback still reads the page name as Home (https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=586;drc=120838b04dcaf072704c6fb382ea9115672cfcaa).

Bug: 330470894
Bug: 333833220
Test: manual
Flag: NA
Change-Id: I32a1ce8844cd111c7d1c492ee0a39fec47858a47
2024-04-25 15:13:41 -07:00
fbaron
9d08e0fe70 Migrate smartspace as a widget and smartspace removal toggle flags to aconfig
Bug: 336823684, 336823681
Test: none
Flag: ACONFIG enable_smartspace_as_a_widget DISABLED
Flag: ACONFIG enable_smartspace_removal_toggle DISABLED
Change-Id: I4cba42e09f58365f761ab866b15a494817e6bb0f
2024-04-25 14:26:30 -07:00
Willie Koomson
ff1a1a9e46 Fix Add button animations
Use AnimatorSet to make the fade animations sequential instead of
simultaneous. Also reduce the total duration to 200ms (100ms fade out,
100ms fade).

Before: http://screencast/cast/NjQ4NTcwMjcyNzQzNDI0MHxjNDY5NDJiNy03Mg
After: http://screencast/cast/NTg5NDA0NDI5ODI0ODE5MnxmMjczMTlmYi05Mw

Bug: 333734220
Test: manual, see screencast
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD

Change-Id: I2ee87f33c46e5dd07974152fa32393c39a18ecf1
2024-04-25 20:51:15 +00:00
Shamali P
01a297942a Fix issue that expanded widgets appear before next item moved down
Issue - http://screen/AYyCKCWZH4uYeBp

* Before - http:/screencast/cast/NTc1NzE0MTg1NDk3ODA0OHwyNjA4ZmU5OC02ZQ
* After - http://screencast/cast/NDcyNTkzNzcyMjYyMTk1MnwxNmU1MTRmNy1jMw

Additionally, also fixes problem that fade in for some expanded sections
didn't always happen.

Bug: 332457155
Flag: N/A
Test: Manual (see video)
Change-Id: Iad3a341d9b992c72b61492d57db4faa96a06ecfa
2024-04-25 20:31:54 +00:00
Helen Cheuk
b9ed7c152a Merge "Disable launcher focus outline animation" into main 2024-04-25 18:43:05 +00:00