Commit Graph

10095 Commits

Author SHA1 Message Date
Schneider Victor-tulias
a028cd11ba Fix NPE in overview action buttons
Flag: N/A
Fixes: 305894735
Test: pressed screenshot overview action button shortly before/after dismissing the current task
Change-Id: Ife93fa9af5416af60cf8ae24275f14bd6857901a
2023-10-24 14:13:39 +00:00
Tracy Zhou
fbc8b715c3 Merge "Null check on RecentsView for endLiveTile" into main 2023-10-24 04:26:35 +00:00
Tracy Zhou
7cf1884d92 Null check on RecentsView for endLiveTile
Fixes: 304914019
manual: N/A
Change-Id: I6c6e3f0f52e57589f71b3c63debac21734fc88bf
2023-10-23 17:17:42 -07:00
Saumya Prakash
c14d48c214 Merge "Check status of mEdgeBackGestureHandler to prevent NPE" into main 2023-10-23 20:22:54 +00:00
Tracy Zhou
9070b93f40 Merge "Do not show task bar edu in folded state with task bar / nav bar unification" into main 2023-10-23 18:34:30 +00:00
Pat Manning
1eb8bd8735 Merge "Increase pinned taskbar height to fit tooltips." into main 2023-10-23 16:13:03 +00:00
Jon @
b61dcac34e Merge "Add HomeTransitionListener to launcher." into main 2023-10-23 15:56:36 +00:00
Pat Manning
5643e7c047 Increase pinned taskbar height to fit tooltips.
Fix: 305706286
Flag: ACONFIG com.android.launcher3.enable_cursor_hover_states TRUNKFOOD
Test: TaskbarHoverToolTipControllerTest

Change-Id: I767947a752eae7a928d59fe332bc62b9fd5b5f37
2023-10-23 15:52:48 +01:00
Tracy Zhou
aa783da782 Do not show task bar edu in folded state with task bar / nav bar unification
Fixes: 306208742
Test: manual
Change-Id: I8321e9d41ea041f77cea3f140d92316c702ce531
2023-10-20 19:47:29 -07:00
Mateusz Cicheński
4d59d52d1e Merge "Validate source rect hint for enter PIP in gesture nav" into main 2023-10-21 00:03:34 +00:00
Jon Miranda
00c3d78191 Add HomeTransitionListener to launcher.
Fixes: 279514548
Bug: 284474103
Bug: 306053414

Flag: LEGACY ENABLE_HOME_TRANSITION_LISTENER DISABLED
Test: App launch -> Hotseat -> Taskbar stashes
      Transluscent app launch and launcher still visible -> No change
      Going home -> Hotseat visible

Change-Id: I6db5253ada3e3b37dfae124f3ee88a9805804fb8
2023-10-20 15:46:11 -07:00
Sunny Goyal
e4900713b9 Merge "Remove RPC due to unnecessary permission check" into main 2023-10-20 21:48:36 +00:00
Pat Manning
4c27e8c6f0 Migrate cursor feature flag to trunk stable flag.
Fix: 300054410
Test: TaplTestsTransientTaskbar, TaplTestsQuickstep
Flag: enableCursorHoverStates
Change-Id: I5c320e0fd2bdd2ed39b00b62b1399e163c3384e7
2023-10-20 12:17:36 +01:00
Mateusz Cicheński
d21cf61e86 Validate source rect hint for enter PIP in gesture nav
If the source rect hint is going outside of visible app bounds,
we should use icon overlay instead.

Test: before http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/fPfOfGUlrBkJ8WbJDqAr2i
Test: after http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/fMcHGqfpA5HCXYoAPV4vTT
Bug: 305090652
Flag: NA

Change-Id: I161f60bf62888c7922227e5d3185810dbe88e317
2023-10-19 23:45:37 +00:00
Andreas Agvard
257f431da2 Merge "Adds haptic build-up during LPNH behind feature flag" into main 2023-10-19 21:48:21 +00:00
Jagrut Desai
34d135e21a Merge "Always use Transient Taskbar All apps icon for taskbar pinning" into main 2023-10-19 20:03:14 +00:00
Andreas Agvard
d1674985d6 Adds haptic build-up during LPNH behind feature flag
Flag: Omnient flags + ENABLE_SEARCH_HAPTIC_HINT
Test: Manual
Bug: 303023676
Change-Id: Ic43d1f34a05622328add6727f36406ce75d5a115
2023-10-19 21:10:42 +02:00
Nicolò Mazzucato
3a412d0471 Merge "Instrument unfold animation on launcher" into main 2023-10-19 12:45:06 +00:00
Alex Chau
0e4e703215 Merge "Migrate ENABLE_OVERVIEW_ICON_MENU to aconfig flag" into main 2023-10-19 08:18:41 +00:00
Sunny Goyal
8bbd8d4c43 Remove RPC due to unnecessary permission check
Bug: 302400996
Test: Presubmit
Flag: N/A
Change-Id: I9c03e95f37e6e7be8a61ad6f5f7548b4860a1704
2023-10-18 10:52:17 -07:00
Pat Manning
131495745c Merge "Add flag guarding around setText in TaskView." into main 2023-10-18 17:38:47 +00:00
Nicolo' Mazzucato
28ee5d441e Instrument unfold animation on launcher
Test: inspected perfetto traces
Bug: 294043453
Bug: 303438877
Flag: not needed
Change-Id: Iec6fe1cbbfdc68adc49c332c15add1333fed7590
2023-10-18 16:37:34 +00:00
Randy Pfohl
8fb1d8f295 Merge "Removing obselete logging used for flaky test investigation" into main 2023-10-18 16:33:06 +00:00
Pat Manning
04dcce8333 Add flag guarding around setText in TaskView.
Bug: 303266975
Test: Forrest runs & Crystalball performance metrics.
Flag: enableOverviewIconMenu
Change-Id: I79e325f9d3377bc078634232c53fd3587d05acc4
2023-10-18 17:13:28 +01:00
Andreas Agvard
6a9f888201 Update LPNH detection
Replaces GestureDetector usage in LPNH handler with internal implementation that we can tweak
in follow up CLs. It's also a pre-requisite for doing a hint haptic.

Flag: CUSTOM_LPNH_THRESHOLDS
Bug: 300219375
Test: Manual
Change-Id: I5a010d8828bf400e9151236554b29f60edba044c
2023-10-18 09:33:51 +02:00
Holly Jiuyu Sun
0fadf743cc Merge "[DMA] Add withFeature API in StatsLogManager." into main 2023-10-17 21:17:38 +00:00
Tracy Zhou
0254ae5480 Merge "Dynamically adjust the paddings of the contextual buttons" into main 2023-10-17 19:26:41 +00:00
randypfohl
e07068a0c9 Removing obselete logging used for flaky test investigation
Bug: 293191790

Test: not needed.

Flag: not needed.

Change-Id: I0378c1cc16ae25006d226db3b858394e5f20a22b
2023-10-17 11:47:00 -07:00
Saumya Prakash
a65c198f23 Check status of mEdgeBackGestureHandler to prevent NPE
Sometimes onAttachedToWindow() can be called before
mEdgeBackGestureHandler is created, which led to a NPE. This change adds
a null check to prevent the crash.

Fix: 303820749
Test: Set mEdgeBackGestureHandler to null and ensured no NPE occured in
onAttachedWindow()

Change-Id: I43ab8bcfc4d720bc537a7ca36e08068a6a27fbea
2023-10-17 18:01:28 +00:00
Schneider Victor-tulias
3c732aa71b Merge "Default to using AppLaunchAnimationRunner when no LaunchableView can be found" into main 2023-10-17 17:22:07 +00:00
Schneider Victor-tulias
7802dfb44d Default to using AppLaunchAnimationRunner when no LaunchableView can be found
Flag: not needed:
Fixes: 305699288
Test: ran launcher and launched apps
Change-Id: I5ab4f3c7d976e463c29340a4a00edf37e15abf47
2023-10-17 11:30:21 -04:00
Riddle Hsu
a60c091c94 Merge "Finish recents animation for standalone recents on home" into main 2023-10-17 10:56:28 +00:00
Riddle Hsu
aeb3ff6b5c Finish recents animation for standalone recents on home
(This is to reland with fixing FallbackRecentsTest#testOverview
by excluding fallback overview panel which doesn't show visual
difference from AnomalyDetector)
There was a check from RunningTask to avoid using transient-launch
when launching recents activity on a 3rd party home. But the info
may not be updated in time (from TaskStackChangeListener) if there
are several changes happen in a short time.

Then it may misjudge that home is still on top but the current top
is a normal app. Then the app will be paused unexpected because
setTransientLaunch() is not called.

Since FLAG_MOVED_TO_TOP is introduced, task reorder will also be
collected in transition, so the check of isHomeTask is longer needed.
But RecentsTransitionHandler still needs to cooperate with it about
how to animate the merging animation while recents animation is running.
To simplify it, just finish the recents animation when recents activity
is launched on top of home activity, i.e. consider it as a regular
launch because only the recents activity is on top and there are no
other apps need to keep visible for live-tile.

Note that setTransientLaunch() is still called for the case. However
its effect will be gone after the transition is finished.

This can also fix various issues when using a 3p launcher:
 - When auto rotation is enabled and put device in landscape:
    - Unable to enter recents from gesture mode
    - System bars are disappeared when pressing recents key
 - Jump-cut when pressing home key to leave recents on home.

Bug: 302703228
Bug: 294029838
Test: WindowInsetsBehaviorTests
Test: Rapidly click navigation bar while a regular app is on top.
      The app should not receive onPause.
Change-Id: I387fcb26aa01072dfd5a215107c9c15b28513a82
2023-10-17 05:45:16 +00:00
Alex Chau
d7bd142267 Merge "Avoid drawing live tile behind recents when launching on grid overview" into main 2023-10-16 19:48:23 +00:00
Alex Chau
1f5de2483b Avoid drawing live tile behind recents when launching on grid overview
Fix: 304911154
Flag: none
Test: Swipe up in tablet, scroll to side, launch focused task
Change-Id: I91dd8b4088f02af9dc5e603853d8e26606acc38f
2023-10-16 18:27:10 +01:00
Shan Huang
90f17d44d2 Merge "Fix scrim attachment and detachment issues." into main 2023-10-16 17:17:14 +00:00
Uwais Ashraf
d174fcaa99 Merge "Revert "Finish recents animation for standalone recents on home"" into main 2023-10-16 08:57:59 +00:00
Uwais Ashraf
35af2d967c Revert "Finish recents animation for standalone recents on home"
Revert submission 24941288-b302703228

Reason for revert: Most likely cause of droidmonitored test failures. b/305629625. Original change was merged at this point https://screenshot.googleplex.com/99p3F266XUYYbA2 causing a 100% failure on main.

Reverted changes: /q/submissionid:24941288-b302703228

Bug: 305629625

Change-Id: Id27c68ec70410d16aeae3bde8b361d9b347ec7eb
2023-10-16 08:56:24 +00:00
Riddle Hsu
290aa6f266 Merge "Finish recents animation for standalone recents on home" into main 2023-10-16 05:46:48 +00:00
Tracy Zhou
33132dc48c Dynamically adjust the paddings of the contextual buttons
- Dynamically adjust the paddings of both start and end contextual containers in different layouts

Test: manual
Bug: 230395757

Change-Id: I2c6a1350e0dab36f6d5100b8d4e2012d8a97cd9b
2023-10-13 20:10:44 -07:00
Tracy Zhou
6bfdfd011b Merge "Correct signal for showing contextual buttons for taskbar" into main 2023-10-13 21:04:13 +00:00
Shan Huang
b78f7de733 Fix scrim attachment and detachment issues.
Attaching: The surface control from Launcher's ViewRootImpl is
occiasionally invalid when back gesture starts, and parenting scrim to
it would fail. We work around this by retrying later on back progressed.

Dettaching: The scrim is not detached in all code paths. We now always
check and detach in finishAnimation() if needed.

This also fixes a possible flicker at the beginning of the transition.
We wait until Launcher is started (and draws at least one frame) to animate the top window.

Test: m -j
Test: Repeatedly trigger back to home animation. Make sure the scrim
attaches and detaches always.

Bug:271606843
Bug:297808832
Bug:217988970
Fixes:271606843
Fixes:297808832
Fixes:217988970

Change-Id: I8b9b023f1fd54bcedd0be15196165e19e8400af7
2023-10-13 13:51:46 -07:00
Jagrut Desai
6965fdd12a Always use Transient Taskbar All apps icon for taskbar pinning
Test: Manual, Visual
Bug: 265436799
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I253f3b7f6b0c1d198ba7c9849e99f6cf4b89a006
2023-10-13 12:49:18 -07:00
Ats Jenk
a89365c2be Merge "Use desktop mode flag for split logic" into main 2023-10-13 18:00:53 +00:00
Schneider Victor-tulias
a96537fa65 Merge "Increase the ActiveGestureLog tracked gesture limit" into main 2023-10-13 16:08:32 +00:00
Jeremy Sim
20410d25f9 Merge "Migrate ENABLE_APP_PAIRS flag to aconfig" into main 2023-10-13 05:22:36 +00:00
Ats Jenk
cd789874c3 Use desktop mode flag for split logic
Remove launcher specific split from desktop flag and use the desktop
windowing feature flag.

Bug: 305095670
Flag: persist.wm.debug.desktop_mode_2
Test: enable desktop mode flag, toggle split from a desktop task
Change-Id: I62b91de3deaa5bba3435faf3a268f5b58cda8276
2023-10-12 23:28:42 +00:00
Jeremy Sim
7dc3bdcd85 Migrate ENABLE_APP_PAIRS flag to aconfig
Fixes: 303323964
Flag: com.android.wm.shell.Flags.FLAG_ENABLE_APP_PAIRS
Test: Unit tests still run correctly
Change-Id: I617c699746492c9c0d131a28791d984afbbdda4d
2023-10-12 15:06:32 -07:00
Sunny Goyal
c173c04422 Generalize userproperties to support for more user types in iconCache
Bug: 305062259
Flag: None
Test: Presubmit
Change-Id: I35cd20a03520ada233809930fcc56cdea1dabec6
2023-10-12 21:25:59 +00:00
Sunny Goyal
4588031286 Merge "Moving onboarding prefs to use LauncherPrefs" into main 2023-10-12 20:51:45 +00:00