Commit Graph

162 Commits

Author SHA1 Message Date
TreeHugger Robot
9f867ac8b6 Merge "Enabling screen record for some flaky tests" into sc-dev am: 5c6d7c3a1f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15112968

Change-Id: I188875721529cbb36fd5ae37fb304953125802fc
2021-06-26 15:10:36 +00:00
Sunny Goyal
85a84e52cc Enabling screen record for some flaky tests
Bug: 187080582
Bug: 192005114
Bug: 192018189
Bug: 192010616
Test: Manual
Change-Id: I32fc0e4c9848c4def1aa6254139579bc631862cc
2021-06-25 15:40:55 -07:00
Alex Chau
7a9972289f Add touch event of on taskbar for various cases
- Temporarily disable leak detection on tablets until b/191449914 is resolved
- Add touch event on taskbar when interacting with navigation buttons
- Added TaplTestsLauncher3.initialize to StartLauncherViaGestureTests which is present in TaplTestQuickstep to solve LauncherInstrumentation being null problem on tablets

Bug: 191344757, 191449914
Test: TaplTestQuickstep and StartLauncherViaGestureTests
Change-Id: I49accc458d133717f290140abe80aae8a683f6c0
2021-06-24 18:00:12 +01:00
vadimt
143748fbf4 Detect leaks only on test success
Bug: 191690396
Test: presubmit

Change-Id: Ie59c3b944d420ac25ebba86bf500fcf33700ca99
2021-06-22 18:49:34 -07:00
vadimt
f9ccf0175d Revert "Removing workaround for battery defender"
This reverts commit f4bb052ca0.

Reason: we have new episodes of phone locking during the test.
https://flakes-clusters.corp.google.com/#?androidAtpBranch=git_sc-dev&androidAtpModule=com.google.android.apps.nexuslauncher.out_of_proc_tests&d=3&maxResults=10

https://flakes-clusters.corp.google.com/#?androidAtpBranch=git_sc-dev&androidAtpModule=com.google.android.apps.nexuslauncher.tests&d=3&maxResults=10

Search for "Phone is locked" and "Keyguard is visible".

Also, for new devices, the phone is locked consistently, see for example
Redfin here:
https://blackbox.googleplex.com/dashboard/Launcher3Main_new_devices/testsuite/git_master/nexuslauncher_oop_tests_platform/2/bramble-userdebug/0

Reverting to see whether this helps.

Bug: 151613234
Test: presubmit
Change-Id: I44a94f9722deaa21d89fdfd79646ae661ebe972d
2021-05-14 11:14:35 -07:00
vadimt
e2801bcb77 Removing pss checks in memory tests
Test: presubmit
Bug: 185181057
Change-Id: I4f504f9540b80c62cd3f1024ff1d1b57102f2ed6
2021-05-12 18:57:55 -07:00
vadimt
eefc2e1de1 Diagnosing only system health problems happened during the test
Test: presubmit
Bug: 187761685
Change-Id: I3feba12e2228fe6dda3b0d65d904b0b839da2108
2021-05-11 00:31:24 +00:00
vadimt
25ebb2d3c1 Disable strictmode leak detection
It doesn't work; the check was enabled by mistake.

Test: presubmit
Bug: 185786290
Change-Id: Ie049f1d6d7cef5acfa3ee29b5f9e9586fbeb24a5
2021-04-19 11:01:45 -07:00
vadimt
a9665751a0 Clearer diag for visible keyguard
Test: presubmit
Bug: 179508881
Change-Id: I69f2e766701e77d927169b570d2dad0bf8d4c75a
2021-04-12 20:00:45 -07:00
Sunny Goyal
940c27ef1a Using an independent drawable for rounded corners
Bug: 183641907
Test: Manual
Change-Id: I3114d43d07c03884348e1c33805545f19bb8d540
2021-03-30 14:47:44 -07:00
Tracy Zhou
9d706b1ada Fix failed test in order to enable Live Tile (in the next change)
Live tile changes certain assumptions we have for tests, for example
- Launcher will not be in the resumed state after swiping up to Overview

Also, disable live tile for 3rd party launcher for now

Test: presubmit
Fixes: 169694902
Change-Id: Ifd466db0354f59290c4f66a0a2ad4c82f1169f29
2021-03-25 19:44:36 -07:00
vadimt
ab469ac515 Better diagnosing leaked activities.
Test: manual
Bug: 181356264
Change-Id: I9bf843a1d26bc4cf255c1b8d2cce0febeaa4c4fe
2021-02-26 14:45:10 -08:00
TreeHugger Robot
f56efc0187 Merge "Adding debug tracing for Device.wait" 2021-01-20 18:58:21 +00:00
Vadim Tryshev
9e86e3b89d Merge "Removing automatic failure investigator" 2021-01-20 18:46:42 +00:00
vadimt
952471f675 Removing automatic failure investigator
It wasn't updated for a while,
creates a false impression that the failure
is already tracked, and hopefully soon
will be replaced by new clustering.

Test: presubmit
Bug: 161478674
Change-Id: Icc3716c1f534867d5e4b21d18c9cede273da8704
2021-01-19 15:14:03 -08:00
vadimt
ed86cb19bc Adding debug tracing for Device.wait
I suspect it may wait for a period of time less than
the specified one, causing flakes.

Test: presubmit
Bug: 177318681
Change-Id: I0be8790c6ee9a5831767fe83c36054ed5a84f8d7
2021-01-15 13:58:03 -08:00
vadimt
f48097f270 Correctly generating heap dumps for OOP tests
Not trying to dump the test process :)

Still using Debug.dumpHprofData for inproc because
using shell command for inproc can deadlock.

Test: manual
Bug: 177065099
Change-Id: I4b581954a01ecc8a1427409baa030aaa3b70d6b5
2021-01-14 19:43:28 -08:00
vadimt
c37058976d Generating Hdumps for more leaks
Test: presubmits
Bug: 177065099
Change-Id: I386229cf92a925d2953952ed0fab6c44dcdc61f0
2021-01-13 11:34:16 -08:00
vadimt
f4bb052ca0 Removing workaround for battery defender
The bug is supposed to be fixed.

Bug: 151613234
Change-Id: I8e803ead29e08e68fa75f61b5ad0e1198c9228ec
(cherry picked from commit ff39fd3e14)
2021-01-05 19:17:33 +00:00
Winson Chung
f99351888c Revert "Revert "Merge commit '8d14dbe041199d611839140f1c9285fd4174e9f4' ...""
This reverts commit 087a9e39b6.

Change-Id: I05b17a6e4aaaef6de3c2fa26aad45a39eb2833f9
2020-10-23 09:27:48 -07:00
Alistair Delva
087a9e39b6 Revert "Merge commit '8d14dbe041199d611839140f1c9285fd4174e9f4' ..."
Revert "Merging from ub-launcher3-master @ build 6877130"

Revert "Merging from ub-launcher3-master @ build 6877130"

Revert "Merging from ub-launcher3-master @ build 6877130"

Revert submission 12738409-merge_ub-launcher3-master_6877130

Reason for revert: Introduced crashes to global presubmit

Reverted Changes:
I624658ce6:Merge commit '8d14dbe041199d611839140f1c9285fd4174...
Iccd2f1e3a:Merging from ub-launcher3-master @ build 6877130
I791d64951:Merging from ub-launcher3-master @ build 6877130
Icdd32ab01:Merging from ub-launcher3-master @ build 6877130

Bug: 169963211
Change-Id: I77a4ae59e823147beae8dd7cb9b54ccdace2c7f4
2020-10-05 14:46:26 +00:00
Samuel Fufa
9fa2d8812a Resolve race condition between @Before conditions
Bug: 159671700
Change-Id: I5c96c32c171b7b539ce0ea799cf45955c2bee670
2020-09-30 10:57:04 -07:00
Yuchen He
30caccbbc2 Enable memory dump for Launcher
Bug: 154772063
Change-Id: I3b2bc2e341037746891658f2596999248ec272ef
(cherry picked from commit 12baaadeca)
2020-07-31 17:07:56 +00:00
Sunny Goyal
8b74cc761b Moving all-apps predictions to Launcher model
Predictions are loaded and managed by Launcher model and follow
the model lifecycle. They are then bound to the callback which
handles the UI

Bug: 160748731
Change-Id: I4a3ea0698d80fafe94afb4ce66ffa7f4a6a91c68
2020-07-29 13:07:52 -07:00
vadimt
839fb7b3ae Eliminating messages that launcher activity is frozen
They were ultimately caused by killing Launcher process from tests.

Now having a test info handler request to clear db.

Bug: 152629799
Change-Id: Ia81ddc3e338718c4cff08c7396b9fda1b7091024
2020-06-22 15:39:19 -07:00
vadimt
45564c831b Removing debug requests from non-debug test info handlers
Bug: 152629799
Bug: 153670015
Change-Id: I02776be811d1d3325b35880d19d25a6638f904ef
2020-06-10 18:48:37 -07:00
TreeHugger Robot
eb0136b7c4 Merge "Abstracting out state handler logic into base classes so that it can also be used in different activity" into ub-launcher3-rvc-dev 2020-05-12 00:29:52 +00:00
TreeHugger Robot
3d668090af Merge "Resolve Test flakes" into ub-launcher3-rvc-dev 2020-05-11 23:40:43 +00:00
Sunny Goyal
35e7d38681 Abstracting out state handler logic into base classes so that it can
also be used in different activity

Change-Id: Ic5e60b21e1429c71f1cd4e7041e70bf4fc9761b7
2020-05-11 16:38:26 -07:00
Samuel Fufa
b549819676 Resolve Test flakes
-> Synchronize calls in LoaderTask.java
issue 156041043

-> Remove non system users on setup
If a work test crashes before getting to run its teardown - we might end up with a user profile that could throw off subsequent tests.
issue 156022161

Test: Manual
Change-Id: Ife708a3de01572f7cb2187078d592d8d570dd951
2020-05-10 13:51:41 -07:00
vadimt
60d3333ff0 Adding waiting for Launcher initialization
This may fix or ease TIS sometimes not receiving events.

Bug: 154157191
Change-Id: I5db9e88397788014dbba9716d777a2b97347828c
2020-05-08 09:29:08 -07:00
vadimt
921f9fd254 Support for counting activity creations
Bug: 139137636
Change-Id: Ib999fd3c82eb2997662578ec35e1d9e1e75e3cbb
2020-04-27 12:41:26 -07:00
TreeHugger Robot
d73d39b45a Merge "Makeshift analog of Strictmode leak detector" into ub-launcher3-rvc-dev 2020-04-23 03:22:31 +00:00
vadimt
b3e8ae8230 Makeshift analog of Strictmode leak detector
Strictmode leak detector is still a goal, but we might not be able to
achieve it in R. Strictmode has several framework-side bugs that perhaps
hide Launcher-side strictmode violations, while the time to fix
everything is limited, and new leaks get introduced all the time.

For now, implementing a check that is slightly more relaxed than
Strictmode, but still ensures the absence of leaks. I’ll keep
eliminating Strictmode violations as well as keep strengthening the
makeshift checker conditions until we’ll be able to enable Strictmode in
continuous testing.

I’m disabling Strictmode checks for now so that they don’t generate
unnecessary hprof dumps, but leaving the code dealing with strictmode.

Bug: 139137636
Change-Id: Ib10136b0d4e9892f70a19cd052ae5a54cf0a4efb
2020-04-22 19:00:12 -07:00
Sunny Goyal
34ff8cb3c1 Adding common code for instrumentation and robolectric tests
Change-Id: Ia338f0565868bb174ef5f6721924944792866be6
2020-04-20 14:42:30 -07:00
Vinit Nayak
916456bb5f Cleanup code related to ag/11035582
Fixes: 154235554
Change-Id: I114d1e1b9e446e15a774a5a51bdf988070091523
2020-04-16 14:16:56 -07:00
Vinit Nayak
770cc42685 Revert "Cleanup code related to ag/11035582"
This reverts commit a2a1f86dff.

Reason for revert: b/154068414

Change-Id: I1db0018fa97d5a5380651cf7d04a05a0abd62857
2020-04-15 05:24:10 +00:00
Vinit Nayak
a2a1f86dff Cleanup code related to ag/11035582
Bug: 153443049
Change-Id: I2a9e46fa4ffc613751c9f427ce892ddad3878b35
2020-04-14 14:02:49 -07:00
Sunny Goyal
e396abf502 Moving model data structures to a separate file
Change-Id: I77ad7a5219e72d2e0d6c1803de2ac3ed6a65a8f7
2020-04-09 13:20:39 -07:00
Vinit Nayak
6b7cc3fdc2 Re-enable orientation sensor for Overview animation
Slight revert of ag/10668129 with adjustment
of disabling it for tests.

Fixes: 151456795
Test: Ran the labtest command for OOP
tests for crosshatch (where this issue
was first detected)

Change-Id: I315d138c2e4a6d4068304e9b5fb2e1b7feb34e63
2020-04-02 11:07:10 -07:00
vadimt
7a9f1628f2 Repeating unlocking the phone several times
Bug: 151613234
Change-Id: Id5cbc247d7827fa31c2011d817b2964c1486daeb
2020-03-21 15:09:39 -07:00
vadimt
7500c241ac Increasing wait time till unlock
Bug: 151613234
Change-Id: I47e0a87551cebf31fa309b9a65b2ecff809a7f00
2020-03-21 13:04:15 -07:00
vadimt
330fde4aaf Adding more checks around unlocking the phone
Bug: 151613234
Change-Id: I045306cce2ce85d6895c9f050ebb4d2bd15ba232
2020-03-20 18:55:53 -07:00
vadimt
1b4247d9cd Disable battery defender to avoid locking during the test
Bug: 151613234
Change-Id: Id323025c1a3bb53cc39839aa2295fcd25436e68e
2020-03-20 14:26:31 -07:00
vadimt
d8070756f1 Making sure the device doesn't lock during test execution
Unlocking the device at the beginning
of the test does help, but perhaps we should prevent
locking during the test execution.
Some failures still remain.

Bug: 151613234
2020-03-19 20:33:47 +00:00
vadimt
14b60d77b7 Unlocking device from the test
This is a workaround for the infra not unlocking
the device properly.

I don't have access to may machine, so
I've created this CL in Gerrit editor, didn't test,
but it should work.

Bug: 151613234
2020-03-19 17:59:34 +00:00
TreeHugger Robot
f67ab6c64d Merge "Catching everything from dumpHprofData" into ub-launcher3-master 2020-03-06 02:14:19 +00:00
vadimt
bb2bf277c0 Catching everything from dumpHprofData
Change-Id: I79ced1d4bb3e6ea43ce6fa5bd07fe22b577006f9
2020-03-05 17:22:18 -08:00
vadimt
6d605da821 Verifying that tests run against a matching Launcher version
Change-Id: I3a6c9e1a2487cfd571abdf4bdd18ab17c7ac9406
2020-03-05 13:36:12 -08:00
vadimt
3d9dad3b9b Saving heap dump immediately as reported by StrictMode
Can do this via API with the exact heap state that triggered the
callback because using API allows to avoid deadlock that we'd have in
main thread if we used shell command.

checkDetectedLeaks() is still needed, as I'll add throwing an
exception there soon.

Bug: 139137636
Change-Id: I3c8670071b058c5c146ac58bb16152c980553065
2020-03-03 18:21:07 +00:00