Commit Graph

6001 Commits

Author SHA1 Message Date
Lucas Dupin
9d8580bd2a Reset DEPTH at the end of launch animations
This way the wallpaper won't be zoomed out if an app crashes.

Test: adb am crash <some test app>
Fixes: 191979512
Change-Id: I7576798f736d63c3e46bbac1b983b9d1a437647d
2021-06-28 11:45:14 -07:00
Tony Wickham
8db306f3c5 Merge "Fix some touch issues during gesture nav transition" into sc-dev 2021-06-24 01:08:43 +00:00
TreeHugger Robot
862224f913 Merge "Ensure InputConsumer is non-null in remaining cases" into sc-dev 2021-06-24 01:04:18 +00:00
Tony Wickham
f64f9a14d8 Ensure InputConsumer is non-null in remaining cases
Anywhere that was using mResetGestureInputConsumer now uses getDefaultInputConsumer, which returns NO_OP if mResetGestureInputConsumer is null.

Test: none
Bug: 191684742
Change-Id: I1ae02b01a9629fa0830955dfe4d83c95a4759c14
2021-06-23 16:39:44 -07:00
Hilary Huo
08843d8e37 Merge "[settings-pixel-search] Add ww logging to track slice fetching timeout" into sc-dev 2021-06-23 22:18:00 +00:00
Tony Wickham
1351c2214d Fix some touch issues during gesture nav transition
- Don't recreate the laucher transition controller if we've already ended it, as it could clobber a touch interaction that started in the meantime
  - Test: swipe up from an app to overivew, swipe to dismiss it during the transition.
  - Previously, we were ending the controller twice (once on touch down as we started proxying, and again in setupLauncherUiAfterSwipeUpToRecentsAnimation()), and the second one could happen after starting the dismiss interaction.
- Don't recreateControllers() if orientation didn't change
  - Test: swipe up to go from an app to home, swipe up to all apps during the transition.
  - Previously, we were getting the following sequence:
    1. Touch down on home to start swiping to all apps - all current controllers get this down event to start determining whether to intercept
    2. Before reaching touch slop, we recreateControllers(), so all new controllers won't get the down event and thus won't intercept
  - Now, we avoid unnecessarily recreateControllers(), so the original controllers can still intercept.

Test: see above
Fixes: 189700453
Change-Id: Icfa5b6cdb32122adaf6ac8e8cb197b0c477dac60
2021-06-23 13:07:18 -07:00
Tracy Zhou
2f8342d791 Merge "Finish recents animation on task dismissal only if the task is a live tile task" into sc-dev 2021-06-23 19:40:15 +00:00
Lucas Dupin
697e51cd8c Merge "Disable blurs when dev setting or battery saver" into sc-dev 2021-06-23 18:40:43 +00:00
Vadim Tryshev
9d7ff51901 Merge "Detect leaks only on test success Bug: 191690396 Test: presubmit" into sc-dev 2021-06-23 17:50:47 +00:00
Zak Cohen
e43edc74ef Merge "Sets a simple locus id when Overview is enabled" into sc-dev 2021-06-23 17:38:16 +00:00
Schneider Victor-tulias
bef29071b5 Merge "Update gesture nav tutorial back left and right videos" into sc-dev 2021-06-23 17:28:35 +00:00
Tracy Zhou
d537968b35 Finish recents animation on task dismissal only if the task is a live tile task
Fixes: 191831190
Test: manual
Change-Id: Ie1dd02a2e8cc401a613a0ed2199400712c6d5291
Merged-In: Ie1dd02a2e8cc401a613a0ed2199400712c6d5291
2021-06-23 17:18:00 +00:00
Hilary Huo
e83189593a [settings-pixel-search] Add ww logging to track slice fetching timeout
Test: https://paste.googleplex.com/6310936320147456
Bug: 191297465
Change-Id: I0a4a65295e7290b55dccdb63830ff60c6838fbb2
2021-06-23 10:16:21 -07:00
Lucas Dupin
b60fff3929 Disable blurs when dev setting or battery saver
Stop rendering blurs whenever a user:
- disables blurs on developer settings
- enables battery saver

Test: manual
Bug: 191814337
Change-Id: I8fd04796054d92171732c8db95b64cfa3ec469ec
2021-06-23 08:37:27 -07:00
vadimt
143748fbf4 Detect leaks only on test success
Bug: 191690396
Test: presubmit

Change-Id: Ie59c3b944d420ac25ebba86bf500fcf33700ca99
2021-06-22 18:49:34 -07:00
zakcohen
e2c4687e51 Sets a simple locus id when Overview is enabled
Bug: 189968849
Test: Ran with logcat to check correct locus is set
Change-Id: I5253d83b4cf5862e49c3183a843bf8f26dce149e
2021-06-22 16:46:30 -07:00
Thiru Ramasamy
2f65e7f274 [AA+] Adds CorrectedDeviceSearchResultContainer to log user interactions on search results from corrected queries.
Bug: 188840584
Test: Local
Change-Id: Ibbf2b228537a19be1e77993efee5edc421ff70eb
2021-06-22 15:40:22 -07:00
Winson Chung
d27f127b3a Merge "Don't finish to home when launching a task from recents" into sc-dev 2021-06-22 18:54:14 +00:00
Winson Chung
856cd1bd4d Don't finish to home when launching a task from recents
- When launching without a task view, we should also not be finishing
  to home (similar to composeRecentsLaunchAnimator) since it will
  clobber the newly launched task

Fixes: 191182965
Test: Open overview with live tile, try to open usb debugging settings
      page
Change-Id: If7464ebf155cee33e81205fbf4899e9ab49a52d0
2021-06-22 18:54:03 +00:00
Cyrus Boadway
9dd0351ed1 Merge "Use icon splash screen when starting activity from widget interaction" into sc-dev 2021-06-22 18:13:52 +00:00
Sunny Goyal
eb3367796a Merge "Fixing TaskView.launchTask.onEndCallback is not called" into sc-dev 2021-06-22 18:08:25 +00:00
Tracy Zhou
578b45f919 Merge "Null check on target set before rendering task open animation" into sc-dev 2021-06-22 17:21:32 +00:00
Zak Cohen
049c2f578b Merge "Fade overview action buttons faster in overview -> home" into sc-dev 2021-06-22 16:53:52 +00:00
Matt Casey
3a65795298 Merge "Send a zero for assist invocation on animation end" into sc-dev 2021-06-22 16:46:41 +00:00
Matt Casey
eeac1aba30 Send a zero for assist invocation on animation end
When a corner gesture doesn't complete, we animate the progress from its
current value back to 0. When it hits 0, sysui will perform some cleanup
e.g. removing the window. However, it's possible the animator won't
return exactly 0 and will complete, so we should send an explicit 0
whenever the animator completes.

Bug: 187768368
Test: We don't have a repro for the bug, but expect this should be more
      robust. Tested to validate it didn't regress.
Change-Id: Id65f94534363c326fc2c8d0a9114a3c036aa55e4
2021-06-22 10:46:10 -04:00
Cyrus Boadway
f158ec33d8 Use icon splash screen when starting activity from widget interaction
Set the flag to use the icon splash screen rather than the empty splash
screen when starting an activity from a widget interaction.

Bug: 191738655
Test: manual
Change-Id: Iff771a43648bbf6dfb88e2a6749c4526fd17da07
2021-06-22 10:14:06 +00:00
Tracy Zhou
8af0dd3e0c Null check on target set before rendering task open animation
Fixes: 190854921
Test: N/A
Change-Id: Iae7ef7cf3f4d2309223bfabe6d40f24b7e34439c
2021-06-21 21:33:28 -07:00
Lucas Dupin
818ed4b794 Merge "Apply depth even when surface is null" into sc-dev 2021-06-22 01:10:23 +00:00
Lucas Dupin
a6c38be150 Apply depth even when surface is null
We need to update mDepth even when the surface is null, otherwise
events will be ignored and mDepth will have the wrong value when
waking up from screen-off.

Test: pull up app drawer, screen off, unlock
Test: go to overview, screen off, unlock
Test: launch app, observe blurs and zoom
Fixes: 191153501
Change-Id: I33f5d84a50e24f05a09769b1f7f3c27969f847cd
2021-06-21 16:27:11 -07:00
Sunny Goyal
696c612964 Fixing TaskView.launchTask.onEndCallback is not called
Sometimes onAnimaitonCancelled can be called without onCreate. Calling
onEnd in this case so that the sate is cleared

Removing additional subclassing for the runner

Bug: 190856140
Test: Manual
Change-Id: If105cb343cab446a4eac90a45184ce50c6e4c485
2021-06-21 16:06:40 -07:00
Sunny Goyal
871d435be2 Merge "Finish wrapped launcher animations if impl is gone" into sc-dev 2021-06-21 23:03:27 +00:00
Sunny Goyal
b3eafe97bb Merge "Fixing animation end not-called when cancelling state the animation recursively" into sc-dev 2021-06-21 22:32:23 +00:00
zakcohen
061548668d Fade overview action buttons faster in overview -> home
Spec says transition should take ~80ms, default for this transition is
~300ms, so clamp to a quarter of the range.

Bug: 191699762
Test: Local
Change-Id: I5ef6701eee0d25d5d9987e05cb53aee3e5e8e143
2021-06-21 15:18:16 -07:00
Tony Wickham
82fc5c83a5 Merge "Ensure mConsumer isn't set to null in reset()." into sc-dev 2021-06-21 22:15:48 +00:00
Evan Rosky
08c3480b84 Finish wrapped launcher animations if impl is gone
If the runner impl is gone (since it is a weakreference), we
still need to complete the animation contract by calling the
finish callback, so do that.

Bug: 183993924
Test: atest ActivityMetricsLoggerTests
Change-Id: Idce1859f0417cb74bbb9884e0d06750539e4545e
(cherry picked from commit 8a672e15cc)
2021-06-21 20:51:12 +00:00
Sunny Goyal
de644313b0 Fixing animation end not-called when cancelling state the animation recursively
Bug: 190856140
Test: Manual
Change-Id: I5d6a00c1d1c0e95e615b7f2115e3e4ebb56b987f
2021-06-21 13:47:49 -07:00
Tony Wickham
9c10d08e1e Ensure mConsumer isn't set to null in reset().
mResetGestureInputConsumer is not initialized until onUserUnlocked(), meaning it might still be null in reset(). Use NO_OP input consumer in that case.

Test: none
Bug: 191669813
Change-Id: Ib9edde50fba0b6164390ec2b5c877d3db74ddfeb
2021-06-21 13:24:01 -07:00
Schneider Victor-tulias
689d69572b Merge "Update All set screen icon" into sc-dev 2021-06-21 17:35:15 +00:00
Jon Miranda
651abb9924 Fix bug where workspace alpha does not get set to 1 when animation gets cancelled.
- Can also remove QSB from app launch animator, since its in the hotseat now.

Bug: 189458349
Test: manual
Change-Id: Ib41376e3f8c58166c6ee6fbfed38bdd443663df4
2021-06-18 15:39:36 -07:00
Schneider Victor-tulias
4ef6bd5a7a Update All set screen icon
Fixes: 191463446
Test: Manual
Change-Id: I746bfb2eab950a01041493bd72d7dda30ac66d7b
2021-06-18 15:36:23 -07:00
Schneider Victor-tulias
03c4fa8342 Update gesture nav tutorial back left and right videos
Bug: 188972959
Test: manual
Change-Id: I03aef0ad47f9a648f7a661c607dd3d4f1f2187c4
2021-06-17 14:07:16 -07:00
Zak Cohen
1d5debd60d Merge "Suppress ViewInflationDuringSwipeUp test." into sc-dev 2021-06-17 18:34:29 +00:00
Winson Chung
caabfa1519 Merge "Do some additional cleanup when switching handlers" into sc-dev 2021-06-17 16:48:42 +00:00
zakcohen
360489ff51 Suppress ViewInflationDuringSwipeUp test.
Test is failing on a subset of devices with a memory leak in an activity.
This is not repoing on other devices so could be a problem with the setup
rather than the code.

Bug: 190618549
Test: Local
Change-Id: I9c6a56432d1b1f59c337bf34e7b8c26befeb2d7d
2021-06-17 09:46:56 -07:00
Jonathan Miranda
28e39335bc Merge "Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag." into sc-dev 2021-06-16 20:34:48 +00:00
Jon Miranda
b73e591712 Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag.
Bug: 191088291
Test: manual
Change-Id: Ia144c72e0fe1292ed856a37ee714a1cda50083d5
2021-06-16 18:13:23 +00:00
Jonathan Miranda
c846245f1b Merge "App Shortcut menu bug fixes and polish." into sc-dev 2021-06-16 18:06:13 +00:00
Jon Miranda
229c4c3235 App Shortcut menu bug fixes and polish.
- Widget is its own item.
- Change order of icon order.
- Update grab handle colors

Bug: 188095695
Test: long press on apps with/without widgets, long press apps on workspace/
      all apps/search

Change-Id: Iabb9b4b3f3a928103b9d62601f22e74ef2325d7c
2021-06-15 18:59:51 -07:00
Winson Chung
d14190d547 Do some additional cleanup when switching handlers
Bug: 183962705
Test: Presubmit

Change-Id: Ia9295d2cf89fa6b6fe77c5e4861a704c4a82ab12
2021-06-15 13:57:06 -07:00
Hongwei Wang
e3bfeddd04 Merge "Use RectFSpringAnim for auto-enter-pip" into sc-dev 2021-06-15 20:50:45 +00:00