Commit Graph

868 Commits

Author SHA1 Message Date
fbaron
9d08e0fe70 Migrate smartspace as a widget and smartspace removal toggle flags to aconfig
Bug: 336823684, 336823681
Test: none
Flag: ACONFIG enable_smartspace_as_a_widget DISABLED
Flag: ACONFIG enable_smartspace_removal_toggle DISABLED
Change-Id: I4cba42e09f58365f761ab866b15a494817e6bb0f
2024-04-25 14:26:30 -07:00
Stefan Andonian
1a626d2d05 Revert^2 "Remove Unused parts of LauncherPrefs causing cyclical dependency."
This reverts commit a80997d9eb.

Bug: 324670265
Test: Locally tested this, as well as ran it through post-submit via go/abdt with the fix.
Flag: NA
Reason for revert: Root-caused the issue with this, and will push the fix along with this revert.

Change-Id: I4bda53d94dfdb865883fef6ceec9dacd0b87f015
2024-04-15 18:28:25 +00:00
Sunny Goyal
8049369af8 Freezing legacy feature flags
Legacy feature flags will be locked to their current values in code.
All new feature development should use aconfig flags

Bug: 332588958
Flag: None
Test: Presubmit
Change-Id: Ie72dd8276b7135620de279835d6721a34f82ede4
2024-04-09 15:26:07 -07:00
Sunny Goyal
89931316a2 Moving various nav-bar configs out of feature flags
Bug: 332588958
Test: Presubmit
Flag: None
Change-Id: Ia4dc5b69bcf4d461e3444b9e37bb7334bb74aae4
2024-04-08 16:54:04 -07:00
Holly Sun
d1bfd56678 [omni] Read long press duration from AppSearch and override server configured value.
Notify the appsearch values to systemui through SystemUiProxy.
See http://shortn/_WqYj0buH7R  for summary

Bug: 330446188
Test: manual. Side load agsa apk to read the value from AppSearch
Flag: legacy CUSTOM_LPNH_THRESHOLDS enabled
Change-Id: I7bd2688178da48ae8eb9e62e135304cba2fec8ce
2024-04-02 19:04:53 +00:00
Anushree Ganjam
bab97ee1f2 Merge "Enable the CUSTOM_LPNH_THRESHOLDS flag." into main 2024-04-02 18:31:51 +00:00
Anushree Ganjam
f1b8e4e155 Enable the CUSTOM_LPNH_THRESHOLDS flag.
Decision by PM: Set the default LPNH_TIMEOUT_MS to 450ms.

Bug: 311355495
Test: Manual
Flag: legacy CUSTOM_LPNH_THRESHOLDS ENABLED
Change-Id: I07f075a7c73e8038a83b19cdc1091c0c8735f869
2024-03-29 12:33:10 -07:00
Sebastian Franco
efab2489d6 Generate grid migration cases and test if they are valid
This makes sure the grid migration logic always produces
valid results.

Bug: 313900847
Bug: 323525592
Flag: NA
Test: ValidGridMigrationUnitTest.kt
Change-Id: I76b19e1fa315f8a997afad34e5a4df7cc465b0c2
2024-03-27 14:03:07 -07:00
Andrew Cole
6667611f59 Merge "Moving FORCE_MONOCHROME_APP_ICONS to New Flag System" into main 2024-03-18 16:10:03 +00:00
Andrew Cole
16b68816ce Moving FORCE_MONOCHROME_APP_ICONS to New Flag System
In order to continue work on theming all app icons we are moving the developer flag over. This is cleanup work

Bug: 270396209
Test: None
Flag: ACONFIG FLAG_FORCE_MONOCHROME_APP_ICONS disabled
Change-Id: Ia290a6761aec68eadd2e78f64ac5dbd233af6033
2024-03-15 14:19:22 -07:00
Brandon Dayauon
69aa9a07ee Merge "Disable two line text legacy flag." into main 2024-03-14 15:11:13 +00:00
Brandon Dayauon
68c18236ad Disable two line text legacy flag.
Will now repurpose the twolinetoggle flag to be the flag that will
make twoline text enabled/disabled.

bug: 316027081
Test: presubmit
manually: https://screenshot.googleplex.com/BsZGCm7DrTZLwG4
Flag: com.android.launcher3.enable_twoline_toggle Staging
Change-Id: Idef427bad6551ae56b13e35393e076b8e000af5a
2024-03-08 21:32:22 -08:00
Anushree Ganjam
3b220c62ce Enable Omnient master flags in client code.
Bug: 327638681
Test: Manual
Flag: legacy ENABLE_LONG_PRESS_NAV_HANDLE ENABLED
Change-Id: Id8990ed145b4f035e5cd14e901676ebbd03733dd
2024-03-07 12:39:18 -08:00
Andy Wickham
e92f25d7cb Add custom extra width to trigger LPNH
This is defined in dp from the edge of the nav handle. So if you
set it to 48, you can invoke 48dp from the left or right of the
handle (which is roughly the size of an average fingertip).

You can also set it to a negative value to make the invocation
region smaller. This applies to both navbar and stashed taskbar,
and the minimum touch target is always 48dp.

For reference, the navbar width is 108dp and taskbar is 220dp.

Defaults to 0, i.e. you can only invoke within the visible navbar.

Bug: 325118077
Flag: LEGACY CUSTOM_LPNH_THRESHOLDS DISABLED
Test: Manual
Change-Id: I904a484a99ac4af05de13573fac610b84fd7f0f1
2024-03-04 10:56:16 -08:00
Priyanka Advani
a80997d9eb Revert "Remove Unused parts of LauncherPrefs causing cyclical dependency."
This reverts commit 21ab3b979b.

Reason for revert: Culprit for b/326611479. Will be verifying through ABTD for confirmation and before submitting the revert.

Change-Id: Ib71791d159b3ac65ca332f58500341a1a0fe36e1
2024-02-23 18:05:39 +00:00
Stefan Andonian
21ab3b979b Remove Unused parts of LauncherPrefs causing cyclical dependency.
This "migration" feature was planned as an effort to reduce latency upon
startup. That being said, now that there is a loading screen being added
to pixel startup time, it doesn't make sense to perform a risky data
migration just to save a 100ms or so of startup time. Therefore, I am
removing this code as a clean up effort to make LauncherPrefs simpler.
Also, there was a cyclical dependency introduced in b/324670265 that
makes this cleanup effort especially worthwhile, as it resolves a bug
for other developers.

Bug: 324670265
Test: Installed this on a device and tested that nothing was broken.
Flag: NA
Change-Id: I81df710057d80fbd071bc26a53cb191d453e7dee
2024-02-22 05:50:15 +00:00
Tracy Zhou
89f72882ce Guard taskbar / navbar unification logic with whether the device is a phone on top of the flag
Test: Rerun the tapl tests
Bug: 325162802
Change-Id: Iffeeb0a60b634e66bc80e4ba45db816cdc8ba564
2024-02-15 22:06:33 -08:00
Fengjiang Li
cd60d191a8 [Predictive Back] Replace legacy flag with aconfig flag in launcher
Fix: 323971106
Flag: ACONFIG launcher.enable_predictive_back_gesture DISABLED
Test: manual
Change-Id: Ie8051af2540699a7d75f1ed05132584d0b40d17d
2024-02-05 16:41:29 -08:00
Anushree Ganjam
43a826c579 Merge "Fix the Int value to reflect shared preferences value in TouchInteractionService." into main 2024-01-29 23:15:56 +00:00
Anushree Ganjam
eb5cb75753 Fix the Int value to reflect shared preferences value in TouchInteractionService.
This cl fixes following things

- When featureFlag is present, always read the value from FeatureFlag.get() instead of preferences.

- Add new function getIntFlagBackedUpByLauncherPrefs to read from sharedPreferences

- Make FlagTogglerPrefUi.java updateMenu() public

- When intFlag is modified in Developer Options, Apply button will show up. So launcher can restart and values get applied.

- Omnient Int flags will read from Featureflag.get() instead of shared preferences directly.

Bug: 320696242
Test: Manual
Flag: NA. Developer Options related

Change-Id: Id916b25d0397505d240ea8444d896c8ace826e57
2024-01-29 14:02:32 -08:00
Sunny Goyal
7891425109 Cleaning up release flag: ENABLE_ICON_LABEL_AUTO_SCALING
Bug: 270393294
Flag: N/A
Test: N/A
Change-Id: Ied7e21150e8176f044615959d20e75bb1cad7dfa
2024-01-29 11:18:29 -08:00
Saumya Prakash
b617daa6c6 Merge "Add standalone taskbar edu tooltip for the pinnable taskbar feature" into main 2024-01-18 01:41:14 +00:00
Saumya Prakash
dddebdff0c Add standalone taskbar edu tooltip for the pinnable taskbar feature
This change adds in a standalone edu window for the pinnable taskbar
feature. The reason for the change is to educate users about pinnable
taskbar to those who have already seen taskbar edu before.

Fixes: 302589411, 300161174
Test: Went through taskbar education taskbar with the flag on and off.
Check that the standalone pinning taskbar only shows up if previous
taskbar education was already completed.
Flag:  ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I03a5fb05ae5f15892421a57355f6d503de56d9fd
2024-01-17 21:23:30 +00:00
Jagrut Desai
fff93577e8 Merge "Update enableTaskbarNoRecreate logic" into main 2024-01-12 22:31:15 +00:00
Charlie Anderson
da3138cd91 Replace ENABLE_LAUNCHER_BR_METRICS flags with fixed aconfig flag.
This is necessary because the value of the read-write flag will not be updated in time for backup/restore.

Bug: 307527314
Test: compiles
Flag: ACONFIG ENABLE_LAUNCHER_BR_METRICS_FIXED TEAMFOOD
Change-Id: I67a1a820734d8881b3ed5be4a1f2f1556e6e4704
2024-01-12 14:33:29 -05:00
Jagrut Desai
057144e0f6 Update enableTaskbarNoRecreate logic
Test: Presubmit
Bug: 318567569
Flag: NONE
Change-Id: I6927f0bab0317219a00a7c09c08640825d54e91b
2024-01-12 10:59:10 -08:00
Charlie Anderson
6c4dde2c4d Merge "Adds a legacy flag to enable Launcher BR metrics." into main 2024-01-05 01:32:11 +00:00
Sunny Goyal
1a8f804195 Merge "Removing ENABLE_CACHED_WIDGET since we now have always listenign widget" into main 2024-01-05 00:02:54 +00:00
Charlie Anderson
a4240c72c0 Adds a legacy flag to enable Launcher BR metrics.
This is necessary because the aconfig flag requires reboot to enable, however backup/restore happens on the first load so the flag will not be ready.

Flag: LEGACY ENABLE_LAUNCHER_BR_METRICS TEAMFOOD
Test: compilation / presubmit
Bug: 305984208
Change-Id: Ida90b1bd485fb037ebf3dde7ad17bf4e462661e6
2024-01-04 17:40:51 -05:00
Sunny Goyal
4df719a1e6 Removing ENABLE_CACHED_WIDGET since we now have always listenign widget
> Also using PendingWidgetView for deferred widget view

Bug: 270395008
Flag: LEGACY ENABLE_CACHED_WIDGET enabled
Test: Exising widgets tests pass.
      Verified UI by forcefully rendering deferred widget

Change-Id: Id34f89d778f9f993c1b7ad13f66e57fda9843417
2024-01-04 09:26:10 -08:00
Jagrut Desai
2107717252 Merge "Change Tracking Bug for Taskbar pinning feature flag" into main 2024-01-02 20:52:50 +00:00
Fengjiang Li
abd3d6ddcc Merge "Revert " ALLAPPS PREINFLATION to TEAMFOOD"" into main 2024-01-02 20:00:35 +00:00
Jagrut Desai
5bcad413ec Change Tracking Bug for Taskbar pinning feature flag
Test: Presubmit
Bug: 296231746
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED
Change-Id: I4be1d2a247f0aa6b39854a667b576a523a8a776a
2023-12-20 11:09:50 -08:00
fbaron
e03af75df4 Remove unused flag UNFOLDED_WIDGET_PICKER
this flag was made long before we actually implemented unfolded two pane picker and by that point we migrated to using aconfig so this flag is not used.

Bug: 301918659
Flag: NONE
Test: NONE
Change-Id: Ibc541826d85ae251337567ae0275e1cd02c7bb43
2023-12-15 14:46:39 -08:00
Fengjiang Li
1a0c278622 Revert " ALLAPPS PREINFLATION to TEAMFOOD"
This reverts commit 11d8641e8a.

Reason for revert: ag/25590079 has been submitted to guarantee that we cancel icon preinflation job when device profile is changed.

Change-Id: I2c9254c63d89c389bd83725301c4957c66dad770
2023-12-14 18:19:54 +00:00
Sebastián Franco
d93bb98e02 Merge "Remove ENABLE_NO_LONG_PRESS_DRAG flag." into main 2023-12-14 17:20:45 +00:00
Anushree Ganjam
8a401e8817 Merge "Fix the server side flag name for LPNH_HAPTIC_HINT_DELAY" into main 2023-12-13 22:57:59 +00:00
Sebastian Franco
cefdb28599 Remove ENABLE_NO_LONG_PRESS_DRAG flag.
Fix: 299748096
Flag: LEGACY ENABLE_NO_LONG_PRESS_DRAG ENABLED
Test: atest TaplDragTest
Change-Id: I6f14f2b048e111912fa0d1b8170ca702705e00bc
2023-12-12 15:23:06 -06:00
Anushree Ganjam
0d86f7859f Fix the server side flag name for LPNH_HAPTIC_HINT_DELAY
Bug: 311370599
Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED
Change-Id: I25675cf65f8c7a53ea37d9ba317ddc6dbb271136
2023-12-08 10:17:42 -08:00
Hyunyoung Song
a6a16220d4 Merge " ALLAPPS PREINFLATION to TEAMFOOD" into main 2023-12-07 21:59:07 +00:00
hyunyoungs
11d8641e8a ALLAPPS PREINFLATION to TEAMFOOD
This flag should be enabled again when there is guarantee that
the icons inflated in the background thread is guaranteed to be in the same
device profile as the device profile that is current on the main UI thread

Bug: 312126498
Test: manual
Flag: LEGACY ENABLE_ALL_APPS_RV_PREINFLATION TEAMFOOD
Flag: LEGACY ALL_APPS_GONE_VISIBILITY TEAMFOOD
Change-Id: I9b4dae4327d6bdee135360ca1f40bdec5234ed56
2023-12-07 12:04:10 -08:00
Tony Wickham
18551f29fe Remove ENABLE_TRANSIENT_TASKBAR and long-press stash support
Flag: NA
Test: manual, TaplTestsTaskbar, TaplTestsPersistent, TaplTestsTransient
Fixes: 270395798
Change-Id: I4ecf5ddcd1206e846538175c684043c5e065fd5d
2023-12-06 22:13:10 +00:00
Holly Jiuyu Sun
a568183f55 Merge "[cleanup] Clean up LayoutType.PEOPLE_TILE." into main 2023-12-06 18:32:30 +00:00
Holly Sun
b226257c17 [cleanup] Clean up LayoutType.PEOPLE_TILE.
Bug: 313696037
Test: manual
Flag: LEGACY ENABLE_PEOPLE_TILE_PREVIEW DISABLED
Change-Id: Iae66c86357ef50a97083c79d6a94d038ad83dcf1
2023-12-04 11:14:00 -08:00
Andreas Agvard
fd7f192a0a Enables ENABLE_SEARCH_HAPTIC_COMMIT
ENABLE_SEARCH_HAPTIC_COMMIT should be enabled for now to keep consistency in
behavior.

Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_COMMIT ENABLED
Bug: 314005577
Change-Id: I98e2dea91fe58b6abaeeb63f6c92a5ee130b5204
2023-12-01 21:16:14 +01:00
Andreas Agvard
1ea0746e1c Adds support for shrinking nav handle on press
Fix: 314158312
Flag: LEGACY SHRINK_NAV_HANDLE_ON_PRESS DISABLED
Test: Manual

Change-Id: Icd46467939ae9a38592ee67ee0d2a521eb8e0b6c
2023-12-01 17:54:41 +01:00
Andy Wickham
faa97d6224 Merge "Adds ENABLE_SEARCH_HAPTIC_COMMIT feature flag." into main 2023-11-30 20:17:42 +00:00
Saumya Prakash
89b93d4bbd Merge "Add taskbar pinning education for new users and update other steps" into main 2023-11-30 20:08:13 +00:00
Tracy Zhou
aa759645cf Merge "Use enableSplitContextually() to guard split keyboard shortcut feature" into main 2023-11-30 18:43:13 +00:00
Tracy Zhou
6209f34b02 Use enableSplitContextually() to guard split keyboard shortcut feature
enableSplitFromFullscreenWithKeyboardShortcuts() depends on enableSplitContextually() from the product perspective, hence merging these two flags

Bug: 270394122
Test: N/A
Change-Id: Iecf46a62bfa21ed0c3bad9ca8c9e2646b3aebc78
2023-11-29 22:20:42 -08:00