Commit Graph

2311 Commits

Author SHA1 Message Date
Treehugger Robot
9cafa2f8e2 Merge "Revert "Revert "Don't allow Desktop tasks to go outside Overview..."" into main 2024-11-04 15:34:43 +00:00
Sam Cackett
1ecdc2d712 Revert "Revert "Don't allow Desktop tasks to go outside Overview..."
Reland submission "Don't allow Desktop tasks to go outside Overview task bounds"

Reverted changes: /q/submissionid:30210454-revert-30114356-desktop-task-view-corner-clipping-KXYKHZHSWL

Change-Id: Ia263edcc876f9f72ca7f70733e96b0823dbd750e
Fix: 376206104
Flag: com.android.window.flags.enable_desktop_windowing_mode
Test: OverviewDesktopTaskImageTest, TaplTestsOverviewDesktop
2024-11-04 10:40:57 +00:00
Sam Cackett
127eb0b44d Merge "Revert "Don't allow Desktop tasks to go outside Overview task bounds"" into main 2024-11-04 10:01:08 +00:00
Manusaran Reddy Avula (xWF)
e906e733be Revert "Don't allow Desktop tasks to go outside Overview task bounds"
Revert submission 30114356-desktop-task-view-corner-clipping

Reason for revert: Culprit for b/376872073

Reverted changes: /q/submissionid:30114356-desktop-task-view-corner-clipping

Fix: 376872073
Bug: 376206104
Change-Id: I51c8b11a868a727145f0bc8a6feb13352a8cbead
2024-11-04 10:00:23 +00:00
Treehugger Robot
72a6d4539a Merge "Don't allow Desktop tasks to go outside Overview task bounds" into main 2024-11-01 12:35:20 +00:00
samcackett
3ae3d297e6 Don't allow Desktop tasks to go outside Overview task bounds
Wrap TaskThumbnailView's in a new DesktopTaskContentView. This is in order to correctly crop the thumbnail children contained in the DesktopTaskView, otherwise any freeform task screenshots at the edges of the DTV leak outside the bounds.

We need a new container to do this, otherwise we will cut off the icon
or the hover border if we apply an outline to the DesktopTaskView itself.

Fix: 376206104
Flag: com.android.window.flags.enable_desktop_windowing_mode
Test: OverviewDesktopTaskImageTest
Change-Id: Ic51438e63aaf671a0a8156815d11fc7fa12beac0
2024-10-30 07:22:45 +00:00
Tracy Zhou
9b18ec739a Merge "Tuning gesture nav params for trackpad 3-finger gestures" into main 2024-10-29 22:12:28 +00:00
Tracy Zhou
21bb53ff08 Tuning gesture nav params for trackpad 3-finger gestures
It's harder to slow down in trackpad swipes than finger swipes on the screen, so the deceleration required to be considered pause for swiping from app should be less strict (set the number for trackpad to 0.85f instead of 0.6f for on-screen). Also added a speed_trackpad_somewhat_fast for the case of swiping up to overview, so that we can be a little bit more lenient to the users for the end speed.

Bug: 375688524
Test: play with 3-finger swipe to home / overview. Make it easier to go to overview, but fast swipe from app still takes user to home
Flag: EXEMPT bugfix
Change-Id: I196a92163fd36e9b7013f4893876b79c9c2c9de0
2024-10-29 13:10:49 -07:00
Bill Yi
11d7806cdd Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic07e472cbad23a039bb8a9d8a3db2fd22e08d6b4
2024-10-28 22:56:31 -07:00
Anushree Ganjam
ba8c0a8fbd Merge "Make ApiWrapper to be injected by dagger (12/n)" into main 2024-10-25 19:27:50 +00:00
Treehugger Robot
38c94afefc Merge "Actually merge the colors for recent indicators." into main 2024-10-24 23:26:18 +00:00
Anushree Ganjam
ef2c5c0e49 Make ApiWrapper to be injected by dagger (12/n)
Bug: 361850561
Test: Manual
Flag: EXEMPT Dagger Integration
Change-Id: I53ec78999085b3e0ad6df69e177806e0cb1b52d1
2024-10-24 12:14:40 -07:00
Wen-chien Wang
94fb42cef9 Merge "Add margins to KQS view that is triggered from taskbar" into main 2024-10-24 17:47:37 +00:00
Treehugger Robot
46a98e1827 Merge "Update taskbar overflow button" into main 2024-10-23 22:49:37 +00:00
Brian Isganitis
c0a18d57e8 Actually merge the colors for recent indicators.
Forgot to do a git add :)

Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Bug: 356394053
Test: go/testedequals
Change-Id: I42f85f5850152f498db8a399835b19a5e493c68d
2024-10-23 14:45:49 -04:00
Treehugger Robot
debda9cdd9 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-10-23 17:34:58 +00:00
Toni Barzic
a5b6c155b6 Update taskbar overflow button
Creates a new view for the taskbar overflow button that draws up to 4
recent item previews. The items are stacked on top of each other in
counter clockwise order, with overlapping bounds, recent items closer
to the top. The item icons have a 2 dip ring around them, of the taskbar
background color.

Adjusts logic to calculate which items become part of the overflow
button, so more recent items get shown in the taskbar.

Initial consideration was to usse FolderIcon to represent the overflow
button, but decided against it because:
*    FolderIcon is fairly entangled with the associated folder view
*    item information uses different data structure (ItemInfo) than
     recent items (GroupTasks)
*    item preview layout within the main icon is similar, but
     sufficiently different that using clipped folder layout rules felt
     like hacking around assumptions made for folder icon UI

Bug: 368119679
Test: Keep opening apps until the task bar enters overflow - verify that
overview button shows up, and contains least recent task
representations. Keep adding items, then closing windows, and verify
the icon gets updated accordingly. Done in landscape and portrait, and
ltr and rtl layout.
Flag: com.android.launcher3.taskbar_overflow

Change-Id: I2824cb0db1f7516ebd74361ce00fb8887857325d
2024-10-23 17:05:58 +00:00
Wen-Chien Wang
69ed08ef86 Add margins to KQS view that is triggered from taskbar
Bug: 368119679
Test: open KQS via taskbar and observe the bounds change
Flag: com.android.launcher3.taskbar_overflow
Change-Id: I5060a339cf0cdf70a2a11b57a325767405772ef8
2024-10-23 04:03:50 +00:00
Bill Yi
451a5e395f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie3164382c2b9dbf6623f91721a88a2347b9fdde1
2024-10-22 13:45:15 -07:00
Brian Isganitis
27e05992f6 Update recent indicators to match spec.
Does not implement any animations.

Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Fix: 356394053
Test: go/testedequals
Change-Id: If8e319b605beedd0e9b14dc37da1b5ffa12f3c9f
2024-10-21 15:04:03 -04:00
Liran Binyamin
2c908e2c10 Merge "Wire up flyout to new bubble animation" into main 2024-10-21 12:20:23 +00:00
Artsiom Mitrokhin
a182675128 Merge "Open taskbar pinning popup view from anywhere" into main 2024-10-18 16:25:15 +00:00
Liran Binyamin
12f77ba713 Wire up flyout to new bubble animation
When a bubble is created or updated we now animate the flyout view
as part of the bar animation.

Note that the flyout is not clickable yet, and that we're not yet
handling bubble notifications interrupting each other.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarViewAnimatorTest
Test: atest BubbleBarFlyoutControllerTest
Test: manual
       - verify flyout view is showing when creating bubble
          - on home
          - in app
          - when bubble bar is empty
Change-Id: I315e46c89a4d20aaaa22972f0d71290a63481d9d
2024-10-18 08:00:05 -04:00
Sunny Goyal
4eaf3df1fe Merge "Moving PluginManager to dagger" into main 2024-10-17 21:47:28 +00:00
Artsiom Mitrokhin
ab7220c342 Open taskbar pinning popup view from anywhere
This CL handles both long-press and right-click events anywhere on
pinned taskbar and opens `TaskbarDividerPopupView` correctly
positioning it above the event coordinates.

Bug: 297325541
Flag: com.android.launcher3.show_taskbar_pinning_popup_from_anywhere
Test: manual for now, flip the flag, long-click or right-click
      on empty space on the pinned taskbar
Change-Id: I1849db14f65bf9478ed9f4fd39f95d08987baf8d
2024-10-17 15:00:40 -04:00
Sunny Goyal
9cd3154952 Moving PluginManager to dagger
Multiple singletons depend on Plugin which can cause deadlock
if PluginManager is initialized on main thread

Test: presubmit
Bug: 361850561
Bug: 373557167
Flag: EXEMPT dagger
Change-Id: I79f17ac6b78a2ce60df2d27a6e794b9e4eba1b51
2024-10-17 11:48:38 -07:00
Bill Yi
7cbcaa7b67 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie3e674cb84d50b961c50a5beb5616fbd002957db
2024-10-16 18:08:40 -07:00
Graciela Putri
19c00bb849 Merge "Add task menu item to move task to external display" into main 2024-10-15 16:51:20 +00:00
Graciela Wissen Putri
2f4ccc63b6 Add task menu item to move task to external display
Call SystemUiProxy.moveToExternalDisplay to move existing Overview task to desktop in external display

Bug: 372872848
Test: atest
NexusLauncherTests:com.android.quickstep.ExternalDisplaySystemShortcutTest
Flag: com.android.window.flags.move_to_external_display_shortcut
Change-Id: I096a9839956ab5cab86bd0aaabc625a8587ca42a
2024-10-14 15:14:01 +00:00
Andy Wickham
0b936727d6 Migrate Contextual Search code to AOSP
- Adds ContextualSearchInvoker
 - Adds ContextualSearchStateManager
 - Adds ContextualSearchHapticManager

Example output from ContextualSearchStateManager
in TouchInteractionService dump:
https://paste.googleplex.com/5536017815961600

Bug: 353715553
Test: go/contextual-search-entrypoints-test-plan
Flag: EXEMPT moving code from vendor to aosp

Change-Id: I8253294d6be427e0fc29d6052994de0c03f05a3e
2024-10-10 21:03:42 +00:00
Liran Binyamin
c25aa0c20f Create container view for bubble bar
The container will be used to inflate the bubble bar flyout view

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: builds successfully -- code is not wired up yet

Change-Id: I3012caa801c73f9e13f26c8803595b59e250ae1e
2024-10-09 11:09:48 -04:00
Treehugger Robot
4205a76f23 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-10-08 05:00:24 +00:00
Bill Yi
b485d4f2ce Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I2575d05bf399281cc1f6ab5a81bb7646d1410f03
2024-10-07 13:39:26 -07:00
Liran Binyamin
75675e123d Rename bubble bar flyout fields
Long term we'd like to use bubbles for any app, so this change
uses more general names instead of the chat-specific naming

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: built and tested on a device
Change-Id: Idec2aa7d9a8df5df0df49231e8871298084f8aa1
2024-10-07 10:37:55 -04:00
Bill Yi
d77f2c1692 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I281ab493777a8d86477c5f5ca1f069cd368af5c3
2024-10-01 10:28:27 -07:00
Bill Yi
2321e1a323 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I5a631a9968edafb4f7cdc83a9b0a21cd7bb65b12
2024-09-26 19:15:19 -07:00
Tracy Zhou
9c9f9a887e Merge "Update suw insets in landscape" into main 2024-09-25 23:27:41 +00:00
Treehugger Robot
d3e1d7ba42 Merge "Fixes to allow enabling of enable_refactor_task_thumbnail flag" into main 2024-09-25 02:48:24 +00:00
Uwais Ashraf
61e6cb27ed Fixes to allow enabling of enable_refactor_task_thumbnail flag
Fix: 362664267
Test: presubmits
Test: Flakiness check run - https://android-build.corp.google.com/builds/abtd/run/L80100030006605258 (shows an acceptably low flake rate)
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I10ef75d6298498ae827de6408ad661fba09cbde5
2024-09-24 15:04:39 +00:00
Bill Yi
36dc0f868c Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I0a8c27aa28eab5f125b478ad4f662655168d5a46
2024-09-23 21:57:58 -07:00
Tracy Zhou
45aa9fdad8 Update suw insets in landscape
I don't know why this was set to 24dp instead of 48dp in portrait (I didn't write this). Let me know if you know the spec

Fixes: 365505500
Test: manual
Flag: EXEMPT bugfix
Change-Id: I5dc5c45e8c4e3952e300e64952462f72bc633908
2024-09-23 17:56:33 -07:00
Jon Miranda
7645ef2ebd Simple implementation of Taskbar Overflow.
- Adds placeholder view to represent the Overflow affordance.
- Overflow button will always appear as long as there are any
  recent apps.*
- Click / long click on the button will open KeyboardQuickSwitch
- Relevant code is Guarded by Flags.taskbarOverflow.

*Note that this is not up to spec. This change is only meant to
setup the codebase to support Taskbar Overflow.

Bug: 368119679
Test: open app, enter desktop windowing, click overflow button
Flag: com.android.launcher3.taskbar_overflow
Change-Id: I47f96797408fda09e8326ba8fb7981c91de80e36
2024-09-21 00:28:20 +00:00
Liran Binyamin
7b0c32567f Merge "Update bubble bar flyout according to spec" into main 2024-09-20 16:42:34 +00:00
Brandon Dayauon
49699b7378 Merge "Update work paused card stokre button to be Primary" into main 2024-09-19 23:41:54 +00:00
Brandon Dayauon
de677d44ca Update work paused card stokre button to be Primary
bug: 362879558
Test manually photo:
beforeLT:https://drive.google.com/file/d/19hsXI3y0m1XgMl2CSxfbAin3U5kL3sB-/view?usp=sharing
beforeDT:https://drive.google.com/file/d/1dPCKZlANJXnM1EAXwaryBSStxYW0f8Pp/view?usp=sharing
afterLT:https://drive.google.com/file/d/1RUMDlgidUw9CEGTiu7PvxwnpLTWTSoXO/view?usp=sharing
afterDT:https://drive.google.com/file/d/1QKzJvieLQZQp1UiG-kQfVxl5gPeIYQX9/view?usp=sharing
Flag: NONE color fix

Change-Id: Ie3b0ec58e293e9d3bf861ff7832f20010d0bff8d
2024-09-19 11:07:12 -07:00
Liran Binyamin
19a43fb7cf Update bubble bar flyout according to spec
Also add a triangle

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutViewScreenshotTest
Test: atest BubbleBarFlyoutControllerTest
Change-Id: I1a16ba6c9e1a2ca4efe01524ba3ef1d049f81d68
2024-09-19 14:02:43 -04:00
Treehugger Robot
1880988d5f Merge "Make AllSetActivity IDP change-aware" into main 2024-09-18 19:21:18 +00:00
Schneider Victor-Tulias
e57c034554 Make AllSetActivity IDP change-aware
Flag: EXEMPT bug fix
Fixes: 366129654
Test: adb shell cmd overlay enable-exclusive --category com.android.internal.systemui.navbar.threebutton while in AllSetActivity
Change-Id: I42dec6a94bf445866828b7404ae5451d505fda02
2024-09-18 10:22:23 -04:00
Liran Binyamin
c2c7913134 Merge "Create BubbleBarFlyoutView" into main 2024-09-18 14:21:26 +00:00
Liran Binyamin
36b5ef2271 Create BubbleBarFlyoutView
Initial version of the flyout view for displaying bubble bar
notification.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutViewScreenshotTest
Test: atest BubbleBarFlyoutControllerTest
Change-Id: I5d0643fe5d2691ad2349b45eaaad6cd2660d9df0
2024-09-17 11:14:54 -04:00