Commit Graph

11894 Commits

Author SHA1 Message Date
Tony Wickham
4c7507571c Merge "Only detect swipe directions that lead to new states" into ub-launcher3-edmonton 2018-05-03 21:38:04 +00:00
android-build-team Robot
6e95c8f34c Merge "Fixing wrong padding being set in multi-window + landscape" into ub-launcher3-edmonton 2018-05-03 21:33:16 +00:00
Sunny Goyal
b44e80000c Fixing wrong padding being set in multi-window + landscape
In multi-window, we only have the correct availableWidth and not the correct width.
Use availableWidth for setting padding instead of fullWidth

Change-Id: Id437088eea49ab5ad103ded6eed904d776e728c9
2018-05-03 14:19:39 -07:00
Tony Wickham
52240a3aa0 Only detect swipe directions that lead to new states
This cleans up the code and ensures that the current state animation
is always initialized when we get drag events.

Also log when we pass through states.

Bug: 78017680
Change-Id: I54ab42923ed539940ea708973ad65f5793669c11
2018-05-03 14:04:25 -07:00
Tony Wickham
257c9ea8d1 Merge "Don't crash if getWidth is 0" into ub-launcher3-edmonton 2018-05-03 20:59:40 +00:00
Winson Chung
83f58f2d2c Fix incorrect reporting of launch failure
- Launcher uses the same consumer to handle task launch failure and
  animation-cancel, so only show the notification when it is an
  actual launch failure.

Bug: 79209142
Change-Id: I6b708ac9888673056f2c6de1d5aee4a281c61027
2018-05-03 20:37:35 +00:00
Tony Wickham
181968b87b Don't crash if getWidth is 0
Bug: 79203256
Change-Id: I3f91adbda40931e882c4f768794a0d803730805e
2018-05-03 12:50:05 -07:00
Winson Chung
3f596f649d Also setEarlyWakeup for single frame transaction to hide window.
Bug: 79204453
Change-Id: Ib13f8a0c49b03fdce960b3f480c598bb70a113ef
2018-05-03 18:24:06 +00:00
Winson Chung
9ebc88a381 Fixing transaction regression.
- Need to call setEarlyWakeup() for each transaction, not just the
  first

Bug: 79204453
Change-Id: Ib83bddb9eaeb7563954bc9d7f584fdd5d302b501
2018-05-03 10:57:23 -07:00
Winson Chung
94262dedb7 Skip snapping to page when there are no pages
- This scrolls the recents view, which affects the empty recents icon
  position.

Bug: 79170402
Test: Clear all tasks, then quickscrub
Change-Id: I316805c0083d4ad65a8df0fafd88545859054405
2018-05-02 17:45:14 -07:00
android-build-team Robot
b8e5bf3e42 Merge "Handling activity recreate due to configuration changes in the middle of the long fling" into ub-launcher3-edmonton 2018-05-02 23:16:13 +00:00
android-build-team Robot
d5efb650af Merge "Using a custom view instead of ImageView to avoid relayout when the icon changes" into ub-launcher3-edmonton 2018-05-02 22:59:02 +00:00
Sunny Goyal
16593d7932 Handling activity recreate due to configuration changes
in the middle of the long fling

Bug: 77651657
Change-Id: I8107c424eb37512ce78c943da04a6e7faf33be65
2018-05-02 15:53:22 -07:00
Sunny Goyal
85c53f2af5 Using a custom view instead of ImageView to avoid relayout when the icon changes
Bug: 78585335
Change-Id: I078aec5b80ec45933ba4974df68cab23ac4a0ca0
2018-05-02 15:38:21 -07:00
Hyunyoung Song
960ab6c085 Merge "Clear all task button should not log as individual swipe up Bug: 78895803" into ub-launcher3-edmonton 2018-05-02 22:32:55 +00:00
android-build-team Robot
433ef09d29 Merge "Moving some callbacks from LauncherCallbacks to OverviewCallbacks" into ub-launcher3-edmonton 2018-05-02 22:06:10 +00:00
android-build-team Robot
145cb8420d Merge "Log OVERVIEW_ACTIVITY via MetricsLogger in quickstep Bug: 77920179" into ub-launcher3-edmonton 2018-05-02 21:53:59 +00:00
Hyunyoung Song
a05860421f Log OVERVIEW_ACTIVITY via MetricsLogger in quickstep
Bug: 77920179

Change-Id: Id4c7dc3d535c7a8009d340183e640b04ab07408a
2018-05-02 14:34:23 -07:00
Tony Wickham
1817942d8a Merge "Add a quick scrub threshold" into ub-launcher3-edmonton 2018-05-02 21:21:24 +00:00
android-build-team Robot
a978a24d09 Merge "Making Clear-all a "button" for accessibility." into ub-launcher3-edmonton 2018-05-02 21:20:37 +00:00
Vadim Tryshev
1e3687d5a1 Making Clear-all a "button" for accessibility.
To get it announced as "Clar all button", not just "clear all".

Bug: 72222505
Test: Manual
Change-Id: Ied1a036fda77c38af39db868d3dc1ae443982bcd
2018-05-02 13:54:38 -07:00
android-build-team Robot
9b83fe225d Merge "Quickstep onboarding backward compatibility for devices release with Android N & O." into ub-launcher3-edmonton 2018-05-02 20:51:37 +00:00
Jon Miranda
ce1402132a Tweaks to opening app window animation.
We decrease the the durations for the downward app launch animations (by 80%)
except for the scale animation.

We do this because we want the window to reach the center faster so that the
window never goes off screen as it scales up.

Bug: 78891245

Change-Id: I6ece6ee1f01d32f2fcee42bba6a99c72b82f9023
2018-05-02 13:49:53 -07:00
Tracy Zhou
8b23c6f60b Quickstep onboarding backward compatibility for devices release with Android N & O.
Quickstep introduces swipe up gesture to open Overview and removes the
Recents button. We still want to show shelf bounce animation for Android
N & O users with Recents button because Overview is updated and swiping
up from there takes users to All Apps.

Test: manual test
Change-Id: I917c91564c47c78d2dc3883b8a7bf7824b5f5bc8
Fixes: 78647939
2018-05-02 13:41:28 -07:00
android-build-team Robot
d79759556d Merge "New calculation for clear-all alpha." into ub-launcher3-edmonton 2018-05-02 20:39:15 +00:00
Vadim Tryshev
80cd825c0f New calculation for clear-all alpha.
Per UX feedback, alpha changes from the central position of the last
task and its overscrolled position. Button location is not used.

Bug: 72222505
Test: Manual
Change-Id: Ifc22c935940eaeb1b1ec6e4a5f2709ac7ae8253b
2018-05-02 13:14:16 -07:00
Tony Wickham
cf563e5f2d Add a quick scrub threshold
Change-Id: I184ca2bd3d97e58f8fe8841a66571ca101ee3dc2
2018-05-02 12:03:22 -07:00
Tony Wickham
f325b19de3 Merge "Gracefully handle some edge cases in quick scrub" into ub-launcher3-edmonton 2018-05-02 16:21:21 +00:00
Tony Wickham
7a5d4ae64f Merge "Fix some state issues with user-controlled animations" into ub-launcher3-edmonton 2018-05-02 16:20:19 +00:00
Jorim Jaggi
bbeedd1d2f Merge "Fix some jank with transitions" into ub-launcher3-edmonton 2018-05-02 13:17:42 +00:00
Sunny Goyal
8e1fbc5103 Moving some callbacks from LauncherCallbacks to OverviewCallbacks
Bug: 78780639
Change-Id: I90f868c741834efbe542367bdc3539f6d14f1939
2018-05-01 16:58:52 -07:00
Hyunyoung Song
78e278e9db Clear all task button should not log as individual swipe up
Bug: 78895803

Change-Id: I3a8c40e892396ea0781423fa1791a9e13a116c45
2018-05-01 15:47:26 -07:00
Tony
f47e5ce3cf Gracefully handle some edge cases in quick scrub
- Switch to normal overview if task fails to launch in onQuickScrubEnd()
- Stop auto-advancing if recents isn't visible
- Wait until transition to quick scrub completes before launching

Bug: 77521777
Bug: 78557737
Change-Id: I5206c0d3c52bf792f52cf3e7adcf03f8a2de18bb
2018-05-01 14:21:04 -05:00
Tony
31fbd4c08b Fix some state issues with user-controlled animations
Previously, user-controlled animations weren't properly being canceled when a
non-user-controlled animation started, e.g. when hitting home. Thus, we could
end in the wrong or inconsistent state because the user-controlled animation's
end runnable was still used. Now we add a cleanup callback for when we reset
the user-controlled animation for one that isn't user-controlled.

Also fixed a couple typos.

Tests (easier with animation durations extended):
- Swipe up and hit home before reaching overview -> land on home
- Go to overview, swipe down slightly (before threshold to go to workspace)
  and let go -> return to overview without flash (recents was resetting)
- Swipe up, press home while swiping -> goes home, stops responding to drag
- Start dismissing task and hit home before it finishes (or while dragging)
  -> goes home, stops responding to drag

Bug: 78249220
Change-Id: If11d8999e3fadba38c987b25af67cd2304cd859b
2018-05-01 13:45:27 -05:00
Winson Chung
976047647e Merge "Also notify the user when a task view fails to launch." into ub-launcher3-edmonton 2018-05-01 18:41:02 +00:00
android-build-team Robot
a269a81881 Merge "Accessibility of clear-all button" into ub-launcher3-edmonton 2018-05-01 18:31:25 +00:00
Winson Chung
6dceb7755a Also notify the user when a task view fails to launch.
Bug: 78660939

Change-Id: I8041d3bdd6da1caed72affb1e295c416214a92d4
2018-05-01 11:27:02 -07:00
Vadim Tryshev
4e3e54a45a Accessibility of clear-all button
Making it visible to accessibility even when it’s completely hidden
behind a task. I had to mark it visible as a view. Now it’s invisible
only when there are no tasks in RecensView, to hide it from
accessibility.

Focusing on the button completely reveals it.

Bug: 72222505
Test: Manual
Change-Id: Ia31a1136e07faed93b4a44d5be69483d3b88364d
2018-05-01 11:20:14 -07:00
android-build-team Robot
954157a228 Merge "Remove associated task views if task is removed while Overview is showing" into ub-launcher3-edmonton 2018-05-01 18:12:34 +00:00
Winson Chung
3b0c3b981b Remove associated task views if task is removed while Overview is showing
Bug: 78660939
Change-Id: Iccfb09c985662c150f42d382b92d17f853abaaea
2018-05-01 10:04:46 -07:00
android-build-team Robot
4c6b638e24 Merge "Secondary split screen app will be next to the navigation bar (2/2)" into ub-launcher3-edmonton 2018-05-01 00:40:27 +00:00
Sunny Goyal
36d090df67 Adding a round rect background for the self in Overview
Bug: 78771910
Change-Id: I71460a284ed185e82d66fe65104402fb99d6b312
2018-04-30 15:37:39 -07:00
Matthew Ng
8013843fbd Secondary split screen app will be next to the navigation bar (2/2)
Refactored docked position code into PhoneWindowManager to determine
which side the docked app should go based on the position of the nav bar
in landscape (as portrait will only have top). Fixed the split screen
entrance animation for quick step's overview.

Change-Id: I0035214cecb9c6403c59f4b938c2d1ae924f34b0
Fixes: 73250406
Test: play around with splitscreen and minimized mode
2018-04-30 15:01:32 -07:00
android-build-team Robot
6dcf142f61 Merge "Fixing task open animation in split screen mode" into ub-launcher3-edmonton 2018-04-30 21:27:38 +00:00
Vadim Tryshev
83b4bb0421 Making sure Clear-all button can't be clicked when transparent
There are times when the button is visible, but completely transparent.
Fixing: now when transparent, it's invisible, consequently, unclickable.

Bug: 72222505
Test: Manual
Change-Id: I1be162b56d6e694199fad7845c64f3438415a190
2018-04-30 12:14:58 -07:00
android-build-team Robot
3aa3eb51e2 Merge "Alpha-optimizing Clear All button." into ub-launcher3-edmonton 2018-04-28 03:20:08 +00:00
Vadim Tryshev
94ab3eee48 Alpha-optimizing Clear All button.
Similar approach is used for its sister buttons in System UI
(like id/dismiss_text which is
"FooterViewButton extends AlphaOptimizedButton").

Bug: 72222505
Test: Manual
Change-Id: Ibb8157bfbf2bf9cddb501c1e80fb9c7c79bb694b
2018-04-27 20:02:38 -07:00
android-build-team Robot
68f138990b Merge "Let Launcher handle proxy touch events even if it is not focused" into ub-launcher3-edmonton 2018-04-28 00:25:01 +00:00
Sunny Goyal
09cc13e20c Let Launcher handle proxy touch events even if it is not focused
Bug: 74616863
Bug: 78367228
Change-Id: I8c9271e95583793af0832e3b07c988261b6267e8
2018-04-27 17:14:05 -07:00
Hyunyoung Song
cbebaa19f9 Add user event logging for clear all button (follow up CL)
Bug: 72222505

Change-Id: I95e3bb8dbf55e9ae4ca8de4040eb89ddfb161368
2018-04-27 16:39:23 -07:00