Commit Graph

19452 Commits

Author SHA1 Message Date
Fengjiang Li
94de34ce2f Merge "[Launcher Jank] Avoid SimpleBroadcastReceiver making binder calls on main thread" into main 2024-06-24 21:00:41 +00:00
Hongwei Wang
4f35222eb6 Merge "Offset display cutous on foldables" into main 2024-06-24 20:29:39 +00:00
Brian Isganitis
5ee679dbb8 Merge "Introduce TestRule for setting Taskbar mode." into main 2024-06-24 20:17:24 +00:00
Jagrut Desai
a7ec8fe852 Merge "Fix taskbar background alpha" into main 2024-06-24 20:14:28 +00:00
Jagrut Desai
eba5d919ef Fix taskbar background alpha
Test: Manual
Bug: 345018985
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Change-Id: Ic675285724bcf64b7bd03f918703defb4dc12a47
2024-06-24 13:11:51 -07:00
Brian Isganitis
cbc07b4282 Introduce TestRule for setting Taskbar mode.
This rule is separate from TaskbarUnitTestRule, because mode isn't
relevant to all Taskbar controllers.

To keep MainThreadInitializedObject behavior consistent across
Robolectric and Instrumented environments, context needs to be a SandboxContext.

Test: TaskbarModeRuleTest
Bug: 230027385
Flag: TEST_ONLY
Change-Id: Iae2e3627b9002e13ee6da135113e7b8bcc4e7d47
2024-06-24 14:34:45 -04:00
Alex Chau
20a077029c Merge "Disable Select mode from Menu in fake landscape" into main 2024-06-24 14:35:43 +00:00
Alex Chau
2026c80016 Disable Select mode from Menu in fake landscape
Fix: 349072279
Test: Verify that Select mode is only available from Menu in grid only Overview on tablets
Flag: EXEMPT bugfix
Change-Id: Icd0d8303547b45d3653696812c51ce2c2bfd410b
2024-06-24 13:41:37 +01:00
Treehugger Robot
c1391754ff Merge "Enable currently functional multivalent tests" into main 2024-06-24 01:17:40 +00:00
Uwais Ashraf
c902df4e41 Enable currently functional multivalent tests
Flag: EXEMPT test-only
Bug: 325088619
Bug: 325088638
Bug: 325088328
Test: Presubmit
Test: Gradle robolectric run
Change-Id: I20e77a401ed98c97168bf9c752eacc93c3c545dd
2024-06-22 22:14:30 +00:00
Treehugger Robot
0abbc4af14 Merge "Add scrim to TaskThumbnailView" into main 2024-06-22 01:22:31 +00:00
Treehugger Robot
f53b40e1a9 Merge "[Launcher Jank] Allow list OverviewCommandHelper making IActivityTaskManager$Stub$Proxy.startActivity from main thread" into main 2024-06-21 23:36:22 +00:00
Jon Miranda
f044d12fcc Merge "Fix taskbar bg delay for the case when user is going home." into main 2024-06-21 23:16:11 +00:00
Treehugger Robot
b938fa20b2 Merge "Close floating views before fake rotation" into main 2024-06-21 22:46:03 +00:00
Fengjiang Li
1f87d94e59 [Launcher Jank] Avoid SimpleBroadcastReceiver making binder calls on main thread
Fix: 348649441
Flag: NONE - jank fix
Test: manual - presubmit
Change-Id: Ie97713f3f0b1f117662d49c6d6a65651c593d424
2024-06-21 14:37:51 -07:00
Jon Miranda
09aa46b88e Fix taskbar bg delay for the case when user is going home.
The default value was not set. I decided to flip the variable to make
it more readable.

Bug: 345768019
Test: swipe up fast to go home, note no taskbar bg
      swipe up slow to reveal taskhome, note taskbar bg shows immediately
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Change-Id: I7fb4bbdce45a14312e42abcf71f7f0643376ddc6
2024-06-21 14:27:01 -07:00
Tony Wickham
74fc385999 Merge "Load and draw Recent/Running tasks that aren't in Hotseat" into main 2024-06-21 21:01:41 +00:00
Tony Wickham
a79bc15cd0 Merge changes from topic "taskbar-running-minimized" into main
* changes:
  Maintain Running Tasks order in Desktop mode
  Change running apps section to use GroupTask instead of AppInfo
2024-06-21 21:00:01 +00:00
Tony Wickham
59e8952fc9 Merge "Handle running task launch properly in desktop mode" into main 2024-06-21 20:57:38 +00:00
Treehugger Robot
f4934108bb Merge "Fix bubble bar bounce animation issue" into main 2024-06-21 20:44:10 +00:00
Hongwei Wang
87b4060106 Offset display cutous on foldables
When entering PiP on foldables, especically in unfolded mode, offset the
display cutouts even if it's from ROTATION_0 (which is always the case
in unfolded state).

Flag: NONE bug fix
Before: http://recall/-/aaaaaabFQoRHlzixHdtY/eIR7VykaHpYeOigkuZVTp
After: http://recall/-/aaaaaabFQoRHlzixHdtY/cP7NticbA68I4eev2MyZgc
Bug: 331128612
Test: Hold unfolded foldable in different orientation, enter PiP
Test: Hold folded foldable in different orientation, enter PiP
Test: see also the videos
Change-Id: I62e8d3f361644ca0ca78ef20b3d3b5441d7f26c8
2024-06-21 12:06:52 -07:00
Fengjiang Li
c5005171a6 [Launcher Jank] Allow list OverviewCommandHelper making IActivityTaskManager$Stub$Proxy.startActivity from main thread
Added comments

Fix: 348668521
Test: presubmit
Flag: NONE - add comment
Change-Id: I0b3cfb4ee7d05c3b3d2f2857542f1a76a5af7e1f
2024-06-21 12:04:04 -07:00
Alex Chau
bde639236f Close floating views before fake rotation
- We do the same in Launcher for real rotation

Fix: 348113790
Test: manual
Flag: EXEMPT bugfix
Change-Id: Ibd5f42db439cd94a389f7aaf6fe2db317c11cd67
2024-06-21 18:37:21 +01:00
Uwais Ashraf
0d9b547471 Add scrim to TaskThumbnailView
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Fix: 334832108
Fix: 348195366
Test: Manual - checked scrim in un/folded
Change-Id: I758a26e9b4498dac509b75afbe059784557b3f8c
2024-06-21 16:27:01 +00:00
Mady Mellor
a2146c8f10 Merge "Update bubble bar overflow to have a unique resId" into main 2024-06-21 15:55:04 +00:00
Hongwei Wang
a648d13ea8 Merge "Position PiP animation based on actual coordinates" into main 2024-06-21 02:51:37 +00:00
Liran Binyamin
cdc3e4d8b4 Fix bubble bar bounce animation issue
The bubble bar bounce animation was assuming that the initial translation
of the bubble bar is also the translation the bubble bar should have at
the end of the animation. This is normally correct except when the
bubble bar is initially hidden. What happens in that case is that the
translation is 0 so the bubble bar gets animated incorrectly.

This change gets the target animation from stash controller.

ABTD 100 runs: https://android-build.corp.google.com/abtd/run/L26900030004638356/

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 347856510
Test: atest BubbleBarTest#selectDifferentBubble
Change-Id: I661bf006c6f23ff871c221f8d9da74d79a2dff11
2024-06-20 18:03:52 -04:00
Liran Binyamin
8af78f19a3 Merge "Animate bubble removal from the bar" into main 2024-06-20 20:57:34 +00:00
Hongwei Wang
cd6172911e Position PiP animation based on actual coordinates
In the previous patchset, we assumed the left/top to be 0/0 which is not
always the case. This could break, for instance, in ActivityEmbedding
setup, where the pip-ing app is on the left side.

Flag: NONE test fix
Bug: 345327260
Test: Verify with apps support auto-enter PiP such as YouTube
Change-Id: Ic2f3289cf0663d0687d5ccd7f4d0250066cb3f67
2024-06-20 13:24:18 -07:00
Liran Binyamin
7b426af15f Animate bubble removal from the bar
This change creates a BubbleAnimator class that handles animating
both new bubbles in and removed bubbles out.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/dMHGANplWjGC5HZT6MXyA4

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 345687290
Test: atest BubbleAnimatorTest
Test: see demo

Change-Id: Ie060495f4b1421d1c8af48a861cd3e12dd0adbe8
2024-06-20 14:57:03 -04:00
Jordan Silva
c9ec536f07 Merge "Fix recents button not navigating to Overview" into main 2024-06-20 16:42:16 +00:00
Luca Zuccarini
11fa93f25d Merge "Fix widget jump at the end of the new home animation." into main 2024-06-20 15:58:55 +00:00
Treehugger Robot
264a7e3336 Merge "Move testQuickSwitchFromHome to possubmit" into main 2024-06-20 14:41:18 +00:00
Luca Zuccarini
4b4e426b30 Fix widget jump at the end of the new home animation.
The window animation wasn't being updated correctly, which resulted in a
jump at the end.

Bug: 298089923
Fix: 347880952
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Test: manual
Change-Id: Idbbd2e8485ae6f2bcbc1b42aa3744c2c659d1cfc
2024-06-20 13:40:45 +00:00
Alex Chau
91602f658c Move testQuickSwitchFromHome to possubmit
Bug: 325659406
Test: presubmit
Flag: EXEMPT test
Change-Id: Iccc2c1f06da85a0df79b5f3e0881535ce226f953
2024-06-20 13:50:19 +01:00
Jordan Silva
3d088e3899 Fix digital wellbeing banner position in portrait mode
The banner should be aligned to the start of the screen, not the center. This CL fixes DWB position for split tasks when device is unfolded.

Change-Id: I0544b4a8eb85b00196373c8a4368e680abab222b
Fix: 348200661
Bug: 345789862
Flag: EXEMPT bugfix
Test: Manual. Add a Digital Wellbeing (DWB) timer to 2 apps. Open these two apps in split mode. Unfold the device and go to Overview. The DWB banner should aligned correctly.
2024-06-20 09:46:30 +00:00
Fengjiang Li
622a7e37c5 Merge "[Launcher Jank] Avoid LauncherWidgetHolder and QuickstepWidgetHolder calling IAppWidgetService$Stub$Proxy.setAppWidgetHidden from main thread" into main 2024-06-19 15:19:22 +00:00
Jordan Silva
6a4c142b5b Fix recents button not navigating to Overview
This CL prevents returning launcher in getVisibleLauncher method when isHomeVisible is true but Launcher is not started.

Bug: 337954957
Bug: 331947116
Flag: EXEMPT bugfix
Test: Manual. With 3-button-nav. Open a video from -1 scren (not in Youtube app), press recent button. More instructions in b/337954957#comment26.
Change-Id: I40edafdab5457666474de2c0368158a9c1c05fb0
2024-06-19 15:08:43 +01:00
Tony Wickham
c5995c8f6d Load and draw Recent/Running tasks that aren't in Hotseat
- Re-support GroupTask as a tag on TaskbarView BubbleTextViews
- Can tap to launch (startActivityFromRecents) or drag and drop
- Move divider when enable_recents_in_taskbar is true

Behavior:
- While in Desktop mode, all open tasks show up in TaskbarView,
  either in the Hotseat section or the Running apps section
  past the divider. Each one also has a running line indicator.
- While in Fullscreen mode, up to 2 Recent apps that are not
  part of Hotseat will be added to the right of the divider.

Flag: com.android.launcher3.enable_recents_in_taskbar
Test: TaskbarRecentAppsControllerTest
Bug: 315354060
Change-Id: I2e2870cca434b51f276a701860edb32069109159
2024-06-19 00:27:30 +00:00
Tony Wickham
7c7c90528d Maintain Running Tasks order in Desktop mode
Fixes: 345034545
Test: TaskbarRecentAppsControllerTest
Flag: com.android.launcher3.enable_recents_in_taskbar
Change-Id: I4ab856c5293625c5279d4713450e5ea2d3b0ed85
2024-06-19 00:27:30 +00:00
Tony Wickham
2021727f1e Change running apps section to use GroupTask instead of AppInfo
- No longer bind All Apps to TaskbarRecentsController, and register
  RecentsModel.RecentTasksChangedListener instead
- The source of truth for "running tasks" in Desktop mode is the
  DesktopTask#tasks list itself, instead of
  RecentsModel.RunningTasksListener (which is no longer used)
- Added TaskInfo.TaskKey#isVisible to distinguish minimized running apps
- Next CL will hook up the UI for Recent/Running tasks that are
  not part of the Hotseat.

Flag: com.android.launcher3.enable_recents_in_taskbar
Test: TaskbarRecentAppsControllerTest
Fixes: 335398876
Bug: 315354060
Change-Id: I1313f97a791c5c0c1db7443a5d4f1d5bc761981f
2024-06-19 00:27:30 +00:00
Tony Wickham
4e1befb394 Handle running task launch properly in desktop mode
- Move logic from KeyboardQuickSwitchViewController to handle
  bringing desktop tasks to front, and still support recent
  tasks for non-desktop mode.

Flag: com.android.launcher3.enable_recents_in_taskbar
Test: manually launch tasks from the Recents section in both
Desktop mode and full screen mode (running vs recent)
Bug: 315354060

Change-Id: I0520351b4d0095a3538c6165acd82a7b4c45a5e2
2024-06-19 00:25:45 +00:00
Mady Mellor
58a6bbac4a Update bubble bar overflow to have a unique resId
This allows the overflow to be tested properly in end-to-end tests.

Flag: com.android.wm.shell.enable_bubble_bar
Test: atest OverflowBubbleTest (with other CL)
Bug: 347312208
Change-Id: Ice969434f9c40602c4b2d1a5baf6ba0509534a56
2024-06-18 16:43:32 -07:00
Fengjiang Li
880de362f1 [Launcher Jank] Avoid LauncherWidgetHolder and QuickstepWidgetHolder calling IAppWidgetService$Stub$Proxy.setAppWidgetHidden from main thread
Fix: 347991067
Test: manual - jank fix
Flag: NONE - jank fix
Change-Id: I881e5961ee4422d89e761c95ee8371902ded7ae6
2024-06-18 15:47:31 -07:00
Fengjiang Li
52c8595224 Merge "[Launcher Jank] Avoid making IWindowManager$Stub$Proxy.registerCrossWindowBlurEnabledListener bind calls from DepthController" into main 2024-06-18 21:48:07 +00:00
Fengjiang Li
05ad8912bc [Launcher Jank] Avoid making IWindowManager$Stub$Proxy.registerCrossWindowBlurEnabledListener bind calls from DepthController
Fix: 347965970
Test: manual - jank fix
Flag: NONE - jank fix
Change-Id: I59605d22ebc215e171c3b93fb1efc3becf2a4ade
2024-06-18 20:18:55 +00:00
Treehugger Robot
b47bed0fe6 Merge "Add logging and error detection around quick switching" into main 2024-06-18 16:24:34 +00:00
Schneider Victor-tulias
78e5bab45a Add logging and error detection around quick switching
Also adding a fallback case for when quick switch could otherwise fail

Flag: NONE debug logs
Bug: 320215753
Test: checked logs
Change-Id: I2c6b6d2c6beee77d8c2bf9e81329c4b16839c328
2024-06-18 10:49:37 -04:00
Mykola Podolian
490858bfba Merge "Added return before the animation is started." into main 2024-06-18 05:45:53 +00:00
Riddle Hsu
d76b06359f Merge "Let sender permission allow background launch when starting recents" into main 2024-06-18 01:48:41 +00:00