Commit Graph

43 Commits

Author SHA1 Message Date
Sunny Goyal
8dbdd3d702 Revert "Add hover state border line to overview task item by usi..."
Revert submission 23378417-cherrypick-overview-border-249859410-786docmioso

Reason for revert: flaky implementation

Reverted changes: /q/submissionid:23378417-cherrypick-overview-border-249859410-786docmioso

Change-Id: I6792fc25dbbd80db24df93ebd7a974b0dc0ba5d5
2023-06-01 21:29:13 +00:00
helencheuk
64975ae992 Add hover state border line to overview task item by using the same approach used by keyboard focus state
Reviewed TAPL DD: https://docs.google.com/document/d/1OmCLgTDw3gFOMXjEvH0W1XoAe0n2J5pPdyMcAHtflMA/edit?resourcekey=0-bXle-rOnQqOR_RJBffRybQ
Fix: 249859410
Test: OverviewTaskImageTest

Change-Id: Ic9ce4e9fe90f38a4bf4be6c7deed302a12a3192a
2023-05-30 21:30:14 +01:00
Thales Lima
1f10e53ba2 Create TAPL test for taskbar in overview
Fix: 269985301
Test: TaplTestsQuickstep
Flag: none
Change-Id: Iea0311bcba54882f7f2cf5d35cd98a538ae85855
2023-05-23 13:22:10 +00:00
Jeremy Sim
da75737d63 Revert "Revert "Create TAPL test suite for splitscreen""
This reverts commit 313a44039f.

Merging will reenable the TAPL suite TaplTestsSplitscreen.java, which was failing on phones due to a function call that only works on tablets.

Fixed by conditionally running the function only on tablet devices.

Fixes: 271852893
Test: Ran tests locally on phone and tablet.
Change-Id: If3e692924ed9c5ee113872e4f8ff0652890d1280
2023-03-14 15:36:32 -07:00
Vinit Nayak
313a44039f Revert "Create TAPL test suite for splitscreen"
This reverts commit 03815e6c79.

Reason for revert: b/271852893

Change-Id: I165a15b29e41ce1114f6b7d92d22cdd8e0dfb5b0
2023-03-06 23:47:20 +00:00
Jeremy Sim
03815e6c79 Create TAPL test suite for splitscreen
This patch creates a new file, TaplTestsSplitscreen.java, containing one TAPL test sequence.

testSplitAppFromHomeWithItself() tests the user flow of splitting from home using an app that is already running, and then selecting the app itself again as a split target from the Taskbar. The expected result is that Launcher shows an error message gracefully and does not crash.

Fixes: 267554450
Test: Ran test file locally and verified that it passes.
Change-Id: I98a1e3a4143d10a6572175711059b3a77aa5dcd0
2023-03-02 16:35:54 -08:00
Tracy Zhou
8bcac711d3 Fix overview actions tapl test failure
We don't show overview actions when the current task is a split

Fix: 242312408
Test: manual and presubmit and forrest
Change-Id: Idae64b4286d2e3143a8b0a66938802dcf0b9d3af
2022-08-12 11:14:12 -07:00
Tracy Zhou
6a4a229c27 Revert "Revert "Add testSplitFromOverview test (for phones)""
This reverts commit 24df4bffd8.

Reason for revert: resubmit

Change-Id: Iebc66cbce6885e06fe7691c548c1ffe950e936df
2022-08-11 17:59:34 -07:00
TreeHugger Robot
0438ea2293 Merge "Revert "Add testSplitFromOverview test (for phones)"" into tm-qpr-dev 2022-07-29 07:05:34 +00:00
Winson Chung
24df4bffd8 Revert "Add testSplitFromOverview test (for phones)"
This reverts commit 1780cee0fe.

Reason for revert: b/240517487

Change-Id: Id0b690ebba880dd9c978ed42c0f965beb2678b8c
2022-07-29 00:01:17 +00:00
Tracy Zhou
f1a523a790 Merge "Add testSplitFromOverview test (for phones)" into tm-qpr-dev 2022-07-28 05:06:40 +00:00
vadimt
f6ef879cf4 Moving all sources that are shared between Launcher and TAPL in one directory
This will help SysUI test team (who uses TAPL) to set up Gradle build for their tests.

Bug: 202567877, 234414088
Test: presubmit
Change-Id: I3d923ea4b54d1a4c3d2b345be09692727d30433e
2022-07-27 20:18:46 +00:00
Tracy Zhou
1780cee0fe Add testSplitFromOverview test (for phones)
Design doc: go/split_tapl

Bug: 238553914
Fixes: 239082974
Test: run this test
Change-Id: I6b67ede6d62a9fb48222aa4d15fe29ccd1d0fa06
2022-07-27 04:18:50 +00:00
Tracy Zhou
86a844c976 Add splitFromOverviewForTablet test
Design doc: go/split_tapl

Bug: 238553914
Test: run this test

Change-Id: Ibb385d852f73dee10470d14c4962cf482740105d
2022-07-19 01:57:35 +00:00
Schneider Victor-tulias
d6279ae641 Update TAPL object hierarchy in preparation for Taskbar TAPL tests
See design at: go/taskbar-tapl-tests

Test: Ran tests remotely
Bug: 215218813
Change-Id: I1c2ceac8954973ea3ae5b2f797fdfb96ba7a6ec4
2022-02-15 13:33:26 -08:00
Pat Manning
1b5975c205 Fix scroll task off screen to support different screen dimensions.
This will fix the breaks on cuttlefish as seen in b/203781041.

Test: TaplTestsQuickstep.java
Bug: 197630182
Change-Id: I3b582a9df1790543c4e1521b45494fb462bb5c1c
2021-10-26 18:08:45 +01:00
Pat Manning
ccec1de6ae Add new quickstep test for many tasks open at once.
This test is needed for testing overview-grid-related functionality.
- Opening non-focused tasks
- Dismissing a non-focused task from the grid
- Grid rows rebalancing after dismissal, which only happens when enough
apps are open to be off-screen.
- Grid tasks do not scroll after dismissal.

Test: TaplTestsQuickstep.java
Bug: 197630182
Change-Id: Ic907db4643cdc2eb9e4610dab917347e234e470c
2021-10-20 14:40:32 +01:00
Pat Manning
a140a0b611 Add TAPL test that dismissing focused task causes next task to become
focused.

Test: TaplTestsQuickstep.java
Bug: 197630182
Change-Id: I6f29dc6e3954f1b22ce8ffdf0a83db97202caefe
2021-10-05 18:00:11 +00:00
Alex Chau
97cba26a20 Wait for dismiss animation to finish before checking task count
- See http://b/193440212#comment5, TaskView takes time after swipe gesture to finish dismiss animation, so wait for the animation to finish before checking task count

Bug: 193440212
Test: TaplTestsQuickstep#testOverview
Change-Id: I21397e68f384e956a7c9f2ee8a8161ac784b4d2e
2021-07-19 17:34:57 +01:00
vadimt
7bd2a77144 Adding more diags for TAPL actions
Ones that change Launcher state.

Test: presubmit
Bug: 187761685
Change-Id: I11a29956613a4a211d49ee3df6d78e0000b80ced
2021-07-02 21:36:11 +00:00
vadimt
a1f0a10662 Removing tracking activity start/stop events
They were not especially useful in investigations; besides, these events
can be sent by the system asynchronously for actions that happened
before entering TAPL, causing flakes.

Change-Id: I72b5aad5521c6c0969f5b657b3db3e4d855f1d64
2020-04-29 14:23:53 -07:00
vadimt
bb3f515690 Catching StaleObjectException (and everything else) from get bounds
This will improve diags because fail() adds useful info to the message

Change-Id: I0a27f80c71a900078c94d9dd44d431fc206a37a0
2020-03-31 14:03:00 -07:00
vadimt
0dd1bd1113 TAPL: Verifying activity start/stop events
It also turned out that Pilfer event seems to come in a
non-deterministic order relative to the events from the Main and TIS
sequences. So I moved it to its own sequence.

Change-Id: Ie4ea5865afd900bebbd8287dad2372c94dce8ad5
2020-03-27 10:23:33 -07:00
Vadim Tryshev
3dd64ca3a8 Revert "TAPL: Verifying activity start/stop events"
This reverts commit 1186700c9a.

Reason for revert: Fails in the lab

Change-Id: I6715a058c76d96752b904331968b46a07ce93f85
2020-02-28 22:28:16 +00:00
vadimt
1186700c9a TAPL: Verifying activity start/stop events
It also turned out that Pilfer event seems to come in a
non-deterministic order relative to the events from the Main and TIS
sequences. So I moved it to its own sequence.

Change-Id: I5851aafb6d04398c5727712eaf8561916a30c4c5
2020-02-27 11:12:35 -08:00
vadimt
d633c9c7da Verifying events from TouchInteractionService
There is a guaranteed order in which TIS events will be registered
relative to other TIS events. However, relative to the touch events
arriving to the activity, TIS events can come in any order.

Now the event checker verifies 2 independent ordered event sequences:
from TIS, and “the rest” (Main).

Change-Id: I5872e0e3b0b498050a91c67105fbe4a29411375a
2020-02-07 11:46:03 -08:00
vadimt
6098a8c8c0 Adding events checking for Launcher starting apps
Change-Id: Id651397f643280a9f99a470df029479bd1b41e5c
2020-01-23 19:12:19 -08:00
vadimt
9af34a7b13 TAPL: verify input events
This will catch cases, for example, when the platform stops delivering
injected events to Launcher, or injects unexpected events, like Back
Button.

Also optimizing and fixing incorrect behavior of calculating the start
time for the event collection.

Change-Id: I2ba0108e6bfa112f2905a05bcb327b148ec08f77
2020-01-22 14:10:53 -08:00
vadimt
299aaf3a8a TAPL: performing event verification for all gestures
+ missed comments from earlier CLs

Change-Id: Iec84de66a3ff9c2aa59a11566560fa6f169190d0
2020-01-17 12:25:40 -08:00
vadimt
bdaa179b92 Consistently checking state change messages
Checking for events whenever Launcher sends them.
Checking for correct events (final events, not for events from
intermediate state changes).

This should simplify diagnosing of bugs involving TAPL.
This is also supposed to fix Fallback overview tests.

Bug: 143488140
Change-Id: If053ed808ec71bf2b652ab680be5bdfe9ff8cbb9
2019-12-09 12:33:39 -08:00
vadimt
73cd121122 When scrolling in All apps, scroll to last clickable row
Not the last row. This fixes tests broken after some assumption broke in
platform at an unknown moment.

Since the gesture distance became smaller in some cases, the speed of
the gesture became slower, and on some devices, the scroll gesture
triggers icon dragging.

To prevent this, I reduced the number of steps in the gesture to 10, but
added a slow-down at the end of the gesture to avoid inertia.

Also made some names and calculations clearer.

Bug: 144180777
Change-Id: Ie6c5776606ecff64d553fa836bdb3d90f32c5d9e
2019-11-15 13:40:29 -08:00
vadimt
849b201de0 Temporary workaround for UIAutomator not recognizing a new window
Bug: 112282235
Change-Id: I145bb88d72689f8c6d61ba3481f25d8978933ab2
2019-08-14 15:38:34 -07:00
vadimt
7a4ed2f258 Removing tracing for fixed bugs
Bug: 133009122
Bug: 133765434
Bug: 134532571
Change-Id: I37aa1851a1bc0874c0b9acf561bde28966e9b523
2019-07-15 18:48:06 -07:00
vadimt
f806125f99 TAPL: switching dismissing tasks to a model-time gesture
Change-Id: I4068c4102cd881b89b680c61699ba78832499a3d
2019-06-20 12:31:01 -07:00
vadimt
26185e1fed Adding debug tracing for a lab-only issue
Task doesn't get resumed upon clicking at it.

Bug: 133765434
Change-Id: I8c5c1308041949d94c6982c78b8337ea81ad400f
2019-05-30 10:30:32 -07:00
vadimt
f9bf37d569 Increasing activated-task wait time to 60000 ms
Bug: 112282235
Change-Id: I14f63ce77395b9f95743a6fb36c0b02a80a8983f
2019-05-28 18:35:36 -07:00
vadimt
4397d8d5ea Improving TAPL diagnostics
Bug: 128531133
Change-Id: If81861afccb665e2dc2293f2704d99818b3297c8
2019-03-25 18:29:37 -07:00
Vadim Tryshev
ceedc95d4c Slowing down dismiss gesture to reduce flakiness
Change-Id: I13a1d2053e841994df537896c4fe397f68fa4a65
2019-02-26 17:24:08 -08:00
Sunny Goyal
4ed58d6c03 Adding tests for fallback recents when a 3rd party launcher is installed
Change-Id: I1d4da13cc779f49832008b12b9628d01631faffe
2018-10-09 14:25:01 -07:00
Vadim Tryshev
e02e06a9d4 Including go/tapl in error messages
Bug: 110103162
Test: making a test fail, checking a link
Change-Id: If64948a6656214c5065150803b2a1a7020fb82c5
2018-09-07 15:46:59 -07:00
Vadim Tryshev
0a9f3ab4a6 Converting tests to Androidx
Bug: 112610679
Change-Id: I712826e668f1fbeb4e47cc541d4f5296d8eb74c0
2018-08-21 15:04:48 -04:00
Vadim Tryshev
2ce6a13f60 Tapl library
The public API of the library has finalized; flakiness has been removed;
code polished.

Bug: 110103162
Test: TaplTests suite
Change-Id: Ic156bbfeedb1cb9c4a48ef907f97e396e8e81936
2018-07-20 14:43:05 -07:00
Vadim Tryshev
5a7d701d55 UNREVIEWED: TAPL prototype for in-lab flake test
These sources didn't pass a normal CR, and mustn't be used in prod. The
goal of landing them is to start in-lab flakiness tests ASAP. A normal
code review will follow after landing cleanup CLs.

Bug: 110103162
Test: Running TaplTests suite
Change-Id: I051591c9af7822d4cbae4261e66563f1ccc1cfcc
2018-06-18 14:29:34 -07:00