Commit Graph

3513 Commits

Author SHA1 Message Date
TreeHugger Robot
7c604edf92 Merge "[Overview Actions] Put the taskview in the middle of the screen." into ub-launcher3-rvc-dev 2020-05-12 23:01:25 +00:00
Becky Qiu
073cbca370 [Overview Actions] Put the taskview in the middle of the screen.
Using horizontal padding 48dp to adjust the scale of the taskview and put it in the middle of the vertical space.

Test: local
Bug: 155444014
Change-Id: Iee6096baf18ae1106c24c83b4675abd4d3ff4d4f
2020-05-12 15:00:54 -07:00
Sunny Goyal
3f948e3f42 Adding state manager to fallback recents activity
Bug: 156398988
Change-Id: Id0a106ef888ade5223940ac8243108c39b4d6b98
2020-05-12 13:31:48 -07:00
TreeHugger Robot
7dcd4d6ed6 Merge "Simplifying animation creating logic for app-to-overview" into ub-launcher3-rvc-dev 2020-05-12 18:42:22 +00:00
TreeHugger Robot
2830c99bee Merge "Even more additional logging for pause non-detection" into ub-launcher3-rvc-dev 2020-05-12 17:35:42 +00:00
vadimt
60bc43d0cc Even more additional logging for pause non-detection
Bug: 156044202
Change-Id: I7c1a8a9ef4149bd64597908c0b6797cfe33fd4b6
2020-05-12 09:51:24 -07:00
Sunny Goyal
4888790bde Simplifying animation creating logic for app-to-overview
Removing optional 'shouldAnimate' flag. This was false only in 3-button mode but
the code was also handling animation, leading to inconsistent expectations. Instead
always assuming animation and finishing the animation promptly.

Change-Id: Ic56476dc5ea64c9a7d7e9744f3e33cd61dfde9e8
2020-05-12 16:37:27 +00:00
TreeHugger Robot
b8759f9b26 Merge "Fixing pullback factor not initialized after launcher process death" into ub-launcher3-rvc-dev 2020-05-12 03:06:29 +00:00
TreeHugger Robot
3d3c41a3a6 Merge "Make educational half-sheet black in dark mode" into ub-launcher3-rvc-dev 2020-05-12 01:07:21 +00:00
TreeHugger Robot
eb0136b7c4 Merge "Abstracting out state handler logic into base classes so that it can also be used in different activity" into ub-launcher3-rvc-dev 2020-05-12 00:29:52 +00:00
Sunny Goyal
35e7d38681 Abstracting out state handler logic into base classes so that it can
also be used in different activity

Change-Id: Ic5e60b21e1429c71f1cd4e7041e70bf4fc9761b7
2020-05-11 16:38:26 -07:00
Tony Wickham
a57000c33d Restart running task if another task was started but not appeared
If we just finish the controller to resume the running task like
we normally would, the delayed task will appear on top when it's
ready. Instead, we need to start the original task in this case.

- Move mLastStartedTaskId to GestureState, shared between swipe
  handlers when continuing the gesture.
- Update logic to change LAST_TASK to NEW_TASK if a task was
  started (but not appeared) during the same gesture; likewise,
  only change NEW_TASK to LAST_TASK if no task was started.
- Finish the controller when successfully starting the task
  that already appeared, since we won't get onTaskAppeared().

Bug: 156132424
Change-Id: I1e9af297840745ab3d5e90214425f10a2616d90a
2020-05-11 18:26:06 -05:00
TreeHugger Robot
ed31f24dbf Merge "Fixing current task not overshooting on swipe-up in overview" into ub-launcher3-rvc-dev 2020-05-11 22:55:45 +00:00
Sunny Goyal
84376f305b Fixing current task not overshooting on swipe-up in overview
> also fixing flicker during swipe-up when scroll is applied before recents
has been initialized

Bug: 154761552
Change-Id: I45c2b6801b8b87097c2816e26a234bab41b72ed4
2020-05-11 14:39:32 -07:00
TreeHugger Robot
6459397e3d Merge "Temporarily removes Settings button from Back tutorial." into ub-launcher3-rvc-dev 2020-05-11 21:10:46 +00:00
Sunny Goyal
ef44cf8f45 Fixing pullback factor not initialized after launcher process death
Instead of storing it on first swipe-up, computing it when required

Change-Id: I4b37002a016328e3b2d1c8535198ec8a6b56faf3
2020-05-11 13:28:53 -07:00
Andy Wickham
168aaf9682 Temporarily removes Settings button from Back tutorial.
Currently it just crashes, so it shouldn't be there. If
and when we decide to add it back, we will need to get
our package whitelisted to send the necessary Intent.

Bug: 149348244
Change-Id: I5ab292d04ebc5679e34e5a92141df3d86ef6e551
2020-05-11 13:24:06 -07:00
TreeHugger Robot
ae5afa74cd Merge "Using TaskViewSimulator for both Launcher and fallback recents" into ub-launcher3-rvc-dev 2020-05-11 19:32:26 +00:00
Vinit Nayak
115e70ddcf Merge "Infer launcher rotation when initializing RecentsOrientedState" into ub-launcher3-rvc-dev 2020-05-11 19:07:54 +00:00
TreeHugger Robot
17d3fe81c4 Merge "[Overview Actions] Change actions view UI based on different nav modes." into ub-launcher3-rvc-dev 2020-05-11 18:52:13 +00:00
Zak Cohen
02a25be89d Merge "Overview Actions - shows a message if action is blocked by policy." into ub-launcher3-rvc-dev 2020-05-11 18:43:55 +00:00
Vinit Nayak
b9522d334a Infer launcher rotation when initializing RecentsOrientedState
fixes: 154776599
Change-Id: I9b95f7f96836a974be0fd1236547efb4b405fda5
2020-05-11 11:23:49 -07:00
Hyunyoung Song
e745f50128 Merge "Hookup statsd for workspace layout logging" into ub-launcher3-rvc-dev 2020-05-11 18:18:57 +00:00
Becky Qiu
7d12134240 [Overview Actions] Change actions view UI based on different nav modes.
1. Change the overview actions container to 66dp height.
2. For 3 button mode, container will have 8dp bottom margin.
3. For gesture mode, container will have 16dp bottom margin.
4. Action buttons and close button will always be in the center vertically.

Spec: https://docs.google.com/presentation/d/1gXWNdCRXvXuEhgDmE0TX2KYqCxIQBXVtWKdl4pKrno8/edit#slide=id.g840c32b190_3_6

Demo:
- 3 button: https://screenshot.googleplex.com/2Y3uMaJMi9E
- gesture: https://screenshot.googleplex.com/XzaKHpp5ke9
Test: tested for both modes and when switch between.
Bug: 155444592

Change-Id: If66d369df0218b7ee2abab8a3f345488bf223b16
2020-05-11 10:46:21 -07:00
vadimt
7b7e62e5eb Additional logging for pause non-detection
Bug: 156044202
Change-Id: I6d7dcdcf73722e66fcbd180c9e309c518766b9b8
2020-05-11 10:10:53 -07:00
Bill Yi
91e0db3905 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: I2f2cda2793113a012d86b0d18cccf3e6fabb7e69
2020-05-10 20:53:08 +00:00
Hyunyoung Song
7f7894e3b7 Hookup statsd for workspace layout logging
Bug: 144953948

Change-Id: I81bd42929b2d65a63c610e95e5e01179a3971493
2020-05-10 01:37:42 -07:00
Zak Cohen
4ebd859bc4 Overview Actions - shows a message if action is blocked by policy.
Device policy or app secure surface policy mean that snapshot based
actions shouldn't work.
This is encoded in whether the snapshot is "real", the fake snapshot is
generated when policy doesn't allow captures.

Test: tested with Test DPC fake device policy app
Change-Id: Ib34e5a90ab58fb401d4516c531866d1c13569256
2020-05-08 17:16:15 -07:00
vadimt
ad87034d1f More logging for pause non-detection
Bug: 156044202
Change-Id: I1c995b6c28f7108b96ff74aa8c3c71f70f8b3fb6
2020-05-08 15:09:37 -07:00
Sunny Goyal
86a2f91101 Using TaskViewSimulator for both Launcher and fallback recents
Fixing fling to home animation in landscape and multi-window orientation

Bug: 155896573
Bug: 155816922
Change-Id: I5fdff8694eced415978345b026858f5167c2a198
2020-05-08 14:48:42 -07:00
Sunny Goyal
9d85f52386 Merge "Fixing swipe-up form app in landspace, rotates the surface" into ub-launcher3-rvc-dev 2020-05-08 20:11:56 +00:00
TreeHugger Robot
4d1203efab Merge "Fixing Fallback recents crashes when going to modal state" into ub-launcher3-rvc-dev 2020-05-08 19:46:35 +00:00
TreeHugger Robot
16fb9fac22 Merge "Adding tracing for switching to overview instead of all apps" into ub-launcher3-rvc-dev 2020-05-08 18:39:39 +00:00
vadimt
2794f563a0 Adding tracing for switching to overview instead of all apps
Bug: 156095088
Change-Id: I1257617192e913d06edd0879396957b1e40524b7
2020-05-08 10:39:29 -07:00
Tony Wickham
a8a377cd49 Merge "Cleanup quick switch logic" into ub-launcher3-rvc-dev 2020-05-08 17:22:19 +00:00
Sunny Goyal
302ecabf2c Fixing Fallback recents crashes when going to modal state
> Adding robo tests to prevent such regressions
Bug: 155570625

Change-Id: I5cfbfc454849116f881322e8785dfdbad6f24d08
2020-05-08 10:12:17 -07:00
TreeHugger Robot
9e77f25d52 Merge "Adding tracing for non-detection of Pause" into ub-launcher3-rvc-dev 2020-05-08 16:08:32 +00:00
Sunny Goyal
7a63fb2da6 Fixing swipe-up form app in landspace, rotates the surface
PreviewPositionHelper was getting the Launcher rotation from context,
instead of RecentsOrientationState

Bug: 156042694
Change-Id: I645eccfcb519c59fe2f78ecb1a77d8a315bc36c9
2020-05-08 08:48:36 -07:00
Jonathan Miranda
759995980a Merge "Add logs to debug playtime crash and band aid fix for release builds." into ub-launcher3-rvc-dev 2020-05-08 03:38:50 +00:00
vadimt
091794671d Adding tracing for non-detection of Pause
Bug: 156044202
Change-Id: I16f196db6266a0c3a84b59b7cdeb29863a37ff0f
2020-05-07 20:06:58 -07:00
TreeHugger Robot
0e0bcc7631 Merge "Moving TransformParams to an separate class." into ub-launcher3-rvc-dev 2020-05-08 00:09:05 +00:00
TreeHugger Robot
e4d1a71413 Merge "Disabling OverviewActionsView buttons while scrolling or clear all shown." into ub-launcher3-rvc-dev 2020-05-08 00:02:54 +00:00
Sunny Goyal
f29376bb29 Moving TransformParams to an separate class.
Moving some hepler methods to TransformParams so that some configurations
can be shared easily.

Change-Id: I07fff1e27e4615b56491aebf0ca2a911686ad979
2020-05-07 15:24:38 -07:00
Samuel Fufa
1012fd2326 Make educational half-sheet black in dark mode
Screenshot: https://screenshot.googleplex.com/tjk37GfrRhO

Bug: 152361557
Test: Manual
Change-Id: I30fffd0af8f4768ac20e6d13899d0e0182b0dec8
2020-05-07 15:18:05 -07:00
Tony Wickham
cc9fe80323 Cleanup quick switch logic
- Remove mFinishingRecentsAnimationTaskId and related logic;
  track mLastStartedTaskId and mLastAppearedTaskTarget instead.
- Don't finish controller if new gesture is in progress, only
  finish it when the last started task appears (and invalidate
  the handler at that point).
- Remove onTaskAppeared() from GestureState, handle it directly
  in BaseSwipeHandler.
- When the end target animation finishes, possibly change the
  end target from LAST_TASK to NEW_TASK or vice versa,
  depending on the last appeared task.

Bug: 154814771
Bug: 154727089
Bug: 155609695
Bug: 154812078
Change-Id: I38669515d064a131361359087f502783d875ddde
2020-05-07 15:39:57 -05:00
Sunny Goyal
f67db3531b Moving animation configuration and definition out of state definition
This removes cross dependency between StateManager and State object so
that it can be easily generalized

Change-Id: I62851fc4b653655cb40f37023db9651055ec7c9c
2020-05-07 01:33:57 -07:00
James O'Leary
ac327df55c Merge "Revert "Compose gesture integrated fully into Launcher"" into ub-launcher3-rvc-dev 2020-05-07 01:14:44 +00:00
TreeHugger Robot
d13dd3bc44 Merge "Skip setting the controller if the animation is already finished" into ub-launcher3-rvc-dev 2020-05-07 00:14:15 +00:00
James O'Leary
2610bfde05 Revert "Compose gesture integrated fully into Launcher"
Revert "Compose gesture integrated fully into Nexus Launcher"

Revert submission 11035205-compose_gesture_fully_integrated_launcher

Reason for revert: Broke Launcher Android Studio build, quick switch, and home gesture doesn't work if Compose is open.
Reverted Changes:
I2d97b22d5:OverscrollPlugin refactored to use onTouchEvent
Ia19a55f65:Compose gesture integrated fully into Nexus Launch...
I65aa07ac1:Compose gesture integrated fully into Launcher

Change-Id: Ic05c47eb686b3942ba519e76db32977fc568844b
2020-05-07 00:13:47 +00:00
Sreyas
78f53856a9 Disabling OverviewActionsView buttons while scrolling or clear all shown.
Bug: 153469850, 153387526
Video: https://drive.google.com/a/google.com/file/d/1mOc8yubux92iKtXRtSOKTcnjWWzvDgC7/view?usp=sharing

Change-Id: Id507d3a050e67057fc34a30771c9566ddfcf94ca
2020-05-06 16:36:24 -07:00