Whenever device rotates, we notify sysui to hide/show
the back gesture if the foreground app also rotates.
We also notify sysui when device rotates to match
the orientation of the current foreground app (this
is for apps with fixed rotations).
Fixes: 154580671
Test: Created test apps of different rotations
and ensured that back functionality was present when
attempting to go back.
Change-Id: I33a71698411d9bc2416b6660f8dbd53233628917
(cherry picked from commit 80303ac4b9)
Merged-In: I33a71698411d9bc2416b6660f8dbd53233628917
There's a race condition between when
the flag is read and when it gets set,
and not registering the listener that
the flag is gating can result in a lot
of bad rotation state.
Fixes: 158592847
Change-Id: Idd78e15669698bb0d057d0b6661ea69bfa5c8202
There's a race condition between when
the flag is read and when it gets set,
and not registering the listener that
the flag is gating can result in a lot
of bad rotation state.
Fixes: 158592847
Change-Id: Idd78e15669698bb0d057d0b6661ea69bfa5c8202
Seeing bugs come in where display rotation value
is incorrect, correcting the check to only
exclude frame rate change flags since multiple
bits can be set.
Fixes: 158383147
Change-Id: If6cdd2c10bf80024ac655451b957034ed84684a7
Seeing bugs come in where display rotation value
is incorrect, correcting the check to only
exclude frame rate change flags since multiple
bits can be set.
Fixes: 158383147
Change-Id: If6cdd2c10bf80024ac655451b957034ed84684a7
This reverts commit 4dfcbec512.
Reason for revert: Fix the margin issue by handling the bottom
insets ourselves.
Change-Id: Ic01cadbbe847e419af8bb444ad57764e719152c3
3 Button overview orientation wasn't
getting set, but working because of the sensor.
Now we set orientation when entering overview,
and reset to rotation 0 when exiting overview.
Also fix related bug in RecentsOriented state
where we weren't updating the current sensor
rotation with foreground app orientation.
Fixes: 157069195
Change-Id: Ide1b7dbeb68aeaf6a3c45f7260595f69f4813d94
This reverts commit 160ca4b8a2.
Reason for revert: Got issues like b/158318606 when switch nav modes, also the margin seems not set properly. And this doesn't work for 3 button mode too. Would switch to just use task menu for all.
Change-Id: I645f2a2a9032ae99799c75bcc6c983c1bbfd8df8
1. When home screen rotation is allowed, we still have action buttons for landscape, but remove bottom margin to shrink the UI.
2. When home screen rotation is not allowed, we do in-place rotation for overview, where we won't show action buttons.
Test: see demo video: https://drive.google.com/file/d/1G6ihv_DOykx1MLpFAQf3VJHq3D1HotnX/view?usp=sharing
Bug: 153736749
Change-Id: Ia1c7ef8c245ac13bf50adf32ee5114f23e491e75
Extracts fake task view animation logic to
SwipeUpGestureTutorialController, which
Home and Overview controllers extend.
Fixes: 157945497
Change-Id: Ibd1c129c57e9bee8db62baae455ca1bd9df114c7
mLastRectRotation's value is used after
swipe gestures are complete to reset the
layout for overview (after swiping to home
animation is complete), so we need to set
it to a valid value instead of -1.
OverviewActions visibility depends on
it being rotation 0 for it to be visible,
otherwise it won't show up.
Bug: 155844780
Test: Swipe up to home from an app,
Swipe up to overview, observe overview
actions show in portrait.
Swipe up and back down from landscape app,
hit back. Open portrait app, ensure back
gesture still works.
Change-Id: Ia923a54e68af567b4470841783328528fffebe6a