Commit Graph

10593 Commits

Author SHA1 Message Date
Tracy Zhou
e66ed03992 Merge "Update task bar height update logic to consider screen rotation cases" into main 2024-01-20 02:12:19 +00:00
Sunny Goyal
3ef2768922 Merge "Simplyfing SystemShortcut rendering" into main 2024-01-20 01:11:36 +00:00
Tracy Zhou
a009a5e82e Update task bar height update logic to consider screen rotation cases
When home screen rotation is enabled, instead of updating taskbar height (assuming that folded task bar is always on the bottom of screen display), we should update taskbar width instead.

Bug: 313371759
Test: try out both folded and unfolded 3-button and gesture nav modes, enable home rotation, make sure all the nav buttons are functional and visible when they should be.
Change-Id: I16f53d9e9c3cd0229fc50b73613b032a96322b97
2024-01-19 16:58:03 -08:00
Tony Wickham
7eceb5b101 Merge "Revert to passing mIsStashed to StashedHandleViewController again" into main 2024-01-20 00:38:16 +00:00
Federico Baron
2b691f67b4 Merge "Add logs to debug b/318394698" into main 2024-01-19 22:38:23 +00:00
fbaron
e5e37faa1f Add logs to debug b/318394698
Flag: NONE
Test: n/a
Bug: 318394698
Change-Id: I3142dafeae0ba31713f514e690c5b7bb730541b0
2024-01-19 13:24:18 -08:00
Tony Wickham
c4df8c2ec6 Revert to passing mIsStashed to StashedHandleViewController again
- Fixes case where handle is initially invisible but will be stashed
  and visible, e.g. when launching an app from home screen
- To fix the original issue of sampling happening unnecessarily for
  three button nav, also check supportsVisualStashing()

Fixes: 321257120
Flag: None
Test: Launch an app from home in gesture nav mode
Test: testThreeButtonsTaskbarBoundsAfterConfigChangeDuringIme
Change-Id: I1f26436de3081fd00f75a5921010e361e9a9f34e
2024-01-19 20:25:25 +00:00
Sunny Goyal
9f226dff72 Simplyfing SystemShortcut rendering
Instead of opening the popup again when the status of AppSharing
changes, updating the UI in-place.

Bug: 321179015
Test: Presubmit
Flag: N/A
Change-Id: I6d7bd8cdf2014fd881324347e3e01b8e7e84ef1e
2024-01-19 10:48:54 -08:00
Sunny Goyal
defc9058a1 Merge "Cleaning up some unused notifications functionality" into main 2024-01-19 16:39:12 +00:00
Johannes Gallmann
3cbcdaff19 Merge "Attach launcher protection scrim to the opening target instead of Launcher's surface." into main 2024-01-19 08:31:32 +00:00
Sunny Goyal
e0c1649d87 Cleaning up some unused notifications functionality
Bug: 321154530
Test: Presubmit
Flag: N/A
Change-Id: I1ff2a4f19595659d89e7d72ee1b29036bbd54d8f
2024-01-19 00:21:02 -08:00
Anushree Ganjam
917619a06a Merge "Remove Pin Prediction shortcut from private space app." into main 2024-01-18 21:45:23 +00:00
Anushree Ganjam
245402984d Remove Pin Prediction shortcut from private space app.
Before: https://screenshot.googleplex.com/68S4y4efJWQkyYk.png
After: https://screenshot.googleplex.com/8XdwUFGsYvHkEQ4.png

Bug: 319250810
Test: Manual
Flag: aconfig com.android.launcher.enable_delete_private_space_pin_shortcut DEVELOPMENT

Change-Id: I33ef2cc35c31f86101197405502d84ad98b36bdc
2024-01-18 11:17:09 -08:00
Saumya Prakash
b617daa6c6 Merge "Add standalone taskbar edu tooltip for the pinnable taskbar feature" into main 2024-01-18 01:41:14 +00:00
Anushree Ganjam
cbfa8043c8 Merge "Add "Don't suggest app" shortcut to suggested apps." into main 2024-01-17 22:25:17 +00:00
Saumya Prakash
dddebdff0c Add standalone taskbar edu tooltip for the pinnable taskbar feature
This change adds in a standalone edu window for the pinnable taskbar
feature. The reason for the change is to educate users about pinnable
taskbar to those who have already seen taskbar edu before.

Fixes: 302589411, 300161174
Test: Went through taskbar education taskbar with the flag on and off.
Check that the standalone pinning taskbar only shows up if previous
taskbar education was already completed.
Flag:  ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I03a5fb05ae5f15892421a57355f6d503de56d9fd
2024-01-17 21:23:30 +00:00
Andy Wickham
32f2cae290 Merge "Allow stashed taskbar to be long pressed." into main 2024-01-17 21:09:15 +00:00
Shamali Patwa
56fd022d10 Merge "Filter shortcuts in the widget picker activity." into main 2024-01-17 14:15:51 +00:00
Pat Manning
5b7f564395 Merge "Add flag guard to hover actions in TouchInteractionService." into main 2024-01-17 13:05:20 +00:00
Pat Manning
8bcf485ac4 Add flag guard to hover actions in TouchInteractionService.
Flag: ACONFIG com.android.launcher3.enable_cursor_hover_states NEXTFOOD
Test: Manual.
Bug: 306745595
Change-Id: I74818f517b84c4aba8a7dd4a77397495595bbef5
2024-01-17 11:44:31 +00:00
Andy Wickham
caf0c35661 Allow stashed taskbar to be long pressed.
Bug: 319175012
Test: Manual and unit test
Flag: NA
(see other change)

Change-Id: Ic8ac68d21c64a909a1035339d36f9c3b50a8963c
2024-01-16 21:43:46 -08:00
Vinit Nayak
701d267b05 Add log when user attempts to split with widget
Bug: 295467097
Flag: none

Change-Id: Ice6cdc7a2db85c8efca7d4e1bc74a0cdc367a9ab
2024-01-16 23:54:19 +00:00
Vinit Nayak
fc02f88d1b Merge "Sync split dismiss anim scrim fadee timing with taskbar to home anim duration" into main 2024-01-16 23:21:03 +00:00
Shamali P
ddde81f4c0 Filter shortcuts in the widget picker activity.
In its current state the WidgetPickerActivity only allows adding widget
items, so to match the state, updated it to show only widgets.

manual test - https://screen/cast/NDUxMjg1NjI0MTM0MDQxNnwxMzE4MzNhOS1mZg

Bug: 320495335
Test: atest Launcher3Tests
Flag: N/A
Change-Id: Ifa75f457219efef49e104efc428d369187db2710
2024-01-16 21:19:16 +00:00
Schneider Victor-tulias
0c8439e17d Merge "Update the KQS app launch animation to match the spec exactly" into main 2024-01-15 18:42:37 +00:00
Johannes Gallmann
898b9af9a2 Merge "Fix stuck wallpaper with predictive back" into main 2024-01-15 09:51:42 +00:00
Anushree Ganjam
64614a1ec6 Merge "Add null check since LauncherUserInfo can be null." into main 2024-01-13 05:04:14 +00:00
Anushree Ganjam
32b5ac61e0 Add null check since LauncherUserInfo can be null.
Bug: 319142187
Test: Manual
Flag: N/A. Crash in tests.
Change-Id: Iaa9fc1b8e7c2c09621d984bfdeb9012bcc479ef8
2024-01-12 18:05:29 -08:00
Tony Wickham
dc566559d0 Merge "Improve Taskbar touchableRegion debuggability" into main 2024-01-13 01:38:18 +00:00
Jagrut Desai
a15b88f484 Merge "Adding Taskbar Pinning Analytics again." into main 2024-01-13 00:54:14 +00:00
Sunny Goyal
39f235154e Merge "Fixing some launcher model tests" into main 2024-01-12 23:04:39 +00:00
Jagrut Desai
fff93577e8 Merge "Update enableTaskbarNoRecreate logic" into main 2024-01-12 22:31:15 +00:00
Charlie Anderson
9fc2fa34b3 Merge "Replace ENABLE_LAUNCHER_BR_METRICS flags with fixed aconfig flag." into main 2024-01-12 21:37:17 +00:00
Jagrut Desai
777f3a4b9d Merge "Fix TaskbarDividerPopupView vertrical Arrow offset" into main 2024-01-12 21:18:27 +00:00
Sunny Goyal
6449a21062 Fixing some launcher model tests
> Removing static mocks and using Sandbox context instead
> Removing inheritence in LauncherModel and converting LauncherApps.Callbacks
  to a separate class. decMaker sometimes fails because of API changes in
  LauncherApps.Callbacks

Bug: 319877828
Test: atest LoaderTaskTest
Flag: N/A
Change-Id: If78b5d83595627a355b284f52d887d75fef53014
2024-01-12 12:30:52 -08:00
Charlie Anderson
da3138cd91 Replace ENABLE_LAUNCHER_BR_METRICS flags with fixed aconfig flag.
This is necessary because the value of the read-write flag will not be updated in time for backup/restore.

Bug: 307527314
Test: compiles
Flag: ACONFIG ENABLE_LAUNCHER_BR_METRICS_FIXED TEAMFOOD
Change-Id: I67a1a820734d8881b3ed5be4a1f2f1556e6e4704
2024-01-12 14:33:29 -05:00
Shan Huang
7fc7c44fc6 Attach launcher protection scrim to the opening target instead of
Launcher's surface.

Bug: 317183323
Flag: NONE
Test: m -j
Test: Swipe back to home, make sure there's no flicker. Try both quick
swipes and slow swipes. Try staying in apps for different durations and
then swipe back.

Change-Id: I59df680d889489291b28610ff76693a63e55e49a
2024-01-12 11:03:35 -08:00
Jagrut Desai
057144e0f6 Update enableTaskbarNoRecreate logic
Test: Presubmit
Bug: 318567569
Flag: NONE
Change-Id: I6927f0bab0317219a00a7c09c08640825d54e91b
2024-01-12 10:59:10 -08:00
Anushree Ganjam
5e9b71e055 Add "Don't suggest app" shortcut to suggested apps.
This works for suggested apps in both Home and AA+. When enable_shortcut_dont_suggest_app is true, the secondary drop target "Don't Suggest app" is removed instead "Don't suggest app" is added to shortcuts.

Video: https://b.corp.google.com/issues/319250810#comment5

Home: https://screenshot.googleplex.com/d7Wts48X6EmFAYg.png
Private space app suggested: https://screenshot.googleplex.com/BukzCRTvkzbpwQ3.png

AA+: https://screenshot.googleplex.com/ADMCHnQ378jvJEE.png
Private space app suggested : https://screenshot.googleplex.com/AYga8Km3646AqMt.png

Bug: 319250810
Flag: aconfig com.android.launcher.enable_shortcut_dont_suggest_app DEVELOPMENT
Test: Manual.

Change-Id: Ia7df749a1c7d806bd9d74124be138384c3050119
2024-01-12 10:33:24 -08:00
Anna Zhuravleva
eb1966c278 Merge "Add shortcut to install an app to Private space" into main 2024-01-12 15:51:05 +00:00
Johannes Gallmann
9532717757 Merge changes I05d517a7,Ided0a095 into main
* changes:
  Minor clenaup in LauncherBackAnimationController
  Fix window corner radius for predictive back to home on Felix
2024-01-12 10:33:56 +00:00
Johannes Gallmann
09f29f7492 Merge "Align window clipping logic of back-to-home to cross-task-back" into main 2024-01-12 09:15:41 +00:00
Tracy Zhou
7a30de2fc3 Merge "Remove taskbar window from WindowManager in TaskbarManager.destroy()" into main 2024-01-12 06:05:44 +00:00
Tracy Zhou
78c548a829 Remove taskbar window from WindowManager in TaskbarManager.destroy()
When task bar crashes (from anything), task bar window is not cleaned up properly. This is because destroyExistingTaskbar() only removes the root layout from the window when we are no longer rendering task bar (one use case of that is folding the device). We need to clean it up in onDestroy() also.

Fixes: 319105323
Test: adb shell am crash com.android.systemui and make sure there is only one task bar window
Change-Id: Ia9c808e903422707bf4c270b2631fc913dde65d9
2024-01-11 16:13:06 -08:00
Tony Wickham
480448b059 Merge "Temporary workaround for taskbar hiding in Desktop" into main 2024-01-11 23:21:42 +00:00
Jagrut Desai
3fc1e3a45d Fix TaskbarDividerPopupView vertrical Arrow offset
Test: Manual
Bug: 310673489
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TEAMFOOD
Change-Id: I6c6af315cb058c8da599af8120a6a903ab247006
2024-01-11 14:00:37 -08:00
Jagrut Desai
80cc62173e Adding Taskbar Pinning Analytics again.
Test: Presubmit
Bug: 265436916
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TEAMFOOD
Change-Id: I742dccccc7648bb7ec8bf94d5f5f55430a5543ab
2024-01-11 11:33:02 -08:00
Anna Zhuravleva
29a3139815 Add shortcut to install an app to Private space
Introduce long-press shortcut to install a copy
of the main user app to private space.

Test: manual, installed apps in different stores
and tried shortcut
https://screenshot.googleplex.com/6oAVamTytiYmvPC.png
Bug: 316118005
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space_install_shortcut DEVELOPMENT

Change-Id: I702cd2a27388e3cc6e9e126308d5479836ba6655
2024-01-11 12:40:28 +00:00
Riddle Hsu
1438af66f8 Merge "Fix leakage of GestureExclusionListener" into main 2024-01-11 05:54:05 +00:00
Tony Wickham
4e7411c54c Temporary workaround for taskbar hiding in Desktop
Taskbar still hides during the transition, but then reappears
after settling.

Flag: LEGACY ENABLE_HOME_TRANSITION_LISTENER enabled
Bug: 314207404
Test: manual
Change-Id: Ie3d29b3d40e513f39cb34176baa781c9f2853e57
2024-01-10 19:59:25 +00:00