Commit Graph

11854 Commits

Author SHA1 Message Date
TreeHugger Robot
803f88b89e Merge "Round split layout values instead of using int cast" into tm-qpr-dev 2022-10-10 17:51:52 +00:00
Vinit Nayak
8addaad158 Merge "Improve splitscreen recents animation in seascape" into tm-qpr-dev 2022-10-10 17:49:54 +00:00
TreeHugger Robot
1f7b2f9a7a Merge "Fix repeated empty workspaces after changing the grid size." into tm-qpr-dev 2022-10-10 16:57:59 +00:00
Alex Chau
21064ef82a Merge "Fix flaky/failing two panel TAPL tests" into tm-qpr-dev 2022-10-10 15:59:37 +00:00
Andras Kloczl
0e4f04d85f Fix flaky/failing two panel TAPL tests
Since Cuttlefish emulators are quite slow, some
of the two panel related TAPL tests were failing
due to multiple page changes instead of single ones.

Test: atest -c NexusLauncherTests:com.android.launcher3.ui.workspace.TwoPanelWorkspaceTest
Bug: 236136463
Fix: 252747355
Change-Id: Ib154cf97040fcea3b4d2d7082352c06de74f8c2a
(cherry picked from commit 486f7c8766)
Merged-In: Ib154cf97040fcea3b4d2d7082352c06de74f8c2a
2022-10-10 10:52:16 +00:00
Luca Zuccarini
82469ea23b Merge "[Toast] Switch to using device config to control keyboard sync." into tm-qpr-dev 2022-10-10 10:22:27 +00:00
Brandon Dayauon
926d04ec14 Merge "Add variable to check if button should apply keyboard insets" into tm-qpr-dev 2022-10-08 12:15:26 +00:00
Brandon Dayauon
b1840e3f36 Add variable to check if button should apply keyboard insets
bug: 251460671
test: manual
Change-Id: I90045c96c0fbf385ad8dd5978089491f3f106dd8
2022-10-07 15:32:23 -07:00
Vinit Nayak
8f54d597bf Round split layout values instead of using int cast
* Silly us, we forgot that int casting always floors.
Math.round() does a mathematical round.

Fixes: 248575056
Test: Wallpaper no longer bleeds through on split
animation.

Change-Id: I068c030ce6b86fc12faee7778c0d87a0d5aea487
2022-10-07 14:46:25 -07:00
Andy Wickham
1874371aab Merge "Differentiate between app row and shortcut icons." into tm-qpr-dev 2022-10-07 20:42:51 +00:00
Andy Wickham
2c5f545d0b Merge "Hide FloatingHeaderView while in Search state." into tm-qpr-dev 2022-10-07 17:20:12 +00:00
Holly Jiuyu Sun
6fa0562aee Merge "Quick launch v2." into tm-qpr-dev 2022-10-07 16:38:14 +00:00
Alex Chau
b7b88b66bb Merge "Add logging to help debug flake when swiping home to overview." into tm-qpr-dev 2022-10-07 11:24:43 +00:00
Vinit Nayak
c7d676ce15 Improve splitscreen recents animation in seascape
* We need to swap the primary and secondary thumbnail
positions in fake seascape since the primary is the
visually left app (which is the bottom in portrait)

Bug: 249693334
Change-Id: I325133ab86e4fcd26c6162a3de007d68e9ba6bf1
2022-10-06 21:32:20 -07:00
TreeHugger Robot
78ec4e0890 Merge "Include additional error log around widget removal" into tm-qpr-dev 2022-10-06 21:31:10 +00:00
Holly Sun
2b17c4b9d0 Quick launch v2.
Set auto-append text in selected text mode. Clicking enter key launches the app. Delete the selected text to remove auto-append text and highlight. Clicking enter key sends raw query to search.

Test: manual
Bug: 210661150
Change-Id: Iee8e716b81a2dde64e60462fd33d4a6eb4abcf01
2022-10-06 10:38:26 -07:00
Pat Manning
24b9554086 Add logging to help debug flake when swiping home to overview.
Bug: 238461210
Bug: 246283207
Test: TaplTestsQuickstep#testSwitchToOverview
Change-Id: I8ee9af4f4a331c43761ba3738e12acb376ababc2
(cherry picked from commit 1edba8b0a6)
Merged-In: I8ee9af4f4a331c43761ba3738e12acb376ababc2
2022-10-06 15:37:47 +00:00
Luca Zuccarini
bda972b2c9 [Toast] Switch to using device config to control keyboard sync.
Bug: 234812580
Test: followed the existing pattern and tested by manually setting and
unsetting the flag through command line - `adb shell device_config put
launcher enable_web_suggest_on_default_browser <true|false>`

Change-Id: Idd479e93b628b78fdf55d826c56f69c5cfdaf46e
2022-10-06 10:26:42 +00:00
Nick Chameyev
cbfb35edc7 Extract PreviewPositionHelper to shared library
Moves Launcher's PreviewPositionHelper to shared
library between SystemUI and Launcher to reuse
it in the future in the partial screensharing
recents selector.

There should be no functional changes in the
code itself.

Bug: 240924926
Test: presubmit
Change-Id: Ib38b6f9db91e63a2598bf81229e3cd3e1a49ca60
2022-10-05 10:23:54 +01:00
Alex Chau
5e47e78a17 Merge "Taskbar in overview" into tm-qpr-dev 2022-10-05 08:58:31 +00:00
Andy Wickham
0d3c3d8fc5 Differentiate between app row and shortcut icons.
This is a simplified version of ag/20118087. It fixes the bug
with rows of shortcuts being in the search results (e.g. Gmail
and WhatsApp conversations), but it will not handle cases where
there are multiple rows of app icons. Currently I do not know of
any cases where that would happen.

Test: Manual with and without inject_web_top (which moves app row)
for WhatsApp and Gmail with AiAi fishfood.
Bug: 239927522

Change-Id: Ie9c62c0ee81086801942328c8770f37d5bf622c3
2022-10-05 00:57:09 -07:00
Tracy Zhou
d7a7bfc304 Merge "Remove ENABLE_QUICKSTEP_LIVE_TILE flag" into tm-qpr-dev 2022-10-04 20:02:30 +00:00
Andy Wickham
e5a49f4b48 Hide FloatingHeaderView while in Search state.
This prevents touches on the profile buttons (which were already
hidden due to the header view having alpha 0, but touches were
still registered).

Fix: 248338523
Test: Manually tap where the work profile button is before and
after this change. Before: switches to work profile. Afer: does
nothing in 0 state; otherwise launches item at that position.

Change-Id: Ie30661146d25740000d7a9cbe79234ac15347253
2022-10-03 23:38:49 -07:00
Pinyao Ting
7fd7e51fa2 Include additional error log around widget removal
As observed in b/248291728, widgets are disappeared after OTA update,
this CL includes additional logging to reveal more information.

Bug: 248291728
Test: manual
Change-Id: I5cf968efc358c3315e5e6ecc4861d5bc888569f1
2022-10-03 17:46:03 -07:00
Alex Chau
d67ddc4920 Taskbar in overview
- Behind ENABLE_TASKBAR_IN_OVERVIEW which is disabled by defualt
- Make taskbar unstashed in overview with background visible
- Ensure taskbar is touchable in overview

Bug: 245320601
Test: Home<->Overview, Home<->App, App<->Overview, Home->Overview->App->Home, Home->App->Overview->Home, Overview->Home->App->Overview, Overview->App->Home->Overview, App->Overview->Home->App, App->Home->Overview->App
Test: Go to AllApps, call KEYCODE_HOME, go to app and taskbar should be there
Test: App->Overview->Select->Home->App
Test: QuickSwitch -> App
Test: Repeat above with ENABLE_TASKBAR_IN_OVERVIEW x taskbarStashed on/off
Test: Repeat above with gesture and 3-button
Change-Id: Ib25d68f68e89564851b226536e456d0b2f6306f8
2022-10-03 20:15:12 +01:00
Federico Baron
1aa91f0f7a Merge "Fix the entry animation for delightful pagination in folders" into tm-qpr-dev 2022-10-01 07:21:53 +00:00
Andy Wickham
7f31d4c0ec Merge "Fix layout for multi-element rows (e.g. Screenshots)." into tm-qpr-dev 2022-09-29 21:08:20 +00:00
Andy Wickham
4c96814b1c Fix layout for multi-element rows (e.g. Screenshots).
Demo with standard 3 element row and overflowing 2 element row:
https://drive.google.com/drive/folders/1o1gvD3mOxFmVW2vqjn3D1Gukz-ie_kmW?resourcekey=0-bHRsdqpUWITEUo39tAMJDg&usp=sharing

Test: Manually with 1, 2, 3, and 4 length rows of 3 screenshots
and putting web suggestions into 2 columns.
Fix: 247837336
Bug: 239927522

Change-Id: I391beb7a24f189b5e55cb7b65c5ffc8349c83cfc
2022-09-29 10:38:20 -07:00
Tracy Zhou
c0095e81ae Remove ENABLE_QUICKSTEP_LIVE_TILE flag
Fixes: 249627137
Test: manual - (1) swipe up from app (2) swipe home (3) quick switch (4) split in overview
Change-Id: Ibe56ba3824b379b20fb3f0aa09be4d6bdb5abaa1
2022-09-29 04:58:52 +00:00
Federico Baron
0602e93426 Fix the entry animation for delightful pagination in folders
Here we fix the animation that was broken in earlier CL's for delightful pagination, now the page indicator has the same smooth entry animation as the dots

Bug: 247561880
Test: manual
Change-Id: I3e2099ba4f5ccfdbc9b4dfe5b48a1c44dbdeda1e
2022-09-28 16:17:51 -07:00
Holly Jiuyu Sun
0c7d83bb14 Merge "Add flag to control show/hide keyboard suggestion strip." into tm-qpr-dev 2022-09-27 23:49:53 +00:00
Sebastian Franco
fa37a0ad9b Fix repeated empty workspaces after changing the grid size.
There are specific scenarios when you can force an extra empty
workspace after changing the grid, fortunately there is a
function that removes empty workspaces.

Fix:229349287
Test: Add a widget in a new empty workspace page, change the
grid then remove the widget in the new grid size then return
to the previous grid and it shouldn't have an empty workspace.

Change-Id: I7b73ae2ca058bc84b3b361930e3dc856c045281b
2022-09-27 21:51:17 +00:00
Federico Baron
d8b78523ca Merge "Replace drawRect with drawable for delightful pagination" into tm-qpr-dev 2022-09-27 03:31:09 +00:00
Brian Isganitis
815018be9a Merge "Properly color taskbar nav buttons when slide-in view is shown." into tm-qpr-dev 2022-09-26 22:56:06 +00:00
Federico Baron
4f5e573d3a Replace drawRect with drawable for delightful pagination
In order to eventually use the shape referenced in the task (https://docs.google.com/presentation/d/1V9-1C3mJ3zRGsuzzzYExisr9vLYecgADa1FucMoW_aw/edit#slide=id.g14256d0c614_0_311) we need to use a drawable. This CL adds the drawable that will be changed to that shape and uses it in PageIndicatorDots.java instead of using drawRect.

Bug: 247561880
Test: manual
Change-Id: I01e10bd9ddc7e378f2dcfdee0f84ba7443c3b9d3
2022-09-26 15:51:33 -07:00
Brian Isganitis
731ef0c301 Properly color taskbar nav buttons when slide-in view is shown.
Supports overriding the current nav bar color with one that would be
visible over a slide-in view.

Demo:
https://drive.google.com/file/d/1MB26QM5qeeyVB6Bj14IGoPCWVT_P7K-3/view?usp=sharing&resourcekey=0-wnMgciNrUXC_l7gI3JFm8A

Test: Manually with light and dark themes, as well as All Apps and EDU
views.
Fix: 248359789

Change-Id: I134ae719b10f3de78ea18220a835de56a82ecb02
2022-09-26 11:41:38 -07:00
Federico Baron
cdadbaa225 Rename alpha and refactor the way alpha is set in PageIndicator
Here we rename DOT_INACTIVE_ALPHA and DOT_ACTIVE_ALPHA to reflect the new code, and we also use mPaginationPaint.setAlpha a bit differently

Bug: 247561880
Test: Manual
Change-Id: I5ee25ee3fb36715d54f9ed86c0d59448829d7260
2022-09-26 09:34:11 -07:00
Andy Wickham
59cd0e0228 Merge "Reduces search clipping when work profile is not present." into tm-qpr-dev 2022-09-24 18:04:52 +00:00
Andy Wickham
14101659f7 Reduces search clipping when work profile is not present.
Basically, adds the spacing that is otherwise included by
the tab protection (which is about 4dp less than the spacing
that was previously being added).

Adds a compile-time flag to render the header at all times to
help visualize issues like this in the future. Check the
screenshots below to see some examples of this.

Screenshots: https://drive.google.com/drive/folders/1n4wwtjMwOR-eDIE1xAoG3oLXO7txpoT_?resourcekey=0-WP0RNbp7vFh2Yw1wUBZTaA&usp=sharing

Bug: 240672593
Bug: 243728487
Test: Manually checked search transition, scrolling behavior, and
highlight of the search results with and without a work profile.

Change-Id: I166d136e568c5621c81378fa09021666d95f0ffc
2022-09-23 19:36:44 -07:00
Federico Baron
178a45a5ab Merge "Add rotation to folder pagination for delightful pagination" into tm-qpr-dev 2022-09-23 21:40:48 +00:00
Becky Qiu
dd002b87e0 Merge "[Toast] Change toast qpr1 feature flags to all apps device config." into tm-qpr-dev 2022-09-23 21:31:15 +00:00
Becky Qiu
3aec5d59dc [Toast] Change toast qpr1 feature flags to all apps device config.
Bug: 247122218
Test: local
Change-Id: I096f9fe4f8d071ea4b3292c6245da0c0ec509077
2022-09-23 11:59:56 -07:00
Federico Baron
bdcc17c2aa Add rotation to folder pagination for delightful pagination
Here we add rotation for the page indicator in order to make it align with the new animation design.

Bug: 247561880
Test: manual
Change-Id: I91202c8ac259d4876f6182938db79c466f99c6ed
2022-09-23 11:30:00 -07:00
Brandon Dayauon
7f98856395 Merge "Fix pause work apps overlapping IME" into tm-qpr-dev 2022-09-23 17:00:25 +00:00
TreeHugger Robot
07bcfaa72a Merge "Adding flag for material U popup" into tm-qpr-dev 2022-09-23 16:56:42 +00:00
Anushree Ganjam
65e73ce5b3 Merge "Add Ime transition type, Controlled and Atomic to LatencyType." into tm-qpr-dev 2022-09-22 23:32:45 +00:00
Brandon Dayauon
23ff6774b7 Fix pause work apps overlapping IME
The bottom margin for button in gesture navigation is wrong.
The bottom margin for the button is supposed to be 20dp from the gesture nav bar,
not 20dp from the bottom of the screen. The calculation was correct for 3 button nav but
was forgotten to be applied to gesture nav.

bug: 246243359
test: Manual - after: https://hsv.googleplex.com/5763335673872384
Change-Id: If678a70b4ad43791cf9e66390164e1ab25a6e366
2022-09-22 13:35:01 -07:00
Holly Sun
cd9e261014 Add flag to control show/hide keyboard suggestion strip.
Test: manual
Bug: 247895327
Change-Id: I9425be72a1bd946a16d3327cbb10d56d2e2250b9
2022-09-22 13:32:00 -07:00
Andy Wickham
0f7b01c775 Merge "Removes search animation when tapping home screen QSB." into tm-qpr-dev 2022-09-22 19:01:12 +00:00
Anushree Ganjam
ae81433665 Merge "HideKeyboard when animations are disabled." into tm-qpr-dev 2022-09-22 18:03:52 +00:00