Commit Graph

17322 Commits

Author SHA1 Message Date
Jeremy Sim
7dc3bdcd85 Migrate ENABLE_APP_PAIRS flag to aconfig
Fixes: 303323964
Flag: com.android.wm.shell.Flags.FLAG_ENABLE_APP_PAIRS
Test: Unit tests still run correctly
Change-Id: I617c699746492c9c0d131a28791d984afbbdda4d
2023-10-12 15:06:32 -07:00
Sunny Goyal
4588031286 Merge "Moving onboarding prefs to use LauncherPrefs" into main 2023-10-12 20:51:45 +00:00
Jon @
5cae6965ae Merge "Fix bug where All Apps button loads in late in taskbar." into main 2023-10-12 20:10:11 +00:00
Tyler Freeman
22781d97d9 Merge "Revert "Combine icon app tests to allow overriding flag for new ..."" into main 2023-10-12 20:06:56 +00:00
Tyler Freeman
1468467706 Revert "Combine icon app tests to allow overriding flag for new ..."
Revert submission 25007147-tapl-flag

Reason for revert: Breaks build: https://b.corp.google.com/issues/305033049

Reverted changes: /q/submissionid:25007147-tapl-flag

Change-Id: I99b5883e64ae25476394a4207c5d6a4d22fc27dc
2023-10-12 18:04:05 +00:00
Jon Miranda
330b7754c6 Fix bug where All Apps button loads in late in taskbar.
We need to re-create the icon alignment controller if the
stash status changes, otherwise it will use an old value.

Bug: 296414290
Test: home to app then quickly unstash
Change-Id: I35f23842f289fce95d102a9a93dc94cd033fa8cc
2023-10-12 17:14:49 +00:00
Pat Manning
654c05837e Merge "Combine icon app tests to allow overriding flag for new icon app chip menu testing as well." into main 2023-10-12 15:59:17 +00:00
Pat Manning
236e738907 Combine icon app tests to allow overriding flag for new icon app chip menu testing as well.
Platinum exlude cl update: cl/572225659

Test: TaplOverviewAppIconMenuTest
Test: TaplAppIconAppChipMenuTest
Bug: 303329286
Bug: 303266562
Fix: 304470271
Change-Id: I4ca163401d6a42961e8955e06c164af0254b1231
2023-10-12 14:53:08 +01:00
Vinit Nayak
e489bd45e6 Merge "Call split finish callback if split invocation fails" into main 2023-10-11 23:33:18 +00:00
Stefan Andonian
3925bdfdf8 Merge "Remove some direct usage of getDevicePrefs()" into main 2023-10-11 23:09:26 +00:00
Stefan Andonian
2171d09fe6 Remove some direct usage of getDevicePrefs()
Bug: 261635315
Test: Manually did testing on device.
Change-Id: I47c88bdc031d330f6efa573411ab5dbf154ec8a2
2023-10-11 23:06:41 +00:00
Tracy Zhou
0dbcbfc08f Merge "Fix transient task bar not automatically stashed in app when ENABLE_TASKBAR_NO_RECREATION is enabled" into main 2023-10-11 22:19:43 +00:00
Charlie Anderson
102a06f810 Merge "Fix status bar flicker on adding widgets requiring configuration." into main 2023-10-11 22:00:40 +00:00
Treehugger Robot
bcd5555863 Merge "Adding Mateusz as an OWNER for Launcher tests" into main 2023-10-11 21:53:30 +00:00
Vadim Tryshev
e86761a225 Adding Mateusz as an OWNER for Launcher tests
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I07a891fe766549208e4402726ee66998db22956d
2023-10-11 14:48:17 -07:00
Vadim Tryshev
4c3757dd2b Merge "Improving diagnostics from fallback recents tests when phone is not unlocked" into main 2023-10-11 18:50:37 +00:00
Schneider Victor-tulias
276420a869 Merge "Fix janky Alt+Tab through overview animation" into main 2023-10-11 18:28:10 +00:00
Tracy Zhou
fbc01a0b4f Fix transient task bar not automatically stashed in app when ENABLE_TASKBAR_NO_RECREATION is enabled
Currently the task bar root layout consumes all the events and does not pass the events to drag layer, without explictly routing those events

Fixes: 303910224
Test: go to an app, swipe home, and then go back to the app. Make sure the task bar is stashed
Change-Id: I6f5e481c267dad25544118134ff95b0cb9bb1a45
2023-10-11 11:25:45 -07:00
Alex Chau
6ae2c4d77d Merge "Revert "Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag""" into main 2023-10-11 15:38:57 +00:00
Vinit Nayak
77ce4c261e Merge "Update API for OneShotRemoteHandler" into main 2023-10-11 15:13:25 +00:00
Vinit Nayak
c4f653c24c Merge "Null out context for all split controllers" into main 2023-10-11 15:12:24 +00:00
Alex Chau
4989f4f36d Revert "Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag""
This reverts commit 7b5472f986.

Reason for revert: aconfig/SetFlagsRule actually works with TAPL tests (http://ag/c/platform/packages/apps/Launcher3/+/24991890/comment/8303a3c6_030ae00b/)
Bug: 270397206

Change-Id: I7529a64c3197e4c2b4d5fb1e46fb29bdea1e52e9
2023-10-11 14:08:22 +00:00
Hyunyoung Song
e0a25fbd51 Merge "Add CUSTOM_LPNH_THRESHOLDS feature flag to customize LPNH" into main 2023-10-11 07:54:26 +00:00
Tracy Zhou
9633e5b74c Merge "Fix phone mode task bar inset values not correctly initialized" into main 2023-10-11 05:32:09 +00:00
Vinit Nayak
def3e9d7f4 Call split finish callback if split invocation fails
Bug: 295981634
Test: Splitting w/ Google TV widget no longer
keeps placeholder views on screen
Flag: ENABLE_SPLIT_WORKSPACE_TO_WORKSPACE

Change-Id: I1d4df9deb9aaaaeef3741a05130429d0091293e8
2023-10-10 21:01:35 -07:00
Vinit Nayak
a439c912d8 Null out context for all split controllers
* Destroy context for AppPairsController and
SplitSelectDataHolder

Bug: 302551868
Change-Id: I5636ecf50d51ad383ac89a457697984bc8d907ca
2023-10-10 20:42:42 -07:00
Vadim Tryshev
f782eaba73 Improving diagnostics from fallback recents tests when phone is not unlocked
Failing earlier so that we don't get strange messages from the middle of the test.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I1e3c70623e6f907bcc6bd0486b6c75afecb610e3
2023-10-10 19:18:22 -07:00
Vinit Nayak
e83b08ff6e Update API for OneShotRemoteHandler
* All no-ops except SplitSelectStateController

Bug: 295981634
Change-Id: Idabe80951ceb2b0a980f3179366d75fc064c69ec
2023-10-10 15:41:26 -07:00
Tracy Zhou
de28c115b2 Fix phone mode task bar inset values not correctly initialized
We rely on contentHeightToReportToApps and tappableHeightToReportToApps (that ultimately call into DeviceProfile) of TaskbarStashController to initialize the insets. However, DeviceProfile only initializes those values when isTaskbarPresent is true. Rather than completely changing the initialization of DeviceProfile, we special case in TaskbarStashController that uses the bar height for inset

Bug: 274517647
Test: turn on FLAG_HIDE_NAVBAR_WINDOW and TASKBAR_NO_RECREATION, make sure the insets are correct in both 3 button and gesture nav mode
Change-Id: I164a6e2c9f9d24888155b45325ee8ce46ca2c39f
2023-10-10 13:02:16 -07:00
Bill Yi
7991a8ed41 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-10-10 19:29:49 +00:00
Sunny Goyal
cd44740567 Moving onboarding prefs to use LauncherPrefs
Bug: 301661768
Test: Presubmit
Flag: N/A
Change-Id: Iec8a5e739f394a152d5ffc57b01e0449e94b4084
2023-10-10 11:47:33 -07:00
Jagrut Desai
3872759957 Merge "Stop Active Gesture Error Detection for Non Gestural Navigation Mode" into main 2023-10-10 17:32:47 +00:00
Schneider Victor-tulias
bdae57c157 Fix janky Alt+Tab through overview animation
Flag: not needed
Fixes: 282172884
Test: used alt+tab in overview; also launched overview through keyboard quick switch view
Change-Id: I3d1e54cda317ee8f8d2b2d698480cd3ca01dfc85
2023-10-10 11:20:15 -04:00
Charlie Anderson
2934c460c4 Fix status bar flicker on adding widgets requiring configuration.
- Changes ProxyActivityStarter theme to draw transparent navigation and status bar

Test: locally
Flag: N/A
Bug: 202485497

Change-Id: I88d14099ec9b1f433fbcdc9184fe5af557bc180b
2023-10-10 11:00:05 -04:00
Alex Chau
09d8e2ca57 Merge "Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag"" into main 2023-10-10 12:26:21 +00:00
Alex Chau
7b5472f986 Revert "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag"
This reverts commit 6f264a927b.

Reason for revert: Keeping old flag system so we can test in Tapl tests (b/283246928)
Bug: 270397206

Change-Id: I3e6364ebac8018facc3b22e510615735299a3dad
2023-10-10 10:38:04 +00:00
Tracy Zhou
f14c534ec5 Merge "Set correct stashed task(nav) bar height with taskbar/navbar unification" into main 2023-10-10 05:08:02 +00:00
Federico Baron
ca39bd99cc Merge "Add screenrecord to testOverviewActionsMenu_iconAppChipMenu" into main 2023-10-09 21:29:11 +00:00
Vadim Tryshev
6bc3f5e0e1 Merge "Introducing a method for execution an action on Launcher for teardown" into main 2023-10-09 21:22:47 +00:00
Tracy Zhou
5bd641e3f5 Merge "Fix task bar crashing in small screen with task bar / nav bar unification on" into main 2023-10-09 20:26:25 +00:00
Vadim Tryshev
39b4fad9b0 Introducing a method for execution an action on Launcher for teardown
If the test fails to initialize properly, tearDown is still called,
and we may have null Launcher activity.

We want to safely skip using that activity to avoid a NullPointerException
that would hide the original error message.

Bug: 304306290
Test: presubmit
Flag: N/A
Change-Id: I89774a92ede046fa3afadacc62df25f4f496f4e7
2023-10-09 11:29:42 -07:00
Alex Chau
461b65fa4e Merge "Use mock TaskStackChangeListeners in RecentsModelTest" into main 2023-10-09 16:39:13 +00:00
Jagrut Desai
5cc3767e60 Stop Active Gesture Error Detection for Non Gestural Navigation Mode
Bug: 290266108
Bug: 294926731
Test: Presubmit
Flag: not needed
Change-Id: I111d60fbedbeb7e8b553cdeadc0e3f39a9a351b2
2023-10-09 09:34:30 -07:00
Vinit Nayak
b95ee09a69 Merge "Dismiss split selection for workspace long-press" into main 2023-10-09 16:13:52 +00:00
Alex Chau
a0c149fc8d Use mock TaskStackChangeListeners in RecentsModelTest
- Also unregistered TaskStackChangeListeners and TaskIconCache listeners in RecentsModel.close(), so clean-up will happen if it's in a SandboxContext

Bug: 303259446
Test: RecentsModelTest
Change-Id: I438a499be8e737de7df79b670ecfd26f0ee70662
2023-10-09 14:31:58 +01:00
Vinit Nayak
4f850a42a0 Merge changes I9e56ddbe,I8767deea into main
* changes:
  Disallow taskbar long click when in split selection state
  Add method to determine if launcher is in split selection state
2023-10-07 00:20:24 +00:00
Vinit Nayak
01849e4c63 Merge "Null reference to activity as runnable back handler" into main 2023-10-07 00:15:54 +00:00
Jagrut Desai
f56bfabaa4 Merge "Change Taskbar Window height logic for taskbar pinning." into main 2023-10-06 23:33:30 +00:00
Vinit Nayak
d0fc718a0a Dismiss split selection for workspace long-press
Bug: 295426148
Test: Enter split contextual from homescreen,
long-press on empty space, split gets dismissed
Flag: ENABLE_SPLIT_WORKSPACE_TO_WORKSPACE

Change-Id: I3a893bea7b22645fe60c65c4c5ab8c2087d769da
2023-10-06 16:05:54 -07:00
Winson Chung
36a9c19487 Merge "Defer nav handle action until after the recents transition is complete" into main 2023-10-06 22:47:32 +00:00