Commit Graph

6460 Commits

Author SHA1 Message Date
Sunny Goyal
774dcd06ae Relying on the controller state instead of animator state for
icon alignment

Bug: 246644619
Test: Presubmit
Change-Id: Iaa4ddd94a6d85acb9f8501263665ea78394815de
2022-11-03 13:42:09 -07:00
Sunny Goyal
fc01c382bf Merge "Removing RemoteTransitionCompat and related wrappers" into tm-qpr-dev 2022-11-03 16:40:27 +00:00
Jon Miranda
8ed5ac05fd Merge "Revert "Revert "Add a way to stash/unstash transient taskbar.""" into tm-qpr-dev 2022-11-03 05:58:38 +00:00
Sunny Goyal
1319de88b4 Removing RemoteTransitionCompat and related wrappers
Bug: 221961069
Test: Presubmit
Change-Id: Ib93640d27a9eb0401882574e37b466163dafa5b3
Merged-In: Ib93640d27a9eb0401882574e37b466163dafa5b3
2022-11-02 23:40:48 +00:00
Sunny Goyal
39b07fd66c Fixing background jump when closing a widget
We do not add background animation when opening target is translucent
Added additional check to not animate background if launcher is not
closing (which is already a subset of all-targets-translucent)

Also removing reverse background animation from widgets, similar
to app-icons as it is never added for launcherNotClosing path

Bug: 242379946
Test: Added translucent activtiy and widget and verified manually
      that the behavior does not change
Change-Id: Icda8007c0063295bf8431c00a0f0b665ecdef109
2022-11-02 19:17:18 +00:00
Saumya Prakash
ccc8e9fcf4 Merge "Removed disabled overview actions at end of scroll" into tm-qpr-dev 2022-11-02 18:30:21 +00:00
Vinit Nayak
626f322343 Merge "Disable Drag from Taskbar in Overview" into tm-qpr-dev 2022-11-02 18:26:02 +00:00
Jon Miranda
575d699edc Revert "Revert "Add a way to stash/unstash transient taskbar.""
This reverts commit afc3bff10b.

Reason for revert: fixing launcher tests broken by original change

We'll only add flags for transient taskbar case

Bug: 256988243
Bug: 256987492
Change-Id: I8915ef5345816316bfb71efc9fc667e4e8db824c
2022-11-02 11:07:27 -07:00
Sunny Goyal
e553fe8aa0 Merge "Updating AIDL interface and removing unused methods" into tm-qpr-dev 2022-11-02 16:43:23 +00:00
Tony Wickham
6b32ce07b1 Merge "Decrease TAPL All Apps scrolling flakiness" into tm-qpr-dev 2022-11-02 15:39:45 +00:00
Sam Dubey
de5d5720a1 Merge "Revert "Add a way to stash/unstash transient taskbar."" into tm-qpr-dev 2022-11-02 10:03:06 +00:00
Sam Dubey
afc3bff10b Revert "Add a way to stash/unstash transient taskbar."
This reverts commit 6163e2d39f.

Reason for revert: Part of Platinum+DM rotation for testing as likely culprit for breaking launcher tests on tablet. Won't be commited until proven otherwise.

Bug: 256988243
Bug: 256987492
Change-Id: I21b3561f489e17c48131d2223a7d90267968232f
2022-11-02 09:16:55 +00:00
Sunny Goyal
04356a26c3 Merge "Updating widget prediction handling:" into tm-qpr-dev 2022-11-02 08:21:20 +00:00
Jon Miranda
b95c4ff849 Merge "Add a way to stash/unstash transient taskbar." into tm-qpr-dev 2022-11-02 05:02:22 +00:00
Sunny Goyal
3c7054f0d2 Updating widget prediction handling:
When handling widget prediction, first match the full provider names
Only if no widgets are found, match any widget in the package

Bug: 256202399
Test: atest WidgetsPredicationUpdateTaskTest
Change-Id: I5337618d935f8b926803aeefede46059545de72d
2022-11-02 02:24:21 +00:00
Vinit Nayak
406bc6f247 Disable Drag from Taskbar in Overview
* Still need to disable drag from all apps in overview
* Disallow any taskbar icon long click when in split select

Bug: 251747761
Test: Drag from hotseat and predicted icons in overview,
snaps back to position

Change-Id: Ib9b068e4914b9197614c8e8f49b7899bb964f92b
2022-11-01 16:29:28 -07:00
Jon Miranda
6163e2d39f Add a way to stash/unstash transient taskbar.
- Adds threshold to show taskbar during swipe
- Introduces FLAG_STASHED_IN_APP_AUTO flag
- Adds logic for taskbar to auto hide based on time
  and touch

Bug: 252905206
Test: manual
Change-Id: I070cd619487fdd4498a988ae5aadce6dd14313f7
2022-11-01 16:03:01 -07:00
Saumya Prakash
12731af30d Removed disabled overview actions at end of scroll
Updated visibility of the overview action bar so that when viewing
the clear all button at the end of the tasks it becomes hidden.
Previously, the overview actions were disabled so they were not
usable anyways. Updated the corresponding tests because expected
behavior was changed.

Test: Manual
Fix: 230508197
Change-Id: I64c91c682009808690d696032ffadefc86dfbac9
2022-11-01 21:49:19 +00:00
Jeremy Sim
eb88b517a6 Merge "Change tablet split confirm timing slightly" into tm-qpr-dev 2022-11-01 20:49:30 +00:00
Thales Lima
b1d991b3de Merge "Calculate taskbar content size for edu" into tm-qpr-dev 2022-11-01 17:57:53 +00:00
Tracy Zhou
0c853991fd Merge "Support split from fullscreen with shortcuts" into tm-qpr-dev 2022-11-01 17:17:33 +00:00
Mady Mellor
9eed65de62 Merge "Remove floating task button from taskbar" into tm-qpr-dev 2022-11-01 16:16:37 +00:00
Tracy Zhou
ba0b5952c8 Support split from fullscreen with shortcuts
Recording: https://recall.googleplex.com/projects/f46cfe9c-8076-4efe-bf8a-b1cc4f1f5e1b/sessions/978a3a55-2982-4026-9726-2a73cb694258

TODO: improve transition animation

Bug: 246661484
Test: manual
Change-Id: Id0d1aec0685bc18f4b273f8e466996efc1d9a3d8
Merged-In: Id0d1aec0685bc18f4b273f8e466996efc1d9a3d8
2022-11-01 04:30:39 +00:00
TreeHugger Robot
59228a6511 Merge "Add app window thresholds for transient taskbar." into tm-qpr-dev 2022-11-01 01:44:14 +00:00
Holly Jiuyu Sun
c5f43eb9f7 Merge "Log sub event type to latency logger." into tm-qpr-dev 2022-10-31 19:28:27 +00:00
Mady Mellor
10856068bc Remove floating task button from taskbar
Not POR to have a button in taskbar for this so removing this bit
of the prototype.

Test: manual - enable floating tasks on tablet and check if there's
               a button in taskbar (there shouldn't be).
Bug: 237678727
Change-Id: Ifb57f6528946f89592649afda84101e4f9cbb198
2022-10-31 11:56:14 -07:00
Jeremy Sim
570ddadcf9 Change tablet split confirm timing slightly
This patch changes the split confirm animation on tablets to 500ms. Based on UX discussion at b/241126570.

Fixes: 241126570
Test: Manual
Change-Id: I1de0e0f8882db059de09685f7756343d8a387b4f
2022-10-27 16:43:07 -07:00
Jeremy Sim
4972822c60 Merge "Add transitions to DWB banner when app thumbnail progresses from Overview tile to fullscreen" into tm-qpr-dev 2022-10-27 23:38:31 +00:00
Holly Sun
4d6fa05c83 Log sub event type to latency logger.
Bug: 255355348
Test: build
Change-Id: Idac85b5e31e2abdd98f6fd1bed4ec687d8bb5cd5
2022-10-27 16:37:18 -07:00
Jon Miranda
0c1714bb45 Merge "Only draw transient taskbar background for transient taskbar" into tm-qpr-dev 2022-10-27 20:42:21 +00:00
Sihua Ma
17137e8bce Merge "Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost" into tm-qpr-dev 2022-10-27 17:53:28 +00:00
Jon Miranda
f80b5f50a3 Only draw transient taskbar background for transient taskbar
Bug: 252905206
Fix: 255925607
Test: disable flag, view taskbar
Change-Id: I1734fa238e3c07f5da6a03659c1079eb1b6b7277
2022-10-27 15:27:38 +00:00
Johannes Gallmann
989ffba0ec Merge "Extracting ViewCapture into common Library" into tm-qpr-dev 2022-10-27 07:30:11 +00:00
Saumya Prakash
5db9942c61 Merge "Revert "Removed disabled overview actions at end of scroll"" into tm-qpr-dev 2022-10-26 22:10:39 +00:00
Saumya Prakash
19250d69f7 Revert "Removed disabled overview actions at end of scroll"
This reverts commit 96cad794d7.

Reason for revert: Breaks build test_suites_x86_64_coverage (linux) build 9222442 in git_tm-qpr-dev. 

Change-Id: I482f526da169505cf5d3f42ef999303dcc162a1f
2022-10-26 20:59:30 +00:00
Saumya Prakash
f1a4121784 Merge "Removed disabled overview actions at end of scroll" into tm-qpr-dev 2022-10-26 20:31:44 +00:00
Jon Miranda
f3a59b59f4 Add app window thresholds for transient taskbar.
- Threshold to move app window
- Threshold to reach home/overview
- Threshold for window to catch up to finger

Bug: 252905206
Test: manual
Change-Id: I71082fab07a0227d64ce6ed66cbfa3c1ffb319f5
2022-10-26 13:02:04 -07:00
Ats Jenk
d98c88b4e0 Merge "Set launcher state to NORMAL when entering desktop" into tm-qpr-dev 2022-10-26 18:58:05 +00:00
Sihua Ma
0593a0d3ec Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost
The wrapper class is created for further changes that will run the wrapped host in the background.

Test: N/A
Bug: 235358918
Change-Id: I9bd6fc2749c5d4a4d3391fb75d0c3ff1e13d17bf
2022-10-26 10:57:13 -07:00
Ats Jenk
f7474fa9a0 Merge "Screenshot freeform task when going to overview" into tm-qpr-dev 2022-10-26 17:01:08 +00:00
Jon Miranda
661f38cdb8 Merge "Add transient taskbar UI" into tm-qpr-dev 2022-10-26 14:56:15 +00:00
Alex Chau
a2ad627607 Merge "Improve All Set page UI for large screens" into tm-qpr-dev 2022-10-26 13:10:45 +00:00
Johannes Gallmann
6518efce73 Extracting ViewCapture into common Library
The ViewCapture functionality is extracted into a common Library accessible to the Launcher and SystemUi modules.

Test: None yet
Change-Id: I4be394ed8dc86e30f6b8c69c438b8bc943e7907c
2022-10-26 12:29:30 +00:00
Merissa Mitchell
e7b6888a36 Merge "Move AllAppsButton placement for desktop environment." into tm-qpr-dev 2022-10-26 03:17:01 +00:00
Ats Jenk
7963c1d051 Set launcher state to NORMAL when entering desktop
When clicking on desktop tile, we need to explicitly move launcher state
to NORMAL. Freeform apps float on top of launcher and launcher remains
visible in the background. When on desktop, launcher should be in normal
state, with icons and widgets hidden. Hiding of the icons etc is handled
already by DesktopVisibilityController.

TODO:
 - need to fix home screen icons flicker, can be solved with new
   launcher state (b/255649902)

Bug: 244348395
Test: manual, click on desktop tile in overview, observe freeform apps
brought to front and overview closes

Change-Id: I214b0d6b622e673e0b0cb82f84b2080b479a7fb9
2022-10-25 18:02:05 -07:00
Ats Jenk
ff9b36762a Screenshot freeform task when going to overview
When freeform tasks are visible in desktop mode, capture a screenshot of
the tasks when opening overview.
Also use RecentsView instead of RecentsAnimationController when
finishing the recents animation. RecentsView.finishRecentsAnimation
method has an extra call to onRecentsAnimationComplete() which ensures
that screenshot does got used.

Bug: 244348395
Test: manual, open freeform task, swipe up to go overview, observe a
screenshot of the task

Change-Id: I066b25ec7ae25d1e09aba0ff0a379d35bbe2b636
2022-10-25 16:51:00 -07:00
Sunny Goyal
3912808183 Merge "Merging MultiValueAlpha with MultiPropertyFactory" into tm-qpr-dev 2022-10-25 21:39:11 +00:00
Merissa Tan
fcb9cb7664 Move AllAppsButton placement for desktop environment.
On desktop environment, we want the AllAppsButton to be on the left side
of the taskbar instead of the hotseat, but retain the functionality of
the button.

Bug: 251372204
Test: Manual
Change-Id: Ia2c95a20583cb98785ab6f8c719559d93982c06f
2022-10-25 14:26:07 -07:00
Jon Miranda
184a04266d Add transient taskbar UI
This change is only for the visual appearance of the
transient taskbar.

Bug: 252905206
Test: manual
Change-Id: I4990b20b39089a0c27ec2a72dd3010cf64ddba1d
2022-10-25 13:46:19 -07:00
Holly Jiuyu Sun
381ba3319d Merge "Log a-z apps count." into tm-qpr-dev 2022-10-25 17:50:19 +00:00