Commit Graph

13928 Commits

Author SHA1 Message Date
Treehugger Robot
6fcd77c19a Merge "Update KQS task view borders" into main 2025-03-12 12:21:08 -07:00
Liran Binyamin
8b7c4a8f28 Merge "Pass a location when dragging bubble to fullscreen" into main 2025-03-12 12:05:36 -07:00
Treehugger Robot
f0e0e8b7ec Merge "Remove redundant FrameLayout from task_header_view.xml" into main 2025-03-12 11:31:52 -07:00
Randy Pfohl
8f8cc2d700 Merge "Fix issue where we don't show home button when keygaurd is occluded by another app and is not visible" into main 2025-03-12 11:29:35 -07:00
Andy Wickham
250d85698c Merge "Adds all_apps_blur flag." into main 2025-03-12 11:25:50 -07:00
Tony Wickham
1db86b7c1b Merge "Fix overview intent from OverviewCommandHelper with window enabled" into main 2025-03-12 11:19:55 -07:00
Thu-Huong Vu
09846676b5 Merge "Register SimpleBroadcastReceiver permission." into main 2025-03-12 10:36:22 -07:00
Treehugger Robot
02be70164c Merge "Add keyboard navigation for App Chip and Chip Menu" into main 2025-03-12 10:09:13 -07:00
Brian Isganitis
2d8be58d59 Merge "Wait until updateItems is called to perform addStaticViews." into main 2025-03-12 09:10:08 -07:00
Jordan Silva
99eefc9055 Add keyboard navigation for App Chip and Chip Menu
Bug: 400410772
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual using Keyboard. Access the app chip via TAB.
Change-Id: I75f80b5c6f366ecfc27596519a721cc6ace18d45
2025-03-12 07:55:04 -07:00
Tony Wickham
47137a3731 Fix overview intent from OverviewCommandHelper with window enabled
Consolidated the existing logic from OtherActivityInputConsumer
into AbsSwipeUpHandler#getLaunchIntent() directly, so it is
inherited for both AbsSwipeUpHandler and OverviewCommandHelper.

This change means we stop starting RecentsActivity when pressing
the overview button. (And, in turn, this means we no longer use
FallbackTaskbarUIController<RecentsActivity>.)

Bug: 401382430
Test: Open an app, press Overview button, dump TaskbarUIController
Flag: com.android.launcher3.enable_fallback_overview_in_window
Flag: com.android.launcher3.enable_launcher_overview_in_window
Change-Id: Ib5da181ecd41141634127d3a70c816d2f45fad08
2025-03-12 10:36:04 -04:00
Uwais Ashraf
d4b187b997 Add perf tracing for several key operations in TaskView lifecycle.
Fix: 402622741
Test: Manually looking at perf traces
Flag: EXEMPT - tracing only
Change-Id: If42a30d83dd72ebfe4074fedd7bdefcd102881d6
2025-03-12 11:02:00 +00:00
Mykola Podolian
4050670549 Merge "Updated animation to account bubble bar stash state." into main 2025-03-11 19:03:01 -07:00
Treehugger Robot
8561c5690f Merge "Drag and drop from the search view on the overview screen." into main 2025-03-11 18:26:48 -07:00
Liran Binyamin
18abe9e97e Pass a location when dragging bubble to fullscreen
When a bubble is dragged to full screen, pass the x and y coordinates
of where the bubble was released to wm shell. The coordinates are used
as a starting point for expanding the full screen task.

Flag: com.android.wm.shell.enable_bubble_to_fullscreen
Bug: 388858013
Test: treehugger
Change-Id: I28bb10bdfb00786e43b350239cfdeb3df20b4a6f
2025-03-11 20:30:32 -04:00
Randy Pfohl
12148f13d2 Fix issue where we don't show home button when keygaurd is occluded by another app and is not visible
Flag: None fixing regression

Test: built and ran locally, verified home button is showing in the
proper scenarios.

Bug: 376851989

Change-Id: Ifcc6c5e41135a7e67aa20c18efac34af32b71e15
2025-03-12 00:21:51 +00:00
Andy Wickham
ccb3a5c25c Adds all_apps_blur flag.
This enables blur both for Taskbar and Launcher, but in slightly
different ways.

For Taskbar All Apps, we apply blur to the overlay window, and
for Launcher All Apps, we utilize the existing DepthController to
blur the wallpaper window. For similicity, we currently fade out
workspace/hotseat to avoid awkward view + window blurs which
don't look that good. This is not the POR, but I think it achieves
most of the effect and will help us get some blur exposure.

Separately I will continue to investigate options such as blurring
workspace in a clever way so it feels blended with the wallpaper,
reusing the Taskbar window and connecting it to LauncherState, or
using a SurfaceView (though I spent quite some time trying this and
it seemed the same as the original issue).

In both cases, we use a 20-30% opacity scrim with a set color, and a
panel that blends 40% opacity of a dark/light color with 10% white.

Also updated some incorrect isTablet checks which really should have
been checking shouldShowAllAppsOnSheet(), which includes the
all_apps_sheet_for_handheld flag.

Demo: https://drive.google.com/file/d/1Ov9Dg3R9YHNfisfxNf97ZIhlDeEA1IWj/view?usp=sharing&resourcekey=0-l_SDpqpS4HtOb10a3b_jNg

Other upcoming improvements: interpolator tweaks, colors of things
inside the app panel (tabs, private space, search results, etc).

Bug: 400827727
Bug: 371343636
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: Ic7063cd822f39a5977715b5477f825bf11e57bdf
2025-03-11 23:34:03 +00:00
mpodolian
61de3b43cb Drag and drop from the search view on the overview screen.
Bubble bar drop targets have been added to the TaskbarDragController
used in the TaskbarOverlayContext. This enables dragging taskbar icons
to the bubble bar drop zone from the search view on the overview screen.

Bug: 399678274
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Go to the overview screen. Click the search icon. Drag any
application icon from the grid to the bubble bar drop zone. Drop the
application icon.

Change-Id: I33eb13785d8837fefc717a95a6566d3091ec855b
2025-03-11 16:07:21 -07:00
Mykola Podolian
00017267df Updated animation to account bubble bar stash state.
Added logic to check the bubble bar stash state and perform appropriate
animations based on that state.

Bug: 399678274
Test: Manual: Have bubbles in the bubble bar. Go to an application.
Swipe up the taskbar handle so the taskbar is shown. Click the search
icon in the taskbar. Start a drag on any icon in the grid. The bubble
bar stashes immediately on drag start. When the icon is dragged over the
bubble bar drop zone, the bubble bar unstashes and is shown at the
dragged location.
Flag: com.android.wm.shell.enable_create_any_bubble

Change-Id: I9663a03a7daacdfaba071d5e35d5b7404cefed4e
2025-03-11 15:57:34 -07:00
Brian Isganitis
2053f6fdfc Wait until updateItems is called to perform addStaticViews.
This is more consistent with pre-LayoutTransition approach, and should
behave more reliably on phones.

Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: Ib758b1e44c3b87d6d2ff71425ed40ff621261104
2025-03-11 18:53:38 -04:00
Jagrut Desai
c05107357b Merge "Don't recreate Desktop Mode Taskbar if already in Desktop Mode." into main 2025-03-11 15:04:53 -07:00
Toni Barzic
94db320a84 Update KQS task view borders
Updates border color to have more contrast to the background, and adds
2dp padding between the border and the task content view - done by
updating BorderAnimator not to assume the border width and stroke are
the same.

Adding padding between the border and task view content exopsed an issue
where the second thumbnail in a split task's borders were not clipped
correctly when adding a border (it looked like the clip rect was not
properly scaled down). This is addressed by moving the tack view
background (and the outline) from the root KeyboardQuickSwitchTaskViews
to the content views (i.e. moving the outline to the view that does not
get scaled when adding a border, and having the second thumbnail end
edge of the clip rectangle match the clip rectangle of the clipped
ancestor view).

Bug: 398770098
Test: Manual
Flag: EXEMPT (a11y) bug fix

Change-Id: Ie058c932411a6b47815b0abf756f739c55b8342f
2025-03-11 22:00:59 +00:00
Treehugger Robot
ace69f7644 Merge "Making various model objects injectable" into main 2025-03-11 14:48:30 -07:00
Jon Miranda
ccbc78735f Merge "Check for isAttachedToWindow before dispatching touch event" into main 2025-03-11 13:38:38 -07:00
Treehugger Robot
89816b8e46 Merge "Track the empty desk correctly inside applyLoadPlan" into main 2025-03-11 12:49:52 -07:00
Treehugger Robot
db6fa77ec3 Merge "Keep the desks order inside overview by its deskId" into main 2025-03-11 12:35:15 -07:00
Jagrut Desai
d8ed1c6ee3 Don't recreate Desktop Mode Taskbar if already in Desktop Mode.
The problem: Due to complexitiy of recent animation, taskbar is currently getting recreated upon recent animation being canceled for Desktop Mode.
Upon canceling of recent animation showDesktopApps is called again, but user is already in desktop mode.

The solution: simply check if user is in desktop mode upon getting onEnterDesktopMode transition callback before recreating taskbar.

Test: Manual
Bug: 399857150
Flag: EXEMPT bugfix
Change-Id: I8f36a8c8c834bca7be1ce7164cd712a7578c1ab4
2025-03-11 10:41:25 -07:00
minch
3049247a2e Track the empty desk correctly inside applyLoadPlan
Track the DesktopTaskView through its `deskId` if it is the current
TaskView or the running TaskView. This is done to support emtpy
desk which has no tasks inside.

Bug: 400532675
Test: m
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: Id1e7e7efc2a6ac3126d0320d85a3d327eec0f3c1
2025-03-11 17:41:25 +00:00
Jordan Silva
afff31deb3 Merge "Add hover and pressed states for app chip and menu items" into main 2025-03-11 10:27:51 -07:00
minch
c972e58da3 Keep the desks order inside overview by its deskId
Bug: 400723456
Test: m
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: Ib86e1260620587293ababfaa94aacef5846a8479
2025-03-11 17:22:50 +00:00
samcackett
d88fb62c4d Remove redundant FrameLayout from task_header_view.xml
Move feature flag logic to the state mapper

Fix: 401469907
Flag: com.android.launcher3.enable_desktop_exploded_view
Test: TaskUiStateMapperTest & TaskContentViewScreenshotTest
Change-Id: Ic6ee5bef438ae2782816f526b003e1fb91992065
2025-03-11 16:49:52 +00:00
Sukesh Ram
feda773d48 Merge "[CD Taskbar] Make External Taskbar 3-Button & Persistent" into main 2025-03-11 09:32:47 -07:00
Treehugger Robot
2595899b6e Merge "Reset All Apps button alpha at the end of all set page -> home animation" into main 2025-03-11 09:12:54 -07:00
Johannes Gallmann
986985f5c0 Merge "Fix back button touch region too small" into main 2025-03-11 08:45:34 -07:00
Schneider Victor-Tulias
f7b75b2f8c Reset All Apps button alpha at the end of all set page -> home animation
Flag: EXEMPT bug fix
Fixes: 360338079
Test: swiped up from the all set page
Change-Id: Ide5eb3b8e81bfc67975932d0806e4ab17d60c078
2025-03-11 07:03:19 -07:00
Jordan Silva
38af4f71c7 Add hover and pressed states for app chip and menu items
Fix: 356830855
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewActionsMenuHoverImageTest
Change-Id: I3a244a4eea07192a622c57d28618dabbb107a088
2025-03-11 05:37:43 -07:00
Massimo Carli
284fdfb2e3 Merge "Consider userId in transparent policy heuristic" into main 2025-03-11 03:55:06 -07:00
Jordan Silva
b6bae63a6e Merge "Fix TaskMenuView to calculate bottom menu's max height" into main 2025-03-11 03:45:25 -07:00
Johannes Gallmann
b44c55a6a1 Fix back button touch region too small
The back button in 3-button-nav touch region was unintentionally
decreased with the predictive_back_three_button_nav flag. The reason is
that NearestTouchFrame did not consider the back button for its touch
forwarding logic, because the back button did not have isClickable set
to true. Manually setting the clickable attribute fixes that.

Bug: 393498908
Test: Manual, i.e. verified that touches close to back button are not routed to the home button
Flag: EXEMPT bugfix
Change-Id: I7ad1ee13f92aa947f1a86f8d65de79a9d9e13899
2025-03-11 08:11:05 +00:00
Wei Sheng Shih
7d05e50e88 Merge "Remove DepartingAnimationTarget from BackMotionEvent(2/2)" into main 2025-03-10 23:25:25 -07:00
Treehugger Robot
3868333a60 Merge "Fix layout transition crash for phone with QSB inline." into main 2025-03-10 17:04:12 -07:00
Thu-Huong Vu
48dd9eee1c Register SimpleBroadcastReceiver permission.
Update SimpleBroadcastReceiver API to pass in broadcast permission and
register Growth Broadcast Receiver with permission to prevent other apps
from triggering Growth Nudge on their behalf.

Flag: EXEMPT add separately
Test: Manual
Bug: 397739323
Change-Id: I3a9d5e131ced752af0a1b35d400eed6d170fc81e
2025-03-10 23:29:33 +00:00
Randy Pfohl
0678d08e87 Merge "Move flags to desktopmodeflag" into main 2025-03-10 14:50:38 -07:00
Sunny Goyal
42975c39db Making various model objects injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ibb45b72c186e6aeeed7a37b0ae3f8083472019d7
2025-03-10 14:37:43 -07:00
Ahmed Fakhry
30d39caacb Merge "Propagate desks changes" into main 2025-03-10 14:06:52 -07:00
Sukesh Ram
c166a373a9 [CD Taskbar] Make External Taskbar 3-Button & Persistent
The gesture handle still persists in conjunction with the three buttons. In addition to being forced into three button mode, the taskbar on external displays needs to never enter transient mode. More info and before/after images on bug.

Flag: com.android.window.flags.enable_taskbar_connected_displays
Bug: 399718805
Test: Manual
Change-Id: Iff5c297c8ac4823fa24e7a8e4becd0447224cac0
2025-03-10 13:58:21 -07:00
Mykola Podolian
595433f1eb Merge "Fixing NPE caused by postponed action relaying on controllers." into main 2025-03-10 13:38:08 -07:00
Jon Miranda
d6b9eff743 Check for isAttachedToWindow before dispatching touch event
Otherwise we get an IllegalStateException

Fixes: 380318615
Test: repos in production
Flag: EXEMPT bugfix
Change-Id: Id72b76ab288f40ee50ba8485d4b0636c525e22e3
2025-03-10 13:10:53 -07:00
Treehugger Robot
a6533ae04b Merge "Improve KQS accessibility" into main 2025-03-10 12:49:00 -07:00
Treehugger Robot
a4fc3ad45d Merge "Introducing a wrapper over binder to simplify lifecycle management for IPC" into main 2025-03-10 12:46:34 -07:00