Commit Graph

10807 Commits

Author SHA1 Message Date
Orhan Uysal
6d73b0a201 Make taskbar visibilty change only in desktop.
Make the DesktopVisibilityController not change the taskbar visibility
when there are no freeform tasks visible.

Test: Go from freeform to fullscreen, observe taskbar doesn't pop up
Bug: 323129412
Flag: ACONFIG com.android.wm.shell.enable_desktop_windowing DEVELOPMENT
Change-Id: I67f246cfc2ddc198326c093fd0af83886de8b0a9
2024-02-22 17:13:42 +00:00
Vineeth Bhende
18f3f63a2c Merge "Add tag for cuj OPEN_ALL_APPS when swiping to open all apps" into main 2024-02-21 02:25:19 +00:00
Vinit Nayak
2b031727f0 Merge "Log split metrics through individual sessions" into main 2024-02-21 00:20:44 +00:00
Alex Chau
d564a9d26c Merge "Update pivots after taskSize is updated" into main 2024-02-20 11:57:49 +00:00
Alex Chau
a6def81654 Merge "Don't run parallax animation for grid overview" into main 2024-02-20 11:35:36 +00:00
Alex Chau
ec6f0bad38 Don't run parallax animation for grid overview
Bug: 286821534
Test: manual
Flag: None
Change-Id: I08c77ce5d538ee07374e9f88fc4d00cc8165f28b
2024-02-20 11:34:58 +00:00
Treehugger Robot
89170d6fab Merge "Update color of Overview ShareTarget scrim" into main 2024-02-19 14:17:47 +00:00
Alex Chau
51c09ed13e Merge "Avoid resetting RecentsAnimationController and RemoteTargetHandle without clear ownership" into main 2024-02-19 12:00:56 +00:00
Alex Chau
6ff4c1f5a4 Merge "Always run animateClose when closing TaskMenuView" into main 2024-02-19 10:27:32 +00:00
Anushree Ganjam
9ea1724245 Merge "Add InteractionJankMonitor for backpress from allapps CUJ_LAUNCHER_CLOSE_ALL_APPS_BACK." into main 2024-02-17 00:23:11 +00:00
Anushree Ganjam
06c98fd685 Add InteractionJankMonitor for backpress from allapps CUJ_LAUNCHER_CLOSE_ALL_APPS_BACK.
Jank CUJ's cannot be added in LauncherState since it's aosp code.
Introduced `onBackPressComplete` method so the LauncherState subclasses can override this method to get back press complete call after back press animation is successful. Here we can add necessary jank CUJ's.

Perfetto trace : https://ui.perfetto.dev/#!/?s=3fc6eed848bdd692949ddb3afbdcdf04a7ef0d99cb9a83804ce9e1840492ed66

Test: Perfetto trace. https://screenshot.googleplex.com/5yviY5LxKusnKvF.png
Bug: 319132905
Flag: NA. Adding jank CUJ.

Change-Id: Ia418f06cb76fe4e14c2032c62c2250e9143442f2
2024-02-16 14:35:20 -08:00
Jon @
d3693424f5 Merge "Notify home is visible when launching a translucent app." into main 2024-02-16 21:43:28 +00:00
Treehugger Robot
821715127d Merge "Prevent taskbar reset animation from playing when gesture is in progress." into main 2024-02-16 21:36:59 +00:00
Ats Jenk
ca99653959 Merge "Create bubbles input consumer before nav bar long press" into main 2024-02-16 19:52:08 +00:00
Alex Chau
c302daec2f Avoid resetting RecentsAnimationController and RemoteTargetHandle without clear ownership
- RecentsView only see itself owning RecentsAnimationController and RemoteTargetHandle after live tile is enabled via onGestureAnimationEnd to RECENTS
- RecentsView will finish recents animation if it owns RecentsAnimationController and is leaving RecentsView
- Otherwise, reset() would not reset RecentsAnimationController or RemoteTargetHandle
- Added logging for interaction between gesture and RecentsView to aid future debugging

Bug: 288557298
Test: manual
Flag: None
Change-Id: Icdcb91b98b2bb5d6d3bc30070f533ea79915bc09
2024-02-16 19:23:08 +00:00
Alex Chau
1ae5e169b0 Update pivots after taskSize is updated
- For case that there are no TaskViews, onLayout is not called, so updatePivots isn't called when folding

Fix: 325314248
Test: Manual
Flag: None
Change-Id: If7377f2e4fcbe4a874f823bb99b0b197cd5f7b87
2024-02-16 15:23:35 +00:00
Alex Chau
60ad90e519 Always run animateClose when closing TaskMenuView
- This avoid diverging code path when animation is off
- Also made sure menuTranslationX and Y always reset when not needed
- Also remove AnimatedVectorDrawable in favour of scale animation in code, as AnimatedVectorDrawable doesn't work well when animation is off

Bug: 319086207
Test: OverviewMenuImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: I4a18cf4aac3237031095c2600c777b6c4c3e518f
2024-02-16 14:58:14 +00:00
bvineeth
e8bdf16b65 Add tag for cuj OPEN_ALL_APPS when swiping to open all apps
Test: Checked trace
Bug: b/270128536
Flag: None
Change-Id: I0d5f562fc156423af2b5ce7e54e1bff54a522aa6
2024-02-16 10:41:15 +00:00
Vineeth Bhende
e2a76cee2b Merge "Add CUJ-LAUNCHER_OPEN_ALL_APPS instrumentation from taskbar" into main 2024-02-16 04:02:24 +00:00
Ikram Gabiyev
1979abe353 Merge "Move IPip and IPipAnimationListener to common" into main 2024-02-15 23:42:51 +00:00
Jon Miranda
26447ddc98 Notify home is visible when launching a translucent app.
To fix the taskbar stash delay when launching an app, ag/18875100
sets the state so that the taskbar stashes immediately after
app is launched.

Since we cannot know if the app is translucent at that point,
we have to check after the animation is started so we can update the
launcher visibility state.

Bug: 314792981
Flag: ACONFIG ENABLE_HOME_TRANSITION_LISTENER TRUNKFOOD
Test: HomeObserverTest
Change-Id: Ifc3a6559d7a8c6fda4c08a0fc2d6791da46b38d6
2024-02-15 13:55:42 -08:00
Schneider Victor-tulias
00a484bf03 Merge "Fix alt-tab initial focus in overview on phones" into main 2024-02-15 21:06:08 +00:00
Ikram Gabiyev
f32c27f773 Move IPip and IPipAnimationListener to common
Move IPip.aidl and IPipAnimationListener.aidl to common.pip
package as a part of PiP2 refactoring.

Make sure users of these Binder interfaces in Launcher
also reference the updated classname and package.

The plan is to use these interfaces to implement
PiP2 <-> Launcher IPC to facilitate transitions and animations
for gesture nav and auto-enter PiP for instance.

Note: this CL shouldn't yield any behavioral changes.

Flag: NA
Bug: 325481148
Test: mp droid
Change-Id: I065334f6777cd1489c739d95abf0fab8285860ed
2024-02-15 11:17:36 -08:00
Schneider Victor-tulias
5c6263afc5 Fix alt-tab initial focus in overview on phones
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 325057678
Test: used alt+tab on a phone from home and from an app
Change-Id: I98388fea448fd1932d767c420e232d1451e0bbfe
2024-02-15 18:07:54 +00:00
Jon Miranda
4a9a67816d Prevent taskbar reset animation from playing when gesture is in progress.
This fixes the bug that appears when you launch an app and immediately
swipe up on taskbar.

Fixes: 278617335
Test: launch app, immediately swipe up on taskbar
Flag: NONE
Change-Id: I56eddfae9c81b1ef827622cf0f13ffd26fadd5c3
2024-02-15 18:04:17 +00:00
bvineeth
d2379d11c7 Add CUJ-LAUNCHER_OPEN_ALL_APPS instrumentation from taskbar
Added instrumentation when allapps is opened by button click in the
taskbar. Starting the slice in the onClickListener of the allApps button
and ending it on the end of the animation.

Test: checked the trace
Fixes: b/270128563
Flag: None
Change-Id: I492a4a7af81e0c40dc3d7d415ffc7b16c057b25d
2024-02-15 12:28:47 +00:00
Alex Chau
a841753785 Update color of Overview ShareTarget scrim
Fix: 323091847
Flag: None
Test: manual
Change-Id: I234aea721eaa81e42551899c6692ea0e9df468cc
2024-02-15 12:14:42 +00:00
Sunny Goyal
772e0127c3 Merge "Cleaning up some no-op calls during workspace binding" into main 2024-02-15 01:56:02 +00:00
Andy Wickham
1abc0a7f66 Merge "Extract TaskbarViewCallbacks to a separate class + factory." into main 2024-02-14 23:15:55 +00:00
Sunny Goyal
e337a80ef2 Cleaning up some no-op calls during workspace binding
Bug: 318539160
Flag: None
Test: Manual
Change-Id: Ida21d849a06ed9c0ebf5671214dd9ee8525288d3
2024-02-14 15:10:54 -08:00
Ats Jenk
32664125af Create bubbles input consumer before nav bar long press
NavHandleLongPressInputConsumer handles long presses on the nav handle
and passes the touches on to a delegate if the touch is not a long
press.
When bubbles are expanded, we create a new input consumer that does
nothing and allows bubble input consumer in shell to take over.
Change the order how the input consumers are created. Create the bubbles
input consumer first, so it can be passed in as a delegate to the
nav handle input consumer. And this avoids bubbles overriding the nav
handle behavior.

Flag: ACONFIG com.android.wm.shell.enable_bubbles_long_press_nav_handle DISABLED
Bug: 324910035
Test: manual, expand a bubble, long press on home button for CtS
Change-Id: I05c219145c096a567bb0bb5a9cb3a40046b29519
2024-02-14 11:25:16 -08:00
Schneider Victor-tulias
33ce1cf67c Merge "Remove KQS touch handling outside its bounds" into main 2024-02-14 18:11:52 +00:00
Saumya Prakash
3acd0708ab Merge "Add insets for taskbar when a camera cutout interrupts it" into main 2024-02-14 17:45:30 +00:00
Alex Chau
76502e84f2 Merge "Refactored StateManager logs" into main 2024-02-14 17:40:08 +00:00
Schneider Victor-tulias
e724cb8e5f Remove KQS touch handling outside its bounds
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 324906627
Fixes: 324893557
Test: opened KQS and tapped outside the bounds with taskbar present/absent
Change-Id: I10de9a1ea1ccca7321981fd5e9e66e9388a8dd0a
2024-02-14 10:42:01 -05:00
Schneider Victor-tulias
6e32385838 Merge "Show scrim immediately when animating to overview from app through KQS" into main 2024-02-14 15:21:35 +00:00
Tracy Zhou
64cdbf5c77 Merge "Do not add jank monitor for stash state change when the drag layer is not attached to the window" into main 2024-02-14 03:08:01 +00:00
Andy Wickham
0ae51bcdb9 Extract TaskbarViewCallbacks to a separate class + factory.
Also log long presses on the taskbar all apps button.

Test: Manual
Flag: NA
Change-Id: Id2bf194f09007bfccff9f83162e4bcfb6562580f
2024-02-13 18:51:48 -08:00
Vinit Nayak
5a9d4af170 Log split metrics through individual sessions
* Now we log the original source of the first selected app
as soon as the user selects it (previously we only did when user
selected second app)
* We log the item info for the second app to determine second
surface.
* Added new metrics to log after user has started a split session
and ended a split session
* We log different cancellation reasons (cancel button,
home gesture, general other app interruptions, etc).
* One KI/Bug: When the second app is selected via taskbar in
overview, the container will say hotseat because we are using
Launcher's logger and not Taskbar's. Taskbar's logger manually
overwrites the container in TaskbarActivityContext, we may be
able to make something hacky that can allow us to overwrite, but
that'll have to be a separate change

Bug: 322551862
Test: Logged metrics manually with event and itemInfo
Change-Id: I177623fd00ce62acf2d4ee983b58561d8c946d59
2024-02-13 17:55:08 -08:00
Schneider Victor-tulias
bd5ffee884 Show scrim immediately when animating to overview from app through KQS
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 324888882
Test: opened overview from app/home with finger swipe/KQS/overview button
Change-Id: Ia4a15f5a64956ec56fc9aae3511173219616245e
2024-02-13 19:00:04 -05:00
Saumya Prakash
bb3af5d904 Add insets for taskbar when a camera cutout interrupts it
Certain devices have camera cutouts that taskbar's insets did not account for previously. This change adds in the cutout's height as a bottom inset (if it is present) to avoid a black bar being drawn in the taskbar area.

Fix: 322954760
Test: Open a full screen app on a large screen device and ensure that a black bar doesn't show up when rotating the screen to 90 degrees and 180 degrees.
Flag: N/A
Change-Id: I876274b561c7f0101554654ce758fc9c08180de7
2024-02-13 23:00:21 +00:00
Saumya Prakash
e1c6312800 Merge "Update back gesture tutorial strings to align with UX" into main 2024-02-13 22:48:17 +00:00
Tracy Zhou
91546d401d Do not add jank monitor for stash state change when the drag layer is not attached to the window
An alternative here is to use the root layer when NO_RECREATE flag is on. However, we do not have a reference to it here (shall we consider passing it in?)

Fixes: 325096498
Test: Need to verify
Change-Id: I1709bc88753a90547f7a61dc6e24cdaf489d19e0
2024-02-13 20:57:16 +00:00
Mady Mellor
9a1fb27508 Merge "Follow changes for MagneticTarget.Listener to pass the dragged object" into main 2024-02-13 17:47:30 +00:00
Alex Chau
4e6e1555c4 Refactored StateManager logs
- Make the log permanaent behind a DEBUG flag
- Logs are currently enabled with b/279059025 marked as the related bug

Bug: 279059025
Flag: None
Test: Manual
Change-Id: I60a75d73d40d00e7d42292f3d42cc9dd8c9b0825
2024-02-13 15:35:15 +00:00
Jordan Silva
3a42f0e0eb Merge "Log split button visibility to debug spacing issue" into main 2024-02-13 11:44:11 +00:00
Tracy Zhou
92f9d10cea Merge "Hide task bar when folding before the new config renders the correct task bar" into main 2024-02-13 03:52:03 +00:00
Tracy Zhou
dfb334f1e1 Hide task bar when folding before the new config renders the correct task bar
Currently on folding, onConfigurationChange doesn't return about 0.5sec after the small screen turns on. The old bar is visible on the new screen before a visual jump from rendering the new bar.

While the ideal solution is to figure out what causes the delay, we can mitigate the visual jump by dimming the old bar when folded listener returns folded

Test: repeatedly fold and unfold, observe that there is no glare task bar change in task bar area after folding
Bug: 291562764
Change-Id: Ic6834d2d3b7df01a8ef841dde601cdb6a3e481b0
2024-02-12 17:06:04 -08:00
Saumya Prakash
96ce6873dd Update back gesture tutorial strings to align with UX
This change updates the feedback shown to users to align with the
strings in figma for the back gesture tutorial.

Fix: 300919987
Test: Went through both the redesigned and previous gesture tutorial and
ensured the updated strings show up in the redesigned tutorial.
Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED

Change-Id: I057af6e8631b86ffaec8093ffbfbeae01c9d917c
2024-02-13 00:35:37 +00:00
Brandon Dayauon
5faed49eaf Merge "Fix color contrast in All Apps text by setting the color to onSurfaceVariant" into main 2024-02-12 23:15:05 +00:00