When unbound, destroy taskbar immediately instead of waiting for
TIS#onDestroy. And then send the reply back to OverviewProxyService
so it can bind to a new TIS.
Fixes: 375315062
Test: Switch users 10 times, no crash (also check logs)
Flag: EXEMPT bug fix
Change-Id: I737c47c7df87e11608672a4e16eb3e9fd645e487
- Update the logic of `getRunningTaskExpectedIndex` to make sure it
will still work with the AddDesktopButton added as the first child
of the RecentsView.
- Introduce `mTaskAlignmentTranslationY` to ClearAllButton, and set
it through RecentsView. Thus, the logic can be used by the
AddDesktopButton as well. etc.
Flag: EXEMPT refactor
Bug: 382057498
Test: Manual
Change-Id: I6d0c031fe1fc0b4c198b9c890a27a69d911d38d9
Separating various overrides to individual modules so that they can be reused in tests
Removing ContextualEduStatsManager and directly using SysUiProxy as all the usescases
are only in quickstep/
This avoids additional Module definition and delegation
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I096459d638553991ed01766002b874589c6b976e
This CL marks `GroupTask.task1` and `GroupTask.task2` as deprecated, and
removes some of the usages of the `task2`. Follow-up CLs will continue
replacing all the usages.
Bug: 388593902
Test: m
Flag: EXEMPT pure refactor with no behavior change.
Change-Id: I530bbba00bd41cf33a952b083de7670d9a490e81
This is the first step in refactoring GroupTask to remove the assumption
about `task1` being always present.
Bug: 388593902
Test: m
Flag: EXEMPT pure refactor with no behavior change.
Change-Id: Ib79d9f2ad7f028b971e2509d846b50fa220bee26
Bug: 387511656
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Checking perfetto traces shows that this reduces the number of continuations on main by ~100 for 30 apps
Test: Opening Overview shows correct content.
Test: TaskThumbnailViewScreenshotTest
Change-Id: If8d3c6a8f82cea38a3fb78339946bec2c8646ab7
Until Taskbar multi instance support was in place, Taskbar would show
multiple icons for different instances of the same app in desktop mode.
Now this is no longer needed as taskbar has multi instance support, so
now there is only one icon per instance of an app of the same user.
Fix: 382589460
Test: Started several Chrome windows -> Taskbar has 1 icon for chrome
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar
Change-Id: I2df4327dcdc9d221164055ebc33ff508273e7ef9
This change explicitly sets the Talkback attributes to allow for
automatically scrolling to the subtitle in the gesture navigation
tutorial. Previously, you would have to tap the subtitle for it to be
announced.
Fix: 386884587
Test: Run the tutorial with talkback enabled and observe talkback announcing the
title and subtitle of the current gesture
Flag: EXEMPT bugfix
Change-Id: I6ca2c1654f9e481165e2135e9afd72fa178f8184
Since there is no display being used for LauncherSwipeHandlerV2Test, then no RecentsDisplayResource gets created for the DEFAULT_DISPLAY (and so RecentsDisplayModel.getFallbackWindowInterface returns null). Adding a mock display
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I43754eafb4f6a9b393e6a7b7fbd5b27903d2f9b9
- The new design have 3 deadzones Rect:
- TaskView (for desktop tasks, focused task or all tasks in small screen)
- Top row
- Bottom row
- The shorter row between top/bottom row is expanded to cover space between the 2 rows
- The large tile row is expanded to cover space between large and small tiles
- Rect illustration: http://screen/8vHAqrYdUB5Rqbc.png
Fix: 323143607
Fix: 323143607
Test: Tap empty space between tasks, Oveview should not dismiss
Test: Tap empty space on shorter rows in grid, Overview should dismiss
Flag: EXEMPT bugfix
Change-Id: Id59c1238df33dfbe67a696d0836ba393321b38ac
- With the introduction of Desktop windowing, we'll need to supprot grid task and large tile (desktop tile) coexisting
- The previous gridOnlyOverview aimed to have taskSize matches actual grid task size, and introduced another carouselTaskSize for scaling in swipe up carousel
- Now I'm reverting to pre-gridOnlyOverview implementation of having taskSize as both large tile size and carousel task size, and gridTaskSize as only task size in grid
TaskViewSimualtor
- Removed no longer needed carousel translation and related calculations
- mIsGridTask is now determined with DeviceProfile, so when swipeing to Desktop task it won't use grid task size
TaskView
- Removed no longer used nonGridPivotTranslationX
RecentsView
- Make getSelectedTaskBounds / getTaskBounds picks the correct taskSize
Fix: 359573248
Fix: 321697299
Fix: 325606690
Bug: 322816508
Test: Swipe up, quick switch, task launching with grid task and desktop tasks; repeat with RTL, three button, phone
Flag: com.android.launcher3.enable_grid_only_overview
Change-Id: I14648c6682c53a4d06f9c9585d53f28dddef4f8f
Introduced logic to control the bubble bar stash handle alpha based on
the notification shade state.
Test: TransientBubbleStashControllerTest
Test: Manual. Have bubbles and the bubble bar stashed. Open the
notification shade, observe that the stash handle fades away. Close the
notification shade, observe that the stash handle fades back in.
Have few bubbles, open bubbles test app, click on bubble icon. Observe
the bubble bar expands without blinking.
Test: Manual.
http://recall/-/gx8ASgewUeUS3QYohfrd1J/e1iUtwaFdezKOb0gBRff7Z
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 376140839
Fixes: 376141264
Change-Id: Id9c473f9aead0e4c5830793d9f3b0b1ae86453e7
* changes:
Take bubble selection from the shell update.
Fix bubbles animation when the new bubble added and old bubble removed.
Fix arrow animation when the new bubble added and old bubble removed.
The header has an app icon, app title and a close button. Currently
clicking on the close button does nothing. Will address it in a
following CL.
Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 353965691
Change-Id: I5e0303a02d5f8afd16a5f5f0335a8fa489ff98f2
=> For prototyping purposes only. The method is protected by system|signature permission.
=> Uses the AutoInstall layout xml specification to allow for getting and setting the current launcher layout.
Test: manual via prototype apk
Flag: EXEMPT prototyping interface
Change-Id: I04dd29ee69db642095dfb5f6c4965cdb8509b05e
Prior to this change, the bubble bar controller determined which bubble
to select. With this change, the selection is now determined by the
update received from the shell.
Test: Manual. Tested the add overflow and remove bubble flows, add
bubble and remove overflow flows, and add bubble and remove bubble flows
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 359952121
Change-Id: I8ec01d6976b1e1cd0129071fd1765041eeb10b83
When determining if a touch event on bubble bar area is a click,
check the time diff between receiving ACTION_DOWN and ACTION_UP
motion events.
This matches with how the click handling is implemented in
View.java.
Bug: 385928447
Test: tap on bubble bar to expand it, long-press on bubble bar to move
Test: atest PlatformScenarioTests:android.platform.test.scenario.sysui.bubble.ShowMultipleBubblesAndSwitchTest
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I5a4a6605adf08f21b28b017cb6edfcb7b898a762
User should only be able to select the second app to split with, not
dismiss or take any other action.
Fix: 320221290
Test: Enable Switch Access. Open some apps.
Go to Overview and select "Split".
Select the second app. Accessibility menu should not be shown.
Flag: EXEMPT bugfix
Change-Id: I9075e018261949366dec21f64249308601690dbe
According to accessibility guidelines, we shouldn't be using this API and definitely not for notifying a user a task has closed, so just removing this use case altogether.
Fix: 386001961
Test: Enable Talkback.
Open some apps.
Go to Overview and dismiss an app.
Talkback shouldn't announce "Task closed".
Flag: EXEMPT bugfix
Change-Id: I1a55017cbd4825103b9a8b93532b06276f28aef6
The AddingAndRemoving animation now uses a newly selected bubble index
and added bubble index arguments.
Test: BubbleAnimatorTest
Test: Manual. Enable optional overflow bubble.
Create a bubble bar with overflow containing a single
bubble. Open the overflow menu and click an overflow bubble icon.
Observe that a new bubble is added and immediately expands while the
overflow bubble is collapsing. Observe that bubbles animation.
Test: Manual. Have few bubbles in the bubble bar. Collapse any bubble.
Observe bubbles are animated correctly.
Video: (slowed down 10 times)
http://recall/-/gx8ASgewUeUS3QYohfrd1J/emOREYETIeV5ktcNZLETYa
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 359952121
Change-Id: If2366ec12cb196757ba6439c5c9306959d4191a9
