Commit Graph

569 Commits

Author SHA1 Message Date
Will Osborn
6c413c1e80 Make TaskAnimationManager per-display
Test: locally tested on Tangor
Flag: com.android.launcher3.enable_overview_on_connected_displays
Bug: 402362875
Change-Id: I6acb166c200e8bd9198e2aa73e506b3c3414f526
2025-03-13 16:14:46 +00:00
Treehugger Robot
f0e0e8b7ec Merge "Remove redundant FrameLayout from task_header_view.xml" into main 2025-03-12 11:31:52 -07:00
Treehugger Robot
ace69f7644 Merge "Making various model objects injectable" into main 2025-03-11 14:48:30 -07:00
samcackett
d88fb62c4d Remove redundant FrameLayout from task_header_view.xml
Move feature flag logic to the state mapper

Fix: 401469907
Flag: com.android.launcher3.enable_desktop_exploded_view
Test: TaskUiStateMapperTest & TaskContentViewScreenshotTest
Change-Id: Ic6ee5bef438ae2782816f526b003e1fb91992065
2025-03-11 16:49:52 +00:00
Sunny Goyal
42975c39db Making various model objects injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ibb45b72c186e6aeeed7a37b0ae3f8083472019d7
2025-03-10 14:37:43 -07:00
Ahmed Fakhry
30d39caacb Merge "Propagate desks changes" into main 2025-03-10 14:06:52 -07:00
Ahmed Fakhry
6a19fc0765 Propagate desks changes
This CL propagates desk changes events to `RecentTasksList` and
`RecentsView`.

Bug: 395908683
Test: m
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: I77457d5e2e66166dd8c7d6505317d9add5b886a2
2025-03-10 18:06:03 +00:00
Sebastián Franco
0d8df93275 Merge "Sync landscape rotation with Overview rotation" into main 2025-03-10 09:30:11 -07:00
Uwais Ashraf
33c6559d41 Move overlay setup functionality to TaskView/Container
Bug: 395294954
Bug: 396064850
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Perfetto trace comparison
Test: OverviewDesktopTaskImageTest
Change-Id: I69ac43350b261532a47f7989848a650ae8a70e9a
2025-03-08 13:49:23 +00:00
Liran Binyamin
a5c9d86e1d Merge "Address flakes in BubbleBarViewAnimatorTest" into main 2025-03-07 18:17:59 -08:00
Treehugger Robot
bac3844525 Merge "Adds tests for popup menu" into main 2025-03-07 17:40:46 -08:00
Liran Binyamin
c2edd1c79a Address flakes in BubbleBarViewAnimatorTest
- Fix some mockito issue by using a fake implementation rather
   than a mock.
 - Return early in the bubble bar animation if there's no animating
   bubble. The issue here is that the scaleY property of the bubble
   bar is set to 1 when the animation is interrupted. However, in
   the test environment, the cancellation of the animator is posted
   to a different thread, and another animation frame is running
   after the scaleY was already reset to 1.

Flag: EXEMPT test only
Test: atest BubbleBarViewAnimatorTest
Bug: 399934422
Bug: 399720438
Change-Id: I271f670c50168237aeaf867c8171ae3023ee09ff
2025-03-07 14:13:31 -08:00
Dave Mankoff
7c06fbd2fe Merge "Nullability fixes for Kotlin 2.1" into main 2025-03-07 13:31:39 -08:00
Sebastian Franco
0e0fffd81c Sync landscape rotation with Overview rotation
Bug: 390487996
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: Ib564c21befd06edd5c720fe33f36780761035fee
2025-03-07 11:48:43 -08:00
Jorge Gil
cf40e5607a Merge "Disable multi-desks in createDesktopTaskPerDisplay test" into main 2025-03-07 08:26:28 -08:00
Dave Mankoff
9768fba0b0 Nullability fixes for Kotlin 2.1
Bug: 399463072
Flag: EXEMPT minor refactor
Tests: presubmits
Change-Id: I758a7ba2d62d2f096f1ceb775ee3f23275dd1c53
2025-03-07 15:28:37 +00:00
Jorge Gil
5d3f714944 Disable multi-desks in createDesktopTaskPerDisplay test
loadTasksInBackground_freeformTask_createsDesktopTaskPerDisplay assumes
that when FLAG_ENABLE_SEPARATE_EXTERNAL_DISPLAY_TASKS is enabled, all
desktop tasks (regardless of the GroupedTaskInfo.deskId) will be grouped
into one GroupTask per display.

However, if multi-desks is enabled, this logic does not apply, and
GroupTasks are created for each desk. Given that this test uses deskId=0
with the expectation that it is an unused/invalid field when testing
FLAG_ENABLE_SEPARATE_EXTERNAL_DISPLAY_TASKS, this CL disables
FLAG_ENABLE_MULTIPLE_DESKTOPS_BACKEND to match that expectation.

Flag: com.android.window.flags.enable_multiple_desktops_backend
Flag: com.android.launcher3.enable_separate_external_display_tasks
Bug: 362720497
Test: atest NexusLauncherTests:com.android.quickstep.RecentTasksListTest
Change-Id: I88cceaa37582fdcf1a3ad4f59712abbfa7e428a8
2025-03-07 01:05:30 +00:00
Shamali P
992facdff3 Unregister widget prediction callback on clear
Noticed that predictor holds the registered callback and caused leak.
Using named listener classes for better stacks and also unregisters them

Bug: N/A
Flag: EXEMPT BUGFIX
Test: WidgetPredictionsRequesterTest
Change-Id: I94211ddbc77077c98b804827bb1cecdefe57703b
2025-03-06 14:25:13 -08:00
Treehugger Robot
872ef49247 Merge "Add TaskContentView parent to TaskThumbnailViewHeader and TTV" into main 2025-03-06 03:37:25 -08:00
Wen-Chien Wang
3c74827da7 Adds tests for popup menu
This cl creates some basic tests for popup menu on hotseat items
and recent tasks.

Bug: 3446576299
Test: The cl itself is for tests
Flag: EXEMPT adding test
Change-Id: I872078969d9c3d20b5bf47a43cd8e3c940dd4d8f
2025-03-05 10:03:47 -08:00
Will Osborn
19bdf47a31 Merge "Make separate dependency scopes and graphs for different RecentsViews" into main 2025-03-05 07:29:04 -08:00
Will Osborn
074a605827 Make separate dependency scopes and graphs for different RecentsViews
Test: locally tested on Tangor
Flag: EXEMPT - bugfix
Bug: 399364544

Change-Id: I788c5644f198ead206bb7512ec96eab838e51cdb
2025-03-05 10:56:25 +00:00
Treehugger Robot
9b775dfdac Merge "Check horizontal touch slop for non-vertical flings" into main 2025-03-04 17:29:35 -08:00
Brian Isganitis
75d443ffdb Initial overflow compatibility with layout transition.
Also implements RTL support for overflow.

Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: I34983821a2a1a80793dc6d811d42cfeafe274ef4
2025-03-04 12:05:58 -08:00
Brian Isganitis
42c58e39fd Migrate layout transition flag to DesktopModeFlag version.
Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: I175e428240bc52689efe0f6e4457620ac2efdbb5
2025-03-04 11:30:23 -05:00
Schneider Victor-Tulias
fad57be97f Check horizontal touch slop for non-vertical flings
Flag: com.android.launcher3.enable_gesture_nav_horizontal_touch_slop
Fixes: 394364217
Test: Tested overview gesture with slight horizontal fling at the end
Change-Id: Ifb716b58486dd0bfadee467978b85150525af333
2025-03-04 07:42:08 -08:00
Brian Isganitis
06d2e58105 Merge "Exclude All Apps divider in desktop mode." into main 2025-03-03 15:58:41 -08:00
Treehugger Robot
5fcd02dff6 Merge "Fix NPE from navbar touch cancel without down." into main 2025-03-03 13:05:39 -08:00
Brian Isganitis
8127148e02 Exclude All Apps divider in desktop mode.
Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 315354060
Test: go/testedequals
Change-Id: Ic9cf42ad9a81357fe7452ed576663bedb54fbcf7
2025-03-03 14:42:16 -05:00
Treehugger Robot
6e8347912c Merge changes I6846a3dd,I45356fd7 into main
* changes:
  Update ActiveGestureLogs to print gestures' display IDs
  Update TIS to use one input monitor per display
2025-03-02 18:07:04 -08:00
Schneider Victor-Tulias
841c6a98d2 Update ActiveGestureLogs to print gestures' display IDs
Flag: com.android.launcher3.enable_gesture_nav_on_connected_displays
Bug: 382130680
Test: connected an external display and checked logs
Change-Id: I6846a3dda77fc4afbbd83855aacca726eeb8eace
2025-03-02 16:03:32 -08:00
Schneider Victor-Tulias
21dba415e9 Update TIS to use one input monitor per display
Flag: com.android.launcher3.enable_gesture_nav_on_connected_displays
Bug: 382130680
Bug: 398881237
Test: connected an external display and attempted touch gestures. checked logs to ensure motion events are separated by display id
Change-Id: I45356fd7f1926685093833990d39c85a4a074c58
2025-03-02 16:03:08 -08:00
Treehugger Robot
eb808032f1 Merge "Propagate the display id with SysUIState changes to launcher" into main 2025-02-28 22:14:13 -08:00
Sam Cackett
e0cc96df62 Add TaskContentView parent to TaskThumbnailViewHeader and TTV
- Add TaskContentView parent view
- Extract TaskThumbnailViewHeader logic and any related state out of
TaskThumbnailView and move to TaskContentView
- Use vertical LinearLayoutManager to hold the TaskThumbnailViewHeader
and TaskThumbnailView
- Rename TaskThumbnailViewHeader to TaskHeaderView. Rename xml and state
 similarly

Bug: 397889146
Flag: EXEMPT. Refactor
Test: Refactoring CL. Existing unit tests still pass.

Change-Id: Ie31f35c6617aab272f984a6beb3e4cb8f58e3ce9
2025-02-28 12:19:26 +00:00
Nicolo' Mazzucato
6bccfb49c2 Propagate the display id with SysUIState changes to launcher
This changes the ILauncherProxy.aidl interface to also allow propagating the display id from SysUI to launcher for each SysUIState update.

The SysUI part of filling SysUI state correctly has not been implemented yet. But for now, only default display flags are propagated anyway.

On the launcher side, the sysui state is propagated correctly to each taskbar instance (there is one for each display)

Bug: 362719719
Bug: 398011576
Bug: 399371607
Test: LauncherProxyServiceTest
Flag: com.android.systemui.shade_window_goes_around
Change-Id: Ic9fa55ca82e4fe395a915c4d611afc8835c5d65d
2025-02-28 10:34:55 +00:00
Andy Wickham
8cbe719df7 Fix NPE from navbar touch cancel without down.
TouchInteractionService sends a touch cancel when the screen turns
off, for example. So we shouldn't assume there was a touch down.

Fix: 398855863
Test: NavHandleLongPressInputConsumerTest#testTouchCancelWithoutTouchDown
Flag: EXEMPT bugfix
Change-Id: Ic1b6e981fe183864663bd44e1488d6f6749183bc
2025-02-28 00:51:42 +00:00
Treehugger Robot
9a5cd11da5 Merge "Move MainThreadInitializedObject to Launcher3 Go." into main 2025-02-27 13:03:12 -08:00
Anushree Ganjam
e6065f5a94 Move MainThreadInitializedObject to Launcher3 Go.
Move SandboxContext to a separate class.
Remove all MainThreadInitializedObject references in Launcher3 and tests.
Remove ObjectSandbox interface and make RoboApplication extend
SandboxContext

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I1a8af5e6ae59df44d8ad6732b4d6e949ac402d6c
2025-02-26 16:49:08 -08:00
Treehugger Robot
acadebfaa1 Merge "Let TaskView allow empty TaskContainers" into main 2025-02-26 12:54:24 -08:00
minch
b8d4758d4e Let TaskView allow empty TaskContainers
Bug: 391918297
Flag: EXEMPT refactor
Test: m
Change-Id: Ia12c01746e6b31ac980c367f1c0144e69765f2a5
2025-02-26 12:50:04 -08:00
Treehugger Robot
006ea72afe Merge "More test for taskbar overflow" into main 2025-02-25 22:35:47 -08:00
Brian Isganitis
fbd55aeda4 Merge "Have per-environment bindings for Taskbar multivalent tests." into main 2025-02-25 09:53:16 -08:00
Sukesh Ram
f1ec7a7699 [CD Taskbar] Refactor TaskbarManager - Add Debugging Support for Stability.
Refactor TaskbarManager & add Debugging Support for Stability. Centralize all existing logging behind existing logging methods.

Bug: 398878697
Bug: 382378283
Bug: 391653300
Test: m
Flag: EXEMPT not adding new behavior
Change-Id: I3f131b5e9ce720140c1d3eb46a53a4763926df83
2025-02-25 02:52:48 -08:00
Toni Barzic
501562f09a More test for taskbar overflow
Adds tests to TaskbarOverflowTests to verify that:
*   tapping overflow view toggles keyboard quick switch view
*   tasks associated with a hotseat item don't get added to
    recents taskbar section / overflow view
*   keyboard quick switch view shown from taskbar contains
    running tasks, excluding tasks associated with a hotseat item

Bug: 379774843
Flag: com.android.launcher3.taskbar_overflow
Test: atest TaskbarOverflowTest

Change-Id: Iee6316c33cef6322d567e853f9fa358b7af9e172
2025-02-25 04:39:23 +00:00
Jeremy Sim
bc872b2ae4 Merge "Fix icon positioning for flexible split in Overview" into main 2025-02-24 17:03:09 -08:00
Jagrut Desai
8b2e5eff9b Desktop Mode Taskbar Recreate Animation
This Cl includes
       - addition of entry/exit callback methods in DesktopVisibilityController.
       - taskbar manager now listens to desktop mode changes.
       - TaskbarBackrgroundRedererer can now individually animation backgrounds for transient and persistent taskbars
       - new channel for taskbar icon alpha added to TaskbarViewController
       - new animated float to handle background alpha while we are recreating taskbar with animation.

Solution:

we use the callabck we get from DekstopVisibilty for entry/exit to first change logic of when we are considered inDesktopMode. Upon entry/exit we notify display controller for info change.
we also at notify taskbar manager who is now a listener to the desktop mode change and start the recreate process. TaskbarManager first animates existing taskbar out of user view and then follows the original recreate flow.

Test: Presubmit
Bug: 343882478
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: Ib827564cacd194f499e7d9b1965e2bb13e3548ab
2025-02-24 11:59:53 -08:00
Jeremy Sim
633b94abf1 Fix icon positioning for flexible split in Overview
In flexible split ratios like 90:10 and 10:90, we hide the Overview icon of the smaller app completely. This resulted in a bug where the single remaining visible icon was positioned badly.

Fixed this by adding a check in updateIconPlacement() so that we can skip the two-icon positioning and center the visible icon alone. Also fixed the cases where split select is initiated on a split tile (from Taskbar). Now the correct icon should be shown and centered.

Fixes: 391865942
Flag: com.android.wm.shell.enable_flexible_two_app_split
Test: Single icon is positioned correctly in the middle. When split select is initiated, the right icon is shown and centered. When app chip menus are enabled, the (existing) correct behavior is not changed.
Change-Id: I79842222fc325a7661cbabbb54d277389a317504
2025-02-24 11:48:50 -08:00
Treehugger Robot
19db412ca6 Merge "Update NavHandle tests to use more conservative timings." into main 2025-02-24 06:51:09 -08:00
Treehugger Robot
63de256dfe Merge "Add deskId to DesktopTask." into main 2025-02-21 18:33:52 -08:00
Andy Wickham
471ad8400f Update NavHandle tests to use more conservative timings.
On some devices, the long press would trigger due to an overly
long wait in the test. Separately, the small slop tests were
using a slop that would trigger the second stage if that flag was
enabled, so the trigger didn't happen (WAI). We already test 2
stage, so I updated these tests to use a smaller slop that should
not trigger with or without 2 stage.

Test: atest NexusLauncherTests:com.android.quickstep.inputconsumers.NavHandleLongPressInputConsumerTest -- --abi arm64-v8a
Flag: EXEMPT tests
Fix: 398216382

Change-Id: Iec633d01eff63eac8ba072fef4ac1e7b452d8242
2025-02-22 02:30:18 +00:00