Commit Graph

6947 Commits

Author SHA1 Message Date
Jon Miranda
6bb01ee8ca Merge "Seamless handoff between stashed handle and taskbar." into tm-qpr-dev 2023-02-21 20:09:41 +00:00
TreeHugger Robot
9769b2844c Merge "Translate the taskbar icons to match nav handle shape." into tm-qpr-dev 2023-02-21 03:24:41 +00:00
Jon Miranda
7a73f3ee82 Seamless handoff between stashed handle and taskbar.
Bug: 267806083
Bug: 246634367
Test: manual
Change-Id: I0c3d7a19aaa36a323c6fb3349852727f56842bb2
2023-02-21 01:42:30 +00:00
Ats Jenk
4004c9d42d Merge "Show highlight around the selected overview tile" into tm-qpr-dev 2023-02-18 01:06:00 +00:00
Robin Lee
aafeb82613 Revert "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and"
This reverts commit 2a58ddb89f.

Reason for revert: b/266987957

Change-Id: I4a4a1f01a693d703f4dc87e8169fbf374729d274
2023-02-17 19:45:27 +00:00
Winson Chung
192e7afc3c Merge "Only call per-user calls for gesture settings observer" into tm-qpr-dev 2023-02-17 19:44:52 +00:00
Winson Chung
0371d0f699 Only call per-user calls for gesture settings observer
Bug: 231648761
Fixes: 269392826
Test: Unable to reproduce 269392826, but verified this doesn't
      break existing paths to adjust the insets
Change-Id: I8aa82f3fb77e627ac02352ef31b788b81c2ca901
2023-02-17 19:44:29 +00:00
Jon Miranda
13e9b9f889 Translate the taskbar icons to match nav handle shape.
- We need to reset icon alignment whenever icon layout bound
  changes. This fixes the issue where we build an icon
  alignment animator before any of the views are laid out.
- Separated animation logic between.
  createTransientAnimToIsStashed and createAnimToIsStashed
* The values still require a bit more tuning but this gets us
  a lot closer to spec for many of the motion polish.

Bug: 267806083
Bug: 246634367
Bug: 246635237
Test: manual
Change-Id: Id122134b22ef4e418ce632e4a8137239dc8bb313
2023-02-17 10:56:59 -08:00
Alex Chau
ac4c866538 Merge "Log stackstrace if updateIconAlphaForHome is called after Taskbar is destroyed" into tm-qpr-dev 2023-02-17 17:49:18 +00:00
TreeHugger Robot
b26e558cb0 Merge "Hide smart actions if we enter split select from home" into tm-qpr-dev 2023-02-16 23:33:07 +00:00
TreeHugger Robot
4c6f172a62 Merge "Suppress transient Taskbar features EDU in overview." into tm-qpr-dev 2023-02-16 23:18:48 +00:00
Alex Chau
9a647d53cb Log stackstrace if updateIconAlphaForHome is called after Taskbar is destroyed
Bug: 269409332
Test: manual
Change-Id: I0ff4be33b1e621b0e1a837f8211eb70c27368be1
2023-02-16 18:56:13 +00:00
Jagrut Desai
202c68c8a2 Merge "Removing ENABLE_ALL_APPS_IN_TASKBAR and FLAG_STASHED_IN_APP_EMPTY Test: Visual(pics in buganizer) Bug: 265462138 Bug: 267382941" into tm-qpr-dev 2023-02-16 17:39:35 +00:00
Vinit Nayak
0a9056502b Merge "Add overview taskbar split support for 3P launcher" into tm-qpr-dev 2023-02-16 00:33:46 +00:00
Ats Jenk
cc0b860235 Show highlight around the selected overview tile
Enable highlight around focused overview item when desktop windowing
prototypes are enabled.
This highlight was built for and enabled with keyboard quickswitch feature.
We don't support quickswitch on desktop yet.
Disable the quickswitch, but keep the border highlight.

Bug: 269342116
Test: enable desktop windowing proto, use an external keyboard and
  alt+tab to switch between apps, observe highlight in overview, no
  quickswitch popup
Test: enable desktop windowing proto, enable
  ENABLE_KEYBOARD_QUICK_SWITCH, observe that alt+tab still opens
  overview
Test: disable desktop windowing proto, enable
  ENABLE_KEYBOARD_QUICK_SWITCH, observe alt+tab opens the quickswitch
  popup, and highlights in overview
Change-Id: I15b36f082610f4ce38143856c84fef723f1b8ba0
2023-02-15 15:41:12 -08:00
Jagrut Desai
4ffc71262d Merge "Making taskbar to stay stashed if user launches app for split screen view from all apps view" into tm-qpr-dev 2023-02-15 23:03:19 +00:00
Brian Isganitis
dbe968335d Suppress transient Taskbar features EDU in overview.
The EDU explains how to drag to splitscreen applications, but this operation is unavailable in overview. Therefore, let's only attempt to show the EDU when we are in an application.

Test: Manual
Fix: 269363653
Change-Id: I97aa5c76b44562189862432fb3856bf5634c6e4b
2023-02-15 22:31:55 +00:00
Stefan Andonian
3a14f1331d Merge "Refactor Workspace Loading / Processing code." into tm-qpr-dev 2023-02-15 22:16:29 +00:00
TreeHugger Robot
3f07d154fb Merge "Deferred widget update" into tm-qpr-dev 2023-02-15 20:01:07 +00:00
Vinit Nayak
f4e7e5aaf4 Add overview taskbar split support for 3P launcher
* Created b/268120202 to track other states of split
selection that are unhandled on 3P launchers

Test: Able to initiate split in overview with 3P launcher
Fixes: 264576761
Change-Id: I0311fe83380bf914fa79956b2565b61cc5eab916
2023-02-15 11:26:06 -08:00
Ats Jenk
4ec2d1296f Merge "Add support for showing border for desktop tile" into tm-qpr-dev 2023-02-15 17:48:53 +00:00
Ats Jenk
5e74542570 Merge "Disable quickswitch for desktop windowing" into tm-qpr-dev 2023-02-15 17:48:12 +00:00
Stefan Andonian
05ca3a8089 Refactor Workspace Loading / Processing code.
There are no behavioral changes (other than we no longer are recycling
objects while processing workspace items), but this refactor will setup
the next change to load the first workspace page before other workspace
pages.

Bug: 251502424
Test: Workspace, app widgets, and containers loaded properly.
Change-Id: I437aab40000d841d7fcc4380d05ab4a8f5d5c2ad
2023-02-15 17:36:27 +00:00
Charlie Anderson
9af03389d6 Merge "adding the new Material U App Shortcut Popup design" into tm-qpr-dev 2023-02-15 15:11:49 +00:00
Vinit Nayak
3287c1d8f9 Hide smart actions if we enter split select from home
Test: Enter split selection from workspace/all apps,
with 1, 0, or more apps in overview
Fixes: 269363674

Change-Id: I8eba01960dd7e3c2683fe8f1d21e81de3b8245a2
2023-02-14 17:33:48 -08:00
Ats Jenk
ae7e03440c Add support for showing border for desktop tile
When a external keyboard is connected and ENABLE_KEYBOARD_QUICK_SWITCH
feature flag is enabled, we highlight the selected tile in overview.
Add support to the new desktop tile to show the highlight.

Bug: 269342116
Test: connect an external keyboard, use alt+tab to open overview and
  switch between the tiles
Change-Id: I29ac5864776a9a251ecdb0cb4b741b12747de564
2023-02-14 14:40:07 -08:00
Schneider Victor-tulias
de7ceba80b Add the KeyboardQuickSwitchView (2/2)
Adding KeyboardQuickSwitchView and associated flows.

Test: Manually tested alt-tab and alt-shift-tab in and out of overview on a tablet and phone
Bug: 258854035
Change-Id: Ifb48b005067b3a9c66acfd5ecdbae144b359d3be
2023-02-14 13:34:37 -08:00
Charlie Anderson
8ad9144ca2 adding the new Material U App Shortcut Popup design
Bug: 247880037
Test: tested manually
Change-Id: I66c291df54dfc2a76fc974082a19091deb167f73
2023-02-14 16:03:15 -05:00
Ats Jenk
ce6cebd392 Disable quickswitch for desktop windowing
When desktop windowing prototypes are enabled, disable quickswitch for
now.
Quickswitch causes issues with how tasks are moved between desktop and
fullscreen in prototype 2. We are currently doing it based on shell
transitions. And whether there are desktop tasks visible or not.
Directly switching from a fullscreen task to desktop tasks does not fit
well into this model. And supporting this is not trivial.
As quickswitch is not a core user journey right now, will disable
quickswitch for the time being.
We can revisit this at a later date, when building out the production
version.

Bug: 268075592
Test: enable proto 1, try to quickswitch from home screen and from apps
Test: enable proto 2, try to quickswitch from home screen, from
  fullscreen app to desktop, fullscreen app to another fullscreen app,
  from desktop to fullscreen app
Change-Id: I06b3461f0134819cfa7c9e5f61df8ed84cc90eb8
2023-02-14 10:47:37 -08:00
Schneider Victor-tulias
673e6437b8 Merge "Add the KeyboardQuickSwitchView (1/2)" into tm-qpr-dev 2023-02-14 17:46:23 +00:00
Winson Chung
c5180384d5 Merge "Update region sampling to account for window visibility" into tm-qpr-dev 2023-02-14 04:48:02 +00:00
Winson Chung
b41d15b5f6 Merge "Have Taskbar report left/right gesture insets" into tm-qpr-dev 2023-02-14 04:45:24 +00:00
Tony Wickham
fc97f74e82 Have Taskbar report left/right gesture insets
Fixes: 231648761
Test: output from adb shell dumpsys activity service
TouchInteractionService, specifically TaskbarInsetsController

Change-Id: I8ed7fefb482bd4f73d2b2026ccb4ac369b6321ab
2023-02-14 04:43:01 +00:00
Winson Chung
a097a960c8 Merge "Reapply previous states when recreating the task bar" into tm-qpr-dev 2023-02-14 00:05:58 +00:00
Schneider Victor-tulias
f908729fa8 Add the KeyboardQuickSwitchView (1/2)
Preparatory change for adding the KeyboardQuickSwitchView and associated flows.

Test: Manually tested alt-tab and alt-shift-tab in and out of overview on a tablet and phone
Bug: 258854035
Change-Id: I468481a023e82d3ef7c7d4d44c5b9435173b49ae
2023-02-13 15:34:39 -08:00
Sunny Goyal
a13cc8167f Deferred widget update
Maintaing a list of pending updates while the host
is not listening, so that these can be applied when
host starts listening again

Bug: 267351283
Test: Manual
Change-Id: I38423862a3461724b36f17ffe44e44c55fee06de
2023-02-13 14:54:25 -08:00
Jagrut Desai
ec0b4e1693 Removing ENABLE_ALL_APPS_IN_TASKBAR and FLAG_STASHED_IN_APP_EMPTY
Test: Visual(pics in buganizer)
Bug: 265462138
Bug: 267382941

Change-Id: I223cd5ea7e5b553619dfc81c36f1be93e399639d
2023-02-13 13:34:23 -08:00
Nicolò Mazzucato
5147b1d509 Merge "Drive Launcher unfold animation from System UI" into tm-qpr-dev 2023-02-11 09:24:42 +00:00
Winson Chung
8bce18a562 Update region sampling to account for window visibility
- Similar to the nav bar, we should also disable region sampling then
  the window is no longer visible (ie. when in immersive mode) otherwise
  we fall back into gpu composition which consumes more battery

Fixes: 268280575
Test: Enter immersive mode and verify region sampling is disabled
Change-Id: I99bf8986c6f22fd8d480d255d10cfcd39cfb79e3
2023-02-11 01:02:35 +00:00
Winson Chung
8fe24e0893 Reapply previous states when recreating the task bar
- When the taskbar is recreated (ie. from a display config change),
  the previous states sent from SysUI need to be reapplied to the
  new controllers

Fixes: 267664948
Test: Wipe device, in SUW accessibility settings change the display
      density and verify it properly tints the back button
Change-Id: I837a67ced2941d4545359b8231026044b5479767
2023-02-11 00:25:01 +00:00
Nicolo' Mazzucato
8d9edd292b Drive Launcher unfold animation from System UI
Before this cl, both Launcher and System UI processes were registering for hinge angle and device state (e.g. folded/unfolded) change events to calculate the current unfold animation progress. In some cases, launcher ui thread was busy, delaying the progress calculation from the hinge angle value (that was received ~at the same time by both processes). This resulted in launcher and sysui unfold animation not being synchronized in some cases.

With this cl, System UI process uses OverviewProxyService to send the unfold events to Launcher. In this way, both process always have the exact same progress (+- 1 frame)

This is currently guarded by a launcher flag, by default with the new behaviour, to allow devs to compare the experience and easily debug potential regressions.

Bug: 268490854
Test: Analysed perfetto trace + RemoteUnfoldTransitionProgressProviderTest + manual
Change-Id: If15fd6fe39abb3d922c5fdb327100206dfa3665d
2023-02-10 22:04:19 +00:00
Schneider Victor-tulias
301433c11a Merge "Reorganize ActiveGestureLogs for ease-of-use" into tm-qpr-dev 2023-02-10 22:01:57 +00:00
Ats Jenk
90d0019447 Merge "Add icon to desktop tile in overview" into tm-qpr-dev 2023-02-10 21:47:31 +00:00
Lucas Silva
bc333343ec Merge "Allow QuickstepTransitionManager to be overridden" into tm-qpr-dev 2023-02-10 20:47:27 +00:00
Ats Jenk
78b614f555 Add icon to desktop tile in overview
Copied over icon from caption desktop button in WMShell. Temporary icon
for now.
Refactored some logic in TaskView to better support for custom
orientation handling in subclasses. Subclasses can override setting
orientation for icon or thumbnail.

Bug: 267326722
Test: manual, enable desktop windowing proto 2 and go to overview
Change-Id: Id66d48fa52a418a07b954a384b2c3ea22f091b1f
2023-02-10 10:16:31 -08:00
Sunny Goyal
c424941565 Merge "Updating Drawables as per GraphicsUtils changes" into tm-qpr-dev 2023-02-10 16:46:19 +00:00
Lucas Silva
099341fa97 Allow QuickstepTransitionManager to be overridden
This allows for custom animations in classes inheriting from
QuickstepLauncher

Bug: 260637266
Test: flashed device and verified animation
Change-Id: I21fa112851e9ce43037151fc4c2fd21e90056712
2023-02-10 10:41:39 -05:00
Luca Zuccarini
527679d258 Merge "Disable splash icon when launching a search result." into tm-qpr-dev 2023-02-10 12:20:53 +00:00
Sunny Goyal
799e12077b Updating Drawables as per GraphicsUtils changes
Bug: 266661614
Test: Presubmit
Change-Id: Ia3d0e0bc7a2b019d234e3bca71e893d5c4c54ca8
2023-02-09 16:14:04 -08:00
Ats Jenk
05abfa49c8 Merge "Fix invoking transient taskbar in desktop windowing prototypes" into tm-qpr-dev 2023-02-09 21:09:43 +00:00