Commit Graph

303 Commits

Author SHA1 Message Date
Alex Chau
fa83199e62 Turn off changing depth in wallpaper picker
Fix: 246845529
Bug: 240580498
Test: manual
Change-Id: Ib8fd624c518fb4c26d2598137d056b196a0ddeb7
2022-09-16 16:39:47 +08:00
Becky Qiu
1c8e630381 Merge "[Toast] Switch to use a device config instead of feature flag for appSearch." into tm-qpr-dev 2022-09-14 06:53:49 +00:00
Becky Qiu
cdac570298 [Toast] Switch to use a device config instead of feature flag for appSearch.
Bug: 241001264
Test: local
Change-Id: I47416b07a62379ab5c2c17b3b769c8bc8b2ef106
2022-09-13 12:26:42 -07:00
Alex Chau
3d2c062567 Change wallpaper depth in widget picker
- Also changed widget picker open/close duration, refactored the values into DeviceProfile
- Generalized MultiAdditivePropertyFactory to accept aggregator as parameter

Bug: 240580498
Test: manual
Change-Id: I6886ca514593e404b8d7b0e8ed44f20ec2b77c73
2022-09-13 12:20:56 +08:00
TreeHugger Robot
d0aba60767 Merge "Introduce KeyboardStateManager to maintain keyboardstate as show or hide." into tm-qpr-dev 2022-09-09 20:10:37 +00:00
Anushree Ganjam
a461660fa8 Introduce KeyboardStateManager to maintain keyboardstate as show or hide.
- Add a feature flag for IME Latency logging.

- Removed mShowImeAfterFirstLayout from ExtendedEditText.

   http://ag/1414509 added `mShowImeAfterFirstLayout`and cl description
   says "Show IME when search query != null after rotation".

   I verified the behavior by turning on "Allow home screen rotation".
   Keyboard is not getting dismissed on rotation in AA+ screen in a-z list
   or even in the search screen.
   Video : https://drive.google.com/file/d/1BWUTrW9OSEo6ojErj8INMwjFCPArVD4B/view?usp=sharing&resourcekey=0-SXTcKyUw1wCSi8Bm37ktow

Bug: 240192346
Test: Manual.

Verified by setting `ENABLE_KEYBOARD_TRANSITION_SYNC` to false and for
following usecases.

- All apps entry with ime enabled, scrolling a-z list to hide keyboard
- Folder name change - showing and dismissing keyboard
- Toast entry from Allapps and QSB - showing and dismissing keyboard

Change-Id: I1a6b5759b8e71e77744f58677b6d1b73e2f633e8
2022-09-09 04:32:33 +00:00
Schneider Victor-tulias
82e112c2a4 Merge "Enable input consumer selection reason logging and gesture navigation error detection." into tm-qpr-dev 2022-09-08 17:53:26 +00:00
Anushree Ganjam
c74ef95d50 Add a feature flag for showing Search Educard in QSB
Bug: 243680092
Test: Manual
Change-Id: I3ba1f577df2a5cfb2eb5f7acad20b47980c20916
2022-09-07 19:14:35 +00:00
Schneider Victor-tulias
119ae79e3c Enable input consumer selection reason logging and gesture navigation error detection.
Bug: 227514916
Test: ran locally, tested multiple gestures and checked logs
Change-Id: Iab0c9a21ee0141744cf82afd16ee941f2b49a9cc
2022-09-01 15:59:07 -07:00
TreeHugger Robot
a29868e30c Merge "[Toast] Add a feature flag for using app search for web zero-state." into tm-qpr-dev 2022-09-01 01:54:18 +00:00
Schneider Victor-tulias
038922a653 Add gesture nav error state tracking and logging
- Added ActiveGestureErrorDetector
- Removed startQuickstep logs; these were confusing and not helpful in ActiveGestureLogs

Test: printed logs after several gestures
Bug: 227514916
Design: go/gesture-nav-logging
Change-Id: Ia2a7e4f90a3a371d9a92190aa66eb07acd061d6c
2022-08-30 12:18:29 -07:00
Sebastian Franco
47558a6201 Adding flag to improve the icons reordering on foldables
Test: compiles
Bug: 188081026
Change-Id: Ifa30bbc9ff38f2cc0f9530f3e075b5eb662f63eb
Merged-In: Ifa30bbc9ff38f2cc0f9530f3e075b5eb662f63eb
2022-08-29 22:08:20 +00:00
Becky Qiu
edea2575e6 [Toast] Add a feature flag for using app search for web zero-state.
Bug: 241001264
Test: local
Change-Id: Id4af1664253182217014a43d8f8025f1a00da291
2022-08-26 16:41:05 -07:00
Schneider Victor-tulias
7fb96a5305 Merge changes I562abc6c,I7a48d960,I0916f969 into tm-qpr-dev
* changes:
  Update ActiveGestureLog to store n-gestures rather than n-events.
  Add input consumer selection reason to active gesture logs
  Collapse EventLogArray into ActiveGesture log.
2022-08-25 20:42:13 +00:00
Schneider Victor-tulias
24637f50c5 Add input consumer selection reason to active gesture logs
Test: manually tried gestures in 3 button and gesture nav and checked logs
Bug: 227514916
Change-Id: I7a48d960ef5a41ddee95153fa08a2345f00cbef7
2022-08-25 10:03:30 -07:00
Sunny Goyal
211496e3d8 Merge "Removing some obsolete features" into tm-qpr-dev 2022-08-22 20:27:45 +00:00
Luca Zuccarini
ee29b830b4 Merge "Set the default for keyboard sync to IS_STUDIO_BUILD." into tm-qpr-dev 2022-08-22 09:12:01 +00:00
Luca Zuccarini
78c6e3f2a4 Set the default for keyboard sync to IS_STUDIO_BUILD.
As discussed offline, I will send out an announcement in the Sysui-studio and #sysui-debug Chat Spaces to solicit bug reports.

Bug: 234812580
Test: manual
Change-Id: Id693e8ebd990b804da247d4639a2dd2d6fbdd01f
2022-08-19 19:09:15 +00:00
Grace Han
4fb9dbb9f5 Merge "Create Flag for Region Sampling in Smartspace" into tm-qpr-dev 2022-08-19 15:59:35 +00:00
Luca Zuccarini
7e02d6845e Introduce a new flag to guard keyboard synchronization.
Bug: 234812580
Test: manual
Change-Id: I1c8714fa68cde06b95f6a7822075188c7dc2f71f
2022-08-05 12:20:14 +00:00
Sunny Goyal
c5c7da9a8b Removing some obsolete features
PROMISE_APPS_NEW_INSTALLS = true
ENABLE_QUICKSTEP_WIDGET_APP_START = true
FOLDER_NAME_SUGGEST = true
ENABLE_PREDICTION_DISMISS = true
HOTSEAT_MIGRATE_TO_FOLDER = false
ENABLE_DEEP_SHORTCUT_ICON_CACHE = true
ENABLE_THEMED_ICONS = true
ENABLE_ALL_APPS_EDU = true
EXPANDED_SMARTSPACE = false

Bug: 241141733
Test: Presubmit
Change-Id: I72c0c20ab7e214994dc3c3665c90e85d45991a7a
2022-08-02 13:38:38 -07:00
Grace
170911d823 Create Flag for Region Sampling in Smartspace
This change adds a feature flag to control region sampling for
the homescreen smartspace. The flag helps developers toggle the
feature on and off during debugging.

Bug: 202758428
Test: N/A
Change-Id: I99e795408f5550b4a535ef181744f029e09c4436
2022-07-22 19:58:00 +00:00
Sunny Goyal
25972b1f2f Adding support for continously capturing view hierarcy in Launcher
Bug: 238243939
Test: Verified data being captured and dumped
Change-Id: Ibe069d39ccf728f7b953f85085e58976be6e05ac
2022-07-11 15:43:54 -07:00
Becky Qiu
da6a8fab1b [Toast] Add a feature flag to use local overrides for search timeout.
Bug: 229038631
Test: manual
Change-Id: I131ee7fc9bd7d09d7a4d4ee3f4577110ed75c0d4
2022-07-06 11:16:00 -07:00
Pinyao Ting
6c7361fb46 Merge "Cache and reuses LauncherAppWidgetHostView when launcher resumes" into tm-qpr-dev 2022-06-27 20:51:22 +00:00
Pinyao Ting
e5dbb75acd Cache and reuses LauncherAppWidgetHostView when launcher resumes
Currently by design when launcher enters the background, it stops
listening to updates in widgets. This eventually causes the dilemma
for launcher when it resumes, before the update can be returned from
the system process via IPC, launcher could do one of the following
to fill the gap:
1. show a deferred widget view -- a placeholder that renders the shape
   of the widget -- to let the user know widget is being reloaded.
2. show whichever widget view that was previously displayed to the
   user that may now contain stale content.

There is a descrepancy here since in some edge cases we are showing the
former while in most other cases we are showing the later. This CL added
a short-term fix to address the descrepancy and favors the later where
possible.

Bug: 218067434
Test: manual
Change-Id: I6cd2cd704186267227e2ec47f2581843fd526fa0
2022-06-15 13:23:31 -07:00
Brandon Dayauon
452ee1e45a ENABLE_HIDEHEADER_PRIVATE_IME
Add featureflag to have the hide header feature
Bug: 222862488
Test: Manual

Change-Id: I5e0cd0e5d40e0eb2d70e95b4981e6b2c7835cf0d
2022-06-13 14:29:17 -07:00
Andy Wickham
b17399e54c Updates keyboard option feature flag name. am: 918ba0c9f2 am: 845d34d210
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18818901

Change-Id: I0ec4213c3716e7b47ea1529e82bfbf7e1a9ae0ac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 22:07:37 +00:00
Andy Wickham
918ba0c9f2 Updates keyboard option feature flag name.
This should ignore any value previously stored for the old flag.

Fix: 235440407
Test: Manual
Change-Id: Ib0b21442443575e88153f5a13ea945bfad3fa9f0
2022-06-09 11:02:39 -07:00
Andy Wickham
36f3ed631f Merge "Enables keyboard option by default." into tm-dev am: 2d5bda75fc am: b8dd99d01e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18687151

Change-Id: I7634a2fcaf0f70ea0f91f2edc576ba78683911cf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-06 22:36:18 +00:00
Andy Wickham
9899468884 Enables keyboard option by default.
This just enables the setting for this feature. The default
value of the setting itself is still false.

Bug: 231433168
Test: Manually verified the option worked as expected, including
showing the user education when typing directly in All Apps
without tapping the QSB. Also verified previous features like
the snackbar to enable keyboard by default worked as before.

Change-Id: If423ae49436d1bf71579d52a99aea5ca3f2407dc
2022-06-02 16:51:01 -07:00
Vinit Nayak
28036435b6 Refactor TaskShortcutFactory to return List of SystemShortcuts
* Remove ENABLE_SPLIT_SELECT feature flag
* Remove unused SystemUiProxy methods

Bug: 233006032
Test: Options show up as expected
Change-Id: I9b98d962db79363a20ad41faa15404f1c156b9ec
2022-06-01 16:27:04 -07:00
Schneider Victor-tulias
766f2fc346 Coordinate the SUW All Set page first reveal with the taskbar unstash to hotseat animation.
Bug: 220096988
Test: manual
Change-Id: I1f517b322e5c18f825be8b51ebb560a4a195b666
2022-05-13 11:17:10 -07:00
Sunny Goyal
2a84e378b7 Adding feature to automatically show keyboard in all-apps
Bug: 227659010
Test: Manual
Change-Id: Id0a295d343aa895a2f672319ae1ccb3a975d41ce
2022-05-06 15:16:08 -07:00
Stefan Andonian
510a818521 Show an 'Undo' snackbar when users dismiss a predicted hotseat item.
Bug: 200841778
Test: Hard-coded the flag to be true, and verified that the snack bar
is shown with the correct text. Also verified that talkback announces
"Item Removed" properly and that the correct log event is produced by
the AppEventProducer which AiAi needs to process the user action.

Change-Id: Ifbb9cf7aecf26cd4bcebf48d4fb07fb3d5af46bb
2022-04-06 17:22:40 +00:00
Sunny Goyal
59c535bb71 Merge "Adding a feature flag to disable icon overrides" into tm-dev 2022-04-01 17:26:09 +00:00
Sunny Goyal
eeca859bc9 Adding a feature flag to disable icon overrides
Bug: 226388663
Test: Verified locally by disabling the feature
Change-Id: Icfbe790046209b15dbdc0e44dcf1a14f1f50de62
2022-03-23 15:31:38 -07:00
Luca Zuccarini
b21fd239a9 [Toast] Flip the QSB motion flag to true by default.
Bug:225749858
Test: manual with soong build as well as server build image with this
change

Change-Id: I5658bae753a7112a64fc89ae54c10c5af3a09654
2022-03-22 15:45:07 +00:00
Luca Zuccarini
24fab62d35 [OneSearch] Add a flag to guard QSB animations.
Bug: 225749858
Test: manual
Change-Id: Ib725b9bcec235d2e23cf93b2f86d0dc9cd0600cb
2022-03-21 19:00:23 +00:00
Becky Qiu
85025d248d [Avocado] Use device config for arm2 flags instead.
Bug: 224861508
Test: manual
Change-Id: Ib42ddb3808cf84ed1511754bf3f8bbcf5d100894
2022-03-15 17:13:56 -07:00
TreeHugger Robot
d21c51c932 Merge "Remove ENABLE_ONE_SEARCH" into tm-dev 2022-03-15 19:26:39 +00:00
Hyunyoung Song
aed4675433 Remove ENABLE_ONE_SEARCH
TL;DR;;
It's no longer bound to the lifecycle of application

Bug: 223750757
Bug: 221956299

Test: device_config commands

Signed-off-by: Hyunyoung Song <hyunyoungs@google.com>
Change-Id: I044bf00fe7272439d2ed4def419f91b4d786fb7a
2022-03-11 09:50:05 -08:00
Shikha Malhotra
7884332174 Top row of first workspace screen occupied only when QSB is placed at
the top.

This CL facilitates making the Feature Flag QSB_ON_FIRST_SCREEN as false
for LauncherLilyGoogle to make sure that that the top row on the first
screen is not blocked for QSB. Hinging it on BuildConfig allows it be
overwritten in LauncherLilyGoogle.

Bug: 208136186
Bug: 188511548

Test: Manually tested that top row of the first screen is not occupied
and does not clear the shortcuts after a power cycle for LauncherLilyGoogle.

Change-Id: I9113e2e2f2c0a160a2e1caf0ef3c5f86c6ec54b8
2022-03-11 13:04:55 +00:00
Hyunyoung Song
915a435f13 ENABLE_QUICK_SEARCH
Bug: 213954097
Test: video attached to the bug

Change-Id: Id46ee329df569cccaeda27574c94dbbb6d9fd41f
2022-03-05 23:29:25 -08:00
Becky Qiu
1684d7a739 [OneSearch] Arm2 - Add feature flags.
Added 2 flags to control web suggestion position and whether use fallback app results.

Bug: 213953197
Test: no test needed
Change-Id: Ia11c8bc9493fa4d61ced6982e7cac538201f1be2
2022-03-01 23:35:31 +00:00
Brian Isganitis
407403315d Add flag for One Search support in Taskbar All Apps.
Test: No
Bug: 216683257
Change-Id: I7a705827f165f60c444bb27c55cdfb6b635215d2
2022-02-28 14:33:47 -08:00
Vinit Nayak
58c27cce73 Remove Taskbar and Taskbar EDU flags.
Bug: 219035565
Change-Id: I643b5d006b5759723418901ffeb463fa04a82cbc
(cherry picked from commit ec4adc1d5a)
2022-02-23 18:14:28 +00:00
Thales Lima
0a7ff8780f Create new logic for grid migration
Fixes 217564863
Test: manual, changing grids from Wallpaper & Style and checking against spec

Change-Id: I94cf77111b37810282527f1a212b6e4126d3eba1
2022-02-23 15:20:50 +00:00
Schneider Victor-tulias
76d56ee5a1 Re-enable bulk icon loading
Bug: 195674813
Test: manual
Change-Id: I8cc02cb8648797e55a83bbb184ed2cd5088a1626
2022-02-16 12:23:34 -08:00
TreeHugger Robot
31abf9b014 Merge "Enable split from workspace / all apps" 2022-02-07 06:43:21 +00:00