Commit Graph

58436 Commits

Author SHA1 Message Date
Azhara Assanova
fc7e84a101 Merge "Add a no-op flag to mutable implicit PendingIntents" 2023-01-26 10:38:36 +00:00
Bill Yi
852466c572 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Idb35345f6f33d345118e6b77969cf1fe185a02ac
2023-01-25 23:45:40 -08:00
Brian Isganitis
49af57bad3 Capitalize Taskbar in EDU tooltip and update strings.
See https://b.corp.google.com/issues/263157739#comment14.

Test: Manual
Bug: 263157739
Change-Id: If487761a097154c9a4a7091ce88de4f707abadc9
2023-01-25 19:10:28 -08:00
Anushree Ganjam
8a8de08d5b Merge "Add logging attribute for VIDEO and SYSTEM_POINTER result type." into tm-qpr-dev am: 8653f1484c am: d8693d7b8f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21049743

Change-Id: Ieef510d8891497f4f123ab4be4a65e062943ea4e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-26 01:37:02 +00:00
Jon Miranda
77685a2c73 New taskbar threhsolds 30/100/180/300
Test: manual
Bug: 266583202
Change-Id: Iebcc70aa2305d6ce915baa7f131fb0a623040d93
2023-01-25 16:55:33 -08:00
Tony Wickham
b9ecff07e4 Fix TaskbarBackgroundRenderer not being applied correctly in 2 cases
- Rename isInAppAndNotStashed to areTaskbarIconsVisibleAndNotStashing,
  and check taskbarViewController.areIconsVisible() accordingly. This
  effectively handles the same as before, but also handles Overview,
  which is not inApp but does have areIconsVisible()
  - This fixes bubble scrim over overview taskbar, as well as showing
    taskbar background behind assistant in 3 button mode.
- Also fix nav bar button dark density changing when applying the
  separate background for assistant

Test: Open bubble and invoke assistant in overview, over IME, inside
an app, over home
Fixes: 266715337

Change-Id: Ie655de7abd1634e2165543d57664d7c7e054a986
2023-01-26 00:53:01 +00:00
Brandon Dayauon
a36f89aa8d Merge "Fix preference screen title to make folded devices the same as phone" into tm-qpr-dev am: 5809508f25
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21077875

Change-Id: Id5b1ef6fbe75a596d9aee1a53a39f83621172cee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-25 23:24:05 +00:00
Anushree Ganjam
d8693d7b8f Merge "Add logging attribute for VIDEO and SYSTEM_POINTER result type." into tm-qpr-dev am: 8653f1484c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21049743

Change-Id: Ic84bb765e4066442ae54eeba3d23413b102c7b9a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-25 23:23:42 +00:00
Andy Wickham
03fdeb7684 Move search bar background protection on top of scrollbar.
This way the search bar looks more connected to the keyboard
without the scrollbar showing next to it.

Note: Here the search bar is added on top of all other views
(previously it was inserted above only the header), and the
protection is always added just behind the search bar.

Also adjusts the height of the scrollbar to end above the search
bar when floating search bar is enabled.

Screenshots:
Scrollbar behind search bar: https://drive.google.com/file/d/10ZJ-q5nA9ZBjr7gjoauTDDAbQRUNk7S7/view?usp=share_link&resourcekey=0-pF6eOcuKz2_sCA_eZpa1Sw
New scrollbar height with floating search: https://drive.google.com/file/d/1fVIJjiG7RMme5fBXiSJmxNfOhHJ__Gwj/view?usp=share_link&resourcekey=0-b9RsB7f55U_rIZBu4IhVGQ

Fix: 265478433
Test: With and without floating search and always-on keyboard and
work profile.

Change-Id: I4f7ae0d376dae215c0cbd8deaee3e4a409d21ae4
2023-01-25 13:42:35 -08:00
Brandon Dayauon
5809508f25 Merge "Fix preference screen title to make folded devices the same as phone" into tm-qpr-dev 2023-01-25 21:38:17 +00:00
Jason Mylen
4f2d04bafe Remove competing long haptic when user long presses on widget.
Before this change removing the competing long press haptic,long
pressing to drag the widget causes a doubleclickesque haptic because
of the first haptic being quickly cancelled.

Bug: 257531349
Test: manual
Change-Id: I320339725f5ba27a22e550c28838adda94384c0f
2023-01-25 21:26:15 +00:00
Anushree Ganjam
8653f1484c Merge "Add logging attribute for VIDEO and SYSTEM_POINTER result type." into tm-qpr-dev 2023-01-25 21:25:24 +00:00
Andy Wickham
ab83443fe8 Merge "Fix header padding when search not enabled." into tm-qpr-dev am: 62ef7ba819 am: 8f7b86df53
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21074687

Change-Id: Ib49fa131add5b09a127c13b5e7915983c7cec9aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-25 20:54:52 +00:00
Andy Wickham
8f7b86df53 Merge "Fix header padding when search not enabled." into tm-qpr-dev am: 62ef7ba819
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21074687

Change-Id: Ib4b17d0ae5e3d7fe796e334526800950365260e9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-25 20:08:42 +00:00
Schneider Victor-tulias
48f3ee9e06 Update the gesture nav tutorial to use a mock transient taskbar
These are temporary UI updates until the redesigned gesture nav tutorial is ready.

Fixes: 265857697
Test: ran tutorial on large screen device
Change-Id: I3e50de1b0f5cd9e84dccea17c7ac07d3668e1168
2023-01-25 11:12:04 -08:00
Andy Wickham
62ef7ba819 Merge "Fix header padding when search not enabled." into tm-qpr-dev 2023-01-25 19:10:09 +00:00
Holly Sun
6a62176621 Move ENABLE_HIDE_GBOARD_HEADER_STATIC from feature flag to server side flag.
Bug: 266708932
Test: manual with adb command
Change-Id: Id064367ee970120cf0aa668b9c81613f7262bad8
2023-01-25 10:12:38 -08:00
Jagrut Desai
98cea8165d Add divider line into taskbar.
Test: Visual(Pics in buganizer)
Bug: 265347148
Change-Id: Ia2fbd5f0938b7eed520652573f4aca5346685429
2023-01-25 10:09:26 -08:00
Bryce Lee
05c9d551d8 Do not allow system gestures when dreaming.
Currently, TaskBar expansion is allowed when an activity context is
available. Since Dreams are implemented as an activity, this leads
to being able to expand the TaskBar over a dream. This changelist
updates the logic to not allow system gestures when dreaming.

Test: manual
Bug: 265755700
Change-Id: If58608c1e491da7906a2615681da0514fa49cfc8
Merged-In: If58608c1e491da7906a2615681da0514fa49cfc8
2023-01-25 17:15:18 +00:00
Azhara Assanova
bf0e65a6e9 Add a no-op flag to mutable implicit PendingIntents
Starting from target SDK U, we will block creation of mutable
PendingIntents with implicit Intents because attackers can mutate the
Intent object within and launch altered behavior on behalf of victim
apps. For more details on the vulnerability, see go/pendingintent-rca.

From a quick analysis, we concluded that the intents passed into
getPendingIntent() can be both explicit and implicit, so we added
a no-op FLAG_ALLOW_UNSAFE_IMPLICIT_INTENT to bypass the above block of
mutable implicit PendingIntents.

The flag is introduced in ag/21018466.

Bug: 236704164
Bug: 229362273
Test: TH passes
Change-Id: Ia26c8f92d1b4b50e04bc6b487619f54efc7d5a1d
2023-01-25 15:39:35 +00:00
Sunny Goyal
49fcae002c Merge "Merging unnecessary subclass of ActivityAllAppsContainerView" into tm-qpr-dev am: dbc5e56e07 am: 10c6b3642a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21087423

Change-Id: Idc426b3c9ae0585860402133de8542cb615bc790
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-25 08:27:39 +00:00
Tracy Zhou
fc47142fbe Merge "Revert "Swipe-up from the bar area on the home screen should pull up overview"" 2023-01-25 07:59:10 +00:00
Tracy Zhou
16938d35a9 Revert "Swipe-up from the bar area on the home screen should pull up overview"
This reverts commit c5985751c4.

Reason for revert: Confirmed with Manasi that we don't want to have a different behavior for the trackpad gesture even if it starts from the task bar area. It should be treated the same.

Change-Id: I5817c477968545e452d7600d43825209e2c75c37
2023-01-25 07:58:45 +00:00
Sunny Goyal
10c6b3642a Merge "Merging unnecessary subclass of ActivityAllAppsContainerView" into tm-qpr-dev am: dbc5e56e07
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21087423

Change-Id: I5dc1727e262b19b99770c000f0f927680b41f051
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-25 07:42:05 +00:00
Fengjiang Li
41d2aa4db3 Merge "Predictive back: widget to all apps" into tm-qpr-dev am: e73db2a011 am: c5a715f531
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20968630

Change-Id: I06791cb598cb1be27a285ae98812650fe3ceffec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-25 06:46:16 +00:00
Sunny Goyal
dbc5e56e07 Merge "Merging unnecessary subclass of ActivityAllAppsContainerView" into tm-qpr-dev 2023-01-25 06:37:15 +00:00
Fengjiang Li
c5a715f531 Merge "Predictive back: widget to all apps" into tm-qpr-dev am: e73db2a011
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20968630

Change-Id: I8b4fb27d441dc449873bfe95ef40a047805bf3d4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-25 05:59:56 +00:00
Fengjiang Li
e73db2a011 Merge "Predictive back: widget to all apps" into tm-qpr-dev 2023-01-25 05:26:49 +00:00
Anushree Ganjam
7cbfdd4f06 Add logging attribute for VIDEO and SYSTEM_POINTER result type.
Bug: 266631411
Test: Manual
Change-Id: Ic2819c6c2a74a2e4bf46fb78448f3723ddfe933e
2023-01-25 02:16:35 +00:00
Bryce Lee
fdd410dec7 Merge "Do not allow system gestures when dreaming." 2023-01-25 00:19:16 +00:00
Evan Rosky
1d2abb366d Merge "Revert^8 "Enable Shell Transitions"" 2023-01-25 00:08:16 +00:00
Fengjiang Li
6bb8d79549 Predictive back: widget to all apps
This CL adds a layer of OnBackPressedHanlderRouter to Launcher:
1. 4 OnBackPressedHandler(s) are added in such order: auto cancel action mode handler, drag handler, view handler and state handler
2. first handler who can handle back will handle the entire back gesture
3. Let WidgetsFullSheet to handle widget to all apps transition

Bug: b/260956481
Test: manual
Change-Id: Idbce3dcec746226dd68aaabaddc8fe01334e9673
2023-01-24 15:51:46 -08:00
Sebastián Franco
1b3d1cfa64 Merge "Adding the avility to add icons on multiple CellLayouts on tests." into tm-qpr-dev am: 68f5667338 am: 56f91702d2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20890013

Change-Id: I3b9bad730707d9e5dca8f10acdb43991cd51c290
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 23:11:45 +00:00
Sebastián Franco
56f91702d2 Merge "Adding the avility to add icons on multiple CellLayouts on tests." into tm-qpr-dev am: 68f5667338
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20890013

Change-Id: I83d66d694897da0463e93bfc740fc48e99428a8c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 21:13:11 +00:00
Sunny Goyal
34c499dc84 Merging unnecessary subclass of ActivityAllAppsContainerView
Bug: 266605714
Test: Presubmit
Change-Id: I87272ee827055f58f91a4ad9fb25d5351d453cdb
2023-01-24 13:01:00 -08:00
Sebastián Franco
68f5667338 Merge "Adding the avility to add icons on multiple CellLayouts on tests." into tm-qpr-dev 2023-01-24 20:02:35 +00:00
Schneider Victor-tulias
cd09b276c5 Merge "Revert^2 "Cancel gestures on launcher destroy"" into tm-qpr-dev am: 74484f4a99 am: 86fbe3c7ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20680308

Change-Id: I8c6e5b7431631ce5577dc6ba8435d607fc3bc883
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 19:32:52 +00:00
Brandon Dayauon
e530801f44 Fix preference screen title to make folded devices the same as phone
Now it says "Search your Phone" on folded devices instead of
"Search your tablet" when unfolded

bug: 265610885
test: Manually - on foldables and tablets
Change-Id: I39ee08539b70b2e7258bca86b1450c62c75f748f
2023-01-24 11:10:15 -08:00
Schneider Victor-tulias
86fbe3c7ea Merge "Revert^2 "Cancel gestures on launcher destroy"" into tm-qpr-dev am: 74484f4a99
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20680308

Change-Id: I53c04f6c97087528d18af02e7f8f3842851f9dc0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 18:24:01 +00:00
Alex Chau
a4dbf074f5 Merge "Destroy taskbar if it's not present in DeviceProfile" into tm-qpr-dev am: 1103195e42 am: a06576bc36
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21060664

Change-Id: Ic7baad6b4dea7d231ba7635ffebdfd3815526a84
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 18:06:22 +00:00
Stefan Andonian
c57c22acc7 Merge "Fix crash in LauncherPreviewRenderer." into tm-qpr-dev am: 74471716ca am: 329a47dd8f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21074684

Change-Id: I00a0a9c4b67f23affafe40c9bfd151bf95d921f7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 18:06:12 +00:00
Alex Chau
a6fcdc88a7 Merge "Revert "Add logs to track app grid changes"" into tm-qpr-dev am: d2e4906230 am: 4be46f4e6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21082383

Change-Id: I5ade2efa762011d4c36b8798da645d448d8834eb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 18:06:02 +00:00
Ats Jenk
0cba2dc700 Merge "Fix flicker when opening transient taskbar" into tm-qpr-dev am: 5858226f02 am: 0800534b21
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21077864

Change-Id: I9b2a1a299e58cdef39229e4eeb872d04c1db253b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 18:04:01 +00:00
Schneider Victor-tulias
74484f4a99 Merge "Revert^2 "Cancel gestures on launcher destroy"" into tm-qpr-dev 2023-01-24 17:55:54 +00:00
Alex Chau
a06576bc36 Merge "Destroy taskbar if it's not present in DeviceProfile" into tm-qpr-dev am: 1103195e42
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21060664

Change-Id: I35f6f8a8773a60e358bf68bbcb7b93d7467d03c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 17:38:51 +00:00
Stefan Andonian
329a47dd8f Merge "Fix crash in LauncherPreviewRenderer." into tm-qpr-dev am: 74471716ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21074684

Change-Id: I32647f81ae33e7e545bfe4645033faa91c6c19bf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 17:38:38 +00:00
Alex Chau
4be46f4e6a Merge "Revert "Add logs to track app grid changes"" into tm-qpr-dev am: d2e4906230
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21082383

Change-Id: If6195d0f1fed6d37e2fbd9190a8239b053f59413
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 17:38:25 +00:00
Ats Jenk
0800534b21 Merge "Fix flicker when opening transient taskbar" into tm-qpr-dev am: 5858226f02
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21077864

Change-Id: I3a8676ce00fce6e1859600045aeec447f6a7a55e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 17:38:10 +00:00
Alex Chau
1103195e42 Merge "Destroy taskbar if it's not present in DeviceProfile" into tm-qpr-dev 2023-01-24 17:35:37 +00:00
Stefan Andonian
74471716ca Merge "Fix crash in LauncherPreviewRenderer." into tm-qpr-dev 2023-01-24 17:35:27 +00:00