aixan/lawnchair
1
0
Fork 0
mirror of https://github.com/LawnchairLauncher/lawnchair.git synced 2026-03-02 17:06:49 +00:00
Code Issues Packages Projects Releases Wiki Activity
58,436 Commits 36 Branches 1,370 Tags
67fa00189dcafe5df7ebc08c3dd1e6ccc2a7e276
Commit Graph

13651 Commits

Author SHA1 Message Date
Nicolo' Mazzucato
696238e086 Provide single threaded executor to UnfoldUnfoldTransitionFactory 
This fixes a concurrency issue where HingeSensorAngleProvider was being stopped and started at the same time in a thread-pool after a fast fold/unfold, despite not providing concurrency guarantees.

In sysui, the background executor provided was already single threaded, so no issue arisen. From Launcher, THREAD_POOL_EXECUTOR was provided.

In a follow up cl, I'll add a @SingleThreadBackground annotation to the executor used in the unfold lib.

Bug: 261320823
Test: manually stress tested fold/unfold.
Change-Id: Iccf1f1f7246d8592d4d80a032479aa75f0050655
 2023-01-12 09:19:48 +00:00
Johannes Gallmann
031fbcc564 Prevent workspace enter animation for predictive back 
Bug: 263913711
Test: Manual, i.e. testing predictive back for four scenarios: Back to all apps, Back to home. Both with the closed app icon visible or not.
Change-Id: Id87686098e6ad413819dc75545071da00291db65
 2023-01-12 10:06:18 +01:00
Tracy Zhou
6fb8b3cec4 Update onOverviewShown interface to get signal of whether it should be 
iterated in forward or backward direction

For more information, check out the change in the same topic.

Bug: 258854035
Test: manual
Change-Id: Id4a201c1979645ec319478f634039a4e9e495a35
 2023-01-12 07:17:58 +00:00
Vinit Nayak
1d7e050bc6 Respect nav button tinting in SUW 
* Check was originally added with rationale in
b/204384193#comment26, however presently we
do provide insets to SUW as of b/253538830
so looks like now we are getting the correct
info from SysUI
* There is a possibly related issue where buttons
are not tinted correctly on the final page of
SUW (b/265238238)

Test: Went through setup manually via adb
and observed that on light theme with dark
dialog scrim the button changes color
adb shell am start -a android.intent.action.MAIN -n com.google.android.setupwizard/.SetupWizardTestActivity
Bug: 256521774

Change-Id: I080033e21d22fbc366b7248b2d647fec610a5fb9
 2023-01-11 21:29:37 -08:00
Christophe Pinelli
9d46bca1b9 Make mutable PendingIntent explicit 
Starting from target SDK U, we will block creation of mutable
PendingIntents with implicit Intents because attackers can mutate the
Intent object within and launch altered behavior on behalf of victim
apps. For more details on the vulnerability, see go/pendingintent-rca.

From a quick analysis, we concluded that the PendingIntent here was only
destined to the test app/to the app, so it was made explicit. Reviewers,
please call out if this is not the case.

Bug: 236704164
Test: atest NexusLauncherTests:com.android.quickstep.DigitalWellBeingToastTest
Test: atest RequestPinItemTest
Change-Id: I81311b0588b7b712c97de6cb016a62bb91c7a77c
 2023-01-12 01:51:44 +00:00
Shan Huang
6677aeab1d Merge "Add background protection for back to home animation." 2023-01-12 01:03:49 +00:00
Stefan Andonian
53b21fae3b Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev am: fb602d4db7 am: 167d350981 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20878611

Change-Id: I7591e1af8af6bcd6b11dea1571668d80ada06201
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-11 23:57:55 +00:00
Stefan Andonian
167d350981 Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev am: fb602d4db7 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20878611

Change-Id: I16987862cffc3730518fe14adf61595d62b8faad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-11 23:11:16 +00:00
Fengjiang Li
e884c2c79f Support predictive back from all apps to home 
bug: b/238475505
Test: manual

Change-Id: Ibf4f7f41a26b044a538e2cd566d2297ed88f1b99
 2023-01-11 22:55:28 +00:00
Stefan Andonian
fb602d4db7 Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev 2023-01-11 22:46:31 +00:00
Tracy Zhou
f1963f7e86 Merge "Swipe-up from the bar area on the home screen should pull up overview" 2023-01-11 22:06:58 +00:00
Shan Huang
a0fb0bf717 Add background protection for back to home animation. 
Bug: 238475118
Test: Swipe back on Settings in light theme. Switch to dark theme and
try again. Make sure scrim looks nice in both cases.

Change-Id: Ic099d7b8e84a04105712f13c94d0c6f82863e844
 2023-01-11 13:57:33 -08:00
Jagrut Desai
cc96cf3345 Adding margin height for transient taskbar to allow users to stash taskbar from full height. am: 50f1e8dfc2 am: 9ef3dff40d 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20903089

Change-Id: Ic564353b9e1b992d0647dcafdfbbb91d07094fbc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-11 20:06:02 +00:00
Stefan Andonian
2a58ddb89f Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and 
into its own class.

Bug: 251502424
Test: Compilation threw no errors and user unlock behavior worked
correctly.

Change-Id: Ifa42dc32f90dfa4fda8df0e52811ddfe20cc5a9b
 2023-01-11 19:33:32 +00:00
Jagrut Desai
9ef3dff40d Adding margin height for transient taskbar to allow users to stash taskbar from full height. am: 50f1e8dfc2 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20903089

Change-Id: I886944c8f9a8ad2083cd84f2cc29cf9c41497b75
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-11 19:09:20 +00:00
Miranda Kephart
aaa77b8035 Update ImageActionUtils to construct a ScreenshotRequest 
Bug: 264457397
Test: atest
Merged-In: Ib629f5d9eed2091f2bc4c1082d5e0dd3d2f9176b
Change-Id: Ib629f5d9eed2091f2bc4c1082d5e0dd3d2f9176b
 2023-01-11 12:44:07 -05:00
Alex Chau
7351218fab Update overview actions top margin 
Bug: 260596114
Test: manual
Change-Id: Ic5f51a8d0505571272e5ad03bd16db2b903fd697
 2023-01-11 15:41:52 +00:00
Sebastian Franco
a955403ba9 Change the access of cellX/Y of CellLayoutLayoutParams to private 
Cherry pick needed for changes on workspace lily

Bug: 188081026
Test: no op change, should compile
Test: ReorderWidgets
Change-Id: I20367974e5a4cead406e18eb66dafd4d59651b2a
 2023-01-11 15:25:23 +00:00
Tony Huang
f1a43efa0b Merge "Fix divider visibility issue on transient taskbar" into tm-qpr-dev am: d058f55578 am: 9898e5cc44 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20747781

Change-Id: I9e780abb3987bf8c40f24fafb5f906ff659ddee8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-11 04:58:05 +00:00
Tony Huang
9898e5cc44 Merge "Fix divider visibility issue on transient taskbar" into tm-qpr-dev am: d058f55578 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20747781

Change-Id: Ifbd4ea9766123d4c5943f0ea75600416a6b39312
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-11 04:17:34 +00:00
Jagrut Desai
50f1e8dfc2 Adding margin height for transient taskbar to allow users to stash taskbar from full height. 
Test: visual(video in buganizer)
Fix: 263526574
Change-Id: I21fd1273b83a4e5efdf7aeacae1303513b9b4d97
 2023-01-11 04:16:07 +00:00
Tony Huang
d058f55578 Merge "Fix divider visibility issue on transient taskbar" into tm-qpr-dev 2023-01-11 03:45:14 +00:00
Jagrut Desai
036e99d048 Merge "Checking can start system gesture before creation of TaskbarStashInputConsumer, so that taskbar does not show up when user performs swipe up from lock screen or notification panel." into tm-qpr-dev am: 4aac33824d am: dc70ea4d65 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20861033

Change-Id: I9be46c3a5bfa91dc707bb2257f205fa6976db0d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-11 00:02:47 +00:00
Jeremy Sim
5f8dd20236 Fix transition animations for launch-from-staged operation 
This change makes it so that a smoother animation will play when the user cancels the splitscreen flow by tapping the staged app to launch the app in fullscreen. Since this was the only blocker to activating the feature, this change also enables launch-from-staged by default and removes the flag.

Fixes: 257513449
Test: Manual
Change-Id: Iabff2fc72bfcd6975d216b5cd86e0df7a772b308
 2023-01-10 15:44:23 -08:00
Jagrut Desai
dc70ea4d65 Merge "Checking can start system gesture before creation of TaskbarStashInputConsumer, so that taskbar does not show up when user performs swipe up from lock screen or notification panel." into tm-qpr-dev am: 4aac33824d 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20861033

Change-Id: I2b508ca826aa1eda8443a51bdf166871019e591c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-10 23:25:59 +00:00
Jagrut Desai
4aac33824d Merge "Checking can start system gesture before creation of TaskbarStashInputConsumer, so that taskbar does not show up when user performs swipe up from lock screen or notification panel." into tm-qpr-dev 2023-01-10 22:58:30 +00:00
Jagrut Desai
ef35e84d19 Checking can start system gesture before creation of TaskbarStashInputConsumer, so that taskbar does not show up when user performs swipe up from lock screen or notification panel. 
Test: visual(video in buganizer)

Fix:261524189, 262589756

Change-Id: I5252281025953753f9184f1b19c534513b5800fa
 2023-01-10 22:57:35 +00:00
Ats Jenk
774f05226b Hide DesktopTaskView background while animating 
While animating DesktopTaskView to/from fullscreen, hide the background.
Background should only show up when this taskview is shown in recents.
While it is animating, we don't need to show it.

Bug: 263264985
Test: manual, trigger transient taskbar, observe that background does
not flicker

Change-Id: I76d0eb1857645b7f04a0b2e1eebe2393c252c257
 2023-01-10 11:39:17 -08:00
Alex Chau
927a806dff Merge "Add debug logs for hotseat disapperaed bug" into tm-qpr-dev am: 616de308b7 am: a2a374bdab 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20883271

Change-Id: I7f448f3b0d0d610da80e7d1ffc66d408913f3ba6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-10 19:24:32 +00:00
Ats Jenk
bc02226647 Merge "Fixes to support transient taskbar in desktop mode" into tm-qpr-dev am: 83a8dad319 am: 6fe43056f6 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20858638

Change-Id: I6ec86947efa15a4d9f148db30124183f771040cf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-10 19:19:46 +00:00
Alex Chau
a2a374bdab Merge "Add debug logs for hotseat disapperaed bug" into tm-qpr-dev am: 616de308b7 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20883271

Change-Id: I0c820b11d56c43167034ff840ddb76e521f7a05a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-10 18:44:57 +00:00
Alex Chau
616de308b7 Merge "Add debug logs for hotseat disapperaed bug" into tm-qpr-dev 2023-01-10 18:34:08 +00:00
Ats Jenk
6fe43056f6 Merge "Fixes to support transient taskbar in desktop mode" into tm-qpr-dev am: 83a8dad319 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20858638

Change-Id: Ib2e57c5d0e5e13846e240c36c9396588326c19a5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-10 18:30:06 +00:00
Ats Jenk
83a8dad319 Merge "Fixes to support transient taskbar in desktop mode" into tm-qpr-dev 2023-01-10 18:09:16 +00:00
Shan Huang
7c2791e9d0 DO NOT MERGE Rename BackEvent to BackMotionEvent in LauncherBackAnimationController. am: 81f7d0bbf5 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20841553

Change-Id: I46ca2de98ffac0aaca33fd98ff3180d0b7efe5ff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-10 17:20:53 +00:00
Thales Lima
3241b26430 Merge "Check kotlin format before uploading" into tm-qpr-dev am: bdfc07f1f0 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20883265

Change-Id: I1f211915948bd6112d605dbd6d2a6569838c1585
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-10 17:20:23 +00:00
Luca Zuccarini
fb4429f0b0 Revert^2 "Update timings for the Home <> All Apps transition." 
e18ac479e5

Change-Id: Id09987b2c67be70e62349574973d4bc62b10bc9d
Bug: 263221786
 2023-01-10 17:05:29 +00:00
Shan Huang
f43527d5df Merge "DO NOT MERGE Rename BackEvent to BackMotionEvent in LauncherBackAnimationController." into tm-qpr-dev 2023-01-10 16:46:55 +00:00
Thales Lima
bdfc07f1f0 Merge "Check kotlin format before uploading" into tm-qpr-dev 2023-01-10 16:41:58 +00:00
Luca Zuccarini
bbcd92caab Merge "Make LauncherAnimationRunner compatible with RemoteAnimationRunner." into tm-qpr-dev am: d23cd42875 am: 2192689237 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20836635

Change-Id: Ic5f8ccc13e5ec0907dd50dac344a8ce55cef8c5e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-10 14:48:40 +00:00
Luca Zuccarini
2192689237 Merge "Make LauncherAnimationRunner compatible with RemoteAnimationRunner." into tm-qpr-dev am: d23cd42875 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20836635

Change-Id: I8ce7a076dc78912445c56a2d39369ad611631e5d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-10 14:12:02 +00:00
Luca Zuccarini
d23cd42875 Merge "Make LauncherAnimationRunner compatible with RemoteAnimationRunner." into tm-qpr-dev 2023-01-10 13:50:50 +00:00
Thales Lima
03ac377a34 Check kotlin format before uploading 
This uses ktfmt on the PREUPLOAD hook to check file formatting.

Bug: 264851618
Test: manual
Change-Id: I8bdeabd9c1ed571a464707e6912419ad3190a169
Merged-In: I8bdeabd9c1ed571a464707e6912419ad3190a169
 2023-01-10 13:24:43 +00:00
Thales Lima
47a40a8bd3 Merge "Check kotlin format before uploading" 2023-01-10 13:23:59 +00:00
Thales Lima
7a3c1e10a7 Check kotlin format before uploading 
This uses ktfmt on the PREUPLOAD hook to check file formatting.

Bug: 264851618
Test: manual
Change-Id: I8bdeabd9c1ed571a464707e6912419ad3190a169
 2023-01-09 17:45:42 +00:00
Jagrut Desai
aca834d085 Merge "Moving Accessibility Annoucement to Task Closed to onEnd animation callback. Test: Manual Fix: 220198279" into tm-qpr-dev am: d8ea04a7f6 am: f0c9360153 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20872232

Change-Id: I949caad9acf9aa55ac8929be42fcb0d7cfac1136
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-09 17:27:17 +00:00
Jagrut Desai
f0c9360153 Merge "Moving Accessibility Annoucement to Task Closed to onEnd animation callback. Test: Manual Fix: 220198279" into tm-qpr-dev am: d8ea04a7f6 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20872232

Change-Id: Ic9f5a0e372b041c9e57121677fc3b9b387e897cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-09 16:51:27 +00:00
Jagrut Desai
d8ea04a7f6 Merge "Moving Accessibility Annoucement to Task Closed to onEnd animation callback. Test: Manual Fix: 220198279" into tm-qpr-dev 2023-01-09 16:19:04 +00:00
Alex Chau
04658bcd42 Add debug logs for hotseat disapperaed bug 
Bug: 260135164
Test: manual
Change-Id: Ic911ba0353b742feb753024543ca19930f11b47d
 2023-01-09 12:43:16 +00:00
Bill Yi
e6bc4f394d Import translations. DO NOT MERGE ANYWHERE 
Auto-generated-cl: translation import
Change-Id: Ia2a7ae96952c7ae4eb491671c7cfe0b0511a518d
 2023-01-08 03:45:38 -08:00