Commit Graph

13651 Commits

Author SHA1 Message Date
Nicolo' Mazzucato
9d4b775b1d Add CUJ_RECENTS_SCROLLING
This adds Jank instrumentation every time recent tasks are scrolled.

Bug: 231130484
Bug: 228969045
Test: recorded prefetto trace while scrolling
Change-Id: I3904257ef60a4e09c91a0d5297beadad0bce8785
2022-10-19 14:25:10 +00:00
Thales Lima
994b181676 Merge "Remove KtR workaround" into tm-qpr-dev 2022-10-19 14:04:48 +00:00
TreeHugger Robot
c9928a1ddf Merge "Implement overlay window for Taskbar EDU and All Apps." into tm-qpr-dev 2022-10-19 14:01:56 +00:00
Pat Manning
ded9a7485e Merge "Add launcher metrics for tracking kids nav mode change events." into tm-qpr-dev 2022-10-19 13:36:56 +00:00
Thales Lima
c863b90571 Merge "Convert make to bp" into tm-qpr-dev 2022-10-19 13:35:18 +00:00
Riddle Hsu
053f5910cb Attempt to reduce flakiness of testDisableRotationCheckForPhone
The request setOrientationLeft() is async that puts the target
rotation to setting. So the actual display rotation change may
happen when executing goHome(). Then the swipe gesture may be
interrupted that causes the test to fail.

Add a condition to wait for leaving natural orientation change
before calling goHome(). Also reorder and simplify the way to
start test activity to reduce execution time.

Bug: 253290379
Test: TaplTestsQuickstep#testDisableRotationCheckForPhone
Change-Id: I881d6f666c98fd3fe601b874adb0d14122bff2b7
2022-10-19 20:51:12 +08:00
Alex Chau
f643a9b683 Fix STATE_DEPTH stuck at 1 after setting wallpaper am: 950a10738b am: 7b815365ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19967480

Change-Id: I1751b4a746d91ad6a4206114437b483b9b14d4a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 10:50:51 +00:00
Alex Chau
7b815365ea Fix STATE_DEPTH stuck at 1 after setting wallpaper am: 950a10738b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19967480

Change-Id: I00d40ac79fd33db656ae72fe492964cc1e46f8c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 10:01:18 +00:00
Alex Chau
8dac89d235 Merge changes from topic "widget_blur" into tm-qpr-dev
* changes:
  Enable wallpaper blur for widget picker
  Fix STATE_DEPTH stuck at 1 after setting wallpaper
2022-10-19 09:37:39 +00:00
TreeHugger Robot
c589595b0a Merge "Fix missing screenshots on rotate from recents view select state" into tm-qpr-dev am: a473ff6c23 am: a3bd0797e6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20196922

Change-Id: Ie42d2366d6f248d223fe8c52c425adea66cbe4b6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 07:52:39 +00:00
TreeHugger Robot
a3bd0797e6 Merge "Fix missing screenshots on rotate from recents view select state" into tm-qpr-dev am: a473ff6c23
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20196922

Change-Id: I2f846705d8d248993b1323783c63fef9f3bdf365
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 07:02:34 +00:00
TreeHugger Robot
a473ff6c23 Merge "Fix missing screenshots on rotate from recents view select state" into tm-qpr-dev 2022-10-19 03:48:11 +00:00
Holly Sun
dbd01bf6f9 Log a-z apps count.
Test: manual
Bug: 247432075
Change-Id: I9538a75bc3cb3d1e8e9089fc5e27d5d770cafb62
2022-10-18 15:57:53 -07:00
Vinit Nayak
18378f5ea6 Merge "Prevent restoring split selection state for fallback overview" into tm-qpr-dev am: 44e788a9d3 am: 4ce144eaa7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20217203

Change-Id: Ia2729d7afc11a0e3378678079bae6f661d71b675
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-18 20:16:46 +00:00
Vinit Nayak
4ce144eaa7 Merge "Prevent restoring split selection state for fallback overview" into tm-qpr-dev am: 44e788a9d3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20217203

Change-Id: Ic6df3639b6f34b17380980dfad46d7af5243e7ed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-18 19:43:22 +00:00
Vinit Nayak
44e788a9d3 Merge "Prevent restoring split selection state for fallback overview" into tm-qpr-dev 2022-10-18 18:50:19 +00:00
Sunny Goyal
dd11f089cc Revert "Revert "Using Transaction directly instead of building s..."
Revert^2 "Removing unused surface transaction wrappers"

2460910c8c454bc2d3c9ae35bd32eeb590851788

Bug: 221961069
Test: Presubmit
Change-Id: I0028c9fe0de6fde6a77de84e4858fda14cd578dd
2022-10-18 16:30:26 +00:00
Alex Chau
950a10738b Fix STATE_DEPTH stuck at 1 after setting wallpaper
- Made BaseDepthController.setDepth/mDepth private, all get/set should be done through STATE_DEPTH or WIDGET_DEPTH
- Generified ClampedDepthProperty into Utilities.ClampedProperty to apply on STATE_DEPTH

Bug: 240580498
Test: Go to walppaper&style, set new wallpaper, then go to widget picker, wallpaper depth should transition smoothly
Change-Id: I53cdedf970fd7ffba6a952c4edf4b34251b01f07
2022-10-18 17:07:17 +01:00
Thales Lima
e9d4044483 Remove KtR workaround
Bug: 229947409
Test: m -j128 Launcher3QuickStep Launcher3QuickStepGo Launcher3 Launcher3Go NexusLauncherRelease NexusLauncherDebug SearchLauncherQuickStep SearchLauncher LauncherGoGoogle
Change-Id: I5792cc6b30dfa856747a1576ef3cb195952c25c7
(cherry picked from commit 51e164688e)
Merged-In: I5792cc6b30dfa856747a1576ef3cb195952c25c7
2022-10-18 13:06:23 +00:00
Thales Lima
2c54bbfdfc Convert make to bp
Fix: 229946262
Test: build all launchers and run atest
Change-Id: Ie9b66ba0d83aa0c3c476dd30853ef52279c9619e
(cherry picked from commit 42f15f9b81)
Merged-In: Ie9b66ba0d83aa0c3c476dd30853ef52279c9619e
2022-10-18 10:02:43 +00:00
Vinit Nayak
392f8878cd Prevent restoring split selection state for fallback overview
* Add flag to explicitly not restore
OVERVIEW_SPLIT_SELECT
* FallbackRecentsView then resets state in
RecentsView if our endState is ever not split selection

Fixes: 253178217
Test: Used launcher developer option to
force use separate recents activity. Tested w/
3 button nav + gesture.

Change-Id: I26c9994bf853e9a005300a02aa143991958fc461
2022-10-17 17:52:16 -07:00
Bill Yi
7cd2b068a4 Merge "Import translations. DO NOT MERGE ANYWHERE" 2022-10-17 23:32:59 +00:00
Vinit Nayak
8c633ed07b Merge "Landscape 3 button nav on taskbar phone supported" into tm-qpr-dev am: 90eff11fee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19541300

Change-Id: I79fceefa8267fc487d0dafaaebf69e94eddc07b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-17 22:52:40 +00:00
Vinit Nayak
d6c5147524 Landscape 3 button nav on taskbar phone supported
* TODO: Seascape bar positioning, add tests

Change-Id: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
Merged-In: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
2022-10-17 13:59:18 -07:00
Vinit Nayak
391b79c084 Merge "Landscape 3 button nav on taskbar phone supported" 2022-10-17 20:14:36 +00:00
Schneider Victor-tulias
e738336001 Fix missing screenshots on rotate from recents view select state
Rotating while in the recents view select state causes all taskview screenshots to disappear. Removing the transition to overview also fixes this, but leaves launcher in an incorrect state.

- Updated API to allow transitioning states without animation.
- Removed the animation to update the state correctly while keeping the ui working.

Fixes: 251067808
Test: rotated back and forth on large and small devices, before and after entering select mode
Change-Id: I5bf89ceb1f6b27cde9f7638f32fee3a78ad85ff6
2022-10-17 09:56:03 -07:00
Pat Manning
5889bc3729 Add launcher metrics for tracking kids nav mode change events.
Fix: 241762670
Test: wwdebug && wwlogcat
Change-Id: I24432f2cd0dddbcc5991645b60a1a8e91dc431e5
2022-10-17 14:06:38 +01:00
Cole Faust
50ec4afe25 Fix errorprone warnings that should be errors
This commit is part of a large scale change to fix errorprone
errors that have been downgraded to warnings in the android
source tree, so that they can be promoted to errors again.
The full list of changes include the following, but not all
will be present in any one individual commit:

BadAnnotationImplementation
BadShiftAmount
BanJNDI
BoxedPrimitiveEquality
ComparableType
ComplexBooleanConstant
CollectionToArraySafeParameter
ConditionalExpressionNumericPromotion
DangerousLiteralNull
DoubleBraceInitialization
DurationFrom
DurationTemporalUnit
EmptyTopLevelDeclaration
EqualsNull
EqualsReference
FormatString
FromTemporalAccessor
GetClassOnAnnotation
GetClassOnClass
HashtableContains
IdentityBinaryExpression
IdentityHashMapBoxing
InstantTemporalUnit
InvalidTimeZoneID
InvalidZoneId
IsInstanceIncompatibleType
JUnitParameterMethodNotFound
LockOnBoxedPrimitive
MathRoundIntLong
MislabeledAndroidString
MisusedDayOfYear
MissingSuperCall
MisusedWeekYear
ModifyingCollectionWithItself
NoCanIgnoreReturnValueOnClasses
NonRuntimeAnnotation
NullableOnContainingClass
NullTernary
OverridesJavaxInjectableMethod
ParcelableCreator
PeriodFrom
PreconditionsInvalidPlaceholder
ProtoBuilderReturnValueIgnored
ProtoFieldNullComparison
RandomModInteger
RectIntersectReturnValueIgnored
ReturnValueIgnored
SelfAssignment
SelfComparison
SelfEquals
SizeGreaterThanOrEqualsZero
StringBuilderInitWithChar
TreeToString
TryFailThrowable
UnnecessaryCheckNotNull
UnusedCollectionModifiedInPlace
XorPower

See https://errorprone.info/bugpatterns for more
information on the checks.

Bug: 253827323
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: If17d2944bfd3e7ab10592a4c74c956203c356f81
2022-10-16 13:35:16 -07:00
Bill Yi
587fe3fa49 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie26e4bfb684515d47461f2e13f19f551ace639cc
2022-10-15 09:48:50 -07:00
Bill Yi
74d23adb42 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I16b068b4fd1d9ad099ae0b7d9c1cb1dfed4c2d9d
2022-10-15 09:48:21 -07:00
Brian Isganitis
2d6371aa34 Implement overlay window for Taskbar EDU and All Apps.
Having EDU in the same window as Taskbar causes it to be above All Apps
and other system views such as the notification tray. This change
refactors the existing All Apps window to accomodate more AFVs so that
EDU can also exist in it.

Demo: http://shortn/_Qcki3gwvf7

Test: Manual
Fix: 232177330
Change-Id: I1bef31d798041a90a0c3e033e71be63898fa5fbc
2022-10-14 22:36:14 +00:00
Sebastián Franco
8f357c149e Merge "Moving the class LayoutParams to a file outside CellLayout" into tm-qpr-dev am: 73b8ee9390 am: 5e8c248e1f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20122918

Change-Id: I51de393340bf6fa5537a145a71ec9d46d4e2beff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 21:46:41 +00:00
Sebastián Franco
5e8c248e1f Merge "Moving the class LayoutParams to a file outside CellLayout" into tm-qpr-dev am: 73b8ee9390
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20122918

Change-Id: Id29fb15737ee63e64c3c3e484872c688cbb2f097
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 21:15:45 +00:00
Sebastián Franco
73b8ee9390 Merge "Moving the class LayoutParams to a file outside CellLayout" into tm-qpr-dev 2022-10-14 20:43:34 +00:00
TreeHugger Robot
77041294ee Merge "Add launcher metrics for tracking kids nav mode change events." into tm-qpr-dev am: 6ccf536f94 am: 22b6d5112b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20164543

Change-Id: I37a6bdf3a792e1861d1e57b5f8b41fa3178a6885
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 19:49:27 +00:00
TreeHugger Robot
22b6d5112b Merge "Add launcher metrics for tracking kids nav mode change events." into tm-qpr-dev am: 6ccf536f94
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20164543

Change-Id: Iaec5bbd931e45ed5ae478ef8f5e91841e0b9c093
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 19:17:36 +00:00
TreeHugger Robot
6ccf536f94 Merge "Add launcher metrics for tracking kids nav mode change events." into tm-qpr-dev 2022-10-14 18:42:05 +00:00
Zim
83776629df Disable Launcher AIDL_TAG tracing special case
Since we enable generate_traces by default for the system and
signature apps, we can remove this special case

Test: Manual
Bug: 161393989
Change-Id: Iff92c0a729a9b9b038fb6310c7509925c59547b6
Merged-In: Iff92c0a729a9b9b038fb6310c7509925c59547b6
2022-10-14 19:28:50 +01:00
Alex Chau
47a07bc704 Decouple taskbar background from overveiw scrim if taskbar is in overview
- Removed all forceHideBackground calls if taskbar would be in overview
- Make overview scrim transparent regardless of stash state if taskbar would be in overview

Fix: 234139692
Test: Go to overview from app with ENABLE_TASKBAR_IN_OVERVIEW on/off and taskbar stashed/unstashed
Change-Id: I29e811cb93894e6c9e7a75c0ea493719f15eeccb
2022-10-14 17:45:41 +01:00
Pat Manning
31cf44c48c Add launcher metrics for tracking kids nav mode change events.
Bug: 241762670
Test: wwdebug && wwlogcat
Change-Id: I5bf05ce1660078951896e0e331bbe74f8f2ebc5f
2022-10-14 16:24:32 +00:00
TreeHugger Robot
3b13487a07 Merge "Update taskbar state when launcher pauses" into tm-qpr-dev am: a1734ad12e am: 8d7387042f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20192617

Change-Id: I2f777edae7bf0c81b3eed62ba391a8f6d863fd02
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 04:27:21 +00:00
TreeHugger Robot
8d7387042f Merge "Update taskbar state when launcher pauses" into tm-qpr-dev am: a1734ad12e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20192617

Change-Id: I290ffa98e5c6c6458983413430bf236c16abf3a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 03:55:26 +00:00
TreeHugger Robot
a1734ad12e Merge "Update taskbar state when launcher pauses" into tm-qpr-dev 2022-10-14 03:23:40 +00:00
Alex Chau
632e69b801 Merge "Run setCurrentPage in applyLoadPlan after scroll initialized" into tm-qpr-dev am: 41ab3f3e14 am: d8465a72cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20139153

Change-Id: I50ed52d8dca4108e57b6ed964e26da28227073d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 01:40:32 +00:00
Alex Chau
d8465a72cd Merge "Run setCurrentPage in applyLoadPlan after scroll initialized" into tm-qpr-dev am: 41ab3f3e14
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20139153

Change-Id: I8f5163a7cf28f9a49b3d4e1dbd3e0777a96448d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 01:07:56 +00:00
Alex Chau
41ab3f3e14 Merge "Run setCurrentPage in applyLoadPlan after scroll initialized" into tm-qpr-dev 2022-10-14 00:31:32 +00:00
Evan Rosky
14145d131a Update taskbar state when launcher pauses
With shell-transit, we need to defer updating state when resumed
(until we commit a transient launch state); however, for pause
this isn't necessary. In fact, now that taskbar exists in overview,
we must update state on-pause since the taskbar is no-longer
already-closed.

Bug: 253473765
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsQuickstep#testOverview
Change-Id: I347da03a211f5b2685f7b18666b2ebb93a1731ef
2022-10-14 00:11:25 +00:00
Nicolò Mazzucato
09fb35bfb0 Merge "Cancel unfold animation when rotation changes" into tm-qpr-dev am: 4afab0b210 am: c757108519
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20175247

Change-Id: I0881823031d7bb1cd7188902e6c29d36f45a64c4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-13 23:58:12 +00:00
Nicolò Mazzucato
c757108519 Merge "Cancel unfold animation when rotation changes" into tm-qpr-dev am: 4afab0b210
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20175247

Change-Id: I21e4f205591cc030fb92f06ff2faa101de97391b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-13 23:27:26 +00:00
Vinit Nayak
831a4f0e1d Landscape 3 button nav on taskbar phone supported
* TODO: Seascape bar positioning, add tests

Change-Id: I542be2f2f682d8c8a9cdd9bb6c667c44ca167f3e
2022-10-13 23:22:38 +00:00