Commit Graph

13651 Commits

Author SHA1 Message Date
Brian Isganitis
ab29830493 Merge "Delay hiding Taskbar EDU until entering home or overview." into tm-qpr-dev am: a1808c3e49
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20727418

Change-Id: I8ffc5766af32fb513c10a62d17a03c1f19e29236
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-18 23:16:04 +00:00
Brian Isganitis
a1808c3e49 Merge "Delay hiding Taskbar EDU until entering home or overview." into tm-qpr-dev 2022-12-18 22:48:39 +00:00
Bill Yi
10abb91019 Merge "Import translations. DO NOT MERGE ANYWHERE" 2022-12-17 14:30:15 +00:00
Thales Lima
6a59006592 Polish hotseat and taskbar with 3 buttons
Change margin spaces and logic of how many items the hotseat and taskbar should show.

Fix: 246424857
Test: DeviceProfileDumpTest
Test: HotseatWidthCalculationTest
Change-Id: I8ec71c56a0aa362483c43d6400c762d12cf45f5b
2022-12-17 11:20:21 +00:00
Bill Yi
fe1df2a780 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-12-17 01:38:47 +00:00
Alex Chau
c5b1f3e3cb Merge "TaskbarViewController should only translate on rotation if icon is aligned with hotseat" into tm-qpr-dev am: 2f581b799b am: ac61bed9a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20748309

Change-Id: I609b9c5deb315c1438376885ddef1bd229773f6b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-16 20:00:20 +00:00
Jeremy Sim
b3b046dc39 Merge "Fix bug with Taskbar second-app-selection animation" into tm-qpr-dev am: e8eb4a3c48 am: c3fabd892a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20704401

Change-Id: I2175338c520d26404b5b329c28b40b9e28e39357
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-16 19:58:15 +00:00
Sihua Ma
1db8bc2467 Add QuickstepWidgetHolder for widget handling
Fix: 235358918
Test: Manual
1. Rebooted the device and verified that widgets are still updating properly
2. Changed the theme from dark to daylight, then from daylight back to dark and verified that widgets are working
3. Kept the device on for several days and verified that widgets are still updating
4. Turn on auto-rotate for the launcher, open any app then exit, verified that widgets will not vanish and reappear
5. Add & remove widgets from the screen, added widgets are still updating

Change-Id: I98ee902f7d16b47bd77626201a4fefc897ba17a0
2022-12-16 11:56:36 -08:00
Alex Chau
ac61bed9a8 Merge "TaskbarViewController should only translate on rotation if icon is aligned with hotseat" into tm-qpr-dev am: 2f581b799b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20748309

Change-Id: Iffd7b5a38263fbbb019b1ddd15ebc500425ee94f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-16 19:20:51 +00:00
Jeremy Sim
c3fabd892a Merge "Fix bug with Taskbar second-app-selection animation" into tm-qpr-dev am: e8eb4a3c48
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20704401

Change-Id: I5b69d3a32c6a0ba95dce3f64f8e314af9e292164
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-16 19:19:24 +00:00
Alex Chau
2f581b799b Merge "TaskbarViewController should only translate on rotation if icon is aligned with hotseat" into tm-qpr-dev 2022-12-16 19:06:25 +00:00
Jeremy Sim
e8eb4a3c48 Merge "Fix bug with Taskbar second-app-selection animation" into tm-qpr-dev 2022-12-16 18:30:38 +00:00
Alex Chau
5786c775a7 Merge "Set iconsSizePx of Taskbar's DeviceProfile directly" into tm-qpr-dev am: 98d33cdff9 am: a1608fb21a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20747426

Change-Id: I1608c3061545fcffaafd398bdb0195e0637d4db8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-16 17:58:51 +00:00
Alex Chau
a1608fb21a Merge "Set iconsSizePx of Taskbar's DeviceProfile directly" into tm-qpr-dev am: 98d33cdff9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20747426

Change-Id: Iabd35264bf880d76d6a669b29f614a8d86334adc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-16 17:25:04 +00:00
Alex Chau
98d33cdff9 Merge "Set iconsSizePx of Taskbar's DeviceProfile directly" into tm-qpr-dev 2022-12-16 16:45:21 +00:00
Bill Yi
1885c489fc Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ib1739767f90d758017acc10481fcac0bb0fffcc9
2022-12-16 04:45:21 -08:00
Bill Yi
0cd317cd08 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I5b1e77bfbf2f911da92bb4bc14fbdf93ffe303b7
2022-12-16 04:44:51 -08:00
Schneider Victor-tulias
7bb558a57e Add check for loading ever applied in check for page scrolls initialized
When "Don't keep activities" is enabled in developer settings, the RecentsView gets re-initialized every home gesture. The home animation can often finish before the load plan ever gets applied, so the page scrolls can be used before the RecentsView has had a chance to add all its TaskViews and recalculate its page scroll.

Fixes: 249020573
Test: launched an app and went home
Change-Id: I83ca9de60b50693f7a22b08534ec36973cd6a0fc
2022-12-16 03:12:58 -08:00
Bill Yi
3e7a6d9b74 Merge "Import translations. DO NOT MERGE ANYWHERE" 2022-12-16 02:18:14 +00:00
Sunny Goyal
8591bbc892 Merge "Unifying multiple all-apps implementations" into tm-qpr-dev am: 09fab7ee7d am: 37dd2e6691
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20713205

Change-Id: I073f6cb4d3a912b585cd1cd0e57f1ced1b0ed3a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 23:48:58 +00:00
Tony Wickham
c6a7ba8163 Adjust taskbar VIS and bottom mandatory gesture insets
- ITYPE_BOTTOM_MANDATORY_GESTURES should always be > 0  in gesture
  navigation mode, but before we were setting it equal to tappableHeight
  which is 0 if the taskbar is stashed. Fixed it to be contentHeight
  instead.
- Updated VIS insets to only override them to be 0 for tappableElement,
  not for others like navigationBars. We still only override this for
  gesture navigation; 3 button mode will continue reporting the same as
  we report to the underlying apps.

Test: manually with 3 button mode, gesture nav mode with taskbar
stashed/unstashed; checked that TaskbarInsetsController dump looks as
expected, and that behaviors like Assistant and IME look correct
Flag: none
Fixes: 262516176

Change-Id: I5a1cdf5a9956777d3189ef6042493e2f5aa9b162
2022-12-15 22:28:40 +00:00
Alex Chau
adbbc2f7fa TaskbarViewController should only translate on rotation if icon is aligned with hotseat
Fix: 254191175
Test: With 3 button, rotate at home and overview, nav button are at expected position. Repeat with TASKBAR_IN_OVERVIEW flag off.
Change-Id: I1e629e6be92c4793d3dfdb0dac60c3bfce886e7a
2022-12-15 22:04:16 +00:00
Sunny Goyal
37dd2e6691 Merge "Unifying multiple all-apps implementations" into tm-qpr-dev am: 09fab7ee7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20713205

Change-Id: I1bd905e44924ec55f8f7cb254d66f9f751357590
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 17:28:53 +00:00
Alex Chau
a68164d89e Set iconsSizePx of Taskbar's DeviceProfile directly
- After ag/20691430, iconScale no longer scale app icons (I should rename it later, after QPR2), so we'll need to set the desired iconSize directly for Taskbar's DeviceProfile
- Extracted setting iconSizePx and testSizePx out of updateIconSize, as they are no longer affected by scaling. This allows TaskbarActivityContext to set desired iconsize and then call updateIconSize

Bug: 256976071
Test: Test Taskbar icon size in different density
Change-Id: I741c178b59e0d8ecb4c63689e68767622329379c
2022-12-15 17:05:12 +00:00
Sunny Goyal
09fab7ee7d Merge "Unifying multiple all-apps implementations" into tm-qpr-dev 2022-12-15 17:03:05 +00:00
Bill Yi
ac3930bede Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-12-15 14:08:52 +00:00
Schneider Victor-tulias
fa854bd707 [DO NOT MERGE] Log gesture velocity to help debug and help direct future gesture nav thresholds. am: 80b25c756a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20652594

Change-Id: I546f4a2c97c5dd18f55993cfb528fe2e76aef095
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 10:29:01 +00:00
Schneider Victor-tulias
887b56ce1b Merge "Log gesture velocity to help debug and help direct future gesture nav thresholds." 2022-12-15 09:42:20 +00:00
Schneider Victor-tulias
85127b4f47 Merge "[DO NOT MERGE] Log gesture velocity to help debug and help direct future gesture nav thresholds." into tm-qpr-dev 2022-12-15 09:42:15 +00:00
Jeremy Sim
768e9ec8c0 Fix bug with Taskbar second-app-selection animation
This patch makes it so that the correct animation will play when the user selects a second app from the Taskbar.

Previously, when the user selected a second app from the Taskbar, an animation would play showing the expansion of the app -- but it would come from the wrong place. The error occurred because when we calculate the animation start position, we assume that the starting view is located in the DragLayer, which fills the whole screen. But in cases where the starting view is located in the Taskbar, the root view is actually the TaskbarDragLayer, which only fills an area on the bottom part of the screen.

Fixed by adding a check to see if the starting view is part of the TaskbarActivityContext, and if so, adding an offset to calculate the correct DragLayer coordinates.

Fixes: 258692761
Test: Manual
Change-Id: I4026676fefe1e4c5cdf9d9a47d95c0d6e64672e8
2022-12-14 17:48:14 -08:00
Bill Yi
78ea5bd253 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie78d4416033cc14e78a40771e66524517e2e7d28
2022-12-14 14:15:06 -08:00
Bill Yi
e9b7c15e95 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I61ee5cd3d8384e48c03f7f1682bdb325e94defaa
2022-12-14 14:14:32 -08:00
Brian Isganitis
73d270bf51 Merge "Assign taskbar EDU same interpolator as all apps." into tm-qpr-dev am: f5c099b528 am: 4aa2644629
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20726289

Change-Id: I82869bb9d8f264bea5f43bff7c652bfdd2c85ee4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 21:34:09 +00:00
Brian Isganitis
4aa2644629 Merge "Assign taskbar EDU same interpolator as all apps." into tm-qpr-dev am: f5c099b528
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20726289

Change-Id: I0184935622d8892842af29629ed96eff65e9507b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 20:50:23 +00:00
Brian Isganitis
f5c099b528 Merge "Assign taskbar EDU same interpolator as all apps." into tm-qpr-dev 2022-12-14 20:25:21 +00:00
Jon Miranda
a965d14c42 Merge "Taskbar All Apps button visual updates" into tm-qpr-dev am: a0743cf62c am: 80f6ece5ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20724415

Change-Id: Id066aeb46d61d892ce6e30688e1b215d958206db
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 20:11:38 +00:00
Brian Isganitis
1e37aae1dc Merge "Polish all apps taskbar unstash behavior for transient and persistent." into tm-qpr-dev am: 8216a26bfe am: 71f9faded9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20713695

Change-Id: I8917a9a3f4ceb856cf1fecf8699e61fb5a0bf459
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 20:10:06 +00:00
Jon Miranda
80f6ece5ad Merge "Taskbar All Apps button visual updates" into tm-qpr-dev am: a0743cf62c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20724415

Change-Id: Ib3ff9ebcfd645a6f929e17e17aec4f14b070b7ec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 19:33:23 +00:00
Brian Isganitis
71f9faded9 Merge "Polish all apps taskbar unstash behavior for transient and persistent." into tm-qpr-dev am: 8216a26bfe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20713695

Change-Id: Ic5f32fca6c7f56c9e17cdc68bc0416c0881e2fd3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 19:32:50 +00:00
Sunny Goyal
adb364a104 Unifying multiple all-apps implementations
> Using a single layout for the all-apps content
> Removing some unnecessary themes
> Fixing search chashes in SecondaryDisplayLauncher

Bug: 259733681
Test: Existing TAPL tests verify that Launcher/AllApps work properly
Change-Id: Icd5310316499cd421bc039cdbd4d398b813cd477
2022-12-14 11:27:12 -08:00
Jon Miranda
a0743cf62c Merge "Taskbar All Apps button visual updates" into tm-qpr-dev 2022-12-14 19:00:18 +00:00
Brian Isganitis
8216a26bfe Merge "Polish all apps taskbar unstash behavior for transient and persistent." into tm-qpr-dev 2022-12-14 18:54:42 +00:00
Alex Chau
c92b91c579 Merge "Don't scale iconSize and textSize in non-default display size" into tm-qpr-dev am: 5c1eb61391 am: 881b7f2d55
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20691430

Change-Id: I083054a14d61a8ebd212c1d1dde5ee210eb84fd3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 18:12:34 +00:00
Alex Chau
881b7f2d55 Merge "Don't scale iconSize and textSize in non-default display size" into tm-qpr-dev am: 5c1eb61391
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20691430

Change-Id: Ife649f8b410276b2cfd84826132fbe00f4835493
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 17:37:24 +00:00
Alex Chau
5c1eb61391 Merge "Don't scale iconSize and textSize in non-default display size" into tm-qpr-dev 2022-12-14 17:15:21 +00:00
Brian Isganitis
338fa3e9ab Delay hiding Taskbar EDU until entering home or overview.
EDU will now end up hiding due to
TaskbarLauncherStateController#onStateChangeApplied closing all AFVs if
we are going to home or overview.

This is a quickfix to make it harder to accidentally close the EDU when
testing out the transient taskbar. We will eventually be moving to a
lighter EDU UI where having gestures occuring behind it will be less
awkward.

Test: Manual
Bug: 260769010
Change-Id: I477abe9339ed10cb3aed8d1a0fbe0e22ac14c7ab
2022-12-13 20:16:29 -05:00
Jon Miranda
e7417ce2ae Taskbar All Apps button visual updates
- Moved to new position
- Using 3x3 icon
- New Colors

Checked with visd that this half is good to go,
will follow up with positioning of the 3x3 icon within
its container.

Bug: 259712417
Test: manual, LTR/RTL modes, transient/persisent models

Change-Id: I298b6dbca004cdb8920e6533fffc8ca83e0197f9
2022-12-13 15:16:01 -08:00
Bill Yi
99d8e6c7a4 Merge "Import translations. DO NOT MERGE ANYWHERE" 2022-12-13 21:48:34 +00:00
Brian Isganitis
47da4167ea Assign taskbar EDU same interpolator as all apps.
This polishes closing both at the same time when they are on top of each
other.

Test: Manual
Bug: 217261955
Change-Id: Iecb8658b98debb0225d3b59da99ecb34d008971a
2022-12-13 16:43:36 -05:00
Brian Isganitis
2a2f1b6cd3 Polish all apps taskbar unstash behavior for transient and persistent.
- During gestures from taskbar all apps, unstash immediately in
  transient.
- Overlay closes sooner if all apps is open (still done later for EDU).
- Taskbar stashes in overview when All Apps is opened.
- Transient app-window threshold is ignored if All Apps is opened.

Test: Manual
Fix: 262076812
Change-Id: I46b2dcdc75ee0cc15c1b47da2139ff8c20cf618a
2022-12-13 16:24:35 -05:00