Commit Graph

8114 Commits

Author SHA1 Message Date
Stefan Andonian
1eb59d6c6a Merge "Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage." into tm-qpr-dev 2023-01-17 18:23:10 +00:00
Nicolo' Mazzucato
cb7bd50247 Log device profile changes in perfetto traces
This is needed to easily spot unwanted DeviceProfile changes in perfetto traces, as each one causes many new inflation and slows down the ui thread considerably.

Test: recorded trace with this log
Bug: 258214245
Change-Id: I805d56d4dfe1c08d7f28215c0462d01fcaece84e
2023-01-17 14:54:11 +00:00
Jeremy Sim
2842bc72fd Fix bug with Taskbar launches in Overview
This patch fixes a bug where Taskbar launches (tapping an icon on the Taskbar) were not executing correctly in Overview.

Now that Taskbar is always present in Overview, we need to handle cases where the user taps to launch an app, but the app is already visible to the user in Overview. This was breaking in a noticeable way with split apps, where the Taskbar simply wouldn't respond when the tapped app was already visible as a live tile.

Fixed by polling RecentsModel for already-running tasks, checking to see if the associated TaskView is visible to the user or not, and calling launchTasks() on the TaskView if so. If the tile is not visible to the user, the app will launch normally.

Fixes: 261952204
Test: Work in progress
Change-Id: If761546913bde7451a22456a272ba6c31942c5f8
2023-01-17 13:54:47 +08:00
Alex Chau
835ccc58e0 Close Taskbar AllApps when going from overview to home
- Also trigger closeAllOpenViews when changing state to NORMAL

Fix: 265689318
Test: manual
Change-Id: I109c0f3a3c741844c8747bd76a6c38bf301ec737
2023-01-16 18:20:27 +00:00
Tony Huang
3f5d510b38 Fix launcher crash by set divider hidden
We will hide divider when isLikelyToStartNewTask become true, but
this call sometime earlier than onRecentsAnimationStart then cause
crash because mRecentsAnimationTargets is still null.

Fix this by checking mRecentsAnimationTargets before set divider
visibility. And also add new condition to hide divider to ensure
it hidden if such case happened.

Fix: 265238266
Test: manaul
Test: pass existing tests
Change-Id: I80b1294e69a52e7ac5255cd8e55e7c5e6a3dcbcb
2023-01-16 14:29:19 +08:00
Sunny Goyal
a34521e434 Updating TaskbarStashController API
> Making the state animator nonNull to avoid null checks at caller
> Updating the methods names to explicitely indication animation
  being started or not

Bug: 265352919
Test: Verified on device
Change-Id: I1f5b47921f831ed0b202aced10825c8e1d39a4dc
2023-01-14 08:07:44 -08:00
Tony Wickham
7d41212d42 Merge "Remove extra overview threshold if the transient taskbar is already open" into tm-qpr-dev am: a329718dcf am: 4f90d44377
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20886425

Change-Id: I046559dca1c9e2866005de73663ca9e5d32940b6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-14 03:18:59 +00:00
Tony Wickham
4f90d44377 Merge "Remove extra overview threshold if the transient taskbar is already open" into tm-qpr-dev am: a329718dcf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20886425

Change-Id: I61fe680a135268379e741a171ed2d29febbeca99
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-14 01:15:34 +00:00
Sebastián Franco
075bd276ca Merge "Change the access of cellX/Y of CellLayoutLayoutParams to private" into tm-qpr-dev am: 519714449f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20838734

Change-Id: Id6707d575fecfeae28b704fd8701c82f4288a9f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-14 01:14:48 +00:00
Tony Wickham
a329718dcf Merge "Remove extra overview threshold if the transient taskbar is already open" into tm-qpr-dev 2023-01-14 01:09:52 +00:00
Sebastián Franco
519714449f Merge "Change the access of cellX/Y of CellLayoutLayoutParams to private" into tm-qpr-dev 2023-01-14 00:59:47 +00:00
Stefan Andonian
d1b33b311c Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage.
LauncherPrefs will contain Launcher's shared preference functionality.
It controls optimizations and classifications such as restorable vs
non-restorable data, bootaware vs non-bootaware data, and configurations
such as default values  so the calling code doesn't need to and our code
base can have a single source of truth for items that are used in
multiple places.

The old APIs remain in place, but are deprecated and will be removed
after all Shared Preference usage has been gated by LauncherPrefs in
future CLs.

Bug: 261635315
Test: Manually tested themed icon, Workspace configuration, and app
install functionality.

Change-Id: I29fd516468bc93fda393062e95be26b6d55c816e
2023-01-14 00:54:15 +00:00
Randy Pfohl
def579a82f Merge "Cleaning up UI jank while quick switching" into tm-qpr-dev am: dcd79bd6cd am: f763efa527
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20898205

Change-Id: Ib63c994382afea82b05815a210079a2c924fafaa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-14 00:08:06 +00:00
Randy Pfohl
f763efa527 Merge "Cleaning up UI jank while quick switching" into tm-qpr-dev am: dcd79bd6cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20898205

Change-Id: I7a302c76532621837b54fbf38dd153fb15f975b6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 23:28:30 +00:00
Randy Pfohl
dcd79bd6cd Merge "Cleaning up UI jank while quick switching" into tm-qpr-dev 2023-01-13 23:02:41 +00:00
Johannes Gallmann
c047a8885c Merge "Prevent workspace enter animation for predictive back" into tm-qpr-dev am: 4aa135f3c7 am: f2709309bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20838736

Change-Id: I13c25d2e87498a6a28dd018dacf6451cbaabb092
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 21:49:01 +00:00
TreeHugger Robot
ec59c7b9c5 Merge "Provide single threaded executor to UnfoldUnfoldTransitionFactory" into tm-qpr-dev am: 60c7dfec29 am: 2618fcf11c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929486

Change-Id: Ic56fd8e629f376893eb10fd21d39384cb3299d0e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 21:48:52 +00:00
TreeHugger Robot
021877cbb4 Merge "Revert "Add debug logs for hotseat disapperaed bug"" into tm-qpr-dev am: 5f3784d147 am: dda983334f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20967683

Change-Id: I55e5316bdfc7a004f31b44a0fadc54d97695ea2d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 21:48:32 +00:00
Sebastian Franco
877088e6c3 Change the access of cellX/Y of CellLayoutLayoutParams to private
Bug: 188081026
Test: no op change, should compile
Test: ReorderWidgets
Change-Id: I20367974e5a4cead406e18eb66dafd4d59651b2a
Merged-In: I20367974e5a4cead406e18eb66dafd4d59651b2a
2023-01-13 18:25:10 +00:00
Johannes Gallmann
f2709309bb Merge "Prevent workspace enter animation for predictive back" into tm-qpr-dev am: 4aa135f3c7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20838736

Change-Id: Ia1e8d8830a99268870f4c9f3cf59ca5d32a731b5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 17:55:35 +00:00
Johannes Gallmann
4aa135f3c7 Merge "Prevent workspace enter animation for predictive back" into tm-qpr-dev 2023-01-13 17:28:42 +00:00
TreeHugger Robot
2618fcf11c Merge "Provide single threaded executor to UnfoldUnfoldTransitionFactory" into tm-qpr-dev am: 60c7dfec29
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929486

Change-Id: Ica6895eddd30abb925ce9b87322711213ae14f68
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 16:01:52 +00:00
TreeHugger Robot
60c7dfec29 Merge "Provide single threaded executor to UnfoldUnfoldTransitionFactory" into tm-qpr-dev 2023-01-13 15:49:07 +00:00
TreeHugger Robot
dda983334f Merge "Revert "Add debug logs for hotseat disapperaed bug"" into tm-qpr-dev am: 5f3784d147
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20967683

Change-Id: I4a77261e41700023d6f3c8856db040b9369a013f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 13:46:23 +00:00
TreeHugger Robot
5f3784d147 Merge "Revert "Add debug logs for hotseat disapperaed bug"" into tm-qpr-dev 2023-01-13 13:01:03 +00:00
Vinit Nayak
07cccd161f Merge "Respect nav button tinting in SUW" into tm-qpr-dev am: f83d8a00a8 am: f47ba402c8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953768

Change-Id: I5ea97c57ae8e590da7c963c52ec3307b536f410b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 04:18:32 +00:00
Vinit Nayak
f47ba402c8 Merge "Respect nav button tinting in SUW" into tm-qpr-dev am: f83d8a00a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953768

Change-Id: I5798568fcfc64ef8d7ce3a5175e45f249c53e08c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 04:14:59 +00:00
Vinit Nayak
f83d8a00a8 Merge "Respect nav button tinting in SUW" into tm-qpr-dev 2023-01-13 03:28:03 +00:00
Jeremy Sim
6872bc1236 Merge "Fix transition animations for launch-from-staged operation" into tm-qpr-dev am: 9dfeb03a71 am: 2bc8635b0a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20844441

Change-Id: Ida4e65f9c12d412ba176dc950219b4c19697877d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-13 00:27:28 +00:00
Sunny Goyal
00e3c1ace4 Using AnimatedFloat for maintaing TaskbarInAppDisplayProgress instead of a float array
Bug: 265352919
Test: Verified on device
Change-Id: I603a817c18720d5f18fe0c2be7bdfd8cf2d6defc
2023-01-12 16:02:42 -08:00
Jeremy Sim
2bc8635b0a Merge "Fix transition animations for launch-from-staged operation" into tm-qpr-dev am: 9dfeb03a71
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20844441

Change-Id: Ie382a53ed107537f52e8bc8777468f52a4288ae9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 23:50:52 +00:00
Ats Jenk
5299847a64 Merge "Skip depth and scrim if freeform tasks are visible" into tm-qpr-dev am: 1c28f290c1 am: a39ff80885
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929665

Change-Id: I4df52bf0788546e48499894283b8196e748a8af6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 23:17:38 +00:00
Ats Jenk
d5315c5b94 Merge "Hide DesktopTaskView background while animating" into tm-qpr-dev am: 984a37d1b1 am: 8df2f4748a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20888248

Change-Id: I73fb5a3819793ada1983ff3766aa9012e67b1ff8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 23:17:15 +00:00
Jeremy Sim
9dfeb03a71 Merge "Fix transition animations for launch-from-staged operation" into tm-qpr-dev 2023-01-12 23:08:37 +00:00
Ats Jenk
a39ff80885 Merge "Skip depth and scrim if freeform tasks are visible" into tm-qpr-dev am: 1c28f290c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929665

Change-Id: If52b473eb05dca4e0b4dcbdc3c9416b4f0abb53f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 22:56:36 +00:00
Tracy Zhou
53fb97468b Merge "Update onOverviewShown interface to get signal of whether it should be iterated in forward or backward direction" 2023-01-12 22:43:15 +00:00
Ats Jenk
1c28f290c1 Merge "Skip depth and scrim if freeform tasks are visible" into tm-qpr-dev 2023-01-12 22:39:57 +00:00
Ats Jenk
8df2f4748a Merge "Hide DesktopTaskView background while animating" into tm-qpr-dev am: 984a37d1b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20888248

Change-Id: I01acb423b0ea3934b2e63779ba8cb3ff3a7ccf03
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 22:37:42 +00:00
Alex Chau
f4269f01d7 Revert "Add debug logs for hotseat disapperaed bug"
This reverts commit 04658bcd42.

Reason for revert: root cause found
Bug: 260135164

Change-Id: I809662780d042923de015ff4cb810b3da5169f83
2023-01-12 22:21:07 +00:00
Ats Jenk
984a37d1b1 Merge "Hide DesktopTaskView background while animating" into tm-qpr-dev 2023-01-12 22:11:12 +00:00
Sebastián Franco
f55e3690ea Merge "Change the access of cellX/Y of CellLayoutLayoutParams to private" 2023-01-12 21:14:23 +00:00
TreeHugger Robot
cadcf8d07a Merge "Support predictive back from all apps to home" into tm-qpr-dev am: 944348a522 am: 318da8ce22
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20789107

Change-Id: I55318b382a572047400085c45a3ea6c1475f966c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 19:59:22 +00:00
Luca Zuccarini
675c1b997e Merge "Revert^2 "Update timings for the Home <> All Apps transition."" into tm-qpr-dev am: 51c89ca493 am: 7495d0f873
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929144

Change-Id: I8c7aa28deccf93c25f4df6d1e2a5ceed63c038d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 19:49:53 +00:00
randypfohl
9c5fa66d2f Cleaning up UI jank while quick switching
Moving a few calls into the UI helper executor thread, as per the associated bug. duplicated the lines so the synchronous nature of clearing previous state wouldn't affect potential timings.

Test: local testing, rotating screen. quick switching apps.

Bug: 257470365
Change-Id: I59abad9ba51c0b19d467646752aa34ae7ef3ec1d
2023-01-12 19:06:04 +00:00
Ats Jenk
ca009e4e93 Skip depth and scrim if freeform tasks are visible
If freeform tasks are shown, skip applying depth effect and scrim
changes. These cause the background to flicker while showing freeform
tasks and for example showing the transient taskbar.

Bug: 263264985
Test: swipe up to show transient taskbar, observe launcher background
does not blur or flicker to black

Change-Id: I5b10d0f0c7065e903cb761488367c02d7e31d8b2
2023-01-12 10:15:30 -08:00
TreeHugger Robot
318da8ce22 Merge "Support predictive back from all apps to home" into tm-qpr-dev am: 944348a522
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20789107

Change-Id: Ib53aa807f447aeba483f6a4a10f078a5b39bf660
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 17:50:42 +00:00
TreeHugger Robot
944348a522 Merge "Support predictive back from all apps to home" into tm-qpr-dev 2023-01-12 17:01:02 +00:00
Tony Wickham
7d192c0e71 Remove extra overview threshold if the transient taskbar is already open
Test: Swipe to overview when taskbar is already opened vs not
Fixes: 264555943
Change-Id: Ib4c31b085ca51e50fd7442ff9a27a5f47822c242
2023-01-12 16:48:35 +00:00
Chavi Weingarten
80995574bd Updated SurfaceSyncGroup API definition.
Test: Builds
Bug: 237804605
Change-Id: I0c1ebefb123d73df797fe6a6ee9eda456f1f0ccc
2023-01-12 16:12:10 +00:00
Luca Zuccarini
7495d0f873 Merge "Revert^2 "Update timings for the Home <> All Apps transition."" into tm-qpr-dev am: 51c89ca493
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20929144

Change-Id: I3629ade53ed1be9d596a158e0f71efd999428aa5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 14:51:20 +00:00