Commit Graph

8114 Commits

Author SHA1 Message Date
Jon Miranda
08be3775f6 Prevent x-axis window movement during the initial swipe up to show transient taskbar
- If gesture starts and isLikelyToStartANewTask=true, we do not clamp
- If gesture starts and isLikelyToStartANewTask=false AND transient taskbar is not
  already showing, we clamp the scrolling

Bug: 258851206
Test: swipe up to show taskbar, no x-axis movement
      swipe left/right still works as expected

Change-Id: Iac194df63e03b4a28b49008983c88c165847aa31
2022-11-18 13:10:34 -08:00
Jon Miranda
e3bcc7bf40 Merge "Fix home/overview threshold." into tm-qpr-dev 2022-11-18 21:02:01 +00:00
Schneider Victor-tulias
e04a878709 Revert "Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly."
This reverts commit a0be92c830.

Reason for revert: Bug fixed and logs are too verbose

Test: ran launcher and checked logs
Fixes: 244593270
Change-Id: Ia67ba96b0b2146308f9cad1df884144edf2ab186
2022-11-18 11:00:33 -08:00
TreeHugger Robot
da0c6436db Merge "End live tile when quick settings expands, not just notification shade." into tm-qpr-dev am: 9b3aaf2b7d am: 1c3916daeb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20508312

Change-Id: I7c35505e38e8ab8f7f6a93086d40640361a08c0d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 17:54:43 +00:00
TreeHugger Robot
1c3916daeb Merge "End live tile when quick settings expands, not just notification shade." into tm-qpr-dev am: 9b3aaf2b7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20508312

Change-Id: Ief0f13b064472a37924ce7fe5c05adf8f35c23a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 17:21:57 +00:00
TreeHugger Robot
9b3aaf2b7d Merge "End live tile when quick settings expands, not just notification shade." into tm-qpr-dev 2022-11-18 16:45:30 +00:00
Jon Miranda
94566f97ec Merge "Use mContext instead of TaskbarActivityContex to enable transient taskbar." into tm-qpr-dev am: 4b26e8f081 am: 81e33a07d3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20511769

Change-Id: Ia09949deb5acd0c5a0d4317619abe38e80f3e406
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 04:13:00 +00:00
Jon Miranda
81e33a07d3 Merge "Use mContext instead of TaskbarActivityContex to enable transient taskbar." into tm-qpr-dev am: 4b26e8f081
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20511769

Change-Id: If783c22198f860dee1e184040f3aa64dea9805e2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 03:41:01 +00:00
Jon Miranda
4b26e8f081 Merge "Use mContext instead of TaskbarActivityContex to enable transient taskbar." into tm-qpr-dev 2022-11-18 03:12:00 +00:00
Jon Miranda
21d4253c01 Fix home/overview threshold.
Fixes: 258836670
Test: Enable I06e16d78c179b7c3281f423ed8c7dd6cfc42229a to visually show
      thresholds on screen
      Swipe up to overview where taskbar not showing
      and also with taskbar already showing

Change-Id: Ie7487a5f869c0718d9ee08209dee8331a01d5989
2022-11-17 18:09:31 -08:00
Brian Isganitis
c6ec460e83 Merge "Add a11y titles for taskbar windows." into tm-qpr-dev am: 50b3b62eba am: 57a3312468
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20239440

Change-Id: Ibf1bf6b7c7845c40ac8bcb1e706674f41230fdb0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 02:03:05 +00:00
TreeHugger Robot
7810361fdb Merge "Fix ConcurrentModificationExceptions during binding." into tm-qpr-dev am: 3a801de233 am: ed37fabc9c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20468156

Change-Id: Idb957261db7fd8ce440a04e909ae5e330767cac7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 02:02:55 +00:00
Brian Isganitis
57a3312468 Merge "Add a11y titles for taskbar windows." into tm-qpr-dev am: 50b3b62eba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20239440

Change-Id: If23159090c979589410bd41a1c82ceb28e70582f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 02:00:04 +00:00
TreeHugger Robot
ed37fabc9c Merge "Fix ConcurrentModificationExceptions during binding." into tm-qpr-dev am: 3a801de233
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20468156

Change-Id: I2a176b09a92ce02acd2a406f6647701098164328
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 01:57:55 +00:00
Brian Isganitis
50b3b62eba Merge "Add a11y titles for taskbar windows." into tm-qpr-dev 2022-11-18 01:56:22 +00:00
TreeHugger Robot
3a801de233 Merge "Fix ConcurrentModificationExceptions during binding." into tm-qpr-dev 2022-11-18 01:44:01 +00:00
Brian Isganitis
424c7f4393 Still launch disabled item if we can't handle its click.
See where ItemClickHandler#handleDisabledItemClick returns false for
context. If we do not honor this return value, the framework will not
show a dialog in response to attempting launch the item.

Fix: 258232619
Test: Manual
Change-Id: Ie3b112eea17caf0a84defb331133bda9f3add5b6
2022-11-18 01:09:18 +00:00
Stefan Andonian
953a517765 Merge "Move SharedPreferences code to its own class." into tm-qpr-dev am: 3233010c5a am: b626411c99
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20446860

Change-Id: Ibafb226c2bc6bd1ea425725920520540a8720351
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 00:47:28 +00:00
Stefan Andonian
b626411c99 Merge "Move SharedPreferences code to its own class." into tm-qpr-dev am: 3233010c5a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20446860

Change-Id: I397957b5d9584aebf4182930763a2c5ab6401073
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-18 00:17:45 +00:00
Brian Isganitis
9390b500a9 Only allow one TaskbarRecentsAnimationsListener at a time.
If another animation is created while one is occurring, we should clean
up the previous one.

Test: Manual
Fix: 233868461
Change-Id: Idf0e33ae95cbf19741ee943e450d478b1e18716b
2022-11-18 00:02:53 +00:00
TreeHugger Robot
5055ac6010 Merge "Update All set page subtitle to use the same device name used acrss the SUW" into tm-qpr-dev am: 4059ff0a0c am: 92924fca3e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20469952

Change-Id: I1980e3960cbfb1913f23392a8c4fa2cdf04dd948
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 23:57:32 +00:00
Stefan Andonian
3233010c5a Merge "Move SharedPreferences code to its own class." into tm-qpr-dev 2022-11-17 23:46:26 +00:00
TreeHugger Robot
92924fca3e Merge "Update All set page subtitle to use the same device name used acrss the SUW" into tm-qpr-dev am: 4059ff0a0c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20469952

Change-Id: Id803a2004f4574287a2d225ed67f30949e6731da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 23:27:22 +00:00
TreeHugger Robot
4059ff0a0c Merge "Update All set page subtitle to use the same device name used acrss the SUW" into tm-qpr-dev 2022-11-17 23:03:31 +00:00
Jon Miranda
2049f3990a Use mContext instead of TaskbarActivityContex to enable transient taskbar.
Bug: 259586791
Bug: 259337908
Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: Ibb0a8e8539946f3a496318a6a9cf4b553693d790
2022-11-17 14:20:33 -08:00
Schneider Victor-tulias
cc1b5c7926 Merge "Fix null-pointer exception in all set activity first reveal animation" into tm-qpr-dev am: 193f8992f1 am: 383c950918
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20486066

Change-Id: I2cfe3bde11e07d7ce7cb38cec52fb42d8357a84a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 22:12:23 +00:00
Schneider Victor-tulias
383c950918 Merge "Fix null-pointer exception in all set activity first reveal animation" into tm-qpr-dev am: 193f8992f1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20486066

Change-Id: I6200232bd2f266a365e8559ca060f0594052d797
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 22:11:05 +00:00
Ikram Gabiyev
c06426164f Stash transient taskbar upon icon drag
Transient taskbar needs to be stashed upon
dragging the icon from it to create a
splitscreen.

Bug: 258850827

Test: manually reproduced the steps in the bug
Change-Id: I88f2b4b25cb4c12fbe7e646a8ed668921ef24ab9
2022-11-17 22:01:41 +00:00
TreeHugger Robot
240848324a Merge "Check NPE and log error condition for enableBlockingTimeout in test harness." into tm-qpr-dev am: 1eb1e03651 am: f8a9e48034
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20501925

Change-Id: I369ed11a3f6b9564d53a89ed9eb40ecae75b849f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 21:57:42 +00:00
Sihua Ma
ff0f98dd03 Clear drag views during swipe up animation progress
This is to avoid clearing it too lately, at a point where the user starts to see a flicker on the screen.

There was already a report of this bug. Filing a bug report on my own because the original one is hard to find. I will mark that as fixed once I find it again.

Test: Manual
Fix: 259157574
Change-Id: Idc9bb67ebf6fc3ff6d78880f28c46d916a02ab77
2022-11-17 13:52:26 -08:00
Schneider Victor-tulias
193f8992f1 Merge "Fix null-pointer exception in all set activity first reveal animation" into tm-qpr-dev 2022-11-17 21:47:18 +00:00
Ats Jenk
4b4e4a39df Add onTaskMovedToFront to close floating views
Fixes a bug with allapps not being closed if the launching activity does
not trigger a onTaskStackChange callback. For example this is the case
when allapps launches a task in freeform mode. In this case the previous
task is still visible and won't be paused. The onTaskStackChange
callback is not triggered. Leaving the allapps view visible.

Bug: 259264346
Test: enable destop mode, open gmail, open allapps and open chrome,
  observe allapps view is closed
Change-Id: I5e60baa15ebc04b5094a84ed977eb9f3bc73d4a6
2022-11-17 13:09:19 -08:00
Brian Isganitis
61b01e2c2a Add a11y titles for taskbar windows.
Test: Manual with Talkback.
Fix: 228389333
Change-Id: If30311166fde155d04cf1c9a6865c98d380a93ea
2022-11-17 20:56:04 +00:00
Stefan Andonian
a04de842d1 Fix ConcurrentModificationExceptions during binding.
The same lists of extra items stored in BgModelData are also stored in
UI components. This is causing ConcurrentModificationExceptions. The
solution is to clone these lists or mark them as immutable before storing
them in their respective components.

Bug: 206918543
Test: Verified that crash no longer occurs after fix.
Change-Id: I571a2c451af58137aa7513b372b6a8ecf9bd3ff6
2022-11-17 20:46:51 +00:00
TreeHugger Robot
f8a9e48034 Merge "Check NPE and log error condition for enableBlockingTimeout in test harness." into tm-qpr-dev am: 1eb1e03651
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20501925

Change-Id: I71768063eba0eebd6b98c504e9dce9bdfdb12d03
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 19:20:00 +00:00
Schneider Victor-tulias
6386d4b55b Update All set page subtitle to use the same device name used acrss the SUW
Fixes: 252972556
Test: launched the all set page on a large screen, foldable and phone
Change-Id: Id6cb86ff85aeb1453f96e707dc4921d23513c406
2022-11-17 10:58:55 -08:00
TreeHugger Robot
1eb1e03651 Merge "Check NPE and log error condition for enableBlockingTimeout in test harness." into tm-qpr-dev 2022-11-17 18:33:23 +00:00
Stefan Andonian
146701ca3e Move SharedPreferences code to its own class.
Bug: 251502424
Test: Code compiled correctly.
Change-Id: Iea0d6ab2999504117546ee0f7adc0c7b8b45c065
2022-11-17 17:22:47 +00:00
Pat Manning
33fa3ffeec End live tile when quick settings expands, not just notification shade.
This is needed for split-shade and for two-finger pull down of shade which goes directly to quick settings.

Fix: 256090552
Fix: 259417195
Test: manual
Change-Id: Ief28ae69d4142ddabb4d4b1a9f821abecd81be1e
2022-11-17 14:47:52 +00:00
Alex Chau
aee9c12a8b Fix janky close animation when taskbar is unstashed
- Updated startRect for close animation when taskbar is unstashed

Fix: 258167450
Test: Use back gesture to close app when taskbarw is stashed or unstashed
Change-Id: I56913c2770024bcb47a74c28941bc59f60b4666b
2022-11-17 10:57:40 +00:00
Pat Manning
50b335fbba Set grid progress even when task count is 0.
Fix: 256090552
Test: manual
Change-Id: I2a0ccaf007af71bbe3338453553a7dff59a7d6d2
2022-11-17 10:55:34 +00:00
Tracy Zhou
66bfb8bfab Merge "Implement split from workspace to workspace" into tm-qpr-dev am: a71d353ff8 am: 7f754c162e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20341821

Change-Id: Ic2b061618579edc04b1fda25955d415803d9556b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 08:14:00 +00:00
Tracy Zhou
7f754c162e Merge "Implement split from workspace to workspace" into tm-qpr-dev am: a71d353ff8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20341821

Change-Id: I868918e650e3ef220a371ff785f2cd8d5de18225
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 07:46:17 +00:00
Tracy Zhou
a71d353ff8 Merge "Implement split from workspace to workspace" into tm-qpr-dev 2022-11-17 07:04:48 +00:00
Jeremy Sim
18618d5635 Merge "Allow user to tap on stashed app to launch task in fullscreen" into tm-qpr-dev am: c480c268e8 am: e589b0bd2e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20432050

Change-Id: I4e96a66a8233d39010a0c33fbcf23a9b9d0f5200
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 05:23:58 +00:00
Jeremy Sim
e589b0bd2e Merge "Allow user to tap on stashed app to launch task in fullscreen" into tm-qpr-dev am: c480c268e8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20432050

Change-Id: I9a65608333cf457ca36e7bcf6407c8296913d9e1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 04:55:09 +00:00
Jeremy Sim
c480c268e8 Merge "Allow user to tap on stashed app to launch task in fullscreen" into tm-qpr-dev 2022-11-17 04:19:04 +00:00
TreeHugger Robot
421eac46b3 Merge "Update transient taskbar transition duration to match spec (417ms)." into tm-qpr-dev am: 1b30bab1e1 am: 7d385f3135
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20469888

Change-Id: I7616c8adc7837475649312216c1dca6dcd78803e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 03:28:55 +00:00
TreeHugger Robot
7d385f3135 Merge "Update transient taskbar transition duration to match spec (417ms)." into tm-qpr-dev am: 1b30bab1e1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20469888

Change-Id: Ia7df964eabebe9816099b5ca0d1689dcc9cc7f3f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 03:03:23 +00:00
TreeHugger Robot
dfd1f36639 Merge "Cleaning Utilities.java" into tm-qpr-dev am: 3ea398ecb7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20392137

Change-Id: Ib65cd706bb230d7e8a8789d8e4a72c8ad0ed5815
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-17 03:02:59 +00:00