Commit Graph

9705 Commits

Author SHA1 Message Date
randypfohl
03d29305ca Setting recentsView orientation to match recents activity orientation
Test: can no longer repro incorrect orientation when launching apps from all apps
      added logs to verify recents activity -> view were the same while rotating
      turned off auto rotate and verified state matched

Bug: 288984663
Bug: 301024104

Change-Id: I7fc3b47bff0a99756aaf877bf634e2d162838d6f
2023-09-20 15:04:55 -07:00
Sunny Goyal
5b86162853 Overriding the default TextClock and AnalogClock behavior to avoid RPCs on main thread
during onAttachToWindow

Bug: 294352799
Test: Verified on device
Flag: N/A
Change-Id: I3cce6900cd62a6e9a57c155b74c15c2340c6011b
2023-09-18 23:04:33 +00:00
Tony Wickham
2316dc4750 Finish recents animation synchronously on cancel event
Fixes: 300247322
Test: invoke omnient via long press nav handle
Flag: ENABLE_LONG_PRESS_NAV_HANDLE

Change-Id: I5d7cd1d0a2a50da26a881a6daa203806bf857909
2023-09-18 15:34:29 +00:00
Nicolò Mazzucato
3c898a7550 Merge "Preload overview after unfold" into udc-qpr-dev 2023-09-18 08:37:56 +00:00
Vinit Nayak
8ad9393213 Merge "Provide bgExecutor for RotationButtonController" into udc-qpr-dev 2023-09-15 17:20:43 +00:00
Vinit Nayak
9b3598f154 Provide bgExecutor for RotationButtonController
Bug: 289341065
Test: Unfolded, checked perfetto trace, it
shows up not on UI thread

Change-Id: I9a080c9a5c3c57f38eb6719ed73952dde4f6bba1
2023-09-15 10:46:00 -04:00
Nicolo' Mazzucato
f6264d2387 Preload overview after unfold
Before this change, the configChange was processed when launcher becomes visible. However, this happened during animations (e.g. swipe to home after unfold to app).

With this change, the onConfigChange received by TIS (so, it's received also if the activity is not visible), is used to preload overview, moving a ~100ms block to unfold instead of during the animation.

Bug: 294352799
Test: recorded a perfetto trace and checked jank decrease
Change-Id: I35a7036887cc9ea490f27d5ccd47fe423775350b
Merged-In: I35a7036887cc9ea490f27d5ccd47fe423775350b
(cherry picked from commit 11ce5f85c9)
2023-09-15 11:38:46 +00:00
Federico Baron
15b81093d7 Merge "Ensure PauseUIUpdate always ends up getting set to false" into udc-qpr-dev 2023-09-14 16:26:34 +00:00
Becky Qiu
28498d5f6f Print out debug logging in bug report if not running test.
Bug: 300101221
Test: local
Flag: not needed, logging only.
Change-Id: If016d6fe35a1c43e1a1f311d696b9f2ca0f36f6a
2023-09-13 17:24:51 -07:00
fbaron
a101ac696f Ensure PauseUIUpdate always ends up getting set to false
when result was null but getTaskbarUIController() is not null, we don't setPauseUIUpdate to false. This CL ensure we always end up setting pauseUIUpdate to false so that the hotseat suggested apps show up.

Fix: 295892343
Flag: no flag
Test: verify hotseat icons don't disappear
Change-Id: Id872f3174df276cb7a4ed7f6672523d0851a11dd
2023-09-13 16:56:02 -07:00
Jagrut Desai
733d440ac1 Merge "Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar" into udc-qpr-dev 2023-09-11 21:52:08 +00:00
Jagrut Desai
6472119d4b Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar
Test: Manual
Bug: 278078311
Flag: Not needed
Change-Id: Ia963e45b3b4e6d928b6292b80b73394e76fe2325
2023-09-11 09:39:23 -07:00
Schneider Victor-tulias
9e6a845ca4 Merge "Add error handling to prevent IllegalArgumentException" into udc-qpr-dev 2023-09-11 15:30:05 +00:00
Andy Wickham
3289e4fa35 Merge "Add tests for LPH override for 3 button mode Taskbar." into udc-qpr-dev 2023-09-07 23:43:42 +00:00
Brian Isganitis
503f04f86d Register OnAttachStateChangeListener before attaching to container.
If we do the reverse, there is a change onAttach will occur before the
callback is registered and invokable (e.g. overlay window already exists
for EDU).

Test: Manual
Fix: 299335210
Flag: None
Change-Id: Ic4befe900c9582e1b01c2bc4699b431f95efa617
2023-09-07 19:15:10 +00:00
Brandon Dayauon
31679166a7 Merge "Add nullable annotation" into udc-qpr-dev 2023-09-05 16:50:38 +00:00
Schneider Victor-tulias
785a7511b6 Add error handling to prevent IllegalArgumentException
ActivityLaunchAnimator.Controller.fromView requires an instance of LaunchableView, however findViewWithBackground had no checks to return one. updated the check to make the exception less likely.

Flag: not needed
Fixes: 297564681
Test: ran launcher and launched apps
Change-Id: Iddbe55c1ff66b067f8456d058cbc60a2a698c4ae
Merged-In: Iddbe55c1ff66b067f8456d058cbc60a2a698c4ae
2023-09-05 13:58:42 +00:00
Saumya Prakash
15b0c9ea54 Merge "Ensure Gesture Nav Edu animation scales to fit different screen sizes" into udc-qpr-dev 2023-09-01 23:49:30 +00:00
Sunny Goyal
a6f089c5fc Merge "Fixes broken callbacks in RecentsAnimationCallbacks" into udc-qpr-dev 2023-09-01 23:46:02 +00:00
Tony Wickham
2677e04510 Merge "Update TaskView corner radius dynamically" into udc-qpr-dev 2023-09-01 22:41:18 +00:00
Saumya Prakash
3ca10a1325 Ensure Gesture Nav Edu animation scales to fit different screen sizes
The lottie animation in the gesture nav tutorial wasn't scaling correctly for certain devices
leading to gaps around the animation. This change uses animation's scale transformation to ensure it fits the
dimensions of the device.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 295809541
Test: Went through the tutorial on different types of devices and ensure
the animation takes up the entire screen.

Change-Id: Iadee0d0389a11aa38c9e947b4b40466acd8f4422
2023-08-31 23:08:54 +00:00
Tony Wickham
5d20ad6500 Update TaskView corner radius dynamically
Previously we set the corner radius just once when TaskView is
constructed, but this doesn't work when reusing the TaskView on a
different display that has a different corner radius.

Flag: none
Test: FullScreenDrawParamsTest
Test: kill launcher, open Overview on one display, then switch to
another display with different corner radii and ensure task radii
have updated while quick switching
Fixes: 293224095

Change-Id: I5f0697a4697400ec0e003c116774d74a945ee59e
2023-08-31 22:41:53 +00:00
Brandon Dayauon
75d8994e6f Add nullable annotation
It looks like from the stack trace that there is an NPE during the setApps() call. So adding nullable and null checking
to make sure mApps is not null.

bug: 296920692
test: presubmit
flag: n/a
Change-Id: If402c0b68db159f7a698e8e2e139d9bd5041b1c1
2023-08-31 13:59:13 -07:00
Saumya Prakash
dbd47e9f75 Merge "Remove extraneous transition from Overview to Home screen" into udc-qpr-dev 2023-08-30 23:06:15 +00:00
Andy Wickham
976876ec5b Add tests for LPH override for 3 button mode Taskbar.
Override == Launcher handles via AssistUtils instead of SysUI.

Bug: 297561673
Test: TaskbarNavButtonControllerTest + bug bash session
Change-Id: I079d4b9045d6f7d94d74e91bcabbbc182de6e17d
2023-08-30 14:45:18 -07:00
Saumya Prakash
c4cc4b13b1 Remove extraneous transition from Overview to Home screen
Previously, users used to be able to swipe down near the
bottom of the screen to leave overview. This was causing the taskbar to
animate to home while still in overview (and causing jank). Since this isn't expected behavior for
how to leave overview, this change removes that method.

Flag: N/A
Fix: 284416178
Test: Completed multiple transitions (ex. Overview to home) with 3
button nav and gesture nav. Ensured swiping down from below the recents
task does not go to the home screen while not affecting other
transitions.

Change-Id: I8cdfde71117dd947174d9c3c3a7f834fbeaddcca
2023-08-30 21:24:45 +00:00
Andreas Agvard
0b8c5fa5c7 Fixes search feature invocation issue
Fixes: 297866704
Flag: N/A
Test: Manual
Change-Id: I9647504e6c6999ce7aa17ab4acfc65d522dcd2af
2023-08-30 20:16:11 +02:00
Sunny Goyal
f98e3a2bdd Fixes broken callbacks in RecentsAnimationCallbacks
finishRecentsAnimation calls cleanup immediately which removes all the
callbacks. This prevents any callback previousy added from getting
the cancelled callback.

Bug: 298069218
Test: Verified locally
Flag: N/A
Change-Id: I54b9a4529870d771f2eff8fd7cb6f2f376f9e112
2023-08-29 16:16:48 -07:00
Vinit Nayak
1757f1b2c0 Merge "Move ending CUJ_SPLIT_SCREEN_ENTER to after we show tasks to user" into udc-qpr-dev 2023-08-29 05:02:42 +00:00
Treehugger Robot
41d269a43b Merge "Add logs around hotseat suggested apps" into udc-qpr-dev 2023-08-28 23:09:44 +00:00
Vinit Nayak
db248cf94f Move ending CUJ_SPLIT_SCREEN_ENTER to after we show tasks to user
* Previously the CUJ was ending after only the launcher side
animation was completing, before we actually made the
call into shell to launch the tasks

Test: Compiles (no baseline to test metrics/latency off of)
Bug: 285578568
Change-Id: I958e4a5265cb2fd81f2358343846385058b4465a
2023-08-28 19:03:39 +00:00
Matt Sziklay
8020100928 Merge "Specify stage and bounds for desktop split." into udc-qpr-dev 2023-08-25 20:50:59 +00:00
Andy Wickham
b2ac210120 Rename AssistUtilsBase -> AssistUtils
Bug: n/a
Test: n/a
Flag: n/a
Change-Id: Ia227b180732d0acfdc4b648885d5ce208d86ee49
2023-08-25 12:12:17 -07:00
Treehugger Robot
dddd60e84f Merge "Cap the width of the bubble bar when collapsed" into udc-qpr-dev 2023-08-25 15:07:56 +00:00
Tracy Zhou
17f50eb8a8 Merge "Ignore touch slop threshold for trackpad gestures using gesture nav" into udc-qpr-dev 2023-08-25 04:29:58 +00:00
Tracy Zhou
a2227658db Ignore touch slop threshold for trackpad gestures using gesture nav
Gesture library has a threshold for 3-finger swipes, and if it's recoginized as one, it only reports movement in one axis. There is no point waiting for it to pass the initial threshold, unlike gestures on the screen.

Bug: 291771975
Test: swipe up slowly, observe the smoothness of the gesture nav animation.
Change-Id: I0904efb1d5cd26f6566da46279d0153e19a9618c
2023-08-24 18:29:44 -07:00
Treehugger Robot
830524d883 Merge "Adding support for clearing overview suggestion state when overview is disabled" into udc-qpr-dev 2023-08-24 22:19:01 +00:00
Andy Wickham
5ed1b4001b Merge "Use new AssistUtils(Base) to override SysUI Assist invocations." into udc-qpr-dev 2023-08-24 19:36:12 +00:00
fbaron
6707ddd016 Add logs around hotseat suggested apps
Bug: 295892343
Test: n/a
Flag: no flag
Change-Id: Id6f464c8614317f58f6886734ad1f9b9709d6aa3
2023-08-24 11:15:46 -07:00
Andy Wickham
f7554ff718 Use new AssistUtils(Base) to override SysUI Assist invocations.
AssistUtils#getSysUiAssistOverrideInvocationTypes(): Sent
over SysUiProxy to request overriding these invocation types.

AssistUtils#tryStartAssistOverride(): Called by OverviewProxy
(TouchInteractionService) for previously requested overrides.
Also used within Launcher for Taskbar and QSB to override
other invocation logic. May return false to indicate that
the override was not handled, so a fallback may be desired.

Bug: 295874732
Test: Manual
Change-Id: I488f3b7da1feb2663feab5d04dfa8d605c070efb
2023-08-23 15:49:02 -07:00
Liran Binyamin
90d3a422f8 Cap the width of the bubble bar when collapsed
When the bubble bar is collapsed we now show at most 2 bubbles.

Fixes: 295020145
Test: Manual
      - Add 1 bubble to the bubble bar
      - Collapse bubble bar
      -- Observe that only that bubble is visible
      - Expand the bubble bar
      -- Observe that both that bubble and the overflow are visible
      - Add another bubble
      -- Observe that 2 bubbles are visible when collapsed
      - Add another bubble
      -- Observe that only the first 2 bubbles are visible when collapsed
Change-Id: I5f534f53eefe9a920b8b3258813d67d021c5f2a8
2023-08-23 07:40:56 +00:00
Liran Binyamin
5e7ca0c0b3 Merge "Handle touches on the bubble bar in Overview" into udc-qpr-dev 2023-08-23 07:13:16 +00:00
Treehugger Robot
7c183e2987 Merge "Taskbar: use ENABLE_HIDE_IME_CAPTION_BAR" into udc-qpr-dev 2023-08-22 22:05:32 +00:00
Sunny Goyal
52a7f05681 Adding support for clearing overview suggestion state when overview is disabled
Bug: 297037290
Test: Presubmit
Flag: N/A
Change-Id: I38f7fd38564c7c529cbd9aa5acead08b181b1b92
2023-08-22 13:46:29 -07:00
Randy Pfohl
f18305ac08 Merge changes I3394267d,Idf9ef20e into udc-qpr-dev
* changes:
  Adding some logging to track test failure in post submit
  enable testWidgets for postsubmit for long term debugging
2023-08-22 17:14:40 +00:00
Vinit Nayak
0989216160 Merge "Null out Activity in split controller" into udc-qpr-dev 2023-08-22 16:21:45 +00:00
Adrian Roos
f45ebad9be Taskbar: use ENABLE_HIDE_IME_CAPTION_BAR
With ENABLE_HIDE_IME_CAPTION_BAR, we no longer need to update the navigation bar override. This was already applied for the navigation bar, but not the task bar. Mirrors the NavigationBar.java change in
I8793db69fb846046300d5a56b3b0060138ef4cd5.

Bug: 289748734
Change-Id: I86079cb6670a2ae3b6fa883694f8af81df212408
Test: presubmit
2023-08-22 16:07:37 +00:00
Liran Binyamin
80f20a2183 Handle touches on the bubble bar in Overview
If the bubble bar is visible and we're in Overview, set the touchable region
of the Taskbar to include the bubble bar bounds.

Fixes: 290197298
Test: Manual
      - Add multiple bubbles to the bubble bar
      - Go to Overview
      - Tap on the bubble bar
      -- Observe that the bubble bar expands
      - Tap on different bubbles
      -- Observe that the bubble bar updates correctly
      - Tap outside the bubble bar
      -- Observe that the bubble bar collapses
      - Tap outside of the bubble bar again
      -- Observe that the launcher state changed and we are in Home
Change-Id: I722778ee41b50ebca57431bb303da89104d25090
2023-08-22 09:13:15 -04:00
Pat Manning
c7087e8f9f Do not consume hover events not coming from cursor for a11y.
Fix: 283041221
Test: TaplTestsTransientTaskbar
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: I95e9ded6873173ea001c82d6319716a2d48b3bad
2023-08-22 09:17:04 +00:00
Treehugger Robot
a5f24d709e Merge "Clean up RECEIVE_UNFOLD_EVENTS_FROM_SYSUI flag" into udc-qpr-dev 2023-08-22 09:09:51 +00:00