Commit Graph

6670 Commits

Author SHA1 Message Date
Ats Jenk
6965cc0d25 Merge "Control stash handle visibility directly" into main 2025-03-28 10:01:02 -07:00
Johannes Gallmann
2fb39cf4f2 Merge "Play haptic on ACTION_DOWN for 3-button-nav buttons" into main 2025-03-27 23:48:51 -07:00
Eric Sum
0f02613b08 Merge "Add ACTION_DESKTOP_MODE_EXIT_MODE_ON_LAST_WINDOW_CLOSE latency (launcher)." into main 2025-03-27 22:19:21 -07:00
Shamali Patwa
f216f3d2ce Merge "Delete the filter code as it will be provided differently in refactor" into main 2025-03-27 16:19:36 -07:00
Ats Jenk
f46ebe0378 Control stash handle visibility directly
Stash handle alpha animator was set to control the visibility of the
view. This caused issues with the state as sometimes the alpha animation
conflicted with the state of the bubble bar. And caused the handle to be
visible when the bubble bar (or handle) should not be.

Remove the ability for the handle alpha animator to manage the
visibility. We already have logic in place to ensure that the stash
handle is visible or invisible based on the state. And it is not needed
for the animator to manage it.

Bug: 392121302
Flag: com.android.wm.shell.enable_bubble_bar
Test: atest NexusLauncherRoboTests
Test: move an app to bubble, move it back to fullscreen, check that
  handle is hidden
Test: check that handle is hidden and shown when in app and opening
  notif shade
Test: check that handle is hidden and shown when in app and locking and
  unlocking device
Test: check that handle is shown when receiving bubbles in app and the
  bar stashes after showing new bubbles
Change-Id: I4af8b4fa38f63b3cbc01f9cf59e66d7fc651ab13
2025-03-27 15:23:38 -07:00
Treehugger Robot
39e6b8c4f6 Merge "[CD][Alt+Tab] Flatten Alt + Tab structure" into main 2025-03-27 14:49:55 -07:00
Shamali P
472709d9ca Delete the filter code as it will be provided differently in refactor
With the dagger update the initialization happens in constructor which
we would avoid once we work on refactor and move it into a repository
class. The list will also be fetched from a different data source, so,
makes sense to delete it at the moment.

Bug: 406324964
Flag: EXEMPT BUGFIX
Test: Not applicable as code is removed
Change-Id: Iab8bb1e94677abf9b5b882f4d3485b002faf3e0f
2025-03-27 14:15:05 -07:00
Jon Miranda
3e0f782663 Merge "Only sync app launch and taskbar when in Normal state." into main 2025-03-27 13:43:15 -07:00
Charlie Anderson
4be299ec97 Merge "Make sure predicted app ring path gets updated with latest shape" into main 2025-03-27 11:45:10 -07:00
Jon Miranda
e5f04cdde0 Only sync app launch and taskbar when in Normal state.
Bug: 319162553
Test: Launch app from overview
Flag: com.android.launcher3.sync_app_launch_with_taskbar_stash
Change-Id: Ibb0849b251d5fa2f85c61946d1834fec78ef2e6a
2025-03-27 11:36:07 -07:00
Pat Manning
9e8341ac2c Run expressive dismiss on closing task from menu.
Add default spring methods for running dismiss on a task.

Fix: 404206966
Test: Manual.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: Ic7c5b82d6b504a31193ba85b0c79dd89be344c22
2025-03-27 08:33:28 -07:00
Ajinkya Chalke
552831ed28 [CD][Alt+Tab] Flatten Alt + Tab structure
Next:
- Look into sorting tasks based on last active time.
- Will update task thumbnails as per latest UX.
- Need to ensure the logic that determines which task has focus when overview is launched.

Bug: 382769617
Test: manually run CUJs
Flag: com.android.launcher3.enable_alt_tab_kqs_flatenning
Change-Id: Ic1ab8a3a30af3d941e26439507e5a583540759e5
2025-03-27 08:52:37 +00:00
Treehugger Robot
b932dea54e Merge "Implement spring animations for running state changes." into main 2025-03-26 21:06:14 -07:00
Charlie Anderson
9a92108984 Make sure predicted app ring path gets updated with latest shape
- fixes issue where transient taskbar uses wrong predicted app shape

Bug: 388255881
Test: changing shapes and unstashing taskbar
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: Ibdc54e4df5fd4f85ed62b5a8179dba044850cbbc
2025-03-26 23:54:55 -04:00
Sunny Goyal
ca1f87d8f5 Update Launcher UI when model changes are made outside of Launcher UI
Bug: 305877212
Flag: EXEMPT bugfix
Test: Verified manually by modifing folder in taskbar
Change-Id: I513dcfbc9e4ffcd970766ce8352815571e576461
2025-03-26 13:52:53 -07:00
Eric Sum
66e5325d6f Add ACTION_DESKTOP_MODE_EXIT_MODE_ON_LAST_WINDOW_CLOSE latency (launcher).
This measures the delay from when the user closes or minimizes
the last open window in desktop mode until the animation to exit
desktop mode draws its first frame.

Flag: EXEMPT metric change

Bug: 390544490
Test: Run `statsd_testdrive 306` and ensure that latency metric is
      reported.
Change-Id: If4923b50feade20ba74560ed7b8d14ea2bb6f71e
2025-03-26 10:41:39 -07:00
Alex Chau
66ac9dc459 Merge "Revert "Remove unnecessary call to RecentsView.reset when switching from any non-overview state."" into main 2025-03-26 10:22:42 -07:00
Jon Miranda
333a9bd983 Merge "Prevent NPE when syncing app launch with taskbar stash." into main 2025-03-26 10:21:58 -07:00
Jagrut Desai
7a6b2a39f6 Merge "Fix Taskbar Flicker with Recents or Running Apps Present" into main 2025-03-26 08:59:05 -07:00
Johannes Gallmann
528bf70f61 Play haptic on ACTION_DOWN for 3-button-nav buttons
Bug: 393959400
Test: Manual, i.e. verified that haptic happens on ACTION_DOWN and on
      long press (except for back button which doesn't have a haptic on
      long press). Also verified that Talkback works.
Flag: EXEMPT bugfix
Change-Id: Ieb1892d69268d0bfba0ead9ec38c8ee9843addef
2025-03-26 16:44:45 +01:00
Alex Chau
fc5a07e40b Revert "Remove unnecessary call to RecentsView.reset when switching from any non-overview state."
This reverts commit 162a85e777.

Reason for revert: b/406430367

Change-Id: I1be60513d8f034d6aab9489a95f98a7a0f16d26d
2025-03-26 07:41:36 -07:00
Treehugger Robot
dd7d89d7e1 Merge "Account for Recents Scale when computing dismiss length to take task off screen." into main 2025-03-26 05:09:07 -07:00
Treehugger Robot
b4a37aed36 Merge "Remove unnecessary call to RecentsView.reset when switching from any non-overview state." into main 2025-03-26 00:12:42 -07:00
Jon Miranda
9bf65787e9 Prevent NPE when syncing app launch with taskbar stash.
This can happen because when callback is ran after onDestroy.
We call the runnable as part of the cleanup process to avoid
a leak.

Bug: 319162553
Fixes: 405316024
Test: Launch an app, note the two animations are synced
      Verified by locally introducing a startDelay (since otherwise it is hard to tell)
Flag: com.android.launcher3.sync_app_launch_with_taskbar_stash
Change-Id: I961b9a185b2751a8a908d1a7b2cbfdb8bfe0b8f9
2025-03-25 15:18:03 -07:00
Treehugger Robot
be8869060d Merge "Use up-to-date hover tooltip text for recents." into main 2025-03-25 14:28:16 -07:00
Jagrut Desai
64d448a8db Fix Taskbar Flicker with Recents or Running Apps Present
Test: Manual, Presubmit
Bug: 404772481
Flag: EXEMPT bugfix
Change-Id: If3b87474e6e85fabf24a42ac2a3e4ac6a19a4358
2025-03-25 14:16:12 -07:00
Brian Isganitis
409ea18bf8 Merge "Perform system actions on focused display." into main 2025-03-25 12:28:30 -07:00
Schneider Victor-Tulias
848b743c20 Close the Recents window onNewIntent
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: Ied8a1ce6bb5b3a0c371ce857fe6df9d94fd04b40
2025-03-25 08:41:39 -07:00
Pat Manning
ac5027dbf8 Account for Recents Scale when computing dismiss length to take task off screen.
Fix: 406213321
Test: Manual.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: If0e79fc58a1f094071b98587e3f57af4af64c524
2025-03-25 14:41:27 +00:00
vinayjoglekar
162a85e777 Remove unnecessary call to RecentsView.reset when switching from any non-overview state.
We were checking whether recents is visible or not while opening all
apps and calling RecentsView#reset. Since Recents is not visible, we
were always calling reset which was making additional blur. Adding check
here of what current state is, will reduce these calls.

Added perfetto traces comparison here

https://drive.google.com/drive/folders/146K_4WLaOGQcZ1gsuhCFlOCzfZ-mJBw8?resourcekey=0-r1-NnNtYGH88d8DGEvnXZg&usp=sharing

Bug: 404647629
Test: Manual. Launcher home -> all apps.
Flag: EXEMPT bugfix
Change-Id: If0e31638adee50d36974abd7a4c809e3747f37a0
2025-03-25 03:40:18 -07:00
Shamali Patwa
bb04b1135f Merge "Revert "Improve reliability of cleanup done in onDestroy."" into main 2025-03-24 13:06:27 -07:00
Treehugger Robot
69998a8c77 Merge "Using Choreographer for getting refreshrate instead of display manager" into main 2025-03-24 11:10:42 -07:00
Sunny Goyal
836a832bfe Using Choreographer for getting refreshrate instead of display manager
Bug: 404582684
Flag: EXEMPT bugfix
Test: Manually verified that values are same as before even after changing refresh rate `adb shell settings put system peak_refresh_rate [30/60/90/120]`
Change-Id: I5d5468d8ab81a9a5e8d8cd67a9097423b750edb3
2025-03-24 08:51:53 -07:00
Shamali Patwa
cfcb27aa9d Revert "Improve reliability of cleanup done in onDestroy."
This reverts commit 9cf28d1772.

Reason for revert: Fix in ag/32425180

Change-Id: I714665944384db6f68634de529272e618bccdad9
2025-03-24 08:46:36 -07:00
Treehugger Robot
f67f97ade2 Merge "Fix action buttons visibility in handheld devices with blur enabled(1/n)" into main 2025-03-24 08:05:04 -07:00
Treehugger Robot
1d5064b8dc Merge "Add debug logging for task view touch controllers." into main 2025-03-24 06:17:26 -07:00
vinayjoglekar
7d27140a59 Fix action buttons visibility in handheld devices with blur enabled(1/n)
Added scrim in overview over blur.

Bug: 404479758
Test: Manual. Enter overview from home with and without tasks in handheld devices.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: If8cb37099f2e2b1fa8bed1611ed359b49f255d64
2025-03-24 18:10:18 +05:30
Treehugger Robot
43b4273e91 Merge "[Memory Leak] Avoid spamming DragLayer's run queue" into main 2025-03-21 22:54:24 -07:00
Sukesh Ram
54f23ff654 Fix Pinning Animation
Fix Pinning Animation.

Flag: EXEMPT not adding new behavior
Bug: 405469510
Test: m
Change-Id: Iabc580031495f39902cb4d718ab12a7362c07d13
2025-03-21 17:18:45 -07:00
Fengjiang Li
8c7805b67a [Memory Leak] Avoid spamming DragLayer's run queue
Avoid adding duplicated ViewTreeObserver#addOnDrawListener from DepthController

Fix: 405158421
Flag: NONE - released code
Test: manual - presubmit
Change-Id: Ib59c130667c5c0a012de3205d11c8de1d6de3903
2025-03-21 13:40:17 -07:00
Treehugger Robot
500698152c Merge "Hide scroll arrows from Alt+Tab UI" into main 2025-03-21 11:41:55 -07:00
Saumya Prakash
cfe62a68d2 Merge "Ensure back button shows up in Simple View for SUW" into main 2025-03-21 10:41:59 -07:00
Treehugger Robot
a75e779ee8 Merge "[CD Taskbar] Bypass binder calls for TaskbarManager#getDefaultDisplayId()" into main 2025-03-20 16:25:34 -07:00
Treehugger Robot
fe15021226 Merge "Fix back button not reacting to accessibility actions (2)" into main 2025-03-20 15:43:52 -07:00
Li Lin
ce62f1d47a Merge "Add action performers for Growth Framework." into main 2025-03-20 14:13:14 -07:00
Sukesh Ram
602874bb51 [CD Taskbar] Bypass binder calls for TaskbarManager#getDefaultDisplayId()
Calls to TaskbarManager#getDefaultDisplay() were making binder calls each time, which caused a crash in cases where binder is blocked. Now, I cache the default displayId avoid these calls.

Flag: EXEMPT not adding new behavior
Bug: 400606685
Test: m
Change-Id: I4a0c0d0c99efb137119b2299d3259541379a6bb6
2025-03-20 13:57:35 -07:00
Jagrut Desai
bda2a6fb10 Merge "Fix 3-button nav diplacement on lockscreen" into main 2025-03-20 13:49:54 -07:00
Mykola Podolian
c12d67c4e0 Merge "Drag and drop from the search view on the overview screen." into main 2025-03-20 13:40:29 -07:00
Randy Pfohl
ccab1b83e8 Merge "Small refactor to displayDecor listeners" into main 2025-03-20 13:31:08 -07:00
Treehugger Robot
00310cd372 Merge "Get top task per display from TopTaskTracker" into main 2025-03-20 12:19:06 -07:00