Commit Graph

10014 Commits

Author SHA1 Message Date
Tracy Zhou
5bd641e3f5 Merge "Fix task bar crashing in small screen with task bar / nav bar unification on" into main 2023-10-09 20:26:25 +00:00
Alex Chau
461b65fa4e Merge "Use mock TaskStackChangeListeners in RecentsModelTest" into main 2023-10-09 16:39:13 +00:00
Vinit Nayak
b95ee09a69 Merge "Dismiss split selection for workspace long-press" into main 2023-10-09 16:13:52 +00:00
Alex Chau
a0c149fc8d Use mock TaskStackChangeListeners in RecentsModelTest
- Also unregistered TaskStackChangeListeners and TaskIconCache listeners in RecentsModel.close(), so clean-up will happen if it's in a SandboxContext

Bug: 303259446
Test: RecentsModelTest
Change-Id: I438a499be8e737de7df79b670ecfd26f0ee70662
2023-10-09 14:31:58 +01:00
Vinit Nayak
4f850a42a0 Merge changes I9e56ddbe,I8767deea into main
* changes:
  Disallow taskbar long click when in split selection state
  Add method to determine if launcher is in split selection state
2023-10-07 00:20:24 +00:00
Vinit Nayak
01849e4c63 Merge "Null reference to activity as runnable back handler" into main 2023-10-07 00:15:54 +00:00
Jagrut Desai
f56bfabaa4 Merge "Change Taskbar Window height logic for taskbar pinning." into main 2023-10-06 23:33:30 +00:00
Vinit Nayak
d0fc718a0a Dismiss split selection for workspace long-press
Bug: 295426148
Test: Enter split contextual from homescreen,
long-press on empty space, split gets dismissed
Flag: ENABLE_SPLIT_WORKSPACE_TO_WORKSPACE

Change-Id: I3a893bea7b22645fe60c65c4c5ab8c2087d769da
2023-10-06 16:05:54 -07:00
Winson Chung
36a9c19487 Merge "Defer nav handle action until after the recents transition is complete" into main 2023-10-06 22:47:32 +00:00
Ats Jenk
186e60e94c Merge changes from topic "overview-to-desktop" into main
* changes:
  Account for freeform tasks being visible in overview
  Enable live tile for desktop
2023-10-06 22:05:06 +00:00
Vinit Nayak
114293fb56 Disallow taskbar long click when in split selection state
* This is specifically when contextual is initiated on home
screen and then user swipes up into overview.
* We no longer want to rely on LauncherStates for split specific
management

Bug: 295981634
Test: Start split on home, swipe up to overview, long press on
taskbar app icons, nothing happens
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE

Change-Id: I9e56ddbe1f536be779d4848769a993724d5395da
2023-10-06 14:42:22 -07:00
Vinit Nayak
1525cd7269 Add method to determine if launcher is in split selection state
* Available for both launcher and taskbar via
ActivityContext

Bug: 295981634
Change-Id: I8767deea0b2432da3047209037874c966b83c3b3
2023-10-06 14:40:49 -07:00
Brian Isganitis
447b09057a Merge "Prevent NPE from changing all apps visibility in shared state." into main 2023-10-06 20:59:33 +00:00
Brian Isganitis
f79785065b Merge "Have dragged search items return to All Apps icon if cancelled." into main 2023-10-06 20:44:06 +00:00
Schneider Victor-tulias
8265d04e0a Merge "Fix NullPointerException in OverviewInputConsumer" into main 2023-10-06 20:30:39 +00:00
Vinit Nayak
4a926d3bfd Null reference to activity as runnable back handler
Bug: 302551868
Change-Id: Ia21c5696ef58c113a8d038cb0f8dfef413d991de
2023-10-06 11:15:14 -07:00
Sunny Goyal
b34296face Merge "Making AsyncClockEventDelegate a singleton" into main 2023-10-06 16:58:41 +00:00
Vinit Nayak
0f9d9a825f Merge "Null reference to split callback" into main 2023-10-06 14:21:18 +00:00
Winson Chung
4f17c97d03 Defer nav handle action until after the recents transition is complete
Bug: 303078360
Test: Force delay in finishing recents transition and verify with bug steps
Change-Id: I2021cc291204261de56ef9c912d8b5935059c7fb
Signed-off-by: Winson Chung <winsonc@google.com>
2023-10-06 03:42:35 +00:00
Vinit Nayak
a7b491e35e Null reference to split callback
Bug: 302551868
Test: Ran atest NexusLauncherTests:com.android.quickstep.TaplTestsSplitscreen
which caused some regressions last time. Passed locally

Change-Id: I94b28296cf12c5087ee3e878352c057d1d1a73de
2023-10-05 17:22:46 -07:00
Tracy Zhou
0812a9495c Fix task bar crashing in small screen with task bar / nav bar unification on
A few params are not set in device profile when task bar (in large screen) is not present, and hence the calculation below causes a crash

Test: Make sure that it doesn't crash in small screen gesture nav mode
Bug: 274517647
Change-Id: I3a61a64ac931fac4aee1a3c40ed54ab9ded298a7
2023-10-05 16:40:48 -07:00
Tracy Zhou
528356e744 Merge "Fix task bar crash in gesture nav mode with task bar / nav bar unification on" into main 2023-10-05 23:38:13 +00:00
Ats Jenk
0927251a7b Account for freeform tasks being visible in overview
When live tiles are enabled, desktop tasks remain visible while in
overview. This is due to tasks remaining in running state.
Update DesktopVsibilityController to handle this case. If in freeform,
it should return that freeform tasks are not visible to any callers.
Also move launcher state handling to inside the controller so we don't
have this handling in other places.
Introduce separate handling of background and overview state. In
background state we want to keep the freeform task visibility state
matching the actualy visibility. And show the launcher views and resume
the activity.
In overview state we want to override the freeform visibility and show
launcher views.

Bug: 297590571
Test: open an app on desktop
      - swipe up for taskbar multiple times, observe that we remain on
        desktop
      - swipe up for taskbar and launch an app, observe it launches on
        desktop
      - swipe up to recents, observe that recents UI is shown and task
        remains running
      - swipe up to recents, launch desktop again from recents
      - swipe up to recents, launch another fullscreen app from recents
      - swipe up from a fullscreen, launch desktop from recents
Change-Id: Id5cef7111da6929c8435ef9d221db1abd8361b15
2023-10-05 15:53:42 -07:00
Stefan Andonian
9acb884c90 Merge "Permanently provide functionality for LauncherPref items that don't need to be migrated, but are boot aware." into main 2023-10-05 21:14:24 +00:00
Sunny Goyal
df178f5320 Making AsyncClockEventDelegate a singleton
RemoteViews can get inflated after the activity is destroyed during
async inflation. This can cause the delegate to loose the destroy event.

Bug: 303686041
Test: Presubmit
Flag: N/A
Change-Id: Iecb9d69d95b2c924e1189ac15515fac327d8f44d
2023-10-05 13:23:58 -07:00
Stefan Andonian
23f869f0f0 Merge "Don't show FloatingIconView during Back to Home Animation when animations are disabled." into main 2023-10-05 20:22:49 +00:00
Tony Wickham
d7c43cab9b Merge "Fix gestures for exclude-from-recents + translucent tasks" into udc-qpr-dev am: cf596d4178 am: 3809c0a278
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24840504

Change-Id: Id81adcfc07d2c6a01655b4d88df524764b38e5fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 19:37:58 +00:00
Tony Wickham
3809c0a278 Merge "Fix gestures for exclude-from-recents + translucent tasks" into udc-qpr-dev am: cf596d4178
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24840504

Change-Id: I4a2cc03328d09757ff1a5454138b61794a5cadee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 19:05:04 +00:00
Vinit Nayak
c939620fd1 Merge changes Id9a74edd,Iab1f1e99 into main
* changes:
  Support fullscreen split selection launch for contextual
  Add icon when launching widgets in split
2023-10-05 18:31:15 +00:00
Tony Wickham
cf596d4178 Merge "Fix gestures for exclude-from-recents + translucent tasks" into udc-qpr-dev 2023-10-05 18:16:40 +00:00
Stefan Andonian
17ee527e15 Don't show FloatingIconView during Back to Home Animation when animations are disabled.
Bug: 235915161
Test: Reproduced the issue locally, then verified that the fix worked as
desired without introducing unwanted side effects.

Change-Id: I3db3b2ddbd34a2ef19eae10282758df32c2d5b3f
2023-10-05 17:44:12 +00:00
Anushree Ganjam
2fbb34fc7b Developer options should reflect the correct DeviceConfig value for ReleaseFlag. am: 13517070d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24945015

Change-Id: Ic0b22dd740409cafc3a4224e3dba3ed7ac60516f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 16:09:05 +00:00
Alex Chau
2ca7481b04 Merge "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag" into main 2023-10-05 15:40:17 +00:00
Schneider Victor-tulias
6c58b1db66 Fix NullPointerException in OverviewInputConsumer
OverviewInputConsumer should wait until the root view is attached to the window before using the ViewRootImpl.

Flag: not needed
Fixes: 303117246
Test: used the OverviewInputConsumer with the keyboard
Change-Id: I78c23cb146f35cdb1f4b87f42726d6260d4a2b87
2023-10-05 10:05:47 -04:00
Uwais Ashraf
cfaba6e814 Merge "Align empty recents message+icon to center of View." into main 2023-10-05 09:00:28 +00:00
Tracy Zhou
27d7769000 Fix task bar crash in gesture nav mode with task bar / nav bar unification on
a11yButton is reserved for 3-button mode so it can be null. Also TaskbarNavLayoutter is used for large screen both in gesture nav and 3-button mode, so need to check isContextualButtonShowing to add contextual buttons

Fixes: 300849078
Test: Make sure that it doesn't crash in large screen gesture nav mode
Change-Id: I9d0694b7f4c95461f24efb2af1af905e68e3cd8d
2023-10-04 20:17:23 -07:00
Anushree Ganjam
13517070d8 Developer options should reflect the correct DeviceConfig value for ReleaseFlag.
Before this change : When a ReleaseFlag is turned on from server side or
set in DeviceConfig, developer options shows the flag is off.

After this change : When a ReleaseFlag is turned on from server side or
set in DeviceConfig, developer options shows the flag is on.

This change doesn't reflect the DeviceConfig value changes done using
`adb shell device_config put` unless launcher is restarted.

Bug: 297202824
Test: Manual
Flag: NA

Change-Id: I5d83207cf454c60278fd02e59199207e855d51a8
Merged-In: I5d83207cf454c60278fd02e59199207e855d51a8
(cherry picked from commit 9eb68bb7cf)
2023-10-05 01:45:32 +00:00
Stefan Andonian
54495f3018 Permanently provide functionality for LauncherPref items that don't need
to be migrated, but are boot aware.

Bug: 251502424
Test: Tested that Migration works as expected, as well as shared
preference information that doesn't need to be migrated. Also sanity
tested phone in general.

Change-Id: Ie8460e360856cbe20a7770b1747f75c7154759ab
2023-10-04 23:32:58 +00:00
Vinit Nayak
ae3c5749ef Support fullscreen split selection launch for contextual
* Migrate animating split placeholder to fullscreen into
SplitAnimationController from RecentsView to consolidate
* Reset state from RecentsView via a callback

Fixes: 295457117
Test: Tapping on placeholder in overview and home works
as expected

Change-Id: Id9a74eddc134a0470110845b90729c05193a1f93
2023-10-04 16:05:03 -07:00
Vinit Nayak
a6bf642d5a Add icon when launching widgets in split
* Load the icon in the BG (though it should be
cached), then run the animation in the FG

Test: Initiating split contextually with a widget
shows icon
Bug: 293935354
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE

Change-Id: Iab1f1e9965479b0f84c74c2a5ae6e272b9a5db3a
2023-10-04 16:05:02 -07:00
Anushree Ganjam
9a809d9121 Merge "Developer options should reflect the correct DeviceConfig value for ReleaseFlag." into main 2023-10-04 22:14:41 +00:00
Tony Wickham
94a0a58b37 Fix gestures for exclude-from-recents + translucent tasks
- If task is translucent and excluded, fade out as swipe up
  - Fade back in when re-launching live tile
- Ignore excluded tasks if there is another visible task,
  and use that underlying task during gesture instead.

Fixes: 299351175
Fixes: 300297333
Fixes: 302672319

Test: Invoke translucent + excluded app (e.g. expanded Volume
dialog) over another app, swipe to overview, quick switch, home

Change-Id: I5740afc4bf561d1a264bd132863ffc15f27d2b20
2023-10-04 20:23:07 +00:00
Brian Isganitis
8f3342967c Prevent NPE from changing all apps visibility in shared state.
Also setting to false in onCloseBegin since this is an earlier signal
than onClosed.

Test: Manual (regular + recreate by toggling dark theme)
Fix: 301705545
Flag: No
Change-Id: Ifb356d4f1346f7af15a375ad7b88d2d8be227328
2023-10-04 15:32:37 -04:00
Brian Isganitis
d5684000f9 Have dragged search items return to All Apps icon if cancelled.
Test: Manual
Fix: 303302706
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: Id2a06b38a987566b8e334125a050196a2845921e
2023-10-04 15:03:59 -04:00
Anushree Ganjam
9eb68bb7cf Developer options should reflect the correct DeviceConfig value for ReleaseFlag.
Before this change : When a ReleaseFlag is turned on from server side or
set in DeviceConfig, developer options shows the flag is off.

After this change : When a ReleaseFlag is turned on from server side or
set in DeviceConfig, developer options shows the flag is on.

This change doesn't reflect the DeviceConfig value changes done using
`adb shell device_config put` unless launcher is restarted.

Bug: 297202824
Test: Manual
Flag: NA

Change-Id: I5d83207cf454c60278fd02e59199207e855d51a8
2023-10-04 11:43:58 -07:00
Uwais Ashraf
e61ad56098 Align empty recents message+icon to center of View.
Seems like it was previously aligned to center of task which doesn't always look good.

Screenshots:
Handheld before - https://screenshot.googleplex.com/6GmqhTjUhUpwwBs
Handheld after - https://screenshot.googleplex.com/3QMYCQaS6USMQYy

Tablet before - https://screenshot.googleplex.com/7tsERFGVsa6QSNY
Tablet after - https://screenshot.googleplex.com/8itDgQ2jDTHk463

Unfolded before - https://screenshot.googleplex.com/AJaqC9LqP2Dwfz2
Unfolded after - https://screenshot.googleplex.com/8aaa7ZhemqHXHRh

Fix: 299100892
Test: OverviewEmptyMessageImageTest and observed on tablet, handheld and unfolded.
Change-Id: I538d25e5a98e25351e71718de3ca572fd00438ad
2023-10-04 14:57:11 +00:00
Tracy Zhou
b1122a4ad3 Merge "Fix some merge issues in repositioning contextual buttons for taskbar/navbar unification" into main 2023-10-04 04:00:24 +00:00
Jeremy Sim
4986aa85e5 Merge "App Pairs: App pairs now save with automatic default name and custom split ratios" into main 2023-10-04 00:06:57 +00:00
Jagrut Desai
0dce287a6c Change Taskbar Window height logic for taskbar pinning.
- Breakout CL part 6
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl makes default taskbar window height to be transient when the taskbar pinning flag is on, so we don't see taskbar window cutoff during animation.

Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I37e8ad0f2c4d144476828f101019dcacdea7acb2
2023-10-03 16:53:32 -07:00
Ats Jenk
eb143041fa Enable live tile for desktop
Remove logic to always screenshot desktop tasks.

Bug: 297590571
Test: swipe up to recents when on desktop
Change-Id: Ie6e95f711e1721f66a2ed6081fe99d941c18b393
2023-10-03 13:52:46 -07:00