Commit Graph

18285 Commits

Author SHA1 Message Date
Pat Manning
5aa23d41dd Focus a task by default when using keyboard to go to overview.
Fix: 322898816
Test: TaplTestsQuickstep.java
Flag: None.
Change-Id: I6d4b0ca6593ed2ac7c7d8793954c36e55b5978de
2024-02-23 12:22:06 +00:00
bvineeth
fdf6df3226 Add tags for CUJ_TASKBAR_EXPAND/COLLAPSE
Test: Checked traces
Flag: None
Bug: b/263362887
Change-Id: I28652b0629b8033fe931809bacceeede3c36ea93
2024-02-23 03:27:54 +00:00
Vineeth Bhende
510886fc14 Merge "Fix taskbar_expand/collapse jank monitor" into main 2024-02-23 03:01:58 +00:00
Bill Yi
697cb554a6 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-02-23 00:10:50 +00:00
Treehugger Robot
b6cbb2a419 Merge "Make getTaskSize actaully a getter that does not modify member variables" into main 2024-02-22 23:03:03 +00:00
Sunny Goyal
1d6f76f811 Merge "Adding support for async view inflation" into main 2024-02-22 22:38:41 +00:00
Anushree Ganjam
cc971f67f5 Merge "Remove Unused parts of LauncherPrefs causing cyclical dependency." into main 2024-02-22 21:53:21 +00:00
Sunny Goyal
72a74669e7 Adding support for async view inflation
Bug: 318539160
Test: atest AsyncBindingTest; atest ItemInflaterTest
Flag: aconfig enable_workspace_inflation DEVELOPMENT
Change-Id: I77a373db7a5805f68f4b8cbfa9b586b5674252de
2024-02-22 10:58:48 -08:00
Saumya Prakash
502f7b94f0 Merge "Increase taskbar edu Done button size to meet accessibility requirements." into main 2024-02-22 18:40:35 +00:00
Sebastián Franco
6a55a7b4b8 Merge "Remove the initialize method from setUp since is now on being called on the super method." into main 2024-02-22 18:38:50 +00:00
Jagrut Desai
08a4e68bae Merge "Handle SystemGestureRegion in TaskbarDragLayer" into main 2024-02-22 17:55:28 +00:00
Sam Cackett
becd601c68 Merge "Translate IconMenu to top / left of thumbnail view" into main 2024-02-22 08:59:42 +00:00
Stefan Andonian
21ab3b979b Remove Unused parts of LauncherPrefs causing cyclical dependency.
This "migration" feature was planned as an effort to reduce latency upon
startup. That being said, now that there is a loading screen being added
to pixel startup time, it doesn't make sense to perform a risky data
migration just to save a 100ms or so of startup time. Therefore, I am
removing this code as a clean up effort to make LauncherPrefs simpler.
Also, there was a cyclical dependency introduced in b/324670265 that
makes this cleanup effort especially worthwhile, as it resolves a bug
for other developers.

Bug: 324670265
Test: Installed this on a device and tested that nothing was broken.
Flag: NA
Change-Id: I81df710057d80fbd071bc26a53cb191d453e7dee
2024-02-22 05:50:15 +00:00
bvineeth
4d38783106 Fix taskbar_expand/collapse jank monitor
Issue : Currently opposite jank is being reported taskbar expand and taskbar collapse


Test: Checked the trace
Fixes: b/326333977
Flag: None
Change-Id: Ib5adeb33506717ee28d669c5d46557087ebf7e60
2024-02-22 04:12:45 +00:00
Treehugger Robot
a5e8751f0d Merge "Merging multiple implementations of CancellableTask" into main 2024-02-22 02:54:30 +00:00
Sebastian Franco
51231ee5c2 Remove the initialize method from setUp since is now on being called on the super method.
Bug: 324261526
Test: most Tapl test
Flag: NA
Change-Id: Icbf9883613069101a3c8428e8e3b02b1eb01dcd0
2024-02-21 17:24:12 -08:00
Bill Yi
def24aa88d Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I543d305f3f7587d6459fb1a926872bea5cf6ab1d
2024-02-21 16:45:43 -08:00
Saumya Prakash
0e126d5550 Increase taskbar edu Done button size to meet accessibility requirements.
Touch targets have to meet a minimum of 48 dp to meet accessibility
requirements. The Done button in taskbar education was previously too short.

Fixes: 320600718
Test: Manual
Flag: N/A
Change-Id: I5fae302b82585e9793d7ede42dbcc6e6395254da
2024-02-21 22:21:49 +00:00
Jagrut Desai
c8a5176bfc Handle SystemGestureRegion in TaskbarDragLayer
- Currently user can tap on taskbar icons when in persitent mode when a popup is visible on screen.
we are making it so that touch event is not performed at view level and get dismissed before at drag layer.

Test: Presubmit, Manual
Bug: 320229858
Flag: NONE
Change-Id: I9a76faa0e282317d808ba0f55b49741dc7b750a3
2024-02-21 11:35:29 -08:00
Vadim Tryshev
67c85d8fc2 Demote unstable test testQuickSwitchFromApp from presubmit
Bug: 325659406
Test: presubmit
Flag: N/A
Change-Id: I997fb09c93400a706c08235ad6d1a6dd910398fd
2024-02-21 10:49:06 -08:00
Brandon Dayauon
0fa9113028 Merge "Add home settings toggle featureflag for enablingTwoLineText" into main 2024-02-21 18:14:21 +00:00
Vineeth Bhende
18f3f63a2c Merge "Add tag for cuj OPEN_ALL_APPS when swiping to open all apps" into main 2024-02-21 02:25:19 +00:00
Vinit Nayak
2b031727f0 Merge "Log split metrics through individual sessions" into main 2024-02-21 00:20:44 +00:00
samcackett
6eaa509481 Translate IconMenu to top / left of thumbnail view
When splitting a task that is already part of a split app pair from the
 TaskBar, with the enableOverviewIconMenu feature enabled, position the
 IconMenu to the left of a leftRightSplitApp pair, or the top of a
 topBottomSplitApp pair

Fixes: 317001670
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Change-Id: I4740d7c96635ee9542f7061938baf6fbf2ca01d4
2024-02-20 16:05:10 +00:00
Alex Chau
5e8811e126 Make getTaskSize actaully a getter that does not modify member variables
- This is a follow-up of ag/26255150 to clean-up usage of getTaskSize
- Removed getTasksize and updatePivots in onLayout, as updateSizeAndPaddings has covered all scenarios
- mLastComputedTaskSize will only be updated from updateSizeAndPaddings, with minor refactoring on how mTaskWidh/mTaskHeight/padding are calculated

Bug: 325314248
Test: Manual on home/app->overview, rotations, fold/unfold etc.
Flag: None
Change-Id: I031a36e5e065a28070fb3f7f146978279f7d8886
2024-02-20 13:30:48 +00:00
Alex Chau
d564a9d26c Merge "Update pivots after taskSize is updated" into main 2024-02-20 11:57:49 +00:00
Alex Chau
a6def81654 Merge "Don't run parallax animation for grid overview" into main 2024-02-20 11:35:36 +00:00
Alex Chau
ec6f0bad38 Don't run parallax animation for grid overview
Bug: 286821534
Test: manual
Flag: None
Change-Id: I08c77ce5d538ee07374e9f88fc4d00cc8165f28b
2024-02-20 11:34:58 +00:00
Treehugger Robot
89170d6fab Merge "Update color of Overview ShareTarget scrim" into main 2024-02-19 14:17:47 +00:00
Alex Chau
51c09ed13e Merge "Avoid resetting RecentsAnimationController and RemoteTargetHandle without clear ownership" into main 2024-02-19 12:00:56 +00:00
Alex Chau
6ff4c1f5a4 Merge "Always run animateClose when closing TaskMenuView" into main 2024-02-19 10:27:32 +00:00
Riddle Hsu
5fbbbcef3a Merge "Make recents activity follow the orientation of activity behind" into main 2024-02-19 07:52:09 +00:00
Anushree Ganjam
9ea1724245 Merge "Add InteractionJankMonitor for backpress from allapps CUJ_LAUNCHER_CLOSE_ALL_APPS_BACK." into main 2024-02-17 00:23:11 +00:00
Anushree Ganjam
06c98fd685 Add InteractionJankMonitor for backpress from allapps CUJ_LAUNCHER_CLOSE_ALL_APPS_BACK.
Jank CUJ's cannot be added in LauncherState since it's aosp code.
Introduced `onBackPressComplete` method so the LauncherState subclasses can override this method to get back press complete call after back press animation is successful. Here we can add necessary jank CUJ's.

Perfetto trace : https://ui.perfetto.dev/#!/?s=3fc6eed848bdd692949ddb3afbdcdf04a7ef0d99cb9a83804ce9e1840492ed66

Test: Perfetto trace. https://screenshot.googleplex.com/5yviY5LxKusnKvF.png
Bug: 319132905
Flag: NA. Adding jank CUJ.

Change-Id: Ia418f06cb76fe4e14c2032c62c2250e9143442f2
2024-02-16 14:35:20 -08:00
Jon @
d3693424f5 Merge "Notify home is visible when launching a translucent app." into main 2024-02-16 21:43:28 +00:00
Treehugger Robot
821715127d Merge "Prevent taskbar reset animation from playing when gesture is in progress." into main 2024-02-16 21:36:59 +00:00
Ats Jenk
ca99653959 Merge "Create bubbles input consumer before nav bar long press" into main 2024-02-16 19:52:08 +00:00
Alex Chau
c302daec2f Avoid resetting RecentsAnimationController and RemoteTargetHandle without clear ownership
- RecentsView only see itself owning RecentsAnimationController and RemoteTargetHandle after live tile is enabled via onGestureAnimationEnd to RECENTS
- RecentsView will finish recents animation if it owns RecentsAnimationController and is leaving RecentsView
- Otherwise, reset() would not reset RecentsAnimationController or RemoteTargetHandle
- Added logging for interaction between gesture and RecentsView to aid future debugging

Bug: 288557298
Test: manual
Flag: None
Change-Id: Icdcb91b98b2bb5d6d3bc30070f533ea79915bc09
2024-02-16 19:23:08 +00:00
Vadim Tryshev
8d657cb911 Merge "Adding screen recording for FallbackRecentsTest.testOverview" into main 2024-02-16 18:07:33 +00:00
Tracy Zhou
e34a1b647d Merge "Update phone gesture nav test in NavButtonLayoutFactoryTest" into main 2024-02-16 17:50:18 +00:00
Alex Chau
1ae5e169b0 Update pivots after taskSize is updated
- For case that there are no TaskViews, onLayout is not called, so updatePivots isn't called when folding

Fix: 325314248
Test: Manual
Flag: None
Change-Id: If7377f2e4fcbe4a874f823bb99b0b197cd5f7b87
2024-02-16 15:23:35 +00:00
Alex Chau
60ad90e519 Always run animateClose when closing TaskMenuView
- This avoid diverging code path when animation is off
- Also made sure menuTranslationX and Y always reset when not needed
- Also remove AnimatedVectorDrawable in favour of scale animation in code, as AnimatedVectorDrawable doesn't work well when animation is off

Bug: 319086207
Test: OverviewMenuImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: I4a18cf4aac3237031095c2600c777b6c4c3e518f
2024-02-16 14:58:14 +00:00
bvineeth
e8bdf16b65 Add tag for cuj OPEN_ALL_APPS when swiping to open all apps
Test: Checked trace
Bug: b/270128536
Flag: None
Change-Id: I0d5f562fc156423af2b5ce7e54e1bff54a522aa6
2024-02-16 10:41:15 +00:00
Tracy Zhou
b263e2d94a Update phone gesture nav test in NavButtonLayoutFactoryTest
I think the test was written in the first version of NavButtonLayoutFactoryTest where phone gesture nav layouter didn't exist (verified with the revision history), hence updating the logic here

Bug: 324989451
Test atest NavButtonLayoutFactoryTest

Change-Id: I325a5d47db86add8d094e61b1de923f50a2db309
2024-02-15 23:42:21 -08:00
Vineeth Bhende
e2a76cee2b Merge "Add CUJ-LAUNCHER_OPEN_ALL_APPS instrumentation from taskbar" into main 2024-02-16 04:02:24 +00:00
Ikram Gabiyev
1979abe353 Merge "Move IPip and IPipAnimationListener to common" into main 2024-02-15 23:42:51 +00:00
Vadim Tryshev
bd85c258aa Merge "Adding screen record for for the case when quick switch gesture doesn't do anything" into main 2024-02-15 23:31:41 +00:00
Jon Miranda
26447ddc98 Notify home is visible when launching a translucent app.
To fix the taskbar stash delay when launching an app, ag/18875100
sets the state so that the taskbar stashes immediately after
app is launched.

Since we cannot know if the app is translucent at that point,
we have to check after the animation is started so we can update the
launcher visibility state.

Bug: 314792981
Flag: ACONFIG ENABLE_HOME_TRANSITION_LISTENER TRUNKFOOD
Test: HomeObserverTest
Change-Id: Ifc3a6559d7a8c6fda4c08a0fc2d6791da46b38d6
2024-02-15 13:55:42 -08:00
Vadim Tryshev
6999ed124d Adding screen record for for the case when quick switch gesture doesn't do anything
Bug: 313464374
Test: presubmit
Flag: N/A
Change-Id: I08e3f964cc0fbaebe4b077f08145dc54b967f936
2024-02-15 13:22:27 -08:00
Schneider Victor-tulias
00a484bf03 Merge "Fix alt-tab initial focus in overview on phones" into main 2024-02-15 21:06:08 +00:00