Title was empty which caused launcher to crash. If title is empty the shortcut is invalid so we want to remove it.
Fix: 300213039
Flag: no flag
Test: no test
Change-Id: Ifa12877b9ac1d8bc266b74a95b6975b7f1bcf31e
As discovered during investigation of system health issues, doing local
color extraction in widgets (for the purpose of making their color
matches the background during a drag) took many CPU cycle during layout
pass, which may have contributed to animation janks in various scenario.
This CL removes the feature in favors of better performance.
Bug: 266941872
Test: manually verified theme are still honored in widgets.
Change-Id: I63b13bc005907779af2322cd4bedbe141b0f3e27
E.g. translation when rotating or unfolding the device.
The button is laid out as needed, so this was most visible when
entering all apps after folding/unfolding the device, but could
also be seen when rotating the device while in all apps.
Fix: 298073915
Test: Manual (folding/rotating device)
Flag: N/A
Change-Id: I573d7113a7870af0a251b3ca3916e3811f370ef9
ENABLE_TWO_PANEL_HOME is no longer used so I will also
remove it.
TwoPanelWorkspaceTest was expecting an icon on the hotseat
which no longer exist.
We will use the new flag system in main for this
feature.
Test: atest ReorderWidgets
Test: atest FoldableIntegrity
Bug: 270395274
Change-Id: I122a924a81ae989ff5636d8e276d6d31bbe0877d
It looks like from the stack trace that there is an NPE during the setApps() call. So adding nullable and null checking
to make sure mApps is not null.
bug: 296920692
test: presubmit
flag: n/a
Change-Id: If402c0b68db159f7a698e8e2e139d9bd5041b1c1
We scroll to top when rotating device, which is a behavior that aligns with other AbstractSlideInView's like allApps
Fix: 293203839
Test: verify that when rotating in widget sheet that the suggested widget no longer overlaps with widget list
Flag: no-flag
Change-Id: Icf021a46ae2c2b85b4c55e40cbd2f7e70f83c248
They are perceived to produce too much noise and maintenance.
Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I062eb5670a92a2ccc7039108829b09ca9d9127ae
The space that should be removed in split screen should check if there is a taskbar or not. Adding the transient taskbar property to DeviceProfile solves that without having to pass context around.
Fix: 289769344
Test: manual
Flag: N/A
Change-Id: Id0c51c4ec9481d3c206eef52d44094ec7a8c98cf
The default handling of back in this preIme case already closes
the keyboard if we return false, so adding it before our own key
handling was stomping on our existing syncronized keyboard.
We should still handle other cases where the system ime animation
coincides with our control, but we at least shouldn't force it on
ourselves.
This fixes the back issue in 3 button mode, and also closes all
apps on the first back gesture as intended (if you hadn't entered
0 state that is).
Demo after fix: https://drive.google.com/file/d/1pK18iEdgxQ0HQmilAMFzn66LVyCH5Ma1/view?usp=drive_link&resourcekey=0-kW4BOC-Pj-wZ_DZL51z6Rg
Bug: 270144901
Bug: 277738379
Test: Manual with 3 button mode and gesture nav, with always on
keyboard on and off
Flag: N/A
Change-Id: I9b1c525494b49cde3307df8b0a73d6143ac9c616
mLayoutHorizontal is exposed so that classes that extend BubbleTextView
can override this programmatically based on LayoutType.
mLayoutHorizontal prevents the title in horizontal cases affecting the
icon bounds measure, and shifting things such as the icon halo.
Bug: b/288471727
Test: See ag/24199217
Test: New tests in SearchResultIconTest
Test: No regression in SearchResultSmallIconRowTest
Change-Id: I424c1597d29ed26d7dea9e666ff2d274847e3217
Include change for setting the hover state flag programatically, as FastBitmapDrawable does not currently support DeviceConfig flags.
Fix: 243191650
Test: FastBitmapDrawableTest. Screenshot tests in another cl.
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: I0eb796ae62e571a3287132bfcb99c4fca1e2fbe4
Re-submit ag/24499161 with ag/24517009 to ensure tests are still passing
Flags: ENABLE_ALL_APPS_RV_PREINFLATION ALL_APPS_GONE_VISIBILITY
Test: Tested in bug bash
Bug: 288161355 291651514
Change-Id: I562d39f5edef46240700669b26d6e8fb27cbb77a
This reverts commit e302fb8cd9.
Reason for revert: WellbeingTests#testPauseAppFromAllApps is failing b/297040371
Change-Id: I92f885abff4bb1e3058eebcd23bf23875e5f84cf
> The coordinator takes care of recreating animations on layout changes and
linking it with state animation
> This also ensures that there is only one animation playing at a time
Bug: 293464892
Test: Verified that calling with multiple animations cancels previos call
Flag: None
Change-Id: Iab161720c94843b5834734da78167344c17539c8
Turning off twoline text for all_apps since we will revisit with UX to minimize grid size changes.
The ENABLE_TWOLINE_DEVICESEARCH is fine to be kept on.
bug: 270390937
test: manual-presubmit
Flag: flipping on -> off
Change-Id: I262f809d43b0781c1942bf7176869d6b74e77f1e
We where adding more CellLayouts but they where later
removed by removeExtraEmptyScreenDelayed but when rotated
the pagination animation is created before they are removed.
With this change the extra CellLayouts won't be added in the first
place.
Fix: 291822492
Test: RoerderWidgets
Test: FoldableItemsIntegrity
Change-Id: I561d2ce961a7ecc50f7a8c99c4acc44262b2e211
