Commit Graph

7877 Commits

Author SHA1 Message Date
Tony Wickham
d4ece9a74c Don't reapply state when setting user controlled animation
Bug: 79525106
Change-Id: Ia41a51559196d4aa657fae47727c7366d9073295
2018-05-10 10:03:54 -07:00
Sunny Goyal
cc0453c5e0 Merge "Fixing disabled filter is not applied to the foregound layer when dragging an icon" into ub-launcher3-edmonton 2018-05-10 06:52:02 +00:00
TreeHugger Robot
788003e4bf Merge "Tune discovery bounce to be more gentle when bouncing." into ub-launcher3-edmonton 2018-05-09 23:26:01 +00:00
Tracy Zhou
6c4fa1045b Tune discovery bounce to be more gentle when bouncing.
Change-Id: I6b1c094bbcd07bfda76bcc2c6b2a6fb249acd377
Fixes: 79491740
Test: Manual test
2018-05-09 23:18:44 +00:00
Sunny Goyal
b6d292d788 Fixing disabled filter is not applied to the foregound layer when dragging an icon
Bug: 79475381
Change-Id: Ic489601f80a3180fe20a83988c2c3db7100e6946
2018-05-09 14:25:09 -07:00
TreeHugger Robot
5be4075727 Merge "Don't end atomic animation when passing through state" into ub-launcher3-edmonton 2018-05-09 20:26:46 +00:00
Tony Wickham
56b247da1d Merge "Add atomic recents animation while swiping up" into ub-launcher3-edmonton 2018-05-09 20:13:23 +00:00
android-build-team Robot
f69f0c2bf0 Merge "Adding a carent in the scrim" into ub-launcher3-edmonton 2018-05-09 20:12:59 +00:00
android-build-team Robot
8473ddb7ee Merge "Tweaks to app closing animation." into ub-launcher3-edmonton 2018-05-09 20:11:23 +00:00
Jon Miranda
d26d5aaa6d Tweaks to app closing animation.
Change-Id: Ia2cbc1401a57ad8dc3e3553110497eb35c19fe64
2018-05-09 12:51:34 -07:00
Sunny Goyal
ef39540dde Adding a carent in the scrim
> Caret is only visible when the accessibility is enabled
> It is visible in NOTMAL and OVERVIEW state and moves out of the
  scrim along with the scrim.
> Acts as an accessible target for various options

Bug: 78172350
Bug: 79215734
Change-Id: I8a968b67e36901859649546295f6491d49cc9ce9
2018-05-09 12:39:30 -07:00
Tony Wickham
fc564f1477 Don't end atomic animation when passing through state
Previously we were ending the atomic animation with the assumption
that it should be complete/almost complete by the time you drag to
the next state. However, it is very easy to drag quickly enough where
that assumption doesn't hold, and thus you just see the atomic
animation pop to the end (i.e. recents showing without animation).

Now instead of ending the atomic animation, we let it continue. But
because the new state animation will have an atomic component that
interferes with the still playing atomic animation, we have to
control the atomic component separately; we control the non-atomic
components until the atomic animation ends, at which point we create
a separate controller to control the atomic components.

Bug: 76449024
Change-Id: Ia4bf19e26d0838f952d9e500fbdd8aba19856a41
2018-05-09 12:36:02 -07:00
Tony Wickham
6becf7c07d Add atomic recents animation while swiping up
State handlers can now specify atomic and non-atomic components of
their animations to states, which can be specified when creating a
new animation. There is now one atomic animation, when going from
NORMAL to OVERVIEW (and in reverse):
- RecentsViewStateController's animation (scale/alpha) is all atomic
- WorkspaceStateTransitionAnimation has atomic and non-atomic:
  - Hotseat and workspace alpha is atomic, as is workspace scale
  - Everything else (scrim, translation, qsb and drag handle alpha) is
    non-atomic
- All apps progress is non-atomic

Also simplified dragging through overview; no longer pulls against you,
so we use an OvershootInterpolator when flinging instead of our custom
interpolator for the spring effect.

Bug: 76449024
Bug: 78089840
Change-Id: Iafac84d0c2b99ee9cf9dd5b30e2218286713b449
2018-05-09 12:33:46 -07:00
Jonathan Miranda
cf4f8c0c2e Merge "Increase REORDER_TIMEOUT to make it easier for users to create/add to folder." into ub-launcher3-edmonton 2018-05-09 18:48:22 +00:00
android-build-team Robot
639b07178f Merge "Using surface rotation instead of insets to determine seascape configuration" into ub-launcher3-edmonton 2018-05-09 16:00:43 +00:00
Tony Wickham
e3a968090a Merge "Cleanup swipe detector in case of double cancel" into ub-launcher3-edmonton 2018-05-09 16:00:02 +00:00
android-build-team Robot
ad59f63aab Merge "Consuming launcher instets in multi-window mode" into ub-launcher3-edmonton 2018-05-08 22:08:17 +00:00
Sunny Goyal
9001b10771 Consuming launcher instets in multi-window mode
Bug: 79267409
Change-Id: I283f9eeffaf322cee9289bf90528c8c51d083a50
2018-05-08 14:57:36 -07:00
Sunny Goyal
fe392da300 Merge "Chaniging all-apps scrim" into ub-launcher3-edmonton 2018-05-08 18:10:12 +00:00
Jon Miranda
217f0ca2d9 Increase REORDER_TIMEOUT to make it easier for users to create/add to folder.
This is more common for tall devices where cell height is relatively larger
than the icon size.

Bug: 78598193
Change-Id: I2835794e4dbe799d0fadefaa723360145d134550
2018-05-08 10:50:40 -07:00
Sunny Goyal
a6616dec28 Fixing stateManager not correctly deduping existing animations
Bug: 79251716
Change-Id: I40c3ebf0ec4d49aa1fe1948ad3d83eb87cc1c5f1
2018-05-08 09:16:04 -07:00
Sunny Goyal
927447e71d Chaniging all-apps scrim
> Converting the scrim to View, to better avoid overdraw
> Overview and Spring loaded state have different scrim alpha
> When going from overview to all-apps, there is a color scrim drawn over the overview panel.
  The slef color is merged with this color to prevent overdraw, and the remaining screen is drawn
  with a cut-out round rect path

Bug: 79111591
Change-Id: I26801fde13dd6adb4b06110bbe8087e35cc31847
2018-05-08 08:29:43 -07:00
Sunny Goyal
59d086c3ce Using surface rotation instead of insets to determine seascape configuration
Insets may not correctly indicate seascape configuration in multi-window or
when the presence of device-cutouts

Bug: 79376298
Change-Id: I8268efca0001fe527a0ffefe48cc71e774fad01c
2018-05-07 17:32:46 -07:00
android-build-team Robot
d10001b5d6 Merge "Improving "shortcuts" window for TalkBack users" into ub-launcher3-edmonton 2018-05-07 20:37:07 +00:00
Vadim Tryshev
a50d99f1c1 Improving "shortcuts" window for TalkBack users
Using pane title, updating the description

Bug: 77633140
Test: Manual
Change-Id: Ia3a9ad75995a4cd3ada9b750e760161da70b9a7c
2018-05-07 13:25:39 -07:00
android-build-team Robot
c247a00e22 Merge "Fixes an issue where on resetup of the FloatingHeaderView it defaulted to the main recyclerview even when the work recyclerview was active which resulted in the recyclerview not responding to scroll changes." into ub-launcher3-edmonton 2018-05-07 19:28:37 +00:00
Jon Miranda
717127186a Fix bug where launcher closing animation isn't run.
In some cases, we prematurely clear the force invisible flag before composing
the launcher animation, causing us to skip the animation.

Bug: 77205145
Change-Id: I4224741649a4fef34e255abac7b66bcf919c042f
2018-05-07 11:46:33 -07:00
Mario Bertschler
1a637bee18 Fixes an issue where on resetup of the FloatingHeaderView it defaulted
to the main recyclerview even when the work recyclerview was active which
resulted in the recyclerview not responding to scroll changes.

Bug: 72426657
Change-Id: I13c43137d69cd73ff7bdfe641f564f18f8443595
2018-05-07 20:43:11 +02:00
Sunny Goyal
39306af7d5 Fixing memory leak on rebind
Folder listeners were only cleared on activity destroy

Bug: 79322746
Change-Id: I5da98b864855303d21b86511de2e2982cd56f305
2018-05-07 09:50:10 -07:00
Tony Wickham
fa6cbbe15b Cleanup swipe detector in case of double cancel
We manually dispatch cancel when returning to the previous state in
onDragEnd(), but could end in a bad state if getting a second,
external cancel (e.g. by pressing home). Thus, we restore the
onCancelListener after manually dispatching cancel.

Bug: 79258868
Change-Id: Idc4c33cede1d8af1829a4a744b9348d379bcf8f7
2018-05-04 13:17:46 -07:00
Sunny Goyal
18c699fbc5 Using the system color extraction logic instead of inbuild logic
> Moving the inbuild color extraction logic to the aosp flavor

Bug: 79111591
Change-Id: I766b0397da7224b424cd5f309cedf635d60a5e0f
2018-05-04 10:16:39 -07:00
Tony Wickham
4c7507571c Merge "Only detect swipe directions that lead to new states" into ub-launcher3-edmonton 2018-05-03 21:38:04 +00:00
Tony Wickham
52240a3aa0 Only detect swipe directions that lead to new states
This cleans up the code and ensures that the current state animation
is always initialized when we get drag events.

Also log when we pass through states.

Bug: 78017680
Change-Id: I54ab42923ed539940ea708973ad65f5793669c11
2018-05-03 14:04:25 -07:00
Mehdi Alizadeh
553de87c80 Merge "Refactors ButtonDropTarget to add extension data" into ub-launcher3-edmonton 2018-05-02 22:23:20 +00:00
android-build-team Robot
433ef09d29 Merge "Moving some callbacks from LauncherCallbacks to OverviewCallbacks" into ub-launcher3-edmonton 2018-05-02 22:06:10 +00:00
android-build-team Robot
145cb8420d Merge "Log OVERVIEW_ACTIVITY via MetricsLogger in quickstep Bug: 77920179" into ub-launcher3-edmonton 2018-05-02 21:53:59 +00:00
Hyunyoung Song
a05860421f Log OVERVIEW_ACTIVITY via MetricsLogger in quickstep
Bug: 77920179

Change-Id: Id4c7dc3d535c7a8009d340183e640b04ab07408a
2018-05-02 14:34:23 -07:00
Mehdi Alizadeh
bda47cf925 Refactors ButtonDropTarget to add extension data
Also fixes a bug where DeleteDropTarget was logging Remove instead of
Cancel.

Bug: 78793340
Test: Enable verbose logging and manual test
Change-Id: I0f0cfff070eab003ebb745292630bc6ce3243f4d
2018-05-02 14:20:09 -07:00
android-build-team Robot
9b83fe225d Merge "Quickstep onboarding backward compatibility for devices release with Android N & O." into ub-launcher3-edmonton 2018-05-02 20:51:37 +00:00
android-build-team Robot
f1db5a0b81 Merge "Settling scrolls over clear-all button." into ub-launcher3-edmonton 2018-05-02 20:44:06 +00:00
Tracy Zhou
8b23c6f60b Quickstep onboarding backward compatibility for devices release with Android N & O.
Quickstep introduces swipe up gesture to open Overview and removes the
Recents button. We still want to show shelf bounce animation for Android
N & O users with Recents button because Overview is updated and swiping
up from there takes users to All Apps.

Test: manual test
Change-Id: I917c91564c47c78d2dc3883b8a7bf7824b5f5bc8
Fixes: 78647939
2018-05-02 13:41:28 -07:00
Vadim Tryshev
a9283beebc Settling scrolls over clear-all button.
Per UX feedback, we divide the "overscroll area" 50/50 and settle to the
closest of the most recent task position and the fully scrolled
position.

Bug: 72222505
Test: Manual
Change-Id: Ic98fa5ae2f14f274f6a425ac687f13f7b3a4332e
2018-05-02 13:30:27 -07:00
android-build-team Robot
cb83d8d9b4 Merge "Increase DELAY_MS for DiscoveryBounce." into ub-launcher3-edmonton 2018-05-02 18:04:46 +00:00
Tony Wickham
7a5d4ae64f Merge "Fix some state issues with user-controlled animations" into ub-launcher3-edmonton 2018-05-02 16:20:19 +00:00
Jorim Jaggi
bbeedd1d2f Merge "Fix some jank with transitions" into ub-launcher3-edmonton 2018-05-02 13:17:42 +00:00
Jon Miranda
8d945e497f Increase DELAY_MS for DiscoveryBounce.
We need it to be longer, otherwise it interferes with the app closing
animation.

Change-Id: Id50e54362564eb8f7c083495fe8ca039c68fba3f
2018-05-01 21:21:48 -07:00
Sunny Goyal
8e1fbc5103 Moving some callbacks from LauncherCallbacks to OverviewCallbacks
Bug: 78780639
Change-Id: I90f868c741834efbe542367bdc3539f6d14f1939
2018-05-01 16:58:52 -07:00
android-build-team Robot
cacf90cc48 Merge "Reusing the same bitmap and pixel array for shape detection" into ub-launcher3-edmonton 2018-05-01 23:32:17 +00:00
android-build-team Robot
4d9c414cdb Merge "Bound overscroll shift amount to avoid content from drawing on top (Y-val) of the QSB." into ub-launcher3-edmonton 2018-05-01 21:07:59 +00:00
android-build-team Robot
3adb0b9f2a Merge "Fade in LauncherRootView in finishFirstPageBind." into ub-launcher3-edmonton 2018-05-01 20:59:00 +00:00