Commit Graph

60459 Commits

Author SHA1 Message Date
Charlie Anderson
471b88269f Prevents cropping of shortcuts in the app popup menu by limiting rows to available screen space.
- Limit the number of shortcut rows shown to what will fit the screen.
 - Fix drag testDragShortcut so that it works for all screen sizes.
 - Prevent cropping and misalignment of shortcut text.

Bug: 247880037
Fixes: 275115239
Test: locally on different devices, and with Display Size set to different sizes
Change-Id: I18b27ec302c34d1d801171ab18c64169a9f252ee
2023-04-06 15:23:38 -04:00
Vinit Nayak
5bda089e2b Close system dialogs on Taskbar home button tap
Fixes: 255879258
Test: Able to go home w/ shade down in app and
in overview

Change-Id: Ia706148b4437e18b16b711bda572c4ba28958718
2023-04-06 12:09:35 -07:00
Winson Chung
48e6b4ccd9 Always provide mandatory bottom gesture insets
Bug: 265614886
Bug: 277185135
Test: atest WindowInsetsPolicyTest
Change-Id: I0cf4d5b72e54caf7c671a5d52a93d2066a79ed65
Merged-In: I964e0b759170c127cb05615ce5bf6fa827621187
2023-04-06 19:08:26 +00:00
Jeremy Sim
4bce4f6193 Merge "Fix bug with split screen not recognizing user differences" into tm-qpr-dev 2023-04-06 19:02:50 +00:00
Saumya Prakash
b4e34d831f Add spacing to gesture nav edu for large fonts.
For devices with smaller screens and the largest fonts and display
sizes, the end screen of the gesture navigation tutorial would cut off
the `Done` button at the bottom. This adds margins so that the button
remains visible on the screen.

Screenshot of Pixel 5 with the largest font and display:
https://screenshot.googleplex.com/AU5rYYBisZ9Azbr.png

Fix: 275540512
Test: Went through the tutorial with default and largest font sizes on both smaller devices and tablets to ensure the button is always visible.
Change-Id: I66baf9b9044211550395bb3823797127de5e1f99
2023-04-06 18:49:59 +00:00
fbaron
fad5b7ebae Make suggestions header sticky in widget picker two pane
The final design makes the suggestions header sticky, but the implementation has it following the original design which wasn't sticky. This CL makes the header sticky.

Bug: 277163859
Test: Verify that suggestions header is sticky in both 1 profile view and in work/personal profile view
Change-Id: I795617edc6d5ba410a97ff87385ec40a62abbc3e
2023-04-06 10:21:39 -07:00
Tracy Zhou
5a56d022cb Log the input type for gesture nav gestures
Test: N/A
Bug: 276152142
Change-Id: I84a7a9470aa3151d4c6b9dbfc61d8f158987ea47
2023-04-06 09:49:28 -07:00
Winson Chung
3d03a208ac Always provide mandatory bottom gesture insets
Bug: 265614886
Bug: 277185135
Test: atest WindowInsetsPolicyTest
Change-Id: I964e0b759170c127cb05615ce5bf6fa827621187
2023-04-06 16:43:16 +00:00
fbaron
a3dbce41e3 Prevent two pane widget picker code from reaching foldables
Currently, there's a few sections of the code that are intended to only be reached by tablets in landscape mode that can be reached by unfolded foldables. Here, we fix this so it no longer occurs.

Bug: 277102339
Test: Verify widget picker works correctly on tablet
Change-Id: I1f2bc99072aff6d852f9ce658ab00fa33b9e02b5
2023-04-06 09:38:15 -07:00
TreeHugger Robot
3c98169752 Merge "Update the pending app icon to match new specs" into udc-dev 2023-04-06 16:24:53 +00:00
Mike Schneider
5bd3864c79 Merge "Fade navbar-handle in/out during TRANSITION_HANDLE_FADE" into tm-qpr-dev am: 2a20958f4b am: 0264036b64
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22433065

Change-Id: I779cae347ca106349f0567cb1660a7f1165b3e5e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-06 16:01:27 +00:00
Mike Schneider
0264036b64 Merge "Fade navbar-handle in/out during TRANSITION_HANDLE_FADE" into tm-qpr-dev am: 2a20958f4b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22433065

Change-Id: Ib0a5f6cea3574815e0f6557c4171ba7d1efe8c6d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-06 15:33:19 +00:00
Jeremy Sim
3b5d0ea09d Merge "Fix bug with split screen not recognizing user differences" into udc-dev 2023-04-06 15:12:35 +00:00
Mike Schneider
2a20958f4b Merge "Fade navbar-handle in/out during TRANSITION_HANDLE_FADE" into tm-qpr-dev 2023-04-06 15:05:35 +00:00
Bill Yi
b7e1d9dc73 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev am: baf58163e6 -s ours am: a65b45db5e -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22499062

Change-Id: I0e1a21fb08bdff37eb923120a3e8e1cd8c9464de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-06 14:26:06 +00:00
Bill Yi
3d62b1e8af [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 5a2d865135 -s ours am: d2092b4c13 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22499062

Change-Id: I318f8f40ae18b647d68b070bdb91c1290976f081
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-06 14:25:51 +00:00
Bill Yi
a65b45db5e [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev am: baf58163e6 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22499062

Change-Id: If00ddb9ac0335f376205085d7fedf305ba4478ee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-06 13:57:45 +00:00
Bill Yi
d2092b4c13 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 5a2d865135 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22499062

Change-Id: Ibb6496cad4e98dc1105354d0c79d2f7e6aea0398
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-06 13:57:30 +00:00
Bill Yi
baf58163e6 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2023-04-06 13:50:21 +00:00
Mike Schneider
7d7b23e6b6 Fade out navbar on lockscreen -> homescreen transition am: 975fa69260 am: 6353f6b8e4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22422409

Change-Id: I83f8ad85e4fbc990afdfc4b88191a10fa989dae1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-06 11:23:41 +00:00
Mike Schneider
6353f6b8e4 Fade out navbar on lockscreen -> homescreen transition am: 975fa69260
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22422409

Change-Id: Ic1b27f08c277fcda8332a37ef596228a9871f2e6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-06 10:54:00 +00:00
Mike Schneider
0d7713780f Fade navbar-handle in/out during TRANSITION_HANDLE_FADE
The existing code relied on the INSTANT / FINAL_FRAME interpolators,
however these did not work as expected for sub-animations with shorter durations,
since the INSTANT / FINAL_FRAME interpolator applies to the sub-animations durations

This caused the stashed handle to jumpcut in/out, while the taskbar icons were
actually visible in the area of the navbar.

This is fixed to polish the lock/unlock animation (b/275319714), but happenes to fix b/276941963 as well.

Before: http://shortn/_uxw2oe7QeA
After: http://shortn/_yMY8IQIM60

Bug: 275319714
Bug: 276941963
Fixed: 275319714
Fixed: 276941963

Test: manual (http://shortn/_rnGNSkRH3w), tapl tests
Change-Id: I79e431e9ee21ede069864ee217bb343f0c32dfc7
2023-04-06 12:39:46 +02:00
Tony Huang
0b69d38787 Revert "Implement two intents or shortcuts to active split"
Revert submission 22349283-intents-split

Reason for revert: Cause master branch build break

Reverted changes: /q/submissionid:22349283-intents-split

Change-Id: I1030f801385b6f17e8565f2f64f71ba5229aed73
2023-04-06 08:08:35 +00:00
Tony Huang
e1826dbdc7 Implement two intents or shortcuts to active split
Implement two intents or shortcuts to active split with shell
transition.

Fix: 259368992
Test: manual
Test: pass existing tests
Change-Id: I13522531022b635dc8508a3213b6f414a6b50ce9
2023-04-06 05:19:50 +00:00
Mike Schneider
975fa69260 Fade out navbar on lockscreen -> homescreen transition
Introduces a new SYSUI_STATE_STATUS_BAR_KEYGUARD_GOING_AWAY QuickStepContract flag, to get an early signal when the keyguard is going away

Bug: 275319714
Test: transitions manual (http://shortn/_ySNBaPFHRZ), existing tapl tests
Change-Id: Ie0044ea8e934afa793ca56a4eacc2b776edbdf0e
2023-04-06 05:08:28 +00:00
Jeremy Sim
1b75c85305 Fix bug with split screen not recognizing user differences
This patch fixes a bug where split screen did not fully support launching intents with different users.

The bug arose because SplitSelectStateController only had one place to store user information about the staged intent, mUser, but this disregarded the fact that the secondary app could also be passed in as an intent, and could belong to a different user from that of the initial app and the existing context. We need to support this case now since we now allow second-app selection from Taskbar.

Fixed by splitting the field into mInitialUser and mSecondUser, which will be tightly bound with mInitialTaskIntent and mSecondTaskIntent to make sure that Intents are always launched with the correct UserHandle.

Fixes: 275410160
Test: Manual
Change-Id: Ic904672769be8fd116180d457b36eb567c5ee304
Merged-In: Ic904672769be8fd116180d457b36eb567c5ee304
Merged-In: I1ec49c75d562e4309a41d98010f0eff113c81e9d
2023-04-06 03:44:33 +00:00
Jeremy Sim
0c5262b9e1 Fix bug with split screen not recognizing user differences
This patch fixes a bug where split screen did not fully support launching intents with different users.

The bug arose because SplitSelectStateController only had one place to store user information about the staged intent, mUser, but this disregarded the fact that the secondary app could also be passed in as an intent, and could belong to a different user from that of the initial app and the existing context. We need to support this case now since we now allow second-app selection from Taskbar.

Fixed by splitting the field into mInitialUser and mSecondUser, which will be tightly bound with mInitialTaskIntent and mSecondTaskIntent to make sure that Intents are always launched with the correct UserHandle.

Change-Id: I1ec49c75d562e4309a41d98010f0eff113c81e9d
Fixes: 275410160
Test: Manual
Merged-In: Ic904672769be8fd116180d457b36eb567c5ee304
2023-04-06 03:42:55 +00:00
Brian Isganitis
93f20cc2d5 Merge "Make navbar scrim taskbar background if taskbar is enabled." into udc-dev 2023-04-05 23:58:01 +00:00
Bill Yi
5a2d865135 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8539b365e0992a4c7092222ab545a88ae6106134
2023-04-05 16:51:13 -07:00
Schneider Victor-tulias
bbe9ca616a Cleanup ENABLE_TASKBAR_POPUP_MENU
Flag: ENABLE_TASKBAR_POPUP_MENU
Fixes: 270392477
Test: opened a popup menu from the taskbar
Change-Id: I779e5410163aa1c9042d2fe128e0c528d168a964
2023-04-05 15:42:40 -07:00
Schneider Victor-tulias
7d8a0df175 Clean up ENABLE_INPUT_CONSUMER_REASON_LOGGING
flag: ENABLE_INPUT_CONSUMER_REASON_LOGGING
Fixes: 270390028
Test: ran launcher and printed gesture nav logs
Change-Id: I0fd0b82c1c812ddc43beba03bd456795f68ada55
2023-04-05 15:40:32 -07:00
Schneider Victor-tulias
aba2d9796e Cleanup ENABLE_BULK_ALL_APPS_ICON_LOADING
Flag: ENABLE_BULK_ALL_APPS_ICON_LOADING
Fixes: 270392465
Test: restarted device
Change-Id: I2fe963a512632919c12e1caaf54b2aa8ecd5a3b5
2023-04-05 15:39:51 -07:00
Schneider Victor-tulias
948fc94e12 Cleanup ENABLE_SMARTSPACE_DISMISS
Flag: ENABLE_SMARTSPACE_DISMISS
Fixes: 270391664
Test: dismissed a smartspace card
Change-Id: Ife2dd2fdc023474f59638f2d423fdb9c21823676
2023-04-05 15:38:43 -07:00
TreeHugger Robot
75f7bbc150 Merge "Allow grids to specify if we should start align taskbar in 3 button nav." into tm-qpr-dev am: 65ac592f40 am: a2b770b484
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22361600

Change-Id: I41eea8cf3fa15c9c5c3f3184f2ba75318332f623
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-05 22:36:14 +00:00
Sunny Goyal
8382546a11 Merge "Removing support for legacy shortcuts from default layouts" into udc-dev 2023-04-05 22:26:36 +00:00
TreeHugger Robot
a2b770b484 Merge "Allow grids to specify if we should start align taskbar in 3 button nav." into tm-qpr-dev am: 65ac592f40
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22361600

Change-Id: I71c7f33286ccfa770f87b812c8ec27fa4ecb25ed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-05 22:06:49 +00:00
Brian Isganitis
5489507e69 Merge "Clean up QUICK_WALLPAPER_PICKER." into udc-dev 2023-04-05 21:56:33 +00:00
TreeHugger Robot
65ac592f40 Merge "Allow grids to specify if we should start align taskbar in 3 button nav." into tm-qpr-dev 2023-04-05 21:46:40 +00:00
Andrew Cole
6598fab10c Merge "Improving a flakey uninstall from allapps test." into udc-dev 2023-04-05 20:27:10 +00:00
Sunny Goyal
afaa8f0bfe Removing support for legacy shortcuts from default layouts
Launcher will only allow deep shortcuts to be pinned on homescreen.

Bug: 275875209
Test: Updated tests
Flag: N/A
Change-Id: I4f2674deb9cd81dd07d5d537f35a51b030a183da
2023-04-05 20:20:34 +00:00
Stefan Andonian
3d877d3b04 Merge "Write ViewCapture data to WmTrace when WindowManager dumps." into udc-dev 2023-04-05 20:19:42 +00:00
Jon Miranda
a65e16fc67 Merge "Allow user gesture to take priority over taskbar translation reset animnatiuon." into tm-qpr-dev am: 4288be12a7 am: b5482137ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22464244

Change-Id: I94b42f6ae10da01e70f6d5555ff596a5d7263785
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-05 19:39:11 +00:00
TreeHugger Robot
c62a0672ab Merge "Don't return early if searching during rebindAdapters()." into udc-dev 2023-04-05 19:33:43 +00:00
Jon Miranda
b5482137ef Merge "Allow user gesture to take priority over taskbar translation reset animnatiuon." into tm-qpr-dev am: 4288be12a7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22464244

Change-Id: I75fdac300d2875b28ef0b230c27396c68b469ade
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-05 18:47:26 +00:00
Jon Miranda
4288be12a7 Merge "Allow user gesture to take priority over taskbar translation reset animnatiuon." into tm-qpr-dev 2023-04-05 18:20:16 +00:00
Jon Miranda
04f051045c Allow grids to specify if we should start align taskbar in 3 button
nav.

Bug: 259712417
Test: check layout on tablet
      check layout on multi_display devices

Change-Id: I282f51e5d76a30e9ad9d8c52d03d4853e965d65a
2023-04-05 10:29:51 -07:00
Andrew Cole
78e1461748 Improving a flakey uninstall from allapps test.
Previously the test froze the all apps list before the uninstall action, but what we are testing here is that the all apps list does change. Also included is a small refactor to use the same wait method for this test and a second test.

Test: Ran Locally on Device
Bug: b/258071914
Change-Id: Ic18be39130fbd7b7e1214d6fc60c1afa30ddf078
2023-04-05 10:16:00 -07:00
Brian Isganitis
296f8776f7 Merge "Support simple A-Z search in Taskbar All Apps." into udc-dev 2023-04-05 17:13:52 +00:00
Federico Baron
7122921153 Merge "Rename widgets two pane sheet layout files and spec files to more fitting name" into udc-dev 2023-04-05 16:36:36 +00:00
TreeHugger Robot
c8cc011fad Merge "Create flag for multi-select edit mode" into udc-dev 2023-04-05 16:36:04 +00:00