Sebastián Franco
2e1524ec2f
Merge "Binding tests to TouchInteractionService to preventing it from getting destroyed" into tm-qpr-dev
2023-02-25 00:45:46 +00:00
Schneider Victor-tulias
501647451f
Merge "Add debug logs to debug flaky workspace binding" into tm-qpr-dev am: cd17310656 am: 4f4962fbc9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21542943
Change-Id: If92717381b6f7ae5b958098141edb3dfa43f91bc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-24 22:50:35 +00:00
Schneider Victor-tulias
4f4962fbc9
Merge "Add debug logs to debug flaky workspace binding" into tm-qpr-dev am: cd17310656
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21542943
Change-Id: I04412352aa7b773103cd08a9c7ce14fe75c2b789
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-24 21:57:41 +00:00
Schneider Victor-tulias
cd17310656
Merge "Add debug logs to debug flaky workspace binding" into tm-qpr-dev
2023-02-24 21:12:41 +00:00
Helen Cheuk
599109b23f
Update folder row and column for 5x5 grid to 4x4. Update dump method to include changed properties and add dump test for 5x5 grid
...
Originally folder row and column for 5x5 grid was 3x3. This change is to update it to 4x4 in config to increase the max number of cells displayed. It also adds corresponding test for 5x5 grid and includes numFolderRows and numFolderColumns in the dump string
Fix: 265139500
Test: DeviceProfileDumpTest
Change-Id: I09fe3eac8113a147cb895988e5424471e4e772e5
2023-02-24 14:40:50 +00:00
Ling Wo
087c19a9ec
Merge "Revert^2 "Expose getSearchBox from the HomeAllApps class"" into tm-qpr-dev am: 6d3658dd0c am: 4f9196c305
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21160354
Change-Id: I2d4c1b04e1f6fef0a0c075e8692a742f5a5bf2c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-24 03:04:55 +00:00
Ling Wo
4f9196c305
Merge "Revert^2 "Expose getSearchBox from the HomeAllApps class"" into tm-qpr-dev am: 6d3658dd0c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21160354
Change-Id: Ia523c1d77e5b7903c3fb3cee502b771fc9e9c9bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-24 02:44:54 +00:00
Ling Wo
6d3658dd0c
Merge "Revert^2 "Expose getSearchBox from the HomeAllApps class"" into tm-qpr-dev
2023-02-24 02:24:54 +00:00
Brandon Dayauon
3d58117d76
Add logging to testDragAppIconToWorkspaceCell()
...
- add time logs to see what is taking up the most time
bug: 269555222
test: presubmit + manually
Change-Id: I36e763a42e0d8ebdcca108d9206418e05ab33e8f
2023-02-23 16:21:50 -08:00
Ling Wo
d70c8a743d
Revert^2 "Expose getSearchBox from the HomeAllApps class"
...
Reverted changes: /q/submissionid:21128652-revert-20714047-b_255390519-CAXVPNWYOY
Change-Id: I0e9680408e8b1db85600a226d808669c65ba4967
Bug: b/266169958
2023-02-23 02:42:09 +00:00
Federico Baron
322c008b07
Merge changes I6c89c639,I6cab9202 into tm-qpr-dev am: 4ee5c429fe am: 87b61adde5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21407904
Change-Id: I75a52dec97590b92eed7037b84eecd1e7de40e1d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-23 02:07:00 +00:00
Federico Baron
87b61adde5
Merge changes I6c89c639,I6cab9202 into tm-qpr-dev am: 4ee5c429fe
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21407904
Change-Id: I8ee82a8b1c954c47c1c495ad05d7f7a33d400e46
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-23 01:13:07 +00:00
Stefan Andonian
f5e204ec82
Merge changes from topic "idp_grid_name" into tm-qpr-dev am: 78187b3812 am: d78817b455
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21529902
Change-Id: Ida13870236ab306c1f1a11db8f29898b56b4c406
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-23 00:59:00 +00:00
Stefan Andonian
9d890f0e7b
Merge "Re-add LockedUserState util that was reverted after TAPL test failures." into tm-qpr-dev am: b334c03c74 am: 2bbdb87ae6
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21532181
Change-Id: I2d1c2023ae697e195c9b35ddbe8322e13cad3471
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-23 00:56:14 +00:00
Federico Baron
4ee5c429fe
Merge changes I6c89c639,I6cab9202 into tm-qpr-dev
...
* changes:
Move 'no widgets found' to right pane and add rounded edges to right pane.
Add ripple effect when a header in widget picker is selected.
2023-02-22 23:24:10 +00:00
Stefan Andonian
d78817b455
Merge changes from topic "idp_grid_name" into tm-qpr-dev am: 78187b3812
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21529902
Change-Id: Ib632a7112fe19dc39d6f7f78fca7b668e00d35d3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 22:32:15 +00:00
Stefan Andonian
2bbdb87ae6
Merge "Re-add LockedUserState util that was reverted after TAPL test failures." into tm-qpr-dev am: b334c03c74
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21532181
Change-Id: I0ed0d81062e264b997e97034ff19bb8ec0aa0951
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-22 22:32:03 +00:00
Stefan Andonian
78187b3812
Merge changes from topic "idp_grid_name" into tm-qpr-dev
...
* changes:
Add unit test and fix bug related to "Migrate IDP_GRID_NAME usage to LauncherPrefs" CL.
Revert "Revert "Migrate IDP_GRID_NAME usage to LauncherPrefs""
2023-02-22 22:09:42 +00:00
Schneider Victor-tulias
6b94a960c0
Add debug logs to debug flaky workspace binding
...
Bug: 270216650
Test: ReorderWidgets
Change-Id: I6fa2eab98c0268000ef4c44980c2917d5ef1bc89
2023-02-22 13:05:13 -08:00
Stefan Andonian
246eeaaea1
Add unit test and fix bug related to "Migrate IDP_GRID_NAME usage to LauncherPrefs" CL.
...
The issue was that kotlin initializes class variables before contructor
variables, but allows constructor variables to be referenced by
the class variables before they are initialized. This led to `isBackedUp`
always being false, and then the SharedPreference store always and only
checking if values were in DEVICE_PREFERENCES rather than the standard
backed up preferences.
The fix is to make the class variable sharedPrefFile lazily retrieved.
That way, isBackedUp will have been initialized and behave correctly.
Bug: 269569568
Test: Everything works on device and manual and unit tests
verified original bug is not present.
Change-Id: I8ab4a5752886ce8f4a2988295fa61c8a2c38ec7c
2023-02-22 19:05:00 +00:00
Stefan Andonian
4c9612be30
Revert "Revert "Migrate IDP_GRID_NAME usage to LauncherPrefs""
...
This reverts commit df11959779 .
Bug: 269569568
Test: In follow-up CL, everything works on device and manual and unit tests
verified original bug from this CL is not present.
Change-Id: I125bbbfd6442cd3fa1e88c9109de536b88981dc6
2023-02-22 18:53:26 +00:00
Stefan Andonian
429460beae
Re-add LockedUserState util that was reverted after TAPL test failures.
...
Bug: 251502424
Test: Unit tests all passed.
Change-Id: I80f1d521d430edf6c4d5e027d14e2087ed7e04f1
2023-02-22 18:49:21 +00:00
Sebastian Franco
0451d239ed
Binding tests to TouchInteractionService to preventing it from getting destroyed
...
Fix: 257514573
Bug: 266716173
Test: atest MemoryTests
Test: atest TaplTestsLauncher3#testDragAppIcon
Change-Id: Ib53bf11f45f9e05bf55116d52f3406f45dfaf6c2
2023-02-22 10:14:29 -08:00
Federico Baron
e8217b3c1b
Add ripple effect when a header in widget picker is selected.
...
We need to use setSelected in order to add a ripple effect when a header is selected in tablet landscape mode, and to set the style through XML rather than programmatically the way it was done before in the method `setLargeScreenTheme`.
Fix: 268558453
Test: Turn on LARGE_SCREEN_WIDGET_PICKER and verify that when selecting a header there's a ripple effect on that header
Change-Id: I6cab920258a57118430d1e07416508ef36faa56d
2023-02-21 16:33:18 -08:00
Stefan Andonian
b77643bd16
Merge "Revert "Migrate IDP_GRID_NAME usage to LauncherPrefs"" into tm-qpr-dev am: b7221177b4 am: c55e9d52e4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21522366
Change-Id: I8d2eab7b9c18900c6b386fab7eb75ed7a9dfef10
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-21 21:27:14 +00:00
Stefan Andonian
c55e9d52e4
Merge "Revert "Migrate IDP_GRID_NAME usage to LauncherPrefs"" into tm-qpr-dev am: b7221177b4
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21522366
Change-Id: Ibad7a921788a1b86a972fcdb6a7f084dd4d4cfe0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-21 19:47:30 +00:00
Stefan Andonian
b7221177b4
Merge "Revert "Migrate IDP_GRID_NAME usage to LauncherPrefs"" into tm-qpr-dev
2023-02-21 18:12:55 +00:00
Stefan Andonian
df11959779
Revert "Migrate IDP_GRID_NAME usage to LauncherPrefs"
...
This reverts commit 6f9a57186c .
Reason for revert: A Bug where only device preferences were being used, not the main shared preference file.
Bug: 269569568
Test: Verified this on device.
Change-Id: I8422b2d7073537bd46c3a91033bd2281bbd306b7
2023-02-21 18:12:11 +00:00
Stefan Andonian
64c3511087
Merge "Revert "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and"" into tm-qpr-dev am: 8989f839f5 am: bcfc5acb9a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21142878
Change-Id: Ib2d66bf6b341da53bf7f835ec534e450f24f2ed6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-20 20:33:43 +00:00
Stefan Andonian
bcfc5acb9a
Merge "Revert "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and"" into tm-qpr-dev am: 8989f839f5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21142878
Change-Id: I0b9740a98594304cca9603dc53583655dc6db976
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-17 23:54:49 +00:00
Robin Lee
aafeb82613
Revert "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and"
...
This reverts commit 2a58ddb89f .
Reason for revert: b/266987957
Change-Id: I4a4a1f01a693d703f4dc87e8169fbf374729d274
2023-02-17 19:45:27 +00:00
Sunny Goyal
3425e350ac
Merge "Using DiffUtil for calculating widget diff instead of a custom implementation" into tm-qpr-dev am: cc10ed5532 am: 75db2c1f59
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21381953
Change-Id: I5dee1553d80878417ef18425e5ff626fc80326e2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-17 06:26:58 +00:00
Sunny Goyal
75db2c1f59
Merge "Using DiffUtil for calculating widget diff instead of a custom implementation" into tm-qpr-dev am: cc10ed5532
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21381953
Change-Id: I42080a592bef63d0cb7e55189a1a6249f331220a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-17 00:02:41 +00:00
Sunny Goyal
cc10ed5532
Merge "Using DiffUtil for calculating widget diff instead of a custom implementation" into tm-qpr-dev
2023-02-16 23:28:19 +00:00
TreeHugger Robot
b0321f97b6
Merge "Making ReorderWidget test more reliable" into tm-qpr-dev am: 1b7a140693 am: f351bd7c6c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21091023
Change-Id: Iaeda98eb011c28cc9e682a6fc07fa64fb4028a15
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-15 22:58:03 +00:00
Stefan Andonian
24cff2fa3e
Merge "Refactor Workspace Loading / Processing code." into tm-qpr-dev am: 3a14f1331d am: 8775725e06
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20544534
Change-Id: I41e7ca11f4462407f73ac6ec4dc16d9fa619a1ee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-15 22:57:29 +00:00
TreeHugger Robot
f351bd7c6c
Merge "Making ReorderWidget test more reliable" into tm-qpr-dev am: 1b7a140693
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21091023
Change-Id: I4d861e9c566303aa9fb41bebaccf6369ef1411df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-15 22:57:04 +00:00
Stefan Andonian
8775725e06
Merge "Refactor Workspace Loading / Processing code." into tm-qpr-dev am: 3a14f1331d
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20544534
Change-Id: I9185bbd2b89d0f40ce85ae4e4b2843643d9ecce8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-15 22:54:49 +00:00
TreeHugger Robot
1b7a140693
Merge "Making ReorderWidget test more reliable" into tm-qpr-dev
2023-02-15 22:50:20 +00:00
Stefan Andonian
3a14f1331d
Merge "Refactor Workspace Loading / Processing code." into tm-qpr-dev
2023-02-15 22:16:29 +00:00
Stefan Andonian
aa03be3a16
Merge "Migrate IDP_GRID_NAME usage to LauncherPrefs" into tm-qpr-dev am: 3788da6285 am: 844dc76a25
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21359246
Change-Id: I77d01b752d13a823b6d41db0b52e62ef46985675
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-15 19:40:23 +00:00
Stefan Andonian
844dc76a25
Merge "Migrate IDP_GRID_NAME usage to LauncherPrefs" into tm-qpr-dev am: 3788da6285
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21359246
Change-Id: If917934e6739a9085ed893ca8d3ff49549f0c45e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-15 19:37:26 +00:00
Stefan Andonian
3788da6285
Merge "Migrate IDP_GRID_NAME usage to LauncherPrefs" into tm-qpr-dev
2023-02-15 18:58:41 +00:00
Stefan Andonian
05ca3a8089
Refactor Workspace Loading / Processing code.
...
There are no behavioral changes (other than we no longer are recycling
objects while processing workspace items), but this refactor will setup
the next change to load the first workspace page before other workspace
pages.
Bug: 251502424
Test: Workspace, app widgets, and containers loaded properly.
Change-Id: I437aab40000d841d7fcc4380d05ab4a8f5d5c2ad
2023-02-15 17:36:27 +00:00
Thales Lima
0eaaddc6c9
Merge "Create a DeviceProfileDumpTest for nonquickstep" into tm-qpr-dev am: 0af71f85dd am: 42c28e7bfe
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20960103
Change-Id: I52af02a531bd19141e29e2945ac960018ad5773f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-15 11:05:59 +00:00
Thales Lima
42c28e7bfe
Merge "Create a DeviceProfileDumpTest for nonquickstep" into tm-qpr-dev am: 0af71f85dd
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20960103
Change-Id: Ia14ebbc496ab0d30ead6771c291593e809f0aabd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-15 10:14:32 +00:00
Thales Lima
0af71f85dd
Merge "Create a DeviceProfileDumpTest for nonquickstep" into tm-qpr-dev
2023-02-15 09:46:11 +00:00
Stefan Andonian
6f9a57186c
Migrate IDP_GRID_NAME usage to LauncherPrefs
...
Bug: 251502424
Test: Grid functionality still worked just fine on device when I tested
it locally.
Change-Id: I23676572637f194e1f739e4b39159311870abc32
2023-02-15 06:01:47 +00:00
Sunny Goyal
892fab2c14
Using DiffUtil for calculating widget diff instead
...
of a custom implementation
This uses the same version as all-apps and avoids whole list refresh
when a widget entry is expanded for the first time
Removing tests which were essentially testing the diffing logic
Bug: 268646258
Test: Verified on device
Change-Id: I4799c66b4674e754547317317e7a63f098fce735
2023-02-14 20:59:29 +00:00
Sunny Goyal
591a128e57
Merge "Moving widget background to xml, so that the same constantstate is used for all entries" into tm-qpr-dev am: a75105ef03 am: 67e1e03913
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21381944
Change-Id: Icde51114b8f5655ea516b0ea8233c5f6734d2997
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2023-02-13 19:32:50 +00:00