Commit Graph

14731 Commits

Author SHA1 Message Date
Nick Chameyev
be2db5bd3d Merge "Do not use private APIs in unfold module" into tm-qpr-dev am: c7ab991818 am: fcf5d393eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21523105

Change-Id: I80ef77898fe2ffc728cdaa2473252ca032880da3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 00:05:17 +00:00
Tony Wickham
7fa1e32f21 Merge "Align taskbar children to Y value instead of X." into tm-qpr-dev 2023-03-06 23:51:50 +00:00
Brian Isganitis
ef9514beab Merge "Implement light mode for persistent Taskbar." into tm-qpr-dev am: 2790c9dbbf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21592661

Change-Id: Idbf2609daac8c6e35c9edae08e05b379eae80a0c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-06 23:48:02 +00:00
Vinit Nayak
313a44039f Revert "Create TAPL test suite for splitscreen"
This reverts commit 03815e6c79.

Reason for revert: b/271852893

Change-Id: I165a15b29e41ce1114f6b7d92d22cdd8e0dfb5b0
2023-03-06 23:47:20 +00:00
Brian Isganitis
2790c9dbbf Merge "Implement light mode for persistent Taskbar." into tm-qpr-dev 2023-03-06 23:07:41 +00:00
Charlie Anderson
52caf63404 Fixes several Visual issues with the app shortcut popup
- Fix system shortcut alignment and ordering.
- Replace horizontal split icon with correct size drawable.
- Remove popup shortcut reversing logic, and instead show same order of shortcuts regardless of orientation.

Test: tested manually on tablet and phone
Bug:269343928
Change-Id: I1700ad1ee04abf0820c87d89e1dc07d6880fd519
2023-03-06 16:40:51 -05:00
TreeHugger Robot
bc74b530aa Merge "Fix an issue with concurrent modification on widget holders list" into tm-qpr-dev am: f22345eace
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21694006

Change-Id: I8104399f1212808af99a048327d7b559f355e006
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-06 20:45:48 +00:00
TreeHugger Robot
f22345eace Merge "Fix an issue with concurrent modification on widget holders list" into tm-qpr-dev 2023-03-06 20:05:29 +00:00
Johannes Gallmann
72313feac1 Merge "Add onEndCallback to ContainerAnimationRunner" into tm-qpr-dev am: 83683829f7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21750179

Change-Id: Iebc90a935e9bbdd865f2fd03b531e5f5bcfefa66
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-06 19:54:47 +00:00
Tony Wickham
48119d4384 Restore old interpolators for Overview -> Home
This regressed due to b/236761067 updating the transition from Split
Select to Home (go to Overview, select an app to enter Split screen, but
then go home instead of picking the second app to split with). Kept the
new interpolators for OVERVIEW_SPLIT_SELECT to home, but restored the
old interpolators for OVERVIEW to home

Test: Manual, watch transition from Overview to Home, and Split Select
to Home
Fixes: 269348223

Change-Id: Ifc72f467881e235c24c35d86755dc5db675a9452
2023-03-06 19:46:59 +00:00
Schneider Victor-tulias
ec76d6e4b9 Translate the navigation setting text to prevent overlapping with home gesture hint
On large fonts and display sizes, the navigation settings text can overlap with the home gesture hint. Adding some additional translation to account for this.

Fixes: 269716511
Test: Launched all set page on the largest and default font and display sizes on a phone
Change-Id: I4a40b06b827667de9b0bdb893320b0a9890f6699
2023-03-06 19:14:40 +00:00
Johannes Gallmann
83683829f7 Merge "Add onEndCallback to ContainerAnimationRunner" into tm-qpr-dev 2023-03-06 18:55:49 +00:00
Hyunyoung Song
a10811b4fe Merge "Hide the splash icon when launching with no view and no item." into tm-qpr-dev am: eeee84efb6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21447384

Change-Id: I97443edd17e2c0d4982a9a63bdd61c78c1b9e4e5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-06 18:39:09 +00:00
Hyunyoung Song
eeee84efb6 Merge "Hide the splash icon when launching with no view and no item." into tm-qpr-dev 2023-03-06 18:23:32 +00:00
Pat Manning
d3cffe8156 Align taskbar children to Y value instead of X.
Fix: 271858023
Test: manual on tablet.
Change-Id: I60882a062d5f2bb8f24525e2cec9c4a091b31545
2023-03-06 17:57:58 +00:00
Hongwei Wang
5f57433ebc Merge "Turn ENABLE_PIP_APP_ICON_OVERLAY on by default" into tm-qpr-dev am: 1897e4f40f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21613694

Change-Id: I03d3746ad0795a87307676fe2ee2d7c18454bcc7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-06 17:50:09 +00:00
Hongwei Wang
1897e4f40f Merge "Turn ENABLE_PIP_APP_ICON_OVERLAY on by default" into tm-qpr-dev 2023-03-06 17:13:56 +00:00
TreeHugger Robot
3dda7ab75f Merge "Sync overview scroll so that it ends before/at same time as taskbar animation" into tm-qpr-dev am: a176ad060f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21778039

Change-Id: I1d7772bfe999a4b9967b1656b99023c94eecdb17
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:46:22 +00:00
Jeremy Sim
2a81b79a3c Merge "Create TAPL test suite for splitscreen" into tm-qpr-dev am: ad9bdcfd2d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21221178

Change-Id: I14e25affb3d204cd2fcf0f693fd53ce502e576f3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:46:09 +00:00
Sunny Goyal
5a4ff1a073 Merge "Simplifying code around multiple translation components" into tm-qpr-dev am: 33c3e77411
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21593003

Change-Id: Id4e43cb78aa1aaeca74c0c3ee449e9bda91924aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:44:31 +00:00
TreeHugger Robot
f5153d5de2 Merge "Translate taskbar to hotseat without jump when swiping up from overview" into tm-qpr-dev am: 3dd1440520
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21592805

Change-Id: Ic8972961193226ab1cb1a0a31bd6ff9e12f980c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:40:43 +00:00
Brian Isganitis
0c15dabc48 Merge changes from topic "running-in-test-camel" into tm-qpr-dev am: d2d2913812
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21725479

Change-Id: Iad48010b9309567049338220a2300cf85f7567c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:34:39 +00:00
Brian Isganitis
3450bbf901 Make isTooltipEnabled a getter due to its mutable dependencies. am: aa08af872b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21652556

Change-Id: I85a188279b8461af0ac98763e9711252669b08e4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:34:33 +00:00
Vinit Nayak
f24a4d5208 Merge "Add null check for recents when tapping on Taskbar icons" into tm-qpr-dev am: f51426a6ee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21701337

Change-Id: I6f299319cac89a12e66c054d9baa39e1107c7651
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:34:02 +00:00
Brian Isganitis
f5dc57a910 Merge "Treat setup wizard default home as null." into tm-qpr-dev am: 5248b02080
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21690746

Change-Id: I51f0ca59c02cba6b44c38971be924dd9b0bb28f7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-04 06:33:34 +00:00
TreeHugger Robot
a176ad060f Merge "Sync overview scroll so that it ends before/at same time as taskbar animation" into tm-qpr-dev 2023-03-04 01:46:17 +00:00
Jeremy Sim
ad9bdcfd2d Merge "Create TAPL test suite for splitscreen" into tm-qpr-dev 2023-03-04 01:10:47 +00:00
Sunny Goyal
33c3e77411 Merge "Simplifying code around multiple translation components" into tm-qpr-dev 2023-03-04 00:59:54 +00:00
Sihua Ma
e0420ab2bc Fix an issue with concurrent modification on widget holders list
This could happen when the QuickstepWidgetHolder is not initialized on the main thread, or destroy() is not called on the main thread, while a random widget is removed at the same time which iterates the widget holder list and calls the callbacks.

Also fixing an issue with memory leak that is caused by the strong reference in WeakHashMap

Test: Presubmit
Fix: 271362384
Change-Id: I621ffb29c167cef9842758c5fdefd6bb66dd487e
2023-03-03 16:34:47 -08:00
TreeHugger Robot
3dd1440520 Merge "Translate taskbar to hotseat without jump when swiping up from overview" into tm-qpr-dev 2023-03-04 00:18:16 +00:00
Brandon Dayauon
ffc7084b37 Correctly make to spec the color for "Turn on work apps" button and add stroke
- define color in base and quickstep

bug: 267975252
test: Manual - video: lightTheme: https://drive.google.com/file/d/1noY5Grq4jOxFIheL91KB_sOYRwp8XIyD/view?usp=sharing
test: darkTheme: https://drive.google.com/file/d/1o1uaTedAKbPy3BTG1GKJ0ldyHFs0-jGN/view?usp=sharing
Change-Id: I266b6624aa6f045c1f30c0db984fa9e1c5f6fe7e
2023-03-03 15:42:13 -08:00
Brian Isganitis
d2d2913812 Merge changes from topic "running-in-test-camel" into tm-qpr-dev
* changes:
  Expose IS_RUNNING_IN_TEST_HARNESS as static method.
  Make isTooltipEnabled a getter due to its mutable dependencies.
2023-03-03 23:15:38 +00:00
Jon Miranda
8f2b50fdeb Sync overview scroll so that it ends before/at same time as taskbar animation
Fixes: 267355260
Test: open overview, scroll to 'Clear all button', tap on blank space
Change-Id: Ia58683f7b167ff42443dda3d39368bf6aaa366e0
2023-03-03 13:34:55 -08:00
Vinit Nayak
f51426a6ee Merge "Add null check for recents when tapping on Taskbar icons" into tm-qpr-dev 2023-03-03 21:33:52 +00:00
Brian Isganitis
5248b02080 Merge "Treat setup wizard default home as null." into tm-qpr-dev 2023-03-03 21:11:18 +00:00
Vinit Nayak
fc155dd5b0 Merge "Fix quick switch in between two split pairs crash" into tm-qpr-dev am: 750009face
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21460191

Change-Id: I5ee197302979a7ee12198d783a6ab703fe9acde1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-03 19:43:10 +00:00
Ats Jenk
7e7f2ff07e Merge "Hide desktop tile when choosing apps for split" into tm-qpr-dev am: 37d6a2be10
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21656508

Change-Id: I40adcf60f0628e8cf4e0c0d1198da7ad7ce975fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-03 19:41:48 +00:00
Schneider Victor-tulias
424d95ed87 Merge "Translate the TutorialStepIndicator to prevent overlapping skip and done buttons" into tm-qpr-dev am: 860b30e7ac
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21527494

Change-Id: I49eefbde68bdd93aac103bdc5f6d2094036bf391
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-03 19:39:11 +00:00
Vinit Nayak
750009face Merge "Fix quick switch in between two split pairs crash" into tm-qpr-dev 2023-03-03 19:37:04 +00:00
Ats Jenk
37d6a2be10 Merge "Hide desktop tile when choosing apps for split" into tm-qpr-dev 2023-03-03 19:32:13 +00:00
Schneider Victor-tulias
860b30e7ac Merge "Translate the TutorialStepIndicator to prevent overlapping skip and done buttons" into tm-qpr-dev 2023-03-03 18:14:44 +00:00
Nick Chameyev
fcf5d393eb Merge "Do not use private APIs in unfold module" into tm-qpr-dev am: c7ab991818
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21523105

Change-Id: Ida34210a83f096beb2c2bb9346dbe864ac09d2df
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-03 17:26:01 +00:00
Ats Jenk
ebd14d02a7 Merge "Support large desktop tile in grid only overview" into tm-qpr-dev am: 8e20d62034 am: e086649965
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21611657

Change-Id: I1aa8dfd348c9fc27597d3dbdb7884c4ed358dd57
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-03 16:54:26 +00:00
Johannes Gallmann
f54b88d2d6 Add onEndCallback to ContainerAnimationRunner
Bug: 247121782
Test: Manual, i.e. tested that callback is invoked after launch animation
Change-Id: Ie52ffa1b76de01943dd16346560768b3ecced118
2023-03-03 16:55:07 +01:00
Nick Chameyev
c7ab991818 Merge "Do not use private APIs in unfold module" into tm-qpr-dev 2023-03-03 13:22:03 +00:00
Vinit Nayak
26c893603f Add null check for recents when tapping on Taskbar icons
Fixes: 270669636
Test: Couldn't repro, but visually we have checks for
recentsView != null && OTHER_CONDITION, but in the else
case we don't check if recentsView being null is the reason
the if-block didn't get triggered

Change-Id: I72e7480bac56c7e7b7edb73edac4309e9923d302
2023-03-02 18:18:11 -08:00
Evan Rosky
b17c27e9f7 Merge "Part of recents transition wrap order" into udc-dev 2023-03-03 02:07:17 +00:00
Ats Jenk
e086649965 Merge "Support large desktop tile in grid only overview" into tm-qpr-dev am: 8e20d62034
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21611657

Change-Id: I79ec0ad431543b9bbc86fc1c1b159a6925c969c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-03 01:27:42 +00:00
Jeremy Sim
03815e6c79 Create TAPL test suite for splitscreen
This patch creates a new file, TaplTestsSplitscreen.java, containing one TAPL test sequence.

testSplitAppFromHomeWithItself() tests the user flow of splitting from home using an app that is already running, and then selecting the app itself again as a split target from the Taskbar. The expected result is that Launcher shows an error message gracefully and does not crash.

Fixes: 267554450
Test: Ran test file locally and verified that it passes.
Change-Id: I98a1e3a4143d10a6572175711059b3a77aa5dcd0
2023-03-02 16:35:54 -08:00
Brian Isganitis
473cfe0a1a Implement light mode for persistent Taskbar.
NavbarButtonsViewController has been massaged to make sure the buttons
contrast well with the color of the Taskbar background that they are on,
if applicable.

Test: Manual
Fix: 268052229
Change-Id: I917a1a1be013c304910b0f674ae8a13abb8e47a1
Merged-In: I917a1a1be013c304910b0f674ae8a13abb8e47a1
2023-03-03 00:35:20 +00:00