aixan/lawnchair
1
0
Fork 0
mirror of https://github.com/LawnchairLauncher/lawnchair.git synced 2026-03-02 08:56:55 +00:00
Code Issues Packages Projects Releases Wiki Activity
60,459 Commits 36 Branches 1,370 Tags
4f69ca52efa7a94de67a2b9c4956e233dfb23d92
Commit Graph

587 Commits

Author SHA1 Message Date
Vinit Nayak
26016622c1 Merge "Refactor SplitSelectStateController to add testing" into tm-qpr-dev am: c9120521ff am: 2fea4c6f1b 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21487925

Change-Id: I418fa47df9af8c94a31d3c30124c96cc78e6d758
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-02-23 00:53:05 +00:00
Vinit Nayak
4e3636e8d0 Refactor SplitSelectStateController to add testing 
Bug: 266482558
Change-Id: I2d62a3a310043710d66a26bc533df2309084b81e
 2023-02-22 10:51:49 -08:00
Vinit Nayak
ec5759b509 Merge "Add overview taskbar split support for 3P launcher" into tm-qpr-dev am: 0a9056502b am: 5c64c1dcb7 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21311163

Change-Id: I1a3433b8b327abf466f0149a8747a67a01c799f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-02-16 02:25:03 +00:00
Vinit Nayak
0a9056502b Merge "Add overview taskbar split support for 3P launcher" into tm-qpr-dev 2023-02-16 00:33:46 +00:00
Vinit Nayak
f4e7e5aaf4 Add overview taskbar split support for 3P launcher 
* Created b/268120202 to track other states of split
selection that are unhandled on 3P launchers

Test: Able to initiate split in overview with 3P launcher
Fixes: 264576761
Change-Id: I0311fe83380bf914fa79956b2565b61cc5eab916
 2023-02-15 11:26:06 -08:00
Schneider Victor-tulias
79855e7cb8 Merge "Add the KeyboardQuickSwitchView (2/2)" into tm-qpr-dev am: 25656568e3 am: 74ffb0ba89 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21087436

Change-Id: Ie6f0b30af20e5905fc10105bbf2fcf8a0db028b0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-02-15 06:15:48 +00:00
Schneider Victor-tulias
de7ceba80b Add the KeyboardQuickSwitchView (2/2) 
Adding KeyboardQuickSwitchView and associated flows.

Test: Manually tested alt-tab and alt-shift-tab in and out of overview on a tablet and phone
Bug: 258854035
Change-Id: Ifb48b005067b3a9c66acfd5ecdbae144b359d3be
 2023-02-14 13:34:37 -08:00
Thales Lima
bb056c6001 Merge "Create an XML parser for WorkspaceSpecs" into tm-qpr-dev am: 5d5aad3024 am: 0ebaf3a46c 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20643018

Change-Id: I471bb3ccd04a0598a309e53038976fbccb638ce1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-02-09 13:01:28 +00:00
Thales Lima
5d5aad3024 Merge "Create an XML parser for WorkspaceSpecs" into tm-qpr-dev 2023-02-09 11:19:59 +00:00
Jeremy Sim
c1237eb5e8 Merge "Improve resilience of testSplitFromOverview()" into tm-qpr-dev am: 5c5797d9bb am: b340f1401f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21314098

Change-Id: Ib1c5502717e5b956f65bdd6385655a211db51863
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-02-09 05:09:34 +00:00
Thales Lima
1a2d4bd6f4 Create an XML parser for WorkspaceSpecs 
Extract DeviceProfileTest to Launcher3 so it can be used in other tests as well, and change name of previous base test to be more descriptive.

Bug: 241386436
Test: WorkspaceSpecsTest
Change-Id: I64613bb5a23c374ed15fb6d936192236a541ab9b
 2023-02-08 11:20:14 +00:00
Jeremy Sim
5edd864c8d Improve resilience of testSplitFromOverview() 
This patch makes it so that TaplTestsQuickstep#testSplitFromOverview() is less flaky.

Previously, this test worked by tapping the center of a Overview tile to confirm split select. However, sometimes the tile would be halfway offscreen, so it would accidentally tap an overlapping UI element (the staged first app) instead, causing the test to fail.

Fixed by using getCurrentTask() to always select an Overview tile that is fully onscreen.

Fixes: 267794149
Test: Manual on phone, confirmed test passing
Change-Id: I8b89509bb53a16e45aea4545562989e2e964de2d
 2023-02-07 13:47:47 +08:00
Pat Manning
39ed8eecfd Merge "Make showing back for bouncer only rely on back disable status, not home and recents as well." into tm-qpr-dev am: f667823a8e am: 23aa4f8022 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21136526

Change-Id: Iec722d8821b90e3cb7021ba7d0a8d4076782f88a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-31 22:13:26 +00:00
Pat Manning
f667823a8e Merge "Make showing back for bouncer only rely on back disable status, not home and recents as well." into tm-qpr-dev 2023-01-31 21:13:46 +00:00
Pat Manning
7462c2ab62 Make showing back for bouncer only rely on back disable status, not home and recents as well. 
Fix: 260655218
Test: manual. Create second user, switch to three button nav, set lockscreen password, lock and show IME on lockscreen.
Change-Id: I1d874196afc24d5bae86d525a81ae199152fc750
 2023-01-31 14:57:26 +00:00
Schneider Victor-tulias
360f6d0130 Merge "Revert "Revert^2 "Cancel gestures on launcher destroy""" into tm-qpr-dev am: 7d346bf90b am: 030ba11d8c 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21100567

Change-Id: Ib3d7981a93d9647a3599df12e8093d31941550fa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-30 22:45:51 +00:00
Schneider Victor-tulias
7d346bf90b Merge "Revert "Revert^2 "Cancel gestures on launcher destroy""" into tm-qpr-dev 2023-01-30 21:39:50 +00:00
Schneider Victor-tulias
ece659d11a Revert "Revert^2 "Cancel gestures on launcher destroy"" 
This reverts commit 377eb40985.

Reason for revert: failing tests
Fixes: 266606727
Fixes: 266621449

Change-Id: I61094be02fb73c5ad65ee65be5ed93a3364f37ef
 2023-01-27 14:38:19 -08:00
Jon Miranda
55dd83a3d6 Merge "Split taskbar test methods by persistent/transient" into tm-qpr-dev am: 6f53364c14 am: bcf6b13ac5 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21120291

Change-Id: I6be4f5deb9511e03a9e7dac1bb3de0147d6e3b5f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-27 22:21:36 +00:00
Jon Miranda
6f53364c14 Merge "Split taskbar test methods by persistent/transient" into tm-qpr-dev 2023-01-27 21:27:01 +00:00
Jon Miranda
7acd32cf16 Split taskbar test methods by persistent/transient 
Test: TaplTestsTaskbar
Bug: 266861780
Change-Id: I0fc0ef58aa4bc087248ab223c4716992bc0cd692
 2023-01-26 16:08:23 -08:00
Evan Rosky
1d2abb366d Merge "Revert^8 "Enable Shell Transitions"" 2023-01-25 00:08:16 +00:00
Schneider Victor-tulias
cd09b276c5 Merge "Revert^2 "Cancel gestures on launcher destroy"" into tm-qpr-dev am: 74484f4a99 am: 86fbe3c7ea 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20680308

Change-Id: I8c6e5b7431631ce5577dc6ba8435d607fc3bc883
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-24 19:32:52 +00:00
Schneider Victor-tulias
74484f4a99 Merge "Revert^2 "Cancel gestures on launcher destroy"" into tm-qpr-dev 2023-01-24 17:55:54 +00:00
TreeHugger Robot
2cd37fb6fe Merge "Implement initial transient Taskbar EDU tooltips." into tm-qpr-dev am: 654f714718 am: 4d7e4c4a8e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20795522

Change-Id: I70307a411262909945f44e7e3b58ff721ccc10d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-21 09:02:06 +00:00
Evan Rosky
e0cfbc3475 Revert^8 "Enable Shell Transitions" 
d9cc7d1eb1

Change-Id: Ic59c027f05e47eb9939c0c65d19892451fd4ae50
 2023-01-21 02:20:39 +00:00
Evan Rosky
feedb575b8 Merge "Revert^7 "Enable Shell Transitions"" 2023-01-21 02:18:16 +00:00
Brian Isganitis
b21ad2da8c Implement initial transient Taskbar EDU tooltips. 
Since this tooltip looks and behaves differently than the existing EDU
sheet, it has its own view and controller implementations (I also may
have wanted to write some Kotlin).

To keep transient taskbar open while on the second EDU step, another
autohide suspend flag is defined. Additionally, special casing is added
to avoid hiding transient taskbar if autohiding is currently suspended.

Tooltips use the same assets as the bottom sheet for now, and are scaled
down to fit the tooltip dimensions.

Reset `Taskbar Education` in Developer Options to try EDU again.

[Demos]
- First: https://screenshot.googleplex.com/ASBeGvrb2EA5wEF.png
- Second: https://screenshot.googleplex.com/7fnfcTh9bMYezDc.png

Test: Manual
Test: Open app, see swipe-up tooltip.
Test: Swipe up to show transient taskbar, see features tooltip.
Bug: 263157739
Fix: 258460203
Change-Id: I473f5fccbae279db0614763b640da0a120b6b7f7
 2023-01-20 15:16:12 -08:00
Evan Rosky
d9cc7d1eb1 Revert^7 "Enable Shell Transitions" 
039217e518

Change-Id: Id82874ee3c209bb024b131b4a427eba25a84cd20
 2023-01-20 23:14:47 +00:00
Evan Rosky
f805d1ee93 Merge "Revert^6 "Enable Shell Transitions"" 2023-01-20 18:27:11 +00:00
Vinit Nayak
1b6c2b7f54 Merge "Add unit tests for TaskbarKeyguardController" into tm-qpr-dev am: 8d98dd2905 am: b069336a7e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21021735

Change-Id: I7591a0a13b438998abfaf84d8c647dd56a92f2a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-20 01:16:11 +00:00
Vinit Nayak
b1c47227b1 Add unit tests for TaskbarKeyguardController 
* Remove setting back button tint for SUW as that
is now done in ag/20953768

Bug: 230027385
Change-Id: I2c157ed67487cab9ba721fa659973351780509bb
 2023-01-18 10:42:45 -08:00
Christophe Pinelli
2acf5a8492 Merge "Make mutable PendingIntent explicit" into tm-qpr-dev am: 3cd6cbe6b4 am: ab2c2d9576 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953789

Change-Id: Iafef3bf70a5dfb0c5a72bf814d23d952cfd7f2f9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-12 20:02:04 +00:00
Christophe Pinelli
9d46bca1b9 Make mutable PendingIntent explicit 
Starting from target SDK U, we will block creation of mutable
PendingIntents with implicit Intents because attackers can mutate the
Intent object within and launch altered behavior on behalf of victim
apps. For more details on the vulnerability, see go/pendingintent-rca.

From a quick analysis, we concluded that the PendingIntent here was only
destined to the test app/to the app, so it was made explicit. Reviewers,
please call out if this is not the case.

Bug: 236704164
Test: atest NexusLauncherTests:com.android.quickstep.DigitalWellBeingToastTest
Test: atest RequestPinItemTest
Change-Id: I81311b0588b7b712c97de6cb016a62bb91c7a77c
 2023-01-12 01:51:44 +00:00
Thales Lima
bdfc07f1f0 Merge "Check kotlin format before uploading" into tm-qpr-dev 2023-01-10 16:41:58 +00:00
Thales Lima
03ac377a34 Check kotlin format before uploading 
This uses ktfmt on the PREUPLOAD hook to check file formatting.

Bug: 264851618
Test: manual
Change-Id: I8bdeabd9c1ed571a464707e6912419ad3190a169
Merged-In: I8bdeabd9c1ed571a464707e6912419ad3190a169
 2023-01-10 13:24:43 +00:00
Thales Lima
7a3c1e10a7 Check kotlin format before uploading 
This uses ktfmt on the PREUPLOAD hook to check file formatting.

Bug: 264851618
Test: manual
Change-Id: I8bdeabd9c1ed571a464707e6912419ad3190a169
 2023-01-09 17:45:42 +00:00
Wei Sheng Shih
573023084b Merge "[ShellTransit] Stabilize QuickSwitch test since Launcher can resumed." into tm-qpr-dev am: 485c8777cc am: 63a63996a5 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20828500

Change-Id: Ib48f066dc9ff1e3677f5b595862a3073e6f9b1ff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-06 12:15:47 +00:00
Vinit Nayak
3c64416769 Merge "Toggle taskbar button nav assistant availability" into tm-qpr-dev am: daffdfa35c am: 1e4e91b296 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20858639

Change-Id: Ib564b8b8a77765e8e8657ed7bbdaae7d14176f82
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-06 11:44:06 +00:00
Wei Sheng Shih
485c8777cc Merge "[ShellTransit] Stabilize QuickSwitch test since Launcher can resumed." into tm-qpr-dev 2023-01-06 03:27:56 +00:00
wilsonshih
ae4a9ac0d4 [ShellTransit] Stabilize QuickSwitch test since Launcher can resumed. 
QuickSwitch can resume Launcher activity due to transient launch when
shell transition is enabled, waiting for the Launcher leave resume
stage to make the test stable.

Bug: 263907455
Test: atest TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet
Change-Id: I2e6e0511cba51f4634ccf3da454e4be1dd93ffd1
 2023-01-04 07:23:51 +00:00
Vinit Nayak
0d784ee7fb Toggle taskbar button nav assistant availability 
* New signals coming in from Sysui reflect the toggle
in Settings for long pressing on home button to
invoke assistant.

Fixes: 255909545
Test: Manual + added unit test for TaskbarNavButtonController
Change-Id: Ic65a80b0b9697990931b7e89756773fb086cc3bd
 2023-01-03 20:07:27 -08:00
Schneider Victor-tulias
377eb40985 Revert^2 "Cancel gestures on launcher destroy" 
f0de6cc2ca

Bug: 261816852
Fixes: 244593270
Fixes: 257976590
Fixes: 261504234
Test: FallbackRecentsTest#goToOverviewFromApp and FallbackRecentsTest#goToOverviewFromHome
Change-Id: If49a08fd62b99c9bbc007900b613b83747916f5f
 2023-01-03 11:31:05 -08:00
Alex Chau
e13b1a22f9 Merge "Polish hotseat and taskbar with 3 buttons" into tm-qpr-dev am: 4537638dfd am: 0d5ca5fe6f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20533919

Change-Id: I37921b47514fc4823b2c6ee7d61fbf1ff6ca7c67
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-12-19 12:26:25 +00:00
Thales Lima
6a59006592 Polish hotseat and taskbar with 3 buttons 
Change margin spaces and logic of how many items the hotseat and taskbar should show.

Fix: 246424857
Test: DeviceProfileDumpTest
Test: HotseatWidthCalculationTest
Change-Id: I8ec71c56a0aa362483c43d6400c762d12cf45f5b
 2022-12-17 11:20:21 +00:00
Alex Chau
c92b91c579 Merge "Don't scale iconSize and textSize in non-default display size" into tm-qpr-dev am: 5c1eb61391 am: 881b7f2d55 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20691430

Change-Id: I083054a14d61a8ebd212c1d1dde5ee210eb84fd3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-12-14 18:12:34 +00:00
Alex Chau
be753137a2 Don't scale iconSize and textSize in non-default display size 
- Cells should get extra space by reducing borderSpace. If that's still not enough, use 0 borderSpace and distribute the space

Fix: 256976071
Fix: 248348171
Test: manual
Change-Id: I067c1aaa553d7a84caeeb9ce21e80cfaf86a3bed
 2022-12-13 16:30:14 +00:00
Sebastián Franco
bdee8e4313 Merge "Ignore all launcher3 flaky test so that they come back online" into tm-qpr-dev am: 878ae3fc85 am: 64d68ce0c7 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20647519

Change-Id: I255b21e3e06e93c90f7b718d265d166abc4b4e72
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-12-07 20:50:40 +00:00
Sebastian Franco
150e572e05 Ignore all launcher3 flaky test so that they come back online 
Test dashboard: https://android-build.googleplex.com/builds/tests/search?filter=mediumFailureRate&filter=highFailureRate&query=config%3Av2%2Fgnl-eng%2Funbundled%2Flauncher%2Flauncher3_test_platform+latest%3A4d&tab=tests

Test: dashboard should not show flaky tests
Bug: 256832045
Change-Id: I06e879dec2703455b7be728c7afd3500d2edd54a
 2022-12-06 17:08:45 -08:00
Vinit Nayak
84c70ff18e Merge "Update test for change in calculation of split portrait clipping" into tm-qpr-dev am: 2cf7994908 am: 5d1bee3835 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20617554

Change-Id: Ib9db0563e56d4c49a522075e609c93740acd0add
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2022-12-02 20:46:36 +00:00