Commit Graph

1053 Commits

Author SHA1 Message Date
Tony Wickham
4f69ca52ef Merge "Remove unused/obsolete feature flags" into udc-dev 2023-05-15 21:46:15 +00:00
Tony Wickham
53c811fd7d Remove unused/obsolete feature flags
Flag: N/A
Test: N/A
Fixes: 270391641
Fixes: 270395077
Change-Id: I91834b43bf043a26c2fe8e5f7b2e720592830918
2023-05-12 21:09:30 +00:00
fbaron
55c10be912 Update app ring color and alpha
Bug: 268521231
Test: Verify that app ring colors match the figma attached in the bug
Flag: no flag
Change-Id: I2270f6e5e3ad2c653aad36feb2232a672bdf2a79
2023-05-11 15:45:52 -07:00
Saumya Prakash
aca2b95fc6 Remove unused Sandbox Mode in the gesture navigation tutorial
Sandbox Mode for the gesture navigation tutorial is unused in both the
current and redesigned versions of the tutorial, and can therefore be
removed.

Flag: N/A
Fix: 280641779
Test: Manually went through both versions of the tutorial on handheld,
foldable, and tablet devices

Change-Id: I2f6db47df0fa39458d17221f24827eb43e2cae31
2023-05-03 21:27:56 +00:00
Saumya Prakash
32a38c9ff1 Merge "Remove unused Assistant gesture tutorial and add error checking" into udc-dev 2023-05-03 17:37:52 +00:00
Fengjiang Li
c15679d512 Merge "[1/n] Launcher Startup Latency: add StartupLatencyLogger to launcher3 and log startup latency" into udc-dev 2023-05-03 03:18:46 +00:00
Fengjiang Li
5a36c17a32 [1/n] Launcher Startup Latency: add StartupLatencyLogger to launcher3 and log startup latency
More details at "Log Startup Latency" section in go/launcher-startup-latency

Test: tested on phone, foldable and tablet, print latency logs in logcat
Bug: 278092752
Change-Id: Ibf269b0ecd6007d29b95e36f65ab6f02c45deb3a
2023-05-02 17:08:05 -07:00
Sihua Ma
8f85ad38ba Merge "Fix ConcurrentModificationException in QuickstepWidgetHolder" into udc-dev 2023-05-02 21:26:53 +00:00
Saumya Prakash
94c8cf49cf Remove unused Assistant gesture tutorial and add error checking
The Assistant gesture tutorial is unused in both the current and
redesigned gesture nav tutorials and can be removed. Left in, its
detections of gestures are leading to bugs with the tutorial.

Additionally, this change adds in error checking for side swipes in the
overview tutorial.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 280115831
Fix: 261239858
Fix: 278926113
Test: Manually went through both versions of gesture tutorial on
handheld, foldable, and tablet devices

Change-Id: Ie481d92ede2c2ab16ce2b3d1f729f6cb88f1b4c0
2023-05-01 17:58:54 +00:00
Vinit Nayak
2a014d4c0d Refactor handling data launching split screen to separate class
* SplitSelectDataHolder contains logic for knowing how
to launch split, separate from the actual API calls to launch split

Flag: ENABLE_SPLIT_LAUNCH_DATA_REFACTOR
Bug: 279494325
Test: Tested w/ all 6 types of launches noted in
SplitSelectDataHolder#@SplitLaunchType.
Also checked to make sure most-recent running tasks are
still being used where applicable.

Change-Id: I8114f87e9956b100622c80f578e291937ed4eeac
2023-04-28 18:00:22 -07:00
Sihua Ma
d72ce23707 Fix ConcurrentModificationException in QuickstepWidgetHolder
If the listeners would modify the listener list in the widget holder, this would cause a ConcurrentModificationException.

Fix: 275100497
Test: N/A
Change-Id: I3ae0e92db71f1c21d35dbf391dfcb92b46dd30f1
2023-04-28 14:21:24 -07:00
Vinit Nayak
80a3213d6b Merge "Route PredictedAppIcon clicks through launcher" into udc-dev 2023-04-25 23:20:41 +00:00
Vinit Nayak
1bb594c72b Route PredictedAppIcon clicks through launcher
* This allows us to intercept launching predicted apps for
split-screen if user is in split selection flow
* Defaults to existing behavior of ItemClickHandler.INSTANCE
if we do not need to intercept the click

Bug: 276361926
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Test: Launches as expected when not in split, launches in
split when selected as second app to initiate split with

Change-Id: Ieb45137ae89da340d314e995f4f6eb1f8b49a42f
2023-04-25 12:31:56 -07:00
Tracy Zhou
eb55f83d88 Merge "Support 4-finger gesture to quick switch" into udc-dev 2023-04-25 18:21:37 +00:00
Vinit Nayak
955555a314 Merge "Support splitting from workspace with Widgets" into udc-dev 2023-04-22 03:55:23 +00:00
Vinit Nayak
fd46900b96 Support splitting from workspace with Widgets
* Need to insert widget's icon in animation
* Launching w/ same package app + widget is
broken

Test: Launched apps from predicted apps + widget,
hotseat apps + widget
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Bug: 276361926

Change-Id: I3e30189e56536371ebd0acfbdd2c073a882cc731
2023-04-21 14:05:12 -07:00
Fengjiang Li
5068718fe8 Merge "Check build version before using predicitve back API" into udc-dev 2023-04-21 20:22:09 +00:00
Fengjiang Li
d0c2359a49 Check build version before using predicitve back API
Test: build and run app
Fix: 278798546
Change-Id: I4a7b226b1d710cc84ef40b59a33f50a84aca84bb
2023-04-21 09:38:59 -07:00
Presubmit Automerger Backend
cc471ee2ee [automerge] Clear Accessibility Focus from icon after Shorcut Menu invoked 2p: cb582591b3 am: 5ab41346d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22750962

Change-Id: I16a861cfa872f928c5e4414a9f0ecdceacf1f325
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-21 03:57:05 +00:00
Jon Miranda
cb582591b3 Clear Accessibility Focus from icon after Shorcut Menu invoked
Similar to I2726504094af2abacf1c41089c7bcd4efb588099

Fixes: 267695526
Test: have talkback on
      open all apps
      open long press menu
      ensure focus stays on pop up menu

Change-Id: I38f78df3855495c53a5ae8966e9a996e4679e95b
2023-04-20 16:21:02 -07:00
Tracy Zhou
7dc9e3a088 Support 4-finger gesture to quick switch
Fixes: 270610237
Test: 4-finger horizontal swipe -> quick switch
Change-Id: I981a7e93ecd07357c7a9cda075f476b397c448cc
2023-04-20 22:34:19 +00:00
Tracy Zhou
75b534e9c9 Support 3-finger swipe to pull down notifications from app
Fixes: 270211015
Test: 3-finger swipe down to bring down notifications. 3-finger swipe up to go home / to Overview

Change-Id: Id0f8ad95d9a4a1f8ecf1632ea28efb0c790c291b
2023-04-19 23:37:37 -07:00
Stefan Andonian
4c28cd49ca Merge "Make all debug feature flags boot aware." into udc-dev 2023-04-13 22:05:36 +00:00
Stefan Andonian
85f1024f44 Make all debug feature flags boot aware.
Bug: 276090194
Test: FeatureFlags worked on device.
Change-Id: I710801d63e6f4283bf15daea2b5be5874de21cc8
2023-04-12 21:02:13 +00:00
Sihua Ma
4c233bd645 Merge "Attempt to fix concurrent modification issue in QuickstepWidgetHolder" into udc-dev 2023-04-11 02:14:22 +00:00
Sihua Ma
6090c345a1 Do not clear the changed view when there is an update to RemoteViews
The way we are stashing the pending updates should follow the behavior pattern as that shown in AppWidgetServiceImpl

Fix: 277120633
Test: Manual
Change-Id: I92b3edb078b30873c2ef1b9fe408cbb76a34e135
2023-04-10 13:45:25 -07:00
Tony Wickham
af02f865ee Merge "Add debug logs for why taskbar might not be destroyed" into tm-qpr-dev am: c8d8c58f5b am: 3979706e06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22391708

Change-Id: I6213932faa483c24c9d083b95ee9247c47127128
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-04 16:37:08 +00:00
Tony Wickham
df59884370 Add debug logs for why taskbar might not be destroyed
Test: Manually read log output
Flag: None
Bug: 254119092
Change-Id: Ibaa7ffdc91030c5c999ddc5f2807a55763854331
2023-04-03 23:20:57 +00:00
Fengjiang Li
9529f08b1b Merge "[Predictive Back] Gate feature under experiment flag" into udc-dev 2023-04-03 17:39:56 +00:00
Vinit Nayak
02f20dddb0 Merge "Default to using SplitSelectSource drawable if TaskView icon drawable is null" into tm-qpr-dev am: 8e307ba50a am: 3e5b212204
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22347415

Change-Id: I2f3da1c74ed5ae04ff9cbc4bc06e280da5390b4d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-03 15:54:11 +00:00
Vinit Nayak
8e307ba50a Merge "Default to using SplitSelectSource drawable if TaskView icon drawable is null" into tm-qpr-dev 2023-04-03 14:58:29 +00:00
Sunny Goyal
ef6b0c0700 Adding a Teamfood flag option
This allows a targetting a collection of flags to a specific group
either using rollout or via opt-in

Flag: N/A
Bug: 274517185
Test: Verified that the team food flag controls dependent-flags
Change-Id: I7e02964d778e3fbf54eda0f34bab8ec5a1206e40
2023-04-02 18:20:30 +00:00
Sihua Ma
5ade3e1fef Attempt to fix concurrent modification issue in QuickstepWidgetHolder
Test: N/A
Bug: 275100497
Change-Id: I5db18ff38aa280c2a9957c457ac9565570933513
2023-03-31 17:06:43 -07:00
Fengjiang Li
dcefed1c98 [Predictive Back] Gate feature under experiment flag
As predictive back will be launched for U-QPR, we should gate it to avoid it leaked to U launch.

Test: turn on/off ENABLE_BACK_SWIPE_LAUNCHER_ANIMATION flag and verify predicitive back is turned on/off
Bug: 264920023
Change-Id: Ieee14ca9d49f052f183d8734d62443b890210544
2023-03-31 14:14:03 -07:00
Vinit Nayak
ecca8eacbc Default to using SplitSelectSource drawable if TaskView icon drawable is null
* Alternative solution could be to set
onTaskViewVisibilityChanged(true) for the taskView that is about
to be dismissed so it loads it's taskIcon/thumbnail back from the cache
* However, that does still leave us open to race conditions (even though
we can be reasonably confident the icon is probably in the cache)
* Also made other changes to allow already public fields on some classes
to be mockable for unit testing

Fixes: 275267738
Test: Tested with fullscreen task at end of overview,
GroupedTaskView at end of overview,
Initiating split from home,
Initiating split from overview actions,
Initiating split from overview app icon

Change-Id: Ic9059c93c07b90f61c9f418d5d36d6ba201ff96a
2023-03-30 15:26:57 -07:00
Schneider Victor-tulias
6468ce77b8 Merge "Add the gesture nav tutorial menu page" into tm-qpr-dev am: 1db2fcbd19 am: cafab1d7cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22119029

Change-Id: Id6121e8c572666f182e0b2d0ca250c636236f19f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 17:28:13 +00:00
Schneider Victor-tulias
f8f602d76c Merge "Fix TwoPanelWorkspaceTests" into tm-qpr-dev am: 90259a6db4 am: d8e5795131
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22185922

Change-Id: Ic5d6ce2a870f19c960baab3af8abfb1faee248f1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 17:16:22 +00:00
Schneider Victor-tulias
1db2fcbd19 Merge "Add the gesture nav tutorial menu page" into tm-qpr-dev 2023-03-29 18:54:22 +00:00
Schneider Victor-tulias
2851be8cba Add the gesture nav tutorial menu page
- Added the gesture tutorial menu page (launched using an intent extra)
- tutorial steps now launch the menu when complete if launched from the menu
- the new default set of tutorial steps is home -> back -> overview. this is to handle the case where an intent is launched that is meant to launch the tutorial menu, but ENABLE_NEW_GESTURE_NAV_TUTORIAL is false

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 274463555
Test: Ran the tutorial and menu on a large screen, foldable and phone
Change-Id: I2eb5f658115be4d5ecb0233a8f09d22efe6ebadc
2023-03-27 14:36:01 -07:00
Schneider Victor-tulias
7cd0ae3f73 Fix TwoPanelWorkspaceTests
- Marking the hotseat long press edu as seen on setup to allow the popup menu to be shown immediately in tests
- Recording onWorkspaceItemLongClick on prediction item long click

Flag: not needed
Fixes: 273239675
Test: TwoPanelWorkspaceTest
Change-Id: I76354fd2e3adde11b2a428374fa9c8855ce2ece9
2023-03-27 14:24:35 -07:00
Hyunyoung Song
c5d4b109ee Merge "Revert "Revert "Hide the splash icon when launching with no view..."" into tm-qpr-dev am: e8abfee5e9 am: bb1237eb76
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22067827

Change-Id: I491a12f6d11c40c165b83f4bd61cf5d9f79d55c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 23:00:41 +00:00
Hyunyoung Song
e8abfee5e9 Merge "Revert "Revert "Hide the splash icon when launching with no view..."" into tm-qpr-dev 2023-03-24 21:41:04 +00:00
Tracy Zhou
8e9db80dac Merge "Update home screen trackpad gesture behaviors" into udc-dev 2023-03-23 19:03:40 +00:00
Tracy Zhou
897e665852 Update home screen trackpad gesture behaviors
- 3-finger swipe up to go to overview
- 2-finger swipe down to pull down notifications
- 2-finger swipe up to open all apps

Fixes: 273972106
Test: manual
Change-Id: I61bd0ad98b21abeb5f9b00786fe358c03a49f539
2023-03-22 23:00:07 +00:00
Tony Wickham
89501aede7 Merge "Set PredictedAppIcon ring disabled when icon is disabled" into tm-qpr-dev am: f93aa98e3a am: b04aeba66b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22125079

Change-Id: Id47004d671ec6f4493217a9e50007b25296e1474
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 19:58:53 +00:00
Tony Wickham
1e29b04f19 Set PredictedAppIcon ring disabled when icon is disabled
Test: drag a predicted app from taskbar, ensure both ring and icon are
set to grayscale
Fixes: 268759548

Change-Id: I764ebcd486c09eceaf30c5bd5153a1dd2ff5be72
2023-03-22 16:53:10 +00:00
Tracy Zhou
a33fb69603 Disable 3-finger workspace scroll
Fixes: 274474023
Test: 3-finger horizontal scroll on the workspace doesn't do anything
Change-Id: I32ade8a5c26eae43f5ce9c8c71d47ed0d1abd5a2
2023-03-21 17:17:35 -07:00
Hyunyoung Song
a38aab93b9 Revert "Revert "Hide the splash icon when launching with no view..."
Revert submission 21916962-revert-21447384-no-splash-UILAXIUPKJ

Reason for revert: Retry errorprone target

Reverted changes: /q/submissionid:21916962-revert-21447384-no-splash-UILAXIUPKJ
Flag: production issue. Not hidden behind flag
Bug: 269343536
Test: manual

Change-Id: Ia365f886d39d63472d72afc2033fc67e19109f57
2023-03-20 23:33:11 -07:00
Mateusz Cicheński
cb7aabd110 Merge "Enable ENABLE_PIP_KEEP_CLEAR_ALGORITHM for teamfood" into tm-qpr-dev am: c8f3c1f172 am: e24ca392e1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21353290

Change-Id: I0754262532fcb792a823658ea494f5e8faa9939c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-18 01:18:43 +00:00
Mateusz Cicheński
2ef25f91ba Enable ENABLE_PIP_KEEP_CLEAR_ALGORITHM for teamfood
Change-Id: I7c09494514dd6ea1baea51a03114c8e77cae118d
Test: atest WMShellFlickerTests
Bug: 183746978
2023-03-17 19:37:41 +00:00