Commit Graph

17248 Commits

Author SHA1 Message Date
Winson Chung
4f17c97d03 Defer nav handle action until after the recents transition is complete
Bug: 303078360
Test: Force delay in finishing recents transition and verify with bug steps
Change-Id: I2021cc291204261de56ef9c912d8b5935059c7fb
Signed-off-by: Winson Chung <winsonc@google.com>
2023-10-06 03:42:35 +00:00
Tracy Zhou
528356e744 Merge "Fix task bar crash in gesture nav mode with task bar / nav bar unification on" into main 2023-10-05 23:38:13 +00:00
Stefan Andonian
9acb884c90 Merge "Permanently provide functionality for LauncherPref items that don't need to be migrated, but are boot aware." into main 2023-10-05 21:14:24 +00:00
Stefan Andonian
23f869f0f0 Merge "Don't show FloatingIconView during Back to Home Animation when animations are disabled." into main 2023-10-05 20:22:49 +00:00
Tony Wickham
d7c43cab9b Merge "Fix gestures for exclude-from-recents + translucent tasks" into udc-qpr-dev am: cf596d4178 am: 3809c0a278
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24840504

Change-Id: Id81adcfc07d2c6a01655b4d88df524764b38e5fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 19:37:58 +00:00
Tony Wickham
3809c0a278 Merge "Fix gestures for exclude-from-recents + translucent tasks" into udc-qpr-dev am: cf596d4178
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24840504

Change-Id: I4a2cc03328d09757ff1a5454138b61794a5cadee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 19:05:04 +00:00
Vinit Nayak
c939620fd1 Merge changes Id9a74edd,Iab1f1e99 into main
* changes:
  Support fullscreen split selection launch for contextual
  Add icon when launching widgets in split
2023-10-05 18:31:15 +00:00
Tony Wickham
cf596d4178 Merge "Fix gestures for exclude-from-recents + translucent tasks" into udc-qpr-dev 2023-10-05 18:16:40 +00:00
Stefan Andonian
17ee527e15 Don't show FloatingIconView during Back to Home Animation when animations are disabled.
Bug: 235915161
Test: Reproduced the issue locally, then verified that the fix worked as
desired without introducing unwanted side effects.

Change-Id: I3db3b2ddbd34a2ef19eae10282758df32c2d5b3f
2023-10-05 17:44:12 +00:00
Anushree Ganjam
2fbb34fc7b Developer options should reflect the correct DeviceConfig value for ReleaseFlag. am: 13517070d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24945015

Change-Id: Ic0b22dd740409cafc3a4224e3dba3ed7ac60516f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-05 16:09:05 +00:00
Alex Chau
2ca7481b04 Merge "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag" into main 2023-10-05 15:40:17 +00:00
Uwais Ashraf
cfaba6e814 Merge "Align empty recents message+icon to center of View." into main 2023-10-05 09:00:28 +00:00
Tracy Zhou
27d7769000 Fix task bar crash in gesture nav mode with task bar / nav bar unification on
a11yButton is reserved for 3-button mode so it can be null. Also TaskbarNavLayoutter is used for large screen both in gesture nav and 3-button mode, so need to check isContextualButtonShowing to add contextual buttons

Fixes: 300849078
Test: Make sure that it doesn't crash in large screen gesture nav mode
Change-Id: I9d0694b7f4c95461f24efb2af1af905e68e3cd8d
2023-10-04 20:17:23 -07:00
Anushree Ganjam
13517070d8 Developer options should reflect the correct DeviceConfig value for ReleaseFlag.
Before this change : When a ReleaseFlag is turned on from server side or
set in DeviceConfig, developer options shows the flag is off.

After this change : When a ReleaseFlag is turned on from server side or
set in DeviceConfig, developer options shows the flag is on.

This change doesn't reflect the DeviceConfig value changes done using
`adb shell device_config put` unless launcher is restarted.

Bug: 297202824
Test: Manual
Flag: NA

Change-Id: I5d83207cf454c60278fd02e59199207e855d51a8
Merged-In: I5d83207cf454c60278fd02e59199207e855d51a8
(cherry picked from commit 9eb68bb7cf)
2023-10-05 01:45:32 +00:00
Stefan Andonian
54495f3018 Permanently provide functionality for LauncherPref items that don't need
to be migrated, but are boot aware.

Bug: 251502424
Test: Tested that Migration works as expected, as well as shared
preference information that doesn't need to be migrated. Also sanity
tested phone in general.

Change-Id: Ie8460e360856cbe20a7770b1747f75c7154759ab
2023-10-04 23:32:58 +00:00
Vinit Nayak
ae3c5749ef Support fullscreen split selection launch for contextual
* Migrate animating split placeholder to fullscreen into
SplitAnimationController from RecentsView to consolidate
* Reset state from RecentsView via a callback

Fixes: 295457117
Test: Tapping on placeholder in overview and home works
as expected

Change-Id: Id9a74eddc134a0470110845b90729c05193a1f93
2023-10-04 16:05:03 -07:00
Vinit Nayak
a6bf642d5a Add icon when launching widgets in split
* Load the icon in the BG (though it should be
cached), then run the animation in the FG

Test: Initiating split contextually with a widget
shows icon
Bug: 293935354
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE

Change-Id: Iab1f1e9965479b0f84c74c2a5ae6e272b9a5db3a
2023-10-04 16:05:02 -07:00
Vadim Tryshev
e8f7dd5a51 Merge "Further tightening leak detector checks" into main 2023-10-04 22:18:18 +00:00
Vadim Tryshev
c116cee748 Further tightening leak detector checks
Some checks see 2 activities for some reason: Launcher and Overview.
Both active.
I'll have to decide what to do with these cases, but for now, I simply don't pass 'true' from places where this can happen.

When we have 2 activities:
Either Overview is present (and I guess we have to close it before the check) or the screenshot shows that there is no Overview, but internally, apparently, Overview activity is active and therefore, technically, is not leaked.
For the latter case, I may need to do some kind of investigation.
But for now, I'm tightening the check where there is no Overview.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I1f1619093e0948b8112f29fd7e94facbf7093983
2023-10-04 22:18:12 +00:00
Anushree Ganjam
9a809d9121 Merge "Developer options should reflect the correct DeviceConfig value for ReleaseFlag." into main 2023-10-04 22:14:41 +00:00
Tony Wickham
94a0a58b37 Fix gestures for exclude-from-recents + translucent tasks
- If task is translucent and excluded, fade out as swipe up
  - Fade back in when re-launching live tile
- Ignore excluded tasks if there is another visible task,
  and use that underlying task during gesture instead.

Fixes: 299351175
Fixes: 300297333
Fixes: 302672319

Test: Invoke translucent + excluded app (e.g. expanded Volume
dialog) over another app, swipe to overview, quick switch, home

Change-Id: I5740afc4bf561d1a264bd132863ffc15f27d2b20
2023-10-04 20:23:07 +00:00
Anushree Ganjam
9eb68bb7cf Developer options should reflect the correct DeviceConfig value for ReleaseFlag.
Before this change : When a ReleaseFlag is turned on from server side or
set in DeviceConfig, developer options shows the flag is off.

After this change : When a ReleaseFlag is turned on from server side or
set in DeviceConfig, developer options shows the flag is on.

This change doesn't reflect the DeviceConfig value changes done using
`adb shell device_config put` unless launcher is restarted.

Bug: 297202824
Test: Manual
Flag: NA

Change-Id: I5d83207cf454c60278fd02e59199207e855d51a8
2023-10-04 11:43:58 -07:00
Uwais Ashraf
e61ad56098 Align empty recents message+icon to center of View.
Seems like it was previously aligned to center of task which doesn't always look good.

Screenshots:
Handheld before - https://screenshot.googleplex.com/6GmqhTjUhUpwwBs
Handheld after - https://screenshot.googleplex.com/3QMYCQaS6USMQYy

Tablet before - https://screenshot.googleplex.com/7tsERFGVsa6QSNY
Tablet after - https://screenshot.googleplex.com/8itDgQ2jDTHk463

Unfolded before - https://screenshot.googleplex.com/AJaqC9LqP2Dwfz2
Unfolded after - https://screenshot.googleplex.com/8aaa7ZhemqHXHRh

Fix: 299100892
Test: OverviewEmptyMessageImageTest and observed on tablet, handheld and unfolded.
Change-Id: I538d25e5a98e25351e71718de3ca572fd00438ad
2023-10-04 14:57:11 +00:00
Bill Yi
6105891d36 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If4ad039f050e4561270ff10218401060c3f94362
2023-10-03 22:14:28 -07:00
Tracy Zhou
b1122a4ad3 Merge "Fix some merge issues in repositioning contextual buttons for taskbar/navbar unification" into main 2023-10-04 04:00:24 +00:00
Jeremy Sim
4986aa85e5 Merge "App Pairs: App pairs now save with automatic default name and custom split ratios" into main 2023-10-04 00:06:57 +00:00
Vadim Tryshev
23825e84a8 Merge "Tearing down the test safely." into main 2023-10-03 21:02:51 +00:00
Liran Binyamin
5bec1164b9 Merge "Make the bubble bar flag dynamic in Launcher." into main 2023-10-03 17:47:11 +00:00
Jeremy Sim
6ac8949fc4 App Pairs: App pairs now save with automatic default name and custom split ratios
[App Pairs 4/?]

This patch includes:
- Ability to save and launch app pairs with custom 0.3, 0.7, or 0.5 split ratios
- App pairs now save with default name "App1 | App2"
- Grid migration, prediction, and other misc. flows should now work with app pairs

Flag: ENABLE_APP_PAIRS (set to false)
Bug: 274189428
Test: AppPairsControllerTest.java
Change-Id: I46dd3e30f8de03dd3e6d086c8ff9fc52e7e7fd2b
2023-10-03 10:38:03 -07:00
Liran Binyamin
e41e6185e4 Make the bubble bar flag dynamic in Launcher.
Changing the flag currently requires a reboot, because it is read once when the process starts and never changes.
This change triggers a re-read of the flag value from SystemProperties whenever Taskbar is recreated.
This allows setting the flag as part of integration tests for bubble bar.

Bug: 273994695
Test: Manual:
       - turn flag off
       - create bubbles
       - observe floating bubbles are added
       - turn flag on
       - change navigation mode to gesture navigation
       - observe bubble bar becomes visible
Change-Id: I277ea6aa2c8d3ab04094537bf4cd31630310dfec
2023-10-03 10:49:30 -04:00
Alex Chau
6f264a927b Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig flag
Bug: 270397206
Test: OverviewActionsControllerTest
Flag: enableGridOnlyOverview
Change-Id: I1519e0e8d5b8a7e294d2d310c1614e8462649031
2023-10-03 12:58:18 +01:00
Tracy Zhou
5b3c85564f Fix some merge issues in repositioning contextual buttons for taskbar/navbar unification
Fixes: 300849078
Test: Rotate around, and make sure the rotation button stays in the same corner
Change-Id: Ifb7904117f4ae8b28f2d14b27fbb39fe1a82e6ae
2023-10-03 01:09:56 -07:00
Vadim Tryshev
c0489b41a7 Tearing down the test safely.
If the test fails to initialize properly, tearDown is still called,
and we may have null Launcher activity.

We want to safely skip using that activity to avoid a NullPointerException
that would hide the original error message.

Bug: 303070230
Test: presubmit
Flag: N/A
Change-Id: I3bb07fa55e5793c73caaaeda57168aa11c85893e
2023-10-02 18:51:42 -07:00
Vadim Tryshev
d8c049f2af Starting to tighten leak detector checks
This will help to detect leaks earlier, not when we have 3 activities in some cases, but when we have 2.

Adding a parameter that enables more strict detection, and using it in some places.

I'll try to convert as many places as possible to the more strict check after landing this CL.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Idd5a0386005e46dad8aab222bd77c0240f23f43a
2023-10-02 18:34:32 -07:00
Vadim Tryshev
a6b74ffdfc Merge "Verifying that workspace looks correct at the end of the test." into main 2023-10-02 21:48:04 +00:00
Tracy Zhou
fe38407873 Merge "Repostion contextual buttons upon layout changes" into main 2023-10-02 20:15:31 +00:00
Brian Isganitis
c0b9b422be Merge "Add AllApps TAPL APIs for toggling with meta key." into main 2023-10-02 19:09:38 +00:00
Alex Chau
8eb662c67b Merge "Create icon app chip menu for overview tasks." into main 2023-10-02 17:40:33 +00:00
Alex Chau
a84e50412c Merge "Mark existing Launcher CUJs as Platinum tests." into main 2023-10-02 13:05:30 +00:00
Pat Manning
1695cc724c Create icon app chip menu for overview tasks.
Fix: 257951354
Test: TaplTestsQuickstep
Test: TaplTestsSplitscreen
Flag: ENABLE_OVERVIEW_ICON_MENU
Change-Id: Id8a14b1970ae42bcc74e95419caeaf52ef63638b
2023-10-02 12:51:56 +00:00
Schneider Victor-tulias
8f795844e9 Merge "Refactor the BorderAnimator for simplicity" into main 2023-10-01 17:27:16 +00:00
Vadim Tryshev
b57e25127e Verifying that workspace looks correct at the end of the test.
I hope that this will lock bugs like b/298114205 in the test that created the bad condition, not the next one.

Bug: 298114205
Test: presubmit
Flag: N/A
Change-Id: If9b48fb5159fc35948607a99f87199d5a32e64d6
2023-09-29 18:31:04 -07:00
Pat Manning
ff74bb5ded Mark existing Launcher CUJs as Platinum tests.
Exclusion CL: cl/565329636 & cl/569615823

Acceptance Criteria:
- TaplTestsQuickstep#testOverviewActionsMenu: https://android-build.corp.google.com/test_investigate/?invocationId=I68300010197543619&testResultId=TR13128935381586398&tab=performance
- OopTaplOpenCloseAllApps#testAllAppsSwipeUpToWorkspace: https://android-build.corp.google.com/test_investigate/?invocationId=I29900010197342608&testResultId=TR26328933842394642&tab=performance
- AddWidgetTest#testResizeWidget: https://android-build.corp.google.com/test_investigate/?invocationId=I56600010197561454&testResultId=TR14428935383013115&tab=performance
- TaplTestsLauncher3#testLaunchHomeScreenMenuItem: https://android-build.corp.google.com/test_investigate/?invocationId=I56600010197561454&testResultId=TR20028935383489058&tab=performance

Bug: 300249773
Test: TaplTestsLauncher3
Test: OopTaplOpenCloseAllApps
Test: AddWidgetTest
Test: TaplTestsQuickstep
Change-Id: Ica71dbad91efe8f5b4fd243f0ec78fc3c3c4d456
2023-09-29 23:27:27 +00:00
Jagrut Desai
9c80d72947 Merge "Fixing testQuickSwitchToPreviousAppForTablet" into main 2023-09-29 19:38:48 +00:00
Brian Isganitis
c3c0664ab1 Add AllApps TAPL APIs for toggling with meta key.
Test: TAPL
Bug: 300147433
Flag: No
Change-Id: Ie4d91ac77a325febb521806a008f8fcad5869f85
2023-09-29 15:26:42 -04:00
Schneider Victor-tulias
7335bcf7f5 Refactor the BorderAnimator for simplicity
The internal implementation of BorderAnimator does not need to be as exposed. refactored the class to be simpler to implement

Flag: ENABLE_KEYBOARD_QUICK_SWITCH, ENABLE_CURSOR_HOVER_STATES
Bug: 302334949
Test: check border animation in keyboard quick switch and recents view
Change-Id: I8a2e4fa0abc5af743352cd6409aee9f2912b41a2
2023-09-29 15:08:05 -04:00
Schneider Victor-tulias
0606b1f296 Merge "Add TAPL tests for the keyboard quick switch view" into main 2023-09-29 18:42:11 +00:00
Luca Zuccarini
850a282446 [Toast] Fix ANR when tapping on rich card chip. am: ba44979d79 am: f876cb4bf4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24894969

Change-Id: Iac57076c82c798876d7d94c9f03d3fc1d34bc09f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-29 18:41:51 +00:00
Schneider Victor-tulias
41b42bf7d5 Add TAPL tests for the keyboard quick switch view
Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Bug: 267520665
Test: TaplTestsKeyboardQuickSwitch
Design doc: go/kqs-tapl-tests

Change-Id: I1c3c5c758011a36ed405426f543ce450910f774e
2023-09-29 14:39:35 -04:00
Luca Zuccarini
f876cb4bf4 [Toast] Fix ANR when tapping on rich card chip. am: ba44979d79
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24894969

Change-Id: Ic9371183df1de229eb96a867c01eab21fd0f8b02
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-29 17:36:12 +00:00