Commit Graph

1290 Commits

Author SHA1 Message Date
Treehugger Robot
b38ab564be Merge "Close gap between grid and clear all for expressive dismiss." into main 2025-02-21 04:01:11 -08:00
Shamali Patwa
e532fc86b4 Merge "Update widgetsModel to return pickable vs all widgets separately." into main 2025-02-20 17:42:32 -08:00
Shamali P
f6efa25a49 Update widgetsModel to return pickable vs all widgets separately.
Earlier wallpaper preview was reading widgets that were eligible for
displaying in picker, which means widgets that are marked as hidden in
picker wouldn't show up in wallpaper preview.

This fix updates widgets model to maintain map of all widgets (instead of just pickable widgets like before), so that the existing `getWidgetsByComponentKey` function used by wallpaper preview can see all widgets. And, updates picker specific methods to use separate functions (suffixed `forPicker` that filter out picker ineligible widgets when read by picker code).

Bug: 385695615
Test: WidgetsModelTest, WidgetsPredictionUpdateTaskTest and demo
Flag: EXEMPT BUGFIX
Change-Id: I59efe38be0ce1f8a956ba4be42fb6e8b48b5d323
2025-02-20 14:13:16 -08:00
Pat Manning
2caae623a6 Close gap between grid and clear all for expressive dismiss.
Fix: 397891454
Test: TaplTestsQuickstep#testDismissLastGridRow
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: Id49447819c38f307f05cd4ecc3d501bd51766443
2025-02-20 18:06:52 +00:00
Treehugger Robot
f4bbd45d13 Merge "Add screen record to determine flake of testDismissCancel." into main 2025-02-20 08:16:52 -08:00
Pat Manning
e79ccd9c96 Add screen record to determine flake of testDismissCancel.
Bug: 396447643
Test: TaplTestsQuickstep#testDismissCancel
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: Iec03b7ed64d21dc425cf84c62dea4131a050b7b2
2025-02-20 14:08:18 +00:00
Sergey Pinkevich
c07d64b601 Merge "Convert DesktopAppLaunchTransitionManagerTest to multivalent" into main 2025-02-20 04:52:11 -08:00
Massimo Carli
2aa0a0dde8 [2/n] Fix tests before adding modal permission check
Flag: com.android.window.flags.enable_modals_fullscreen_with_permission
Bug: 394714626
Test: atest NexusLauncherTests:com.android.quickstep.DesktopSystemShortcutTest
Test: atest NexusLauncherTests:com.android.quickstep.ExternalDisplaySystemShortcutTest

Change-Id: I74ad0ca6b089a790a8f84ee6ba735b9d01acdc2f
2025-02-19 09:12:18 +00:00
Treehugger Robot
f1397811e0 Merge "Do not crash DesktopVisibilityController on unknown displays" into main 2025-02-18 17:02:00 -08:00
Ahmed Fakhry
41111bd8f6 Do not crash DesktopVisibilityController on unknown displays
Instead of requiring that a valid display ID is given to
the APIs in `DesktopVisibilityController` and crashing the Launcher,
this CL lets the code handle invalid IDs gracefully, and adds a test
that fails without the fix.

Bug: 392986431
Test: atest NexusLauncherTests:com.android.launcher3.statehandlers.DesktopVisibilityControllerTest
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: Id1bc7876ce654b96191c85089557b9279963acd8
2025-02-18 20:54:19 +00:00
Sergey Pinkevich
861a31e8fd Convert DesktopAppLaunchTransitionManagerTest to multivalent
Bug: 378096575
Flag: NONE test fix, not actual code editing
Test: DesktopAppLaunchTransitionManagerTest

Change-Id: I6dc335fea156f4e830e9c2cadf3c98ff01fb7c4f
2025-02-18 13:45:51 +00:00
Sergey Pinkevich
6880093100 Merge "Open and close animation for trampoline task" into main 2025-02-14 15:22:20 -08:00
Pat Manning
8bda4f6b5f Update dismiss length for tasks to bring them off screen.
Fix: 393553524
Test: TaplTestsQuickstep#testDismissBottomRow
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I959bcc86ad986abfe4546add62146e99f3707cc4
2025-02-14 18:32:00 +00:00
Sergey Pinkevich
9c8926bff5 Open and close animation for trampoline task
Moving most of the logic from DesktopAppLaunchTransition to DesktopAppLaunchAnimatorHelper to make it more testable

Bug: 391548553
Flag: com.android.window.flags.enable_desktop_trampoline_close_animation_bugfix
Test: DesktopAppLaunchAnimatorHelperTest

Change-Id: I606fc3fc25250ea4128f3089b701a1ae153dc47a
2025-02-14 10:20:26 +00:00
Sunny Goyal
c864281f3c Revert "Refactor all uses of DisplayController singleton INSTANCE"
Revert submission 31490053-DisplayControllRefactorForCD

Reason for revert: Leak is displayProvider

Reverted changes: /q/submissionid:31490053-DisplayControllRefactorForCD

Change-Id: Ib65150cdde765be009b5c4ce960f9fe025de9e60
2025-02-12 10:27:18 -08:00
Will Osborn
5f8b6206ce Refactor all uses of DisplayController singleton INSTANCE
And make DisplayController display id aware

Test: locally tested on Tangor
Flag: EXEMPT refactor
Bug: 392858637

Change-Id: I805cd7323c48a2988c95b9fda7f6cfe4c153860c
2025-02-12 10:46:34 +00:00
Pat Manning
a82868d7df Add spring animations for neighboring tasks on dismiss cancel
Fix: 389083088
Test: TaplTestsQuickstep#testDismissCancel
Test: TaskGridNavHelperTest
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I1240519eea499b5839d64e537588bde3cb0a424b
2025-02-10 13:24:19 -08:00
minch
dbdf49726f Refactor TaskView to allow no TaskContainers
Flag: EXEMPT refactor
Bug: 391918297
Test: m
Change-Id: I3343da2b6d73a0b0283334a37be5ae288d94f776
2025-01-30 18:23:57 +00:00
Eghosa Ewansiha-Vlachavas
064af3dfa7 Merge "[2/n] Include default home package in windowing exemptions check" into main 2025-01-29 21:52:45 -08:00
Anushree Ganjam
4597aae947 Move SimpleOrientationTouchTransformer to Dagger.
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I2c7adf5da76f0a60c167f4c650622ba8dfeac98d
2025-01-29 17:15:03 -08:00
Eghosa Ewansiha-Vlachavas
686276b571 [2/n] Include default home package in windowing exemptions check
Test desktop and external display system shortcuts with default home
package.

Flag: NONE bug fix
Test: atest -c NexusLauncherTests:com.android.quickstep.DesktopSystemShortcutTest,
      atest -c NexusLauncherTests:com.android.quickstep.ExternalDisplaySystemShortcutTest
Fixes: 389906224
Change-Id: I0d48ac3ffe995ebefffd1ea1b6892a72a3d3a4f1
2025-01-29 08:05:26 +00:00
Schneider Victor-tulias
c4aa8188e7 Merge changes I73042126,If7c21ab5 into main
* changes:
  Fix TaplTestsQuickstep test failures with recents window flag on
  Clean up the input stream on TAPL test failure
2025-01-28 13:20:58 -08:00
Schneider Victor-Tulias
3b71faed91 Fix TaplTestsQuickstep test failures with recents window flag on
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I73042126e2af1ffabe8a368d8a02ae1a4552d9a2
2025-01-28 14:05:45 -05:00
Gustav Sennton
1cce85f197 Remove old Desktop transitions flags usages
Bug: 369763947
Test: n/a
Flag: EXEMPT flags removal
Change-Id: Ie4cd157bb94477db83a1995f976c2057f78902e4
2025-01-27 14:44:22 +00:00
Eghosa Ewansiha-Vlachavas
432544a529 Merge "[2/n] Hide desktop button in overview for incompatible tasks" into main 2025-01-24 13:01:25 -08:00
Eghosa Ewansiha-Vlachavas
c808bb1b23 [2/n] Hide desktop button in overview for incompatible tasks
Flag: NONE bug fix
Test: atest -c NexusLauncherTests:com.android.quickstep.DesktopSystemShortcutTest,
      atest -c NexusLauncherTests:com.android.quickstep.ExternalDisplaySystemShortcutTest
Fixes: 389923274

Change-Id: I82acc85ca57b5454f9eeedd800dcd7da9990f9c8
2025-01-23 17:14:52 +00:00
Sunny Goyal
a5fef475a5 Revert "Revert "Migrating RecentsAnimationDeviceState and depend..."
Revert submission 31416515-revert-31332401-recents-device-state-LXBUANUQFL

Reason for revert: Fixing build breakage and resubmitting

Reverted changes: /q/submissionid:31416515-revert-31332401-recents-device-state-LXBUANUQFL

Change-Id: I3b89356df57f1e7ff1a9e364c0d766578e23798c
2025-01-22 18:31:06 -08:00
Liana Kazanova (xWF)
fa30e3fc0e Revert "Migrating RecentsAnimationDeviceState and dependent obje..."
Revert submission 31332401-recents-device-state

Reason for revert: DroidMonitor: Potential culprit for http://b/391684419 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Reverted changes: /q/submissionid:31332401-recents-device-state

Change-Id: I3986328ee3aa8ebb822f7ef05b9f80ef68872aef
2025-01-22 13:50:08 -08:00
Sunny Goyal
d7bfa76bcc Migrating RecentsAnimationDeviceState and dependent objects to Dagger
Bug: 361850561
Flag: EXEMPT dagger
Test: Presubmit

Change-Id: I2c45ec49a913abb0532e83b09e797012e06eb8c4
2025-01-21 23:53:02 -08:00
Treehugger Robot
5684d23331 Merge "Don't expect another task to become focused when dismissing Desktop task" into main 2025-01-21 20:33:31 -08:00
Vinit Nayak
e7753eb796 Merge "Remove and cleanup AppPairs flag" into main 2025-01-21 12:20:55 -08:00
Alex Chau
341330bacd Don't expect another task to become focused when dismissing Desktop task
- Don't consider Dekstop task as focused in TAPL
- Renamed variables in dismissTasks_whenDesktopTask_IsInTheCenter as there isn't always a focused task

Fix: 391354508
Test: TaplTestsOverviewDesktop#dismissTasks_whenDesktopTask_IsInTheCenter
Flag: EXEMPT BUG_FIX
Change-Id: Iadc0cf81f37d537837e565e233d11c4148cf3045
2025-01-21 17:58:58 +00:00
Jagrut Desai
625b78ae13 Fix Taskbar icon Accessibilty Focus on hovering
The problem: ArrowTipView was TypeAccessible hence taking a focus away from taksbar icon. The hover event was getting consumer by onHover of the listener and not getting passed to view. Upon passing the hover event we see icon scale up. We don't want both icon to scale up and show
tootip when hovering.

The Solution: pass motion event to onHoverEvent for icon view and mark ArrowTipView to be not included as Accessible View. For disabling hove
ring for taskbar icon we introduced new field to track if hovering is enabled for display type for that icon.

Test: Manual, Presubmit
Bug: 284081291
Flag: EXEMPT bugfix
Change-Id: Ie02d17856b26f82887fd178ccf0a7351416cc43e
2025-01-17 09:57:38 -08:00
Treehugger Robot
948222d92a Merge "Add a tapl test for locked taskbar" into main 2025-01-16 21:08:23 -08:00
Toshiki Kikuchi
6df54399fb Add a tapl test for locked taskbar
This CL adds a new tapl test to verify the behavior of the “locked”
taskbar which is sticky even when the home is on top.

Bug: 388125007
Flag: EXEMPT add test
Test: TaplTestsLockedTaskbar

Change-Id: I80d8d565ac63c2e3a8c2f79c46809f89fadfd181
2025-01-17 12:11:29 +09:00
Sihua Ma
8fc266d063 Move tests to multivalent
Test: SysUI studio
Test: atest NexusLauncherRoboTests
Flag: EXEMPT test migration
Change-Id: Idd9e52f281d955e87f6db638ebfd8218a4dcb77f
2025-01-17 00:04:27 +00:00
Anushree Ganjam
25717836e1 Merge "Use RunListener to Clear inline mocks at the end of each test class." into main 2025-01-16 13:28:04 -08:00
Anushree Ganjam
0a29e73ffb Use RunListener to Clear inline mocks at the end of each test class.
Inline mocks are leaking activity contexts and accumulation of these activity contexts led to OOM that resulted in test failure.

See https://github.com/mockito/mockito/issues/1614 for details on mockito caused memory leaks

This change works for both soong and gradle builds.

Bug: 378520480
Test: atest and android studio builds
Flag: TEST_ONLY
Change-Id: I4a50993621ea416a02a41dd2f9c330d1599f065c
2025-01-16 11:19:52 -08:00
Vinit Nayak
3456fcbe03 Remove and cleanup AppPairs flag
Test: Launcher compiles and runs
Bug: 274835596
Flag: EXEMPT cleanup
Change-Id: Iab8f17d444753df303ed1a09d6547917545e66f5
2025-01-16 14:02:55 -05:00
Saumya Prakash
26bceb527e Merge "Avoid per task app icons in Taskbar for desktop mode" into main 2025-01-15 14:18:38 -08:00
Treehugger Robot
65ad1c2b19 Merge "Cleanup enableUseTopVisibleActivityForExcludeFromRecentTask flag" into main 2025-01-15 09:42:54 -08:00
Uwais Ashraf
5b13bb4adb Cleanup enableUseTopVisibleActivityForExcludeFromRecentTask flag
Fix: 342627272
Flag: com.android.launcher3.enable_use_top_visible_activity_for_exclude_from_recent_task
Test: TaplTestsQuickstep
Change-Id: I3217869ec6f9c623c55c2504607b386020da7292
2025-01-15 04:07:56 -08:00
Treehugger Robot
93cd05e34a Merge "Remove some usages of GroupTask.task2" into main 2025-01-14 17:03:25 -08:00
Ahmed Fakhry
28869b86e9 Remove some usages of GroupTask.task2
This CL marks `GroupTask.task1` and `GroupTask.task2` as deprecated, and
removes some of the usages of the `task2`. Follow-up CLs will continue
replacing all the usages.

Bug: 388593902
Test: m
Flag: EXEMPT pure refactor with no behavior change.
Change-Id: I530bbba00bd41cf33a952b083de7670d9a490e81
2025-01-14 18:13:46 +00:00
Vinit Nayak
75d7e07844 Merge "Remove and cleanup splitContextual flag" into main 2025-01-14 09:39:59 -08:00
Vinit Nayak
3815a095f1 Remove and cleanup splitContextual flag
Bug: 276361926
Flag: EXEMPT removing flag
Change-Id: I6f567a8aae5b962f36ec2bc96b7fb05906b4ff2f
2025-01-14 10:23:59 -05:00
Saumya Prakash
aabcfa27ae Avoid per task app icons in Taskbar for desktop mode
Until Taskbar multi instance support was in place, Taskbar would show
multiple icons for different instances of the same app in desktop mode.
Now this is no longer needed as taskbar has multi instance support, so
now there is only one icon per instance of an app of the same user.

Fix: 382589460
Test: Started several Chrome windows -> Taskbar has 1 icon for chrome
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar
Change-Id: I2df4327dcdc9d221164055ebc33ff508273e7ef9
2025-01-13 22:37:25 +00:00
fbaron
486016efd6 Add screenrecord for testLaunchShortcut_fromTaskbarAllApps
Flag: TEST_ONLY
Test: testLaunchShortcut_fromTaskbarAllApps
Bug: 373417111
Change-Id: Iee2eba237920228e5658bd7746beae03edaeff8b
2025-01-13 14:11:58 -08:00
Xiaoqian (Daisy) Dai
6dbd67ae7d Merge "desktop-exploded-view: Add header to individual windows." into main 2025-01-13 11:40:53 -08:00
Treehugger Robot
3ddd380c14 Merge "Remove ScreenRecord for a closed bug" into main 2025-01-13 10:19:05 -08:00