Commit Graph

4127 Commits

Author SHA1 Message Date
Winson Chung
550dc8dc69 Merge "Clear ref after animation if visual stashing not supported" into sc-v2-dev 2021-11-22 17:22:16 +00:00
Alex Chau
3c2298668a Merge "Remove temporary logging for NO_SCREENSHOT bug/." into sc-v2-dev 2021-11-22 11:12:23 +00:00
Winson Chung
c2a84d887f Clear ref after animation if visual stashing not supported
Bug: 206814323
Test: Presubmit
Change-Id: Ia38bd2707edbddf1b1f2ad98b3cdac4c8c62a6d3
2021-11-19 23:52:18 +00:00
Winson Chung
5e49df2bbe Merge "Set sync applier on the transform params for the glued targets" into sc-v2-dev 2021-11-19 22:24:13 +00:00
Jonathan Miranda
2d9ac4e67f Merge "Use empty intent instead of null when creating stub TaskKey" into sc-v2-dev 2021-11-19 22:05:07 +00:00
Vinit Nayak
54baaae0ab Merge "Open taskMenu based on TaskIdAttributeContainer" into sc-v2-dev 2021-11-19 21:51:03 +00:00
Zak Cohen
d95942132d Remove temporary logging for NO_SCREENSHOT bug/.
Bug: 202414125, 203583301
Test: Local
Change-Id: I8345bd9f1c3ee93971d64ed49cf613cfd09ce10c
2021-11-19 13:49:36 -08:00
Jon Miranda
1f2b9b1c36 Use empty intent instead of null when creating stub TaskKey
Bug: 199027804
Test: manual
Change-Id: Ie66c8740453088791e026fa51a2842f59c6c67fd
2021-11-19 12:06:42 -08:00
Vinit Nayak
a59835214f Open taskMenu based on TaskIdAttributeContainer
* We were always passing in the same task no matter
which task icon was clicked.
* Use TaskIdAttributeContainer to associate
IconViews with their respective tasks

Fixes: 206154715
Test: Correct menu opens for split and fullscreen
tasks

Change-Id: I5f264bb69828532bdefffb7ec4b9ff1e501de086
2021-11-19 11:38:31 -08:00
Winson Chung
a5960223cf Set sync applier on the transform params for the glued targets
Bug: 199043513
Test: Swipe up with split task and scroll really quickly
Change-Id: Ie10b27457903d8db4d4c973ab5b7e669da2c4998
2021-11-19 19:33:54 +00:00
Jonathan Scott
6547721d8c Merge "Revert "Open taskMenu based on TaskIdAttributeContainer"" into sc-v2-dev 2021-11-19 16:44:30 +00:00
Jonathan Scott
ec79eb9cbc Revert "Open taskMenu based on TaskIdAttributeContainer"
This reverts commit c1ec2d4260.

Reason for revert: broken build b/207126572

Change-Id: I0908e8e6579bc54c6ce1dff88bddf8b030f336d9
Fixes: 207126572
2021-11-19 16:43:45 +00:00
TreeHugger Robot
988a87526e Merge "Open taskMenu based on TaskIdAttributeContainer" into sc-v2-dev 2021-11-19 16:06:30 +00:00
Alex Chau
2998307cd6 Use only current density to check isTablet
- Removed DeviceProfile.allowRotation and use DeviceProfile.isTablet instead, which only uses current density to calculate its value
- Reverted default allow_rotation preference handling to before ag/14234761

Fix: 203817448
Test: isTablet is set correctly in different screen sizes
Change-Id: Ic6c8dfc774e7787f62d489ad27720a7644c1e8c7
2021-11-19 15:27:01 +00:00
Fedor Kudasov
039501f41f Merge "Move FloatingTaskInit set up into init method" into sc-v2-dev 2021-11-19 10:26:46 +00:00
Vinit Nayak
788821ec4e Launch GroupedTaskView from thumbnails
* Previously when starting the remote animation
we were relying on SplitPlaceholderViews to
animate into the proper place since we weren't
launching from the TaskView itself
* Now when launching from a GroupedTaskView,
we use the existing animation that handles that
animation in addition to showing the new split tasks

Fixes: 206608786
Test: Thumbnails animate from home -> overview -> launch
Change-Id: I1499ead7d90cd41e285ed0f4df66ea31f0dfbc95
2021-11-18 22:58:53 -08:00
TreeHugger Robot
84b64d7910 Merge "Reset split selection state when RecentsView resets" into sc-v2-dev 2021-11-18 23:51:47 +00:00
Vinit Nayak
97f9bd575a Reset split selection state when RecentsView resets
* We weren't calling reset on the views
involved in split selection when recents view gets
a reset call (oops)
* Use device theme for split placeholder theme instead
of hardcoding to white

Fixes: 206155455
Change-Id: I3768fd574cb21eec9562d89c1a93eaa3f53d5ff1
2021-11-18 14:06:27 -08:00
TreeHugger Robot
39aceb6dc7 Merge "Check if ThumbnailData's bitmap is null in TaskThumbnailCache" into sc-v2-dev 2021-11-18 19:46:50 +00:00
Thales Lima
bd1aec6721 Merge "open grid task menu to the right of icon" into sc-v2-dev 2021-11-18 18:19:58 +00:00
Alex Chau
4670d37e55 Check if ThumbnailData's bitmap is null in TaskThumbnailCache
- This makes sure TaskThumbnailCache fetch for thumbnail when its Bitamp is null

Fix: 206959035
Test: See steps in b/206959035
Change-Id: I03b574b0f8cc7390a8cad618bd810f44f0dee279
2021-11-18 15:57:28 +00:00
Thales Lima
45f2306ce9 open grid task menu to the right of icon
This makes the TaskMenuViewWithArrow open to the right of the icon if
there is enough space, and to the left if not. It also works correctly
in RTL, inverting the side to open by default.

Bug: 193432925
Test: open Overview and tap the app icon
Change-Id: Ib1098f48ed28d2e0758fb0e3fb733e86271fa1a0
2021-11-18 12:01:16 -03:00
TreeHugger Robot
1edee616ae Merge "Move live tile app to top when the task view is tapped" into sc-v2-dev 2021-11-18 12:26:05 +00:00
Alex Chau
60d5315e19 Refresh overlay when thumbnail was set for first time
Bug: 202414125
Test: TaplTestsNexus.testOverviewActions && TaplTestsQuickstep.testOverviewActions
Change-Id: I2cc38df4c891fb21a8295d4f9c75e396c71449f2
2021-11-18 10:31:13 +00:00
TreeHugger Robot
5394db834f Merge "Use split thumbnail width/height directly" into sc-v2-dev 2021-11-18 04:42:27 +00:00
Vinit Nayak
be7ce023de Use split thumbnail width/height directly
* When swiping to QS from home, the
bounds for the rect on screen are incorrect
because it's technically off-screen when
it's being queried

Fixes: 206155441
Change-Id: Ibb17f2ac291f867b6de06041c980e434ce92cf27
2021-11-17 19:05:29 -08:00
TreeHugger Robot
010faef3a5 Merge "Add animated background to the suw all set page." into sc-v2-dev 2021-11-18 00:07:35 +00:00
TreeHugger Robot
ec2bd55047 Merge "Use TOUCHABLE_INSETS_REGION when IME is visible" into sc-v2-dev 2021-11-17 23:57:56 +00:00
Vinit Nayak
c1ec2d4260 Open taskMenu based on TaskIdAttributeContainer
* We were always passing in the same task no matter
which task icon was clicked.
* Use TaskIdAttributeContainer to associate
IconViews with their respective tasks

Fixes: 206154715
Test: Correct menu opens for split and fullscreen
tasks

Change-Id: I79a32541ea9ebae9ad78ad933f55212d0bc64b56
2021-11-17 15:29:42 -08:00
Fedor Kudasov
c8f686710e Move FloatingTaskInit set up into init method
This makes the code more tidy and consistent with
other classes. Additionally, this allows for easier
annotation of the initialization code.

Bug: 205828770
Test: m LauncherGoResLib
Change-Id: Ib7ecf32cffd5c6af67a4c2095d7cb3e3a2f387e4
(cherry picked from commit f50acd3ed8)
2021-11-17 22:13:43 +00:00
Tony Wickham
bf4a91b0f1 Use TOUCHABLE_INSETS_REGION when IME is visible
This ensures the dismiss button is fully clickable even if taskbar is stashed.

Test: Stash taskbar, can dismiss keyboard by tapping anywhere on the back button
(Same with taskbar unstashed)
Fixes: 206851484

Change-Id: I06f86191e36b596a928c8db8d67a012be033daba
2021-11-17 14:04:25 -08:00
Tracy Zhou
5163574b7a Move live tile app to top when the task view is tapped
- transition animation for foldables need it

Bug: 205789573
Test: manual
Change-Id: Icf11d204968dbffa6bb9c930deaa57d35e2eff4a
2021-11-17 13:59:49 -08:00
Alex Chau
7c9055fc6b Merge "Fix launch animation from bottom row and end of grid" into sc-v2-dev 2021-11-17 21:02:16 +00:00
Tracy Zhou
a37f8baa1d Merge "Refine when to move live tile app below recents view" into sc-v2-dev 2021-11-17 19:53:14 +00:00
Winson Chung
0e1cd933ba Merge "Fix issue with grouped task rects being calculated slightly off" into sc-v2-dev 2021-11-17 19:42:53 +00:00
Winson Chung
9304879387 Fix issue with grouped task rects being calculated slightly off
- This was causing bleed through between split tasks and perhaps
  some rounded corners to be calculated incorrectly
- Also reset the translation after it is adjusted for dismissing
  in case the dismiss gesture is canceled.  This doesn't fix the
  issue with bleed through between the task views (to be fixed
  separately), but makes sure it isn't permanently set on the task

Bug: 206739664
Test: Split tasks, swipe up and check the bounds

Change-Id: I34430e958ca7a75f48621bc27a281e93fdf97179
2021-11-17 17:40:58 +00:00
Fedor Kudasov
3256e1e744 Add some more @Nullable annotations
Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I6d2f269c4ec5f6cdee31ad68545c2720fbf1d8fc
(cherry picked from commit 9385170c1b)
2021-11-17 08:40:17 +00:00
Tracy Zhou
a4edc07ec8 Refine when to move live tile app below recents view
- We will still need to figure out why, but currently the overview scrim blocks the cut out during transition. To go around this, we need to move live tile app after the overview transition animation is over
- Some of the logic in RecentsView is no longer necessary since we are no longer reusing live tile params and simulator, but assign new targets each time

Fixes: 205587164
Test: manual
Change-Id: Icadf26182112bba544a4103b626effa37d4028b5
2021-11-16 21:17:19 -08:00
TreeHugger Robot
b797ca77b2 Merge "Fix memory leak in TaskbarLauncherStateController" into sc-v2-dev 2021-11-16 21:34:52 +00:00
TreeHugger Robot
36705e6039 Merge "If hometask is last task to be dismissed, show empty recents instead of home screen" into sc-v2-dev 2021-11-16 20:25:06 +00:00
Tracy Zhou
1fdea66f16 Fix memory leak in TaskbarLauncherStateController
mIconAlphaForHome.setConsumer(null) in onDestroy()

Test: Run BinderTests#testSwitchToOverview locally
Bug: 206633573
Change-Id: I912cd66097b113ee84197f23a5862e333d7e63f2
2021-11-16 11:31:15 -08:00
Alex Chau
04309940c0 If hometask is last task to be dismissed, show empty recents instead of home screen
- http://ag/16221737 ensure homescren stub is always added if tasks hasn't been loaded in RecentsView. This introduced an edge case that after dismissing home task view, no task remains in overview and it get dismissed
- The fix is to show empty recents instead of home screen if last task dismissed is a home task (showing empty recents isn't always correct, as there might be unloaded tasks, but it's better than dismissing overview)
- Also tuned the timing of when mLoadPlanEverApplied is set

Fix: 206462357
Test: FallbackRecentsTest.goToOverviewFromHome
Change-Id: I0f395639f57a1a57fddf750623a8a74b8ede8555
2021-11-16 18:48:28 +00:00
Alex Chau
1c4871298e Merge "Crop letterbox insets when thumbnail is from different aspect ratio" into sc-v2-dev 2021-11-16 18:40:31 +00:00
Alex Chau
b7abf7e96d Fix launch animation from bottom row and end of grid
- Apply gridTranslationY when calculating taskRect so it's used to calculate RecnetsView pivot
- Moved recentsViewScroll to RecentsView group and applied after recentsViewScale
- Before: http://dr/file/d/1-Nrqa80J4FRbjcdZ3GZSeKwfQF8fN9a1/view?resourcekey=0-gYT9z1HA0YksW5Ujbzsmeg
- After: http://dr/file/d/1-DpZrg5_nFeUKS-8APnLvG8SJVvke9BU/view?resourcekey=0-p59hm-abzpU7Y7tqWyneTQ

Fix: 200813202
Test: Launch task from grid from top/bottom/left/right/focus
Test: Launch task from left/middle/right in small screen
Change-Id: I814512c02611f59a5a6d1f53411d42cf4f0f26b3
2021-11-16 13:55:38 +00:00
Fedor Kudasov
72c8e71e06 Merge "Annotate RecentsView with @Nullable" into sc-v2-dev 2021-11-16 10:26:23 +00:00
Tracy Zhou
0200636585 Merge "Track LauncherState, RecentsAnimation, resumed state for task bar in one place" into sc-v2-dev 2021-11-16 09:41:58 +00:00
Fedor Kudasov
3a0f8a90bd Annotate RecentsView with @Nullable
Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I44a4f7ce4258e54d43ca2c5a3937c81a4a686f80
(cherry picked from commit ac9cee5a7c)
2021-11-15 20:39:07 +00:00
Fedor Kudasov
9d6fb64f45 Simplify getTaskViewAt call
RecentsView getTaskViewAt method is nullable and is safe
to call for an out of bound index.

Bug: 205828770
Test: m LauncherGoResLib
Change-Id: I7709d63ad4490fd756a50caaf42ba70c4fad4d06
(cherry picked from commit 41edede1ee)
2021-11-15 20:37:12 +00:00
Fedor Kudasov
ba47b591c4 Merge "Add @Nullable annotations for simple cases" into sc-v2-dev 2021-11-13 09:00:32 +00:00
Winson Chung
ea77e49524 Merge "Freeze task list if requested when launching split tasks" into sc-v2-dev 2021-11-12 20:51:15 +00:00