Commit Graph

848 Commits

Author SHA1 Message Date
vadimt
480083490f Tapl: AllApps: ensuring a minimal vertical size of an icon
Clicking an icon within its padding area is ignored by Launcher. Hence,
ensuring that the whole icon is visible.

Bug: 141770616
Change-Id: I19e3ba7cfa25de75a47202845d0838bea46af92c
2019-11-13 20:20:57 +00:00
vadimt
7afd271a17 When scrolling in All apps, scroll to last clickable row
Not the last row.

Also scrolling in the middle of All Apps, not at the top, because
otherwise the scroll can start on search box.

Bug: 144180777
Change-Id: I219faec165b8b403530a9c09d419cc453aea6039
2019-11-11 10:46:28 -08:00
vadimt
b0a14e96ae Removing temporary tweaks to make tests pass in presubmit
Now that we have a more reliable build of CF

Bug: 142828227
Change-Id: Ib385443048b6ccd9e1eb3372dc39947536f948bd
2019-11-11 09:23:28 -08:00
Jon Miranda
13a7980e09 System apps must target API 29 or higher
AndroidManifest.xml already updated

Bug: 143991628
Change-Id: Ia9ddeda016548a0ebe5c5ec527741a7a8f9c0e4d
2019-11-06 16:01:25 -08:00
vadimt
137f5b62ac Improve diags when system errors cause failing Launcher tests
Now, for example, we won't diagnose a locked phone as a
"home button not showing in 3-button mode", even though it's technically
correct.

Change-Id: Ibdfa0741af7ff8545a811f6702dda74dc6c31c2e
2019-11-04 14:50:22 -08:00
Pinyao Ting
5eee5f4da0 enable custom shortcut test
Bug: 141568904
Change-Id: Ie51ef6f7a2f5d4579689a82184bdd7681a266d04
2019-10-31 17:09:40 -07:00
Sunny Goyal
3808a69a6c Storing BitmapInfo instead of icon and color directly in itemInfo
This will allow subclassing BitmapInfo to support custom icon/dynamic
icons which can be loaded on the background thread instead of going
through IconFactory which runs on UiThread

Change-Id: Ieced6e91330bdff1b505826d097a8df711dfe967
2019-10-28 11:12:47 -07:00
vadimt
b7eedb4579 Support for overriding test run flavor
Change-Id: I054a1eaa888cd97a7c7fa5fcc65513d6d89c3a1c
2019-10-25 16:44:29 -07:00
vadimt
23c8341096 Removing tracing and @Stability for a fixed bug
Bug: 142514365
Change-Id: I147850db274c465fb964eca30b97b3ebaaa2ccf6
2019-10-25 11:21:33 -07:00
Winson Chung
ef558648e6 Bump time to scroll to last visible row (affects jank/perf tests)
- Regression from ag/9592395, bump the time of scrolling to the
  last visible row slightly to prevent a fling

Bug: 141484300
Change-Id: I41c041fe591aceebc63b7e869a705164babb09ea
2019-10-24 15:31:34 -07:00
Tony Wickham
5aeb3b84b8 Refactor SwipeDetector to track both axes
Existing clients now use the SingleAxisSwipeDetector subclass. A
followup CL will add BothAxesSwipeDetector, whose first client will be
the quick switch from home controller.

Bug: 126596417
Change-Id: I54c71088cfe99ff28cdc719a1eb7a7d06ac95d2d
2019-10-24 10:38:17 -07:00
TreeHugger Robot
85561d1e44 Merge "Fix testQuickSwitchFromApp" into ub-launcher3-master 2019-10-24 00:12:09 +00:00
Tony Wickham
bc42d64c85 Fix testQuickSwitchFromApp
Instead of starting getAppPackageName() and relying on it being our Test
Pin Item activity, instead launch our own test activities with the
FLAG_ACTIVITY_MULTIPLE_TASK and FLAG_ACTIVITY_NEW_DOCUMENT flags.

Test:
- Locally run testQuickSwitchFromApp() from Android Studio
- flake -oop -t com.android.quickstep.TaplTestsQuickstep#testQuickSwitchFromApp

Bug: 140252765
Change-Id: Ie137261ce65bfd3dd39df78d57784854a026e967
2019-10-23 23:42:19 +00:00
Winson Chung
f6448e62e6 Merge "Reduce animation time for some common TAPL actions (affects jank/perf tests)" into ub-launcher3-master 2019-10-23 23:40:53 +00:00
Winson Chung
82b2ef27c8 Reduce animation time for some common TAPL actions (affects jank/perf tests)
- All apps swipe up 1s -> 200ms (doesn't matter if it's a fling)
- Scroll to last visible row 2.5s -> 1.25s (seems sufficient to not be a fling)
- Drag icon to workspace 2s -> 500ms (seems sufficient to not be a fling)
- This changes the total frames produced for the jank tests, but should not
  change the jank proportion or the individual frame drawing times

Bug: 141484300
Change-Id: I9f2e647ebc2c27c6269238daa4c3e6ad314c8161
Signed-off-by: Winson Chung <winsonc@google.com>
2019-10-23 23:31:20 +00:00
TreeHugger Robot
7caa519140 Merge "Step 4 from the plan below:" into ub-launcher3-master 2019-10-23 17:54:19 +00:00
vadimt
3a13366e00 Restoring 10-sec wait for model initialization
Will see if ag/9573576 fixed long model loading

Bug: 136278866
Bug: 142514365
Change-Id: If0dc61faff00683cf3248c127a64ff5b065f9ae4
2019-10-18 12:43:10 -07:00
vadimt
ad81b816f0 Step 4 from the plan below:
1. Skip all tests that fail in inproc mode on CF (this CL)
2. Observe postsubmit and make sure no inproc tests are failing or too
flaky on CF
3. Enable presubmit
4. Switch to skipping tests from step 1 only for inproc presubmit;
they'll start failing in postsubmit
5. Gradually make all tests pass and not flaky and enable them back on
presubmit

Bug: 142828227
Change-Id: I0092d6b92b0358866f8cbf9e00dbe3fabe23703d
2019-10-17 17:52:29 -07:00
vadimt
af317c7821 More preparation for enabling inproc presubmits
Bug: 136278866
Change-Id: Icc4a0d935acf76950197bc184f8dba5d07ee85c5
2019-10-17 12:07:10 -07:00
TreeHugger Robot
35903d2cb2 Merge "Reducing the time for expected launcher initialization back to 10 sec" into ub-launcher3-master 2019-10-17 07:18:37 +00:00
vadimt
6332b7d73c Reducing the time for expected launcher initialization back to 10 sec
It was temporarily raised to 60 sec.

https://googleplex-android-review.git.corp.google.com/9563509
should've fixed some problems with loading time, but likely not all.

We need to observe whether this test starts flaking again.

testDragIcon will run only in Launcher postsubmit, and won't block
merges to platform if it fails.

Bug: 142514365
Change-Id: I2b9a9d043346ebda721221cefd6118a1a799501f
2019-10-16 17:49:29 -07:00
vadimt
3680357a67 Preparing to enabling Inproc launcher tests as presubmit
The plan:
1. Skip all tests that fail in inproc mode on CF (this CL)
2. Observe postsubmit and make sure no inproc tests are failing or too
flaky on CF
3. Enable presubmit
4. Switch to skipping tests from step 1 only for inproc presubmit;
they'll start failing in postsubmit
5. Gradually make all tests pass and not flaky and enable them back on
presubmit

Bug: 142828227
Change-Id: I6ea3d53771503e8fd968555bb2e4cb1be10d83ef
2019-10-16 17:35:18 -07:00
Winson Chung
40f8756793 Merge "Fix a couple trace issues" into ub-launcher3-master 2019-10-16 20:54:43 +00:00
Winson Chung
5cc62c7d0b Fix a couple trace issues
- Adding trace tokens since we can be starting/ending traces out of order
- Fixing issue with draw hitting twice causing the trace stack to be
  popped twice
- Fix issue with endFlagOverrides not removing from the stack

Bug: 142803200

Change-Id: I8649b94249910a352f00f2f2c2459c355d2bab00
2019-10-16 12:34:58 -07:00
Sunny Goyal
8409284b2c Merge "Cleaning up properly after RaceConditionReproducerTest" into ub-launcher3-master 2019-10-16 19:11:23 +00:00
Sunny Goyal
bffbd7521d Cleaning up properly after RaceConditionReproducerTest
Change-Id: I43362fbc63789d3ce3468266a5189a9f9d209d00
2019-10-16 11:57:43 -07:00
Tony Wickham
6b62f28ef9 Fix quick switch test gesture in landscape 2-button mode
am: a0f77c4449

Change-Id: I998081a53a94ff3b1559a7e77d4d470056cfab00
2019-10-15 21:20:24 -07:00
vadimt
36d7be7fc9 Implementing test stability attribute
Change-Id: I5d78a19039ab2bcdb217886fdaca29e3df412780
2019-10-15 18:40:53 -07:00
Tony Wickham
a0f77c4449 Fix quick switch test gesture in landscape 2-button mode
It should swipe from the bottom right to top right when the nav bar is
on the right, rather than from the bottom left to bottom right.

For now, disable testQuickSwitchFromApp() because it seems to have
other failures as well.

Bug: 140252765
Change-Id: I1f4989f3ea5456c18bb9cbf42ea4b157cee500d7
2019-10-15 17:30:47 -07:00
Vadim Tryshev
984187b0a1 Merge "Increasing wait time for loading model to 60s" into ub-launcher3-master 2019-10-16 00:08:22 +00:00
vadimt
4565739fb7 Increasing wait time for loading model to 60s
Bug: 142514365
Change-Id: I15e0ff8e2a721f7ffdefdf2eb02e114212dded3b
2019-10-15 17:06:41 -07:00
Pinyao Ting
b3d3ca87dd temporarily disable a regression test to unblock merging to master
The test case testDragCustomShortcut was created initially to prevent future regression on custom shortcut (b/141568904), which was caused by ag/9342399.

Some times after ag/9342399 was reverted on ub-launcher3-master, a different error is causing custom shortcut to not working intermittently (b/141528961). Since this is different from b/141568904, it should not be a blocker to merging to master.

Bug: 141568904
Change-Id: Ia11e1ae44d0ef86c16876c002954aa662f1edbc8
2019-10-15 21:32:47 +00:00
TreeHugger Robot
6c12641bee Merge "Unifying various tracing calls" into ub-launcher3-master 2019-10-14 22:29:59 +00:00
Sunny Goyal
17c72fbb60 Unifying various tracing calls
Change-Id: Iedf6662ad1d7281b850bdc43b3a1e373ce535ac6
2019-10-14 14:23:19 -07:00
Tony Wickham
2f767469ae Merge "Add tests for quick switch from an app and home" into ub-launcher3-qt-future-dev
am: 7a2076e3ab

Change-Id: Id525dae6616757688ccf0e203fefeb9bd6ef08ff
2019-10-14 12:20:37 -07:00
Tony Wickham
1e73e320b7 Add tests for quick switch from an app and home
Bug: 140252765
Change-Id: I5621b614ae2d8cd3db03cae818cf8b8c1c6cb20f
2019-10-14 11:51:19 -07:00
TreeHugger Robot
4be6169d4e Merge "Fix test bug where launcher throws NPE because it isnt loaded yet." into ub-launcher3-master 2019-10-14 17:49:41 +00:00
Winson Chung
c062580b5a Wait for the task to be in recents before validation
- There are two issues:
  1) Currently the system does not add the task to the task list until
     the activity starting the task has been resumed (to be fixed in a
     follow up platform CL). When the three activities are started in
     sequence, it's possible for one of the activities to not reach the
     resumed state leading to an unexpected number of recent tasks the
     next time it's fetched.
  2) When swiping up, it may take time for getTasks to return and call
     applyLoadPlan, so try and wait until the task views have had a
     chance to be applied before continuing.
  3) Use the launcher activity tracker instead of activity rule since it
     will return the same activity even after the activity is destroyed
- Move the margin handling to the caller instead of the scroll method

Bug: 141580748
Change-Id: I2b7634f5ac6869ba4b369b3bd60e0f63747c0f0b
2019-10-11 17:10:38 -07:00
Winson Chung
c039634c25 Workaround for failing test & fix scrolling in tests
- Workaround issue where instrumentation will fail to finish an activity
  causing the activity to linger longer than expected (leading to issues
  with ordering of static resources like the app widget host registration)
- Fix calculation for scrolling the screen, the previous calculation
  would result in the gesture starting at the left gesture margin due
  to rounding which can trigger a back action instead of the desired
  scroll

Bug: 142351228
Change-Id: I34bdb471030518d2b983cac2badd4d8b0e7d571b
2019-10-10 17:31:38 -07:00
TreeHugger Robot
f31dab5e02 Merge "Removing static instance of LauncherAppsCompat and unnecessary wrapper classes" into ub-launcher3-master 2019-10-08 18:49:36 +00:00
vadimt
4b5c1ef71b Adding support for intentionally leaking views.
Bug: 139137636
Change-Id: I923d1781daee9ae47eb306ee8fa3c44790c6993f
2019-10-08 17:04:26 +00:00
TreeHugger Robot
86017c9611 Merge "Removing access to LauncherModel.getCallbacks" into ub-launcher3-master 2019-10-08 16:26:12 +00:00
TreeHugger Robot
fedd5f1fd7 Merge "Removing host deletion on startup and corresponding callbacks" into ub-launcher3-master 2019-10-07 18:28:44 +00:00
Vadim Tryshev
7949c5a7e4 Merge "Diagnosing anomalies prior to swiping up to Home" into ub-launcher3-qt-qpr1-dev am: c3a4819b8c
am: af754b9a9a

Change-Id: I9a65f1c85623f801adbd380c85a039b5c55526bf
2019-10-03 18:18:33 -07:00
Vadim Tryshev
af754b9a9a Merge "Diagnosing anomalies prior to swiping up to Home" into ub-launcher3-qt-qpr1-dev
am: c3a4819b8c

Change-Id: Ifc6a781cea4dc38b58435314b8760e89b327446a
2019-10-03 18:11:32 -07:00
Vadim Tryshev
c3a4819b8c Merge "Diagnosing anomalies prior to swiping up to Home" into ub-launcher3-qt-qpr1-dev 2019-10-04 00:48:34 +00:00
vadimt
f4255c6c1b Dump view hierarchy before swiping to home am: 233afe98e9
am: 3878d3ef09

Change-Id: Ief39f3c713dd94b93b6dfa2f1e0732c810ba5d3a
2019-10-03 17:41:35 -07:00
vadimt
3878d3ef09 Dump view hierarchy before swiping to home
am: 233afe98e9

Change-Id: Ib67aa2247ae43f4e875deb07a9d8b53aa5e6f181
2019-10-03 17:35:28 -07:00
vadimt
43c3d2d40a Diagnosing anomalies prior to swiping up to Home
Bug: 141864547
Change-Id: I5f3814c6a90df85136484813ca4ee684da101016
2019-10-03 17:09:16 -07:00
Vadim Tryshev
35d9ac924c Merge "Logging the initial state for swiping up to home" into ub-launcher3-qt-qpr1-dev am: c49ec38140
am: f078975e9d

Change-Id: I7cff417f917643adb1835eb4b7ccad0e75cb22ce
2019-10-03 14:40:14 -07:00