Commit Graph

7033 Commits

Author SHA1 Message Date
vadimt
480083490f Tapl: AllApps: ensuring a minimal vertical size of an icon
Clicking an icon within its padding area is ignored by Launcher. Hence,
ensuring that the whole icon is visible.

Bug: 141770616
Change-Id: I19e3ba7cfa25de75a47202845d0838bea46af92c
2019-11-13 20:20:57 +00:00
Pinyao Ting
2cf2871392 include predicted_rank in app launch logging
Test:
1. . build/envsetup.sh && tapas NexusLauncher
2. ccdebug && cclogcat
3. launch from workspace any app that is also in predicted apps
4. verify in terminal it has correct predicted_rank

Bug: 143855018
Change-Id: I07a62f07057537a6c09384cf944bbc5aa5888d22
2019-11-12 16:40:34 -08:00
TreeHugger Robot
40755182ee Merge "Preventing dead lock in layout inflation" into ub-launcher3-master 2019-11-12 19:56:17 +00:00
Sunny Goyal
cac41df9ad Fixing inverted filtering logic for notifications
Bug: 144290150
Change-Id: I52e54148069b4ba7ccd318ad47920b45a53300f1
2019-11-11 14:03:44 -08:00
Sunny Goyal
d1a67d0d72 Preventing dead lock in layout inflation
Bug: 143353100
Change-Id: I52d0794aad26c1d1de8cb373f3398f626c15b4af
2019-11-11 11:08:39 -08:00
TreeHugger Robot
1ca9c89b01 Merge "[DO NOT MERGE] Folder name suggest Bug: 142498588" into ub-launcher3-master 2019-11-09 02:52:21 +00:00
Hyunyoung Song
4c74620d6a [DO NOT MERGE] Folder name suggest
Bug: 142498588

Change-Id: I735c842522f08db1fb9a11f731b63f8dba5a298f
Signed-off-by: Hyunyoung Song <hyunyoungs@google.com>
2019-11-08 15:07:48 -08:00
Jon Miranda
238343a65b Merge "Address SessionCommitReceiver vulnerability by validating intent." into ub-launcher3-qt-future-dev
am: 992cfbf63d

Change-Id: Id80274e147008bd00aeb581d637fcd82938c034f
2019-11-08 13:59:11 -08:00
TreeHugger Robot
992cfbf63d Merge "Address SessionCommitReceiver vulnerability by validating intent." into ub-launcher3-qt-future-dev 2019-11-08 21:50:02 +00:00
Jon Miranda
7e04887e59 Address SessionCommitReceiver vulnerability by validating intent.
Bug: 144081762
Change-Id: I28699d26abefc716e57c281c15699f15003229b2
2019-11-08 13:02:52 -08:00
TreeHugger Robot
f59803e708 Merge "Add visual indicator for predicted hotseat icons" into ub-launcher3-master 2019-11-08 15:45:22 +00:00
Samuel Fufa
ba6b47fd8e Add visual indicator for predicted hotseat icons
Bug: 142753423
Test: Manual
Change-Id: Ie4325660fc5392358ec845ae58385bef279db60f
2019-11-07 16:49:24 -08:00
TreeHugger Robot
45656e296f Merge "Scaling down hotseat to match prediction row size when going to overview" into ub-launcher3-qt-future-dev 2019-11-07 23:35:15 +00:00
Hyunyoung Song
00105625f4 Merge "[DO NOT MERGE] Folder name suggest Bug: 142498588" into ub-launcher3-qt-future-dev 2019-11-06 23:24:02 +00:00
Hyunyoung Song
7564d3b8bd [DO NOT MERGE] Folder name suggest
Bug: 142498588

Change-Id: I735c842522f08db1fb9a11f731b63f8dba5a298f
Signed-off-by: Hyunyoung Song <hyunyoungs@google.com>
2019-11-06 23:06:01 +00:00
Sunny Goyal
37279e2313 Scaling down hotseat to match prediction row size when going to overview
Bug: 141265005
Change-Id: I3b11146881af334508f553e4ca3a36b9291511d9
2019-11-06 14:39:28 -08:00
Sunny Goyal
a5020007e3 Scaling down hotseat to match prediction row size when going to overview
Bug: 141265005
Change-Id: I3b11146881af334508f553e4ca3a36b9291511d9
2019-11-06 22:36:34 +00:00
Tony Wickham
238c4bae27 Merge "Add BothAxesSwipeDetector" into ub-launcher3-qt-future-dev
am: ea09b9c963

Change-Id: I926c97b277e1ee268269955b6a8c66dab32f3178
2019-11-06 09:12:00 -08:00
Tony Wickham
ea09b9c963 Merge "Add BothAxesSwipeDetector" into ub-launcher3-qt-future-dev 2019-11-06 16:58:07 +00:00
Samuel Fufa
5fe9dd028c Merge "Fix icons vanishing when dragged within folder" into ub-launcher3-qt-future-dev
am: 734574221b

Change-Id: I857a428a0a828a922482372dbe63a8bd3bbd233b
2019-11-05 20:54:57 -08:00
TreeHugger Robot
734574221b Merge "Fix icons vanishing when dragged within folder" into ub-launcher3-qt-future-dev 2019-11-06 04:40:41 +00:00
Samuel Fufa
1b9e540a52 Fix icons vanishing when dragged within folder
Bug: 143702700
Test: Manual
Change-Id: Idc24086553fd337fc2a553e25daa570073d9ad51
2019-11-05 19:49:30 -08:00
Samuel Fufa
306177c14e Fix dragging icon badge offset
am: 37b2489ff7

Change-Id: Ibe7dbed4d3880086da14692597341ea9487efc29
2019-11-05 18:53:46 -08:00
Pinyao Ting
fe160c55c2 Merge "Add IconCache support for deep shortcuts, loads deepshortcut on background thread. Added a feature flag to toggle on/off this feature." into ub-launcher3-master 2019-11-05 23:33:48 +00:00
Samuel Fufa
37b2489ff7 Fix dragging icon badge offset
Bug: 143702640
Test: Manual
Change-Id: I86d97c1f0ea02c86f4bf745a8bdda3887c62f27e
2019-11-05 15:29:22 -08:00
Pinyao Ting
c1a1ced33a Add IconCache support for deep shortcuts, loads deepshortcut on
background thread.  Added a feature flag to toggle on/off this
feature.

Bug: 140242324
Test:
  1. (Custom Shortcut) Long click on google maps -> widgets -> drag
     driving mode to workspace.

  2. Open chrome -> add to home screen -> add -> add automatically.

  3. InstallShortcutReceiver
     In Launcher.completeAddShortcut, commend out the code that
     calls PinRequestHelper.createWorkspaceItemFromPinItemRequest,
     then open chrome -> add to home screen -> add -> add
     automatically.

  4. ShortcutDragPreviewProvider
     qdb -> long press on suggested app that has deep shortcut
     -> drag to workspace.

Change-Id: If7babe4eddf5434909bf686b4e9bde15e444d9fd
2019-11-05 11:27:28 -08:00
TreeHugger Robot
8e24097014 Merge "Implement hotseat prediction client" into ub-launcher3-master 2019-11-05 19:18:49 +00:00
Samuel Fufa
efb665d3ec Implement hotseat prediction client
Bug: 142753423
Test: Manual
Change-Id: I9f697c474b29340c9b33ddf896a49e8f3f893f8b
2019-11-05 09:53:25 -08:00
Winson Chung
5d3dc9c76d Merge changes I4649483a,I890a45e6,I6ccfab86 into ub-launcher3-master
* changes:
  17.5/ Remove synchronized calls, verify controller before finishing animation
  17/ Update activity tracker callback
  16/ Renaming the swipe handlers
2019-11-05 05:18:05 +00:00
Winson Chung
52c57f73d2 17/ Update activity tracker callback
- Immediately callback when scheduling activity tracker callback and the
  activity already exists
- Remove LauncherInitListenerEx, it was only used to update the prediction
  ui state, but not all of the callers of the launcher activity init
  listener actually needs this (ie. Go doesn't have overview predictions,
  overscroll input consumer/touch interaction service doesn't need it.)

  Instead we only call it in the places we need it LauncherSwipeHandler (for
  swipe up) and OverviewCommandHelper (for the nav bar button).

Bug: 141886704

Change-Id: I890a45e658be813e99b2a02f179fce611ede9ce8
2019-11-04 20:13:11 -08:00
Jon Miranda
e6691f34c1 Add additional shortcutExists check to prevent same app from being auto added.
am: f788bbb0c4

Change-Id: I42f0c4d75f8be38b9e81c5932fc1def710a68f36
2019-11-04 17:32:56 -08:00
Jon Miranda
f788bbb0c4 Add additional shortcutExists check to prevent same app from being auto added.
Since we made the change to treat all auto added workspace items as promise
icons, the initial shortcutExists check breaks since its comparing the promise
intent to the actual app intent. This additional shortcutExists check can
compare the proper intents.

Bug: 143803446
Change-Id: Ifa27b15205d6e17f83a4437ac175d51815688c84
2019-11-04 14:19:17 -08:00
TreeHugger Robot
43968167d9 Merge "enable custom shortcut test" into ub-launcher3-master 2019-11-04 20:24:55 +00:00
Tony Wickham
0124076feb Merge "Fix issue where popup jumps to full size before closing" into ub-launcher3-qt-future-dev
am: d942b4208d

Change-Id: I8380d0a9659f1f24c1a451d1a07b97e5ec0689fa
2019-11-01 16:59:42 -07:00
Tony Wickham
59a53e4a43 Merge "Maintain dot and text visibility if a new popup is created while closing" into ub-launcher3-qt-future-dev
am: c1fafebd47

Change-Id: I64870047d8bbcdcbc01b767da52c734f946480af
2019-11-01 16:59:22 -07:00
Tony Wickham
d942b4208d Merge "Fix issue where popup jumps to full size before closing" into ub-launcher3-qt-future-dev 2019-11-01 23:39:18 +00:00
Tony Wickham
c1fafebd47 Merge "Maintain dot and text visibility if a new popup is created while closing" into ub-launcher3-qt-future-dev 2019-11-01 23:38:51 +00:00
Tony Wickham
6894f4f1bb Fix issue where popup jumps to full size before closing
Some background on what was happening:
- When mEndRect.isEmpty(), we set it to (0, 0 , width, height)
- We called mEndRect.setEmpty() in animateClose(), but override
  mEndRect if the reveal animation set the outline bounds.
- But the reveal animation doesn't set the outline bounds until
  after the arrow animation (40ms) finishes, i.e. the arrow scales
  up for 40ms then we clip to outline and start revealing the popup
- Thus, if you started a drag before the arrow animation finished,
  we called mEndRect.setEmpty(), which made the close animation start
  from the full popup size even though it was previously invisible.

To fix this, we clip the popup to its (empty) outline while the
arrow animates in, and then we can always start from wherever the
outline currently is when we close the popup.

Test:
- Set animation duration to 10x
- Long press an icon, and start dragging before the arrow scale
  animation finishes
- The popup never shows, whereas before it jumped to full size

Bug: 143639898
Change-Id: I284dd06a23e0e9c3faf066a0083ac13bac88ebcc
2019-11-01 15:53:52 -07:00
Tony Wickham
20af12eb38 Maintain dot and text visibility if a new popup is created while closing
Test:
- Long press an icon to open the popup
- Long press the same icon while the popup is open

Previously, the dot would reappear (when the original popup finished closing).
Now, the dot stays hidden, as it should since a popup is showing.

Bug: 143639898
Change-Id: Ia0bdb626e02f4ad9ba12c27d94fea054b4afe50e
2019-11-01 13:26:40 -07:00
Pinyao Ting
5eee5f4da0 enable custom shortcut test
Bug: 141568904
Change-Id: Ie51ef6f7a2f5d4579689a82184bdd7681a266d04
2019-10-31 17:09:40 -07:00
Samuel Fufa
3f43d823ae Merge "Predictive hotseat prototype" into ub-launcher3-master 2019-10-30 20:49:51 +00:00
Samuel Fufa
225ac27143 Predictive hotseat prototype
Supports filling hotseat with predicted apps, pinning of predicted apps
and manages replacing predicted apps with user drag.

Bug:142753423
Test:Manual
Change-Id: I224294f9353a64c46d28c22263a72332a79fddf4
2019-10-30 13:19:10 -07:00
TreeHugger Robot
de6770a2ec Merge "Adding support for dynamic calendar and clock icons" into ub-launcher3-master 2019-10-30 18:16:28 +00:00
Jon Miranda
6173355db1 Merge "Fix bug where Files app keeps getting added to the workspace." into ub-launcher3-qt-future-dev
am: 23df556ec4

Change-Id: I408d6c3d537124b8c8bfa4670261435d004eb7d3
2019-10-30 10:54:26 -07:00
TreeHugger Robot
23df556ec4 Merge "Fix bug where Files app keeps getting added to the workspace." into ub-launcher3-qt-future-dev 2019-10-30 17:29:36 +00:00
Jon Miranda
a8109fb98c Fix bug where Files app keeps getting added to the workspace.
Caused by mainline updates where Files app session commit is broadcasted.
Launcher workaround is to not auto-add system apps to the workspace.

Bug: 139663018
Change-Id: Id61532bd0df2cd5f3bdfc28a3616ba5e5ff3d18a
2019-10-30 09:56:44 -07:00
TreeHugger Robot
a9c69e1c43 Merge "Cleaning up unused allAppsIconSize/allAppsIconTextSize variables." into ub-launcher3-master 2019-10-29 22:57:24 +00:00
Andy Wickham
6547f1a937 Forces OveriewInputConsumer to be used when Assistant is running on top of Launcher.
Previously it was using OtherActivityInputConsumer, which got things in a
pretty weird state (e.g. most recent app would appear in the center as if
it was the active app when you started Quick Switching, etc.).

By default (toggleable by a feature flag), OverviewWithoutFocusInputConsumer
is used because Assistant doesn't seem to respect the CLOSE_SYSTEM_DIALOGS
broadcast, at least in half-shelf mode. In this case, the Home intent is
sent on swipe up, or you can dismiss it with the back gesture or by tapping
above the half shelf.

The new feature flag ASSISTANT_GIVES_LAUNCHER_FOCUS routes touches through
OverviewInputConsumer. As opposed to OverviewWithoutFocusInputConsumer,
this allows Quick Step to work while Assistant is running. Additional logic
is added to dismiss the Assistant when appropriate. Note that the dismissal
happens atomically, so it's not completely fluid with the other animations.
As mentioned above, this is disabled by default because Assistant doesn't
currently respect CLOSE_SYSTEM_DIALOGS.

Demo with the flag enabled (and Assistant respecting CLOSE_SYSTEM_DIALOGS):
https://drive.google.com/open?id=1W5jGpn_TEC-KjrYwQtaBT3pzxG_5tC4W

Bug: 139661510
Change-Id: I261653118aff289b329ec2a7ca6e52f100f7835a
Merged-In: I261653118aff289b329ec2a7ca6e52f100f7835a
2019-10-29 14:39:35 -07:00
Andy Wickham
d386d7da7c Forces OveriewInputConsumer to be used when Assistant is running on top of Launcher.
Previously it was using OtherActivityInputConsumer, which got things in a
pretty weird state (e.g. most recent app would appear in the center as if
it was the active app when you started Quick Switching, etc.).

By default (toggleable by a feature flag), OverviewWithoutFocusInputConsumer
is used because Assistant doesn't seem to respect the CLOSE_SYSTEM_DIALOGS
broadcast, at least in half-shelf mode. In this case, the Home intent is
sent on swipe up, or you can dismiss it with the back gesture or by tapping
above the half shelf.

The new feature flag ASSISTANT_GIVES_LAUNCHER_FOCUS routes touches through
OverviewInputConsumer. As opposed to OverviewWithoutFocusInputConsumer,
this allows Quick Step to work while Assistant is running. Additional logic
is added to dismiss the Assistant when appropriate. Note that the dismissal
happens atomically, so it's not completely fluid with the other animations.
As mentioned above, this is disabled by default because Assistant doesn't
currently respect CLOSE_SYSTEM_DIALOGS.

Demo with the flag enabled (and Assistant respecting CLOSE_SYSTEM_DIALOGS):
https://drive.google.com/open?id=1W5jGpn_TEC-KjrYwQtaBT3pzxG_5tC4W

Bug: 139661510
Change-Id: I261653118aff289b329ec2a7ca6e52f100f7835a
Tested: Manually used quick switch after invoking Assistant from home screen.
2019-10-29 14:25:29 -07:00
Sunny Goyal
14168431bd Adding support for dynamic calendar and clock icons
Change-Id: Icdba34340a27a4f6dff7310d0bf9fd29aef1330c
2019-10-29 13:50:02 -07:00