Commit Graph

9280 Commits

Author SHA1 Message Date
Liran Binyamin
42076f4645 Merge "Crash fix in BubbleStachedHandleViewController." into udc-qpr-dev 2023-06-08 16:24:06 +00:00
Jagrut Desai
a8aefb6e14 Merge "Remove Hotseat Education from Large Screens" into udc-dev am: 0704595a99 am: c457d85fec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590297

Change-Id: Ic1c06094e140e8e6e1aaf6fafd1bde84f8c31281
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-08 00:31:12 +00:00
Treehugger Robot
936722a71f Merge "Adds an overflow bubble to the bubble bar." into udc-qpr-dev 2023-06-07 22:09:31 +00:00
Sunny Goyal
cda1842e7a Merge "Removing all usage of LauncherProvider" into udc-qpr-dev 2023-06-07 22:03:48 +00:00
Vadim Tryshev
544dff52af Merge "Switch ScrimView to use view alpha" into udc-qpr-dev 2023-06-07 21:47:59 +00:00
Sunny Goyal
7b9e28f152 Removing all usage of LauncherProvider
Also fixing a race condition in model when an item update/delete task
gets queued and executed after the model has reloaded (making the old
data obsolete)

Bug: 277345535
Bug: 263079498
Test: Presubmit
Flag: N/A
Change-Id: Ibd4bdbb3eece05b38b73a22a4be5f368df3754f0
2023-06-07 12:57:13 -07:00
Treehugger Robot
9c9764c28b Merge "Moved TISBinder lifecycle handling to TISBinderHelper" into udc-qpr-dev 2023-06-07 19:37:13 +00:00
Schneider Victor-tulias
19d085107a Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851 am: 396bb7c262
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: Ifd444206ac34ba591bf2f6033bf6961fadb5425f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 18:21:17 +00:00
Jagrut Desai
d94017474f Remove Hotseat Education from Large Screens
Currently there is an taskbar icon unstashing animation that happens on top of hotseat education. Hotseat education is redudunt for large screens(Tablets, Foldable-unfolded). To solve this we will remove this reduntdant feature for large screens

Test: Manual
Bug: 282617747
Flag: not needed
Change-Id: Ia5e2c51f7ef927a59cb6efa195c1cdfc627205d9
2023-06-07 10:52:39 -07:00
Ats Jenk
71f6dbece4 Merge "Dismiss all task ids from TaskView" into udc-qpr-dev 2023-06-07 17:17:42 +00:00
Schneider Victor-tulias
871d7fc351 Moved TISBinder lifecycle handling to TISBinderHelper
- All instances where we used TISBinder will now use TISBinderHelper#getBinder. This will allow TISBinderHelper to handle its lifecycle
- Moved all instance of TaskbarManager and OverviewCommandHelper as well since TIS and TISBinder handle their lifecycles
- Cleaning up launcher instance from TaskbarManager when TISBinder is being destroyed

Flag: not needed
Bug: 283490010
Test: ran launcher and performed gestures
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:248794e698417b1156bf911adb31682186fe2e34)
Change-Id: I8415a6b2c1dba0776e7c0e1ee32ad3c683100bde
2023-06-07 17:15:18 +00:00
Schneider Victor-tulias
bfa0fae851 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev 2023-06-07 16:49:20 +00:00
Liran Binyamin
2f1b547a4b Crash fix in BubbleStachedHandleViewController.
Switching between gesture nav and 3 button nav may lead to a state where
the RegionSamplingHelper is unexpectedly null.

Bug: 269670598
Test: In Settings switch navigation modes until launcher crashes.
Change-Id: I56d6eea81070f367db292c1ded9866452f6e2650
2023-06-07 11:55:02 -04:00
Ats Jenk
7a48f57043 Dismiss all task ids from TaskView
In recents we were hardcoding that only two task ids can be dismissed
when dismissing a TaskView. Update the logic to dismiss arbitrary
number of task ids that are returned from TaskView.

Fixes task dismissal logic for desktop where there can be more than 2
tasks represented by one taskview.

Flag: not needed, trivial change
Bug: 280830106
Test: Add chrome, files and calculator to desktop. Dismiss the desktop
  tile with 3 apps from overview. Open youtube and move it to desktop.
  Observe that desktop only contains youtube. None of the 3 previous
  apps are added back.
Test: Move 2 apps to split screen, dismiss the split tile from overview.
  Observe both apps are dismissed.
Test: Dismiss a single app from overview.
Change-Id: I139943f5d678d63f449116de26debae9be122b21
2023-06-06 22:38:39 +00:00
Fengjiang Li
7d6a8b1c3a Merge "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test" into udc-dev am: 3dca7b3c6a am: 69a9a4cd52
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23300979

Change-Id: If1ffa619e26ab7b76d6e0b946bcd29d121cd7219
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 19:43:54 +00:00
Fengjiang Li
3dca7b3c6a Merge "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test" into udc-dev 2023-06-06 18:19:38 +00:00
Schneider Victor-tulias
ab51f2110a Add null-check to findLastActiveTaskAndRunCallback
ItemInfo.getTargetComponent is nullable, so we can't always create a ComponentKey. Added a null-check and proper creation of ComponentKeys

Flag: not needed
Fixes: 286053950
Test: started and completed splitscreen selection from home, taskbar and overview
Change-Id: Ifa30f194ae064fab8aad79c5116f8c859dfd8cf1
2023-06-06 11:02:09 -07:00
Ats Jenk
826b28d703 Merge "Animate in desktop app select toast" into udc-qpr-dev 2023-06-06 16:49:27 +00:00
TreeHugger Robot
8704476235 Merge "Don't allow Taskbar unstash during Assistant gesture" into udc-dev am: e2a6113e93 am: 39748f8883
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23565985

Change-Id: I26e34597aa96c2eb304ef40404b4492faf7f1074
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 03:03:33 +00:00
TreeHugger Robot
9bf69ea28d Merge "Prevent initiating split with task excluded from recents" into udc-dev am: 0d3edbfeb6 am: 4418ade8ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23495351

Change-Id: Ib86e56e308adf538911531dc8296d2d0dd865c9e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 00:27:11 +00:00
Ats Jenk
a37f3f2c2c Animate in desktop app select toast
Add an animation for the desktop app select toast.
Played when the toast is added to the screen.

Bug: 261234402
Test: have an app on desktop, swipe up to home, verify that the toast
  has an appear animation, per the spec
Test: when toast is visible, tap on cancel button, observe toast fades
  out
Test: when toast is visible, launch an app, verify toast fades out
Change-Id: I593d6c326d6d638f1bc06e8c6add31b0244e4cb5
2023-06-05 16:39:29 -07:00
Tony Wickham
97bada6339 Don't allow Taskbar unstash during Assistant gesture
Test: manual with "swipe to invoke assistant" enabled
Flag: none
Fixes: 282060498
Change-Id: I317d01dbbb59d020338b17d424c853a00ef03cce
2023-06-05 23:23:40 +00:00
TreeHugger Robot
859d0d87e2 Merge "Simplifying some test utility methods" into udc-qpr-dev 2023-06-05 23:10:06 +00:00
Vinit Nayak
868bef2f2b Prevent initiating split with task excluded from recents
Bug: 280138741
Flag: None
Test: Verified split option doesn't show on QR quick-tile app
in recents

Change-Id: I751e450ba3be4a97eba5ad4e8ed86bf9631164ce
2023-06-05 13:48:01 -07:00
Liran Binyamin
a15b5913e9 Merge "Don't create the bubble bar controllers if the bubble bar view does not exist. This fixes a crash that happens when changing navigation modes." into udc-qpr-dev 2023-06-05 18:21:43 +00:00
Sunny Goyal
db51eeff7c Merge "Updating the top scrim to also use dynamicaly generated bitmap" into udc-qpr-dev 2023-06-05 17:18:28 +00:00
Ats Jenk
8fe538b1b9 Merge "Use listener to track desktop task visibility in launcher" into udc-qpr-dev 2023-06-05 16:44:28 +00:00
Fengjiang Li
1a2462914d Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test
Fix: 282945183
Test: N/A
Change-Id: I96680f04a6946129b14c365e2300f408dfe8f0c3
2023-06-05 09:19:07 -07:00
Sunny Goyal
6773667e34 Revert "Revert "Adding main thread binder tracing in development..."
Revert submission 23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Reason for revert: Fixed broken build
Reverted changes: /q/submissionid:23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Change-Id: I3e130a780b8641c4a17a5cdf799513f2ba08b16e
2023-06-02 18:14:35 -07:00
Sunny Goyal
c41af6d681 Merge "Enabling app tracing for Launcher" into udc-qpr-dev 2023-06-03 01:05:19 +00:00
Brian Isganitis
992065ba38 Merge changes from topics "all-apps-search-delegate-qpr", "search-container-view" into udc-qpr-dev
* changes:
  Add initial support for search session in Taskbar All Apps.
  Add All Apps search delegate for inflating search box.
2023-06-03 00:59:47 +00:00
Ats Jenk
da7e55591e Use listener to track desktop task visibility in launcher
Launcher registers a listener with WMShell to receive updates about
desktop stashed state. The same listener can be used to receive updates
about desktop visibility.
Previously launcher was relying on sysui state flag for desktop
visibility. But this flag is not checked when launcher starts. Only
updates are handled. When launcher restarts and desktop is visible,
launcher state was not correctly set.
This listener is "sticky", meaning when a listener registers, it will
receive a callback with the current value. This allows launcher to
update its state on start.

Flag: persist.wm.debug.desktop_mode_2
Bug: 280490493
Test: move an app to desktop, observe launcher icons are hidden
Test: swipe home from a desktop app, observe launcher icons shown
Test: while desktop app is open, change system theme to dark or light,
  observer launcher is restarted and icons remain hidden
Change-Id: Id8be1989b32d9ccd2e0539b65529fed096342ac3
2023-06-02 23:20:58 +00:00
Saumya Prakash
217b1f3559 Merge "Match displayed instruction with voiceover text." into udc-dev am: 0ebdfc6660 am: 1e65cdcdd7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23450321

Change-Id: I9ab9421797150c221202be6817d4414f1dbecfb8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 23:09:35 +00:00
vadimt
99c4becf24 Switch ScrimView to use view alpha
Using view alpha instead of background paint’s color alpha component
will make ScrimView alpha and visibility available to View Capture and
any analysis tool that’s based on it.

The change makes ScimView background completely opaque, and makes Scrim
View use variable alpha instead of always-1.0 alpha.

Changes some code that depends on the old way of representing ScrimView
opacity.

Also moves “updateSysUiColors()” call in ScrimView#setBackgroundColor
below updating alpha and background color so the new values are used in
the calculations.

Bug: 282991128
Test: local, presubmit
Change-Id: I6ca089bae55adfb9c3140d06da4fbb3b08f2bf8b
2023-06-02 15:47:51 -07:00
Mady Mellor
0175c0080b Merge "Modify Taskbar code to accommodate bubble bar gesture to stash/unstash" into udc-qpr-dev 2023-06-02 22:08:10 +00:00
Saumya Prakash
0ebdfc6660 Merge "Match displayed instruction with voiceover text." into udc-dev 2023-06-02 22:00:25 +00:00
Brian Isganitis
70da3e6452 Merge "Fix how task stack listener closes overlays on task changes." into udc-dev 2023-06-02 21:49:27 +00:00
Sunny Goyal
a8209d5da9 Enabling app tracing for Launcher
Bug: 273718665
Test: None
Flag: N/A
Change-Id: Ie6fa50b602bf180dd5dcba999c9e18f07a17d589
2023-06-02 19:21:10 +00:00
Saumya Prakash
fbeb143ea6 Match displayed instruction with voiceover text.
When users are using TalkBack, the text being read aloud did not match
the text displayed on the screen. This change fixes that in accordance
to the accessibility testing principles by changing the text spoken
aloud.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 274996517
Test: Manually went through both versions of the tutorial using talkback
and without using it. Ensured the spoken text matched the displayed
text

Change-Id: I896f2c09bd220615722777c73935f70c946715b2
2023-06-02 18:32:33 +00:00
TreeHugger Robot
b73bafc52a Merge "Log windowManager.getPossibleMaximumWindowMetrics" into udc-dev am: 014a684343 am: 43b4a71690
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23517420

Change-Id: Id44d5120ed1083870c7d3b9256978ab940d03379
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 18:31:08 +00:00
TreeHugger Robot
014a684343 Merge "Log windowManager.getPossibleMaximumWindowMetrics" into udc-dev 2023-06-02 17:09:46 +00:00
Brian Isganitis
7a5809e47b Add initial support for search session in Taskbar All Apps.
A search session is represented as a stub ResourceBasedOverride that can
be extended for controlling a search session.

Test: Manual (including aosp Quickstep)
Bug: 216683257
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I9cf4b5f84feec5215840d456b601c6a9f7c4c211
2023-06-02 15:55:46 +00:00
Brian Isganitis
0aa30e2292 Fix how task stack listener closes overlays on task changes.
Originally gated onTaskMovedToFront behind prototype because looked like
it was causing overlay to close when it shouldn't. However, it turns out
it was actually onTaskStackChanged that was doing this.

Additionally, changing onTaskMovedToFront to close with animation, because this will fire if swiping up from all apps (going to overview so Launcher is considered as the task moving to front). Also, registered onTaskCreated to be a bit more thorough.

Test: Manual (EDU, All Apps, and EDU + All Apps)
Fix: 283373523
Flag: none
Change-Id: I4cd3969f91a93bab190b764a656d9cfc03d1ce09
(cherry picked from commit 34c6b871af)
2023-06-02 15:34:35 +00:00
Alex Chau
eb9171c378 Log windowManager.getPossibleMaximumWindowMetrics
Bug: 283944974
Test: manual
Change-Id: I15d4bb81604b018f8a2c69c56509e2a66caae306
2023-06-02 15:44:54 +01:00
Sunny Goyal
ee9740462e Simplifying some test utility methods
Bug: 283821111
Test: Presubmit
Flag: N/A
Change-Id: I7b9690bc0cc53d097d26cd4f0ab2dd36ba88e1cb
2023-06-02 13:30:55 +00:00
Santiago Aboy Solanes
0edac04688 Merge "Revert "Adding main thread binder tracing in development build."" into udc-qpr-dev 2023-06-02 09:06:26 +00:00
Santiago Aboy Solanes
ee846feb80 Revert "Adding main thread binder tracing in development build."
Revert submission 23482347-launcher-binder-tracing

Reason for revert: Broken Build 10242119 on git_master on errorprone b/285434612

Reverted changes: /q/submissionid:23482347-launcher-binder-tracing

Change-Id: Id9726474265e839a59d6eb34822e7a86d40f0fc9
2023-06-02 08:59:28 +00:00
Treehugger Robot
329f11180d Merge "Create separate fullscreen launch type for shortcuts" into udc-dev am: 55f38fb397 am: 0189f4454a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23480181

Change-Id: I79987e6f9f237cbaf2f2a4317e93506fe216b7d1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 06:37:06 +00:00
Treehugger Robot
55f38fb397 Merge "Create separate fullscreen launch type for shortcuts" into udc-dev 2023-06-02 05:22:23 +00:00
Anushree Ganjam
87cb7ad06a Merge "Add UID in AppInfo." into udc-dev am: 9b4f62e681 am: eb9cd7e26e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23331302

Change-Id: I2bfbbf5fd5ec777baca79d89c13204857e600f8d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 01:46:38 +00:00