Commit Graph

3298 Commits

Author SHA1 Message Date
Vinit Nayak
b974a86c8f Add IDs to buttons in 3 button nav for Taskbar
Bug: 191449914
Test: testSwitchToOverview passes
See bug for more details

Change-Id: I108bbe7607181680bca7cb5fad5e7289191edde6
2021-06-18 18:20:44 -07:00
Sunny Goyal
d7e17a860f Merge "Fixing out of order taskbar callbacks" into sc-v2-dev 2021-06-19 00:40:46 +00:00
Vinit Nayak
70565c5e7d Merge "Default to requesting command type TOGGLE for OverviewCommandHelper" into sc-v2-dev 2021-06-18 22:56:24 +00:00
Sunny Goyal
6e1ce8ccb8 Fixing out of order taskbar callbacks
OnCreate can come before onDestroy for a previous activity which can
cause the callbacks for taskbar to get cleared

Bug: 190170303
Test: Presubmit
Change-Id: I48334605384d4604043a50ffc3d137f84575148a
2021-06-18 12:44:38 -07:00
Vinit Nayak
ae7c8cacd5 Merge "Enable 3 button nav for taskbar" into sc-v2-dev 2021-06-18 05:43:41 +00:00
Sunny Goyal
deec62378c Fixing Taskbar not initialized properly on recreate
Bug: 187353581
Test: Manual
Change-Id: I6e675937a033a4edcb4fa4e8151c210e14e8f896
2021-06-17 15:19:12 -07:00
Vinit Nayak
e91e4f0328 Default to requesting command type TOGGLE for OverviewCommandHelper
Parity with how sysui switches between apps for double
tapping recents button.

Fixes: 190660016
Test: Double tap to switch works, tapping fast also works
Change-Id: If6dda377d8accf564f3385e78c6721c677310361
2021-06-17 12:37:02 -07:00
Alex Chau
f77d45cce8 Merge "Send TaskBar touch events to tests" into sc-v2-dev 2021-06-17 17:52:44 +00:00
Winson Chung
3df79133f2 Merge "Do some additional cleanup when switching handlers" into sc-dev am: caabfa1519
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14985080

Change-Id: I59c266315e6c5fe8989dcff36fe395457792c189
2021-06-17 17:01:52 +00:00
Winson Chung
caabfa1519 Merge "Do some additional cleanup when switching handlers" into sc-dev 2021-06-17 16:48:42 +00:00
Alex Chau
5ca9df757a Apply dismissScale on TaskView instead of TaskThumbnailView
- As icon is hidden while TaskView become focused, there is no need to apply the scaling on TaskThumbnailView only. Apply scaling on TaskView to simplify

Bug: 14622874
Test: manual
Change-Id: Idb5fc8540649d57a071a42d36388dedcdcf893eb
2021-06-17 13:37:10 +01:00
Alex Chau
ecc32bd227 Send TaskBar touch events to tests
Bug: 191344757
Test: TaplTestsQuickstep.testOverview
Change-Id: I9e1a4c6d4616e5791762a6340944212e4631862e
2021-06-17 12:56:03 +01:00
Sunny Goyal
e900ec68d0 Merge "Updating taskbar icon alignment state" into sc-v2-dev 2021-06-16 22:08:07 +00:00
Jonathan Miranda
c01e87daf0 Merge "Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag." into sc-dev am: 28e39335bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14987185

Change-Id: Iecfbdc781852e24aafb92744f9a3de4ff5cbbd00
2021-06-16 20:39:08 +00:00
Jonathan Miranda
28e39335bc Merge "Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag." into sc-dev 2021-06-16 20:34:48 +00:00
Sunny Goyal
5cf86b263e Updating taskbar icon alignment state
Icon alignment is only tied to Launcher paused/resumed state
Creating two separate states for this:
  1) Launcher paused/resumed
  2) Active gesture interaction (live-titles can affect paused state)

Removing state handler dependency on taskbar visibility

Bug: 190170303
Bug: 187353581
Bug: 187919439

Test: Manual
Change-Id: Ia97cdf43cec1d9213f5dc2af8d66258b34c57514
2021-06-16 13:30:36 -07:00
Vinit Nayak
58ffbef8f0 Enable 3 button nav for taskbar
Bug: 180046394
Test: Switched between gesture and button nav on
phone and tablet.

Change-Id: Iac2357a3256f8b6b36ca49d3680594a91e824a5f
2021-06-16 13:26:21 -07:00
Jonathan Miranda
47f8a1c3ef Merge "App Shortcut menu bug fixes and polish." into sc-dev am: c846245f1b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14985072

Change-Id: Icba377c0032eee2dacec8a3c4364fa5b958880b7
2021-06-16 18:19:16 +00:00
Jon Miranda
b73e591712 Add ENABLE_SCRIM_FOR_APP_LAUNCH feature flag.
Bug: 191088291
Test: manual
Change-Id: Ia144c72e0fe1292ed856a37ee714a1cda50083d5
2021-06-16 18:13:23 +00:00
Jonathan Miranda
c846245f1b Merge "App Shortcut menu bug fixes and polish." into sc-dev 2021-06-16 18:06:13 +00:00
TreeHugger Robot
9cc7c45b7f Merge "Tap on recents button twice to go to last app" into sc-v2-dev 2021-06-16 07:18:07 +00:00
Jon Miranda
229c4c3235 App Shortcut menu bug fixes and polish.
- Widget is its own item.
- Change order of icon order.
- Update grab handle colors

Bug: 188095695
Test: long press on apps with/without widgets, long press apps on workspace/
      all apps/search

Change-Id: Iabb9b4b3f3a928103b9d62601f22e74ef2325d7c
2021-06-15 18:59:51 -07:00
Vinit Nayak
5219c563be Merge "Initial commit of TaskBar on keyguard" into sc-v2-dev 2021-06-15 23:05:17 +00:00
Vinit Nayak
113377d8b8 Tap on recents button twice to go to last app
Fixes: 190660016
Test: Tapped on recents twice and saw last app.
Tapped on recents and tried to tap on other app
icons and none of them launched.

Change-Id: Ie89f1ec0464f194087dc07ab99deb8223ab6ddb8
2021-06-15 15:12:17 -07:00
Hongwei Wang
413a443a71 Merge "Use RectFSpringAnim for auto-enter-pip" into sc-dev am: e3bfeddd04
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14984847

Change-Id: I4994f8b872c2b59497bea0106036baf30cb0a7f8
2021-06-15 21:17:48 +00:00
Thiru Ramasamy
e6f240bc12 Merge "Enable logging for 'Themed icons' setting." into sc-dev am: 640fc8b84d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14983277

Change-Id: If40731963001b85a16505ad162e52aad2a971154
2021-06-15 21:17:03 +00:00
Winson Chung
d14190d547 Do some additional cleanup when switching handlers
Bug: 183962705
Test: Presubmit

Change-Id: Ia9295d2cf89fa6b6fe77c5e4861a704c4a82ab12
2021-06-15 13:57:06 -07:00
Hongwei Wang
e3bfeddd04 Merge "Use RectFSpringAnim for auto-enter-pip" into sc-dev 2021-06-15 20:50:45 +00:00
Thiru Ramasamy
640fc8b84d Merge "Enable logging for 'Themed icons' setting." into sc-dev 2021-06-15 20:47:23 +00:00
TreeHugger Robot
58e3a767ec Merge "Only inflating taskbar views for valid items" into sc-v2-dev 2021-06-15 19:19:55 +00:00
Hongwei Wang
9d3e31e67c Use RectFSpringAnim for auto-enter-pip
Make SwipePipToHomeAnimator a subclass of RectFSpringAnim and use the
bounds calculated from latter for auto-enter-pip transition.

Note that the landscape to portrait case may not fully comply to
RectFSpringAnim as we calculate the position separately in
SwipePipToHomeAnimator.

Video: http://recall/-/aaaaaabFQoRHlzixHdtY/CWBPU2A6vB8CeTFRanQLx
Bug: 184789411
Test: manual, see video
Change-Id: I67dae09e682b7d8f1a1f08995eb3bcf76bdf7417
2021-06-15 12:04:17 -07:00
TreeHugger Robot
86ec716300 Merge "Update all apps divider to pill shape" into sc-dev am: 4ff2682787
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14966493

Change-Id: I4eb5916743ec677f9658c3a51d05802d9f71afca
2021-06-15 18:52:50 +00:00
Vinit Nayak
560d28e3a1 Initial commit of TaskBar on keyguard
Bug: 180046394
Test: Tested with pin + keyboard +
pattern

Change-Id: I951d9508b1325c157a9c0d92fa8e77fe8df9c460
2021-06-15 11:33:26 -07:00
TreeHugger Robot
4ff2682787 Merge "Update all apps divider to pill shape" into sc-dev 2021-06-15 18:33:22 +00:00
Winson Chung
0c36935be9 Merge "Don't rely on intent to call back from activity tracker" into sc-dev am: 1b369c4763
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14909197

Change-Id: Ic05028f7cbd58bd4312b04c32f60f31ec33a1721
2021-06-15 18:16:19 +00:00
TreeHugger Robot
5636db853d Merge "Fix foreground position during widget home animation" into sc-dev am: 3e366d6529
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14948450

Change-Id: If1d918feb23b9f2282bcc88107d9beaa65c21fcd
2021-06-15 18:16:00 +00:00
Winson Chung
1b369c4763 Merge "Don't rely on intent to call back from activity tracker" into sc-dev 2021-06-15 18:04:52 +00:00
TreeHugger Robot
3e366d6529 Merge "Fix foreground position during widget home animation" into sc-dev 2021-06-15 17:59:48 +00:00
Thiru Ramasamy
74a6d2ea55 Enable logging for 'Themed icons' setting.
Eldar: http://eldar/510864786
Bug: 191161241
Test: local - http://gpaste/5934701681311744 & http://gpaste/6715297709948928
Change-Id: I18ad97f68b372997e222f06dabf8bbe83f15d92f
2021-06-15 10:48:43 -07:00
Sunny Goyal
ea8ac5a223 Only inflating taskbar views for valid items
Also enabling view cache for folders

Bug: 187353581
Test: Manual
Change-Id: I5bc695fd86475f30611bc6b362b4ae93c48c26bb
2021-06-15 10:37:23 -07:00
Winson Chung
1c2d522d1b Don't rely on intent to call back from activity tracker
- The intent is not updated in certain cases which means that the
  callback may not be made if Launcher gets recreated. Instead
  have the tracker manage the set of registered callbacks.
- This change allows AbsSwipeUpHandler to continue to receive
  onActivityInit calls even if Launcher restarts, and also to
  handle a case where restarting while waiting for a page-settling
  callback will continue to finish the gesture.

Bug: 183962705
Test: Force recreate at various points in the gesture

Change-Id: Ib5ead8c868e798e26e56776f57bd715c79d087cd
2021-06-14 20:57:40 -07:00
Jonathan Miranda
620c7d1854 resolve merge conflicts of bea8267854 to sc-v2-dev
Bug: 181901105
Change-Id: I4bbe6258e0d2e5f04931d2a3d8d1f784a90f91de
Merged-In: Ia904b8b96301042c900e0589f33fc625c1c1148b
2021-06-15 02:32:30 +00:00
Hongwei Wang
7987decd95 Merge "Calculate the position from start bounds for auto-enter PiP" into sc-dev am: 5a2a6e7325
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14940622

Change-Id: I22c35c165d0e881f46843da229374f095b9a1e82
2021-06-15 01:03:08 +00:00
Jonathan Miranda
bea8267854 Merge "Address LAUNCHER_APP_LAUNCH_FROM_ICON jank." into sc-dev 2021-06-15 00:32:40 +00:00
Jon Miranda
0750f03c96 Address LAUNCHER_APP_LAUNCH_FROM_ICON jank.
- Delay app launch animations by a frame, and skip logic to skip the first frame.
- Note the icon pressed state animation still occurs, so there is still some
  visual feedback for the user that something is happening.

Bug: 181901105
Test: ensure animation still looks smooth (using window animation scale & record in slow mo)
Change-Id: Ia904b8b96301042c900e0589f33fc625c1c1148b
Merged-In: Ia904b8b96301042c900e0589f33fc625c1c1148b
2021-06-14 23:29:29 +00:00
Hongwei Wang
5a2a6e7325 Merge "Calculate the position from start bounds for auto-enter PiP" into sc-dev 2021-06-14 22:21:19 +00:00
Evan Rosky
1f804199c4 Merge "Finish wrapped launcher animations if impl is gone" into sc-v2-dev 2021-06-14 19:58:13 +00:00
Samuel Fufa
d85735db47 Update all apps divider to pill shape
Screenshot: https://screenshot.googleplex.com/4AJFL7MjJuZr7tf
Bug: 188946089
Test: local
Change-Id: If45512b24caefc66725892ab8429afd3d9ce20c8
2021-06-14 13:37:52 -05:00
Jon Spivack
7b57deb534 Merge "Send NIU Actions Intents to default Assistant" into sc-dev am: 3e48c63180
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/14940621

Change-Id: I9f11bc98ec704e6eeb1e3c4ce278e92aadc5765f
2021-06-14 18:23:45 +00:00
Jon Spivack
3e48c63180 Merge "Send NIU Actions Intents to default Assistant" into sc-dev 2021-06-14 18:13:34 +00:00