Commit Graph

9346 Commits

Author SHA1 Message Date
Alina Zaidi
b5459c9ba5 Merge "Update bottom widget picker and pin widget dialog layout in landscape mode." into sc-dev 2021-06-15 17:23:02 +00:00
Santhosh Thangaraj
4d61c56200 Merge "Fix the page number based Seen impression." into sc-dev 2021-06-15 15:20:40 +00:00
Alina Zaidi
dfa6aa828c Update bottom widget picker and pin widget dialog layout in landscape mode.
Bug: 189726613
Test: Manually tested
Change-Id: I048740f949571423ab53bbb01e7128d9981b1ce7
2021-06-15 14:27:57 +01:00
Jonathan Miranda
bea8267854 Merge "Address LAUNCHER_APP_LAUNCH_FROM_ICON jank." into sc-dev 2021-06-15 00:32:40 +00:00
Jon Miranda
0750f03c96 Address LAUNCHER_APP_LAUNCH_FROM_ICON jank.
- Delay app launch animations by a frame, and skip logic to skip the first frame.
- Note the icon pressed state animation still occurs, so there is still some
  visual feedback for the user that something is happening.

Bug: 181901105
Test: ensure animation still looks smooth (using window animation scale & record in slow mo)
Change-Id: Ia904b8b96301042c900e0589f33fc625c1c1148b
Merged-In: Ia904b8b96301042c900e0589f33fc625c1c1148b
2021-06-14 23:29:29 +00:00
Hyunyoung Song
8c0f8fba9c Merge "Fix NPE inside REcyclerViewFastScroller" into sc-dev 2021-06-14 23:18:22 +00:00
Jonathan Miranda
11bf817e86 Merge "Folder polish - update color extraction, fix contrast issues." into sc-dev 2021-06-14 20:11:50 +00:00
Samuel Fufa
b8b822a74b Merge "Introduce inline education for work profile" into sc-dev 2021-06-14 19:29:28 +00:00
TreeHugger Robot
012e978e31 Merge "Ensure that the cancel and end listener are called when cancelling state animation" into sc-dev 2021-06-14 19:16:47 +00:00
Jon Miranda
5688010306 Folder polish - update color extraction, fix contrast issues.
- Also fixes open/close animation when items were not getting clipped
  due to folder not being measured yet.

Bug: 190210234
Bug: 190164147
Test: manual
Change-Id: I230c33d7e4e1871d8d702737c56c79ce46504b8f
Merged-In: I230c33d7e4e1871d8d702737c56c79ce46504b8f
2021-06-14 17:54:19 +00:00
Jonathan Miranda
b7cab26529 Merge "Do not add padding left/right when cell layout border spacing exists." into sc-dev 2021-06-14 17:29:19 +00:00
Hyunyoung Song
a9aeebc5bb Fix NPE inside REcyclerViewFastScroller
Bug: 190939643
Test: manual
Change-Id: Ic01111bb1389b2fa84d86c0ecc20f1eec0940e51
2021-06-14 09:12:30 -07:00
Stevie Kideckel
d541300f0e Merge "Use LayoutManager.onLayoutCompleted as a signal that content has changed" into sc-dev 2021-06-14 09:18:06 +00:00
Takeshi Hagikura
7937cecde2 Merge "Update the colors of the tabs of work profile pagination" into sc-dev 2021-06-14 07:54:39 +00:00
Samuel Fufa
154ad76f40 Introduce inline education for work profile
Bug: 186857875
Test: local
Change-Id: I796b04fbb3ffc714a01104107774819d35034f93
2021-06-14 01:01:42 -05:00
Samuel Fufa
2f346b8666 Merge "[AllApps][Work] Introduce work toggle Fab" into sc-dev 2021-06-14 02:34:58 +00:00
Samuel Fufa
45e0e26971 [AllApps][Work] Introduce work toggle Fab
Screenshot: https://screenshot.googleplex.com/C4r7kKPxv3PKdyN
Bug: 186856928
Test: on-device
Change-Id: Ifd8ce20fcf2247a6e80537dc7631458e594a8a63
2021-06-13 20:01:20 -05:00
Winson Chung
beebc45e5d Merge "Add sdk check to recyclerviewfastscroller" into sc-dev 2021-06-13 03:13:49 +00:00
Stevie Kideckel
2f0c5ac3c8 Merge "Account for header margin depending on which header is selected" into sc-dev 2021-06-12 21:47:01 +00:00
Cyrus Boadway
f2ec20325b Merge "Add activity-start/return animation to widget configuration" into sc-dev 2021-06-12 17:15:11 +00:00
Cyrus Boadway
3616f29f83 Merge "Use the splash screen background color as the fallback background color" into sc-dev 2021-06-12 17:14:49 +00:00
TreeHugger Robot
76f5572648 Merge "Fix CellLayout cast exception when drag is canceled" into sc-dev 2021-06-12 12:24:06 +00:00
Jon Miranda
af6ebe87ea Do not add padding left/right when cell layout border spacing exists.
Bug: 188094809
Test: enable layout bounds and view text spanning entire cell
Change-Id: Ia7ed45d0e844b2594a8708e03fe385a321345f5e
2021-06-11 18:02:49 -07:00
Hyunyoung Song
ebd88cb00b Add sdk check to recyclerviewfastscroller
Bug: 189982238
Test: builds
Change-Id: I2298a67fd957cd2a77c8e5e4c34b828c044f1a61
2021-06-11 15:55:37 -07:00
Sunny Goyal
a7b018535b Ensure that the cancel and end listener are called when cancelling state animation
Bug: 190856140
Test: Manual
Change-Id: Ib6b869445cee9fad2a97a590d27429140f2b3ba9
2021-06-11 14:53:55 -07:00
Steven Ng
77a1393c44 Fix CellLayout cast exception when drag is canceled
Test: Long press a widget and then release when the resize frame is
      shown. Then, click the content of the widget to launch the
      widget's activity. Go back to home screen and then immediately
      long press the same widget again. No crash was observed.
Bug: 189814379
Change-Id: I4232ecf9d9d9efaba817b7777314f0814bb7ef21
2021-06-11 20:18:21 +01:00
Jonathan Miranda
d88f572864 Merge "Adding color back to popup container." into sc-dev 2021-06-11 17:16:27 +00:00
Hyunyoung Song
6e673c7ed8 Merge "Fix RecyclerViewFastScroller bugs, hide keyboard" into sc-dev 2021-06-11 16:45:23 +00:00
Hyunyoung Song
7cc29dc44d Fix RecyclerViewFastScroller bugs, hide keyboard
Bug: 189982238
Bug: 187561242
Bug: 187909098

Test: manual
Change-Id: I693810e5761004c48d028253c25a2fe96477af40
2021-06-11 09:43:10 -07:00
Stevie Kideckel
2dab912b95 Use LayoutManager.onLayoutCompleted as a signal that content has changed
onChildAttachedToWindow is called before the layout manager is finished
processing the layout, so incorrect measurements / intermediate
animation states can be present.

onLayoutCompleted occurs after each full layout calculation, including
measuring multiple views or animating, and is a better signal to use.

Fix: 190391539
Test: verified locally with search use case and other expand collapse
cases

Change-Id: If01caf33c6c3371636895e1361d80de536363239
2021-06-11 16:40:49 +00:00
Anton Hansson
17ef90b2cb Merge "Revert "[AllApps][Work] Introduce work toggle Fab"" into sc-dev 2021-06-11 15:02:25 +00:00
Anton Hansson
fc235903ab Revert "[AllApps][Work] Introduce work toggle Fab"
This reverts commit 08cca82eca.

Reason for revert: broke errorprone build
Bug: 190150515

Change-Id: I1d8707392310e745713b8780bdb957299b88a3a6
2021-06-11 14:05:07 +00:00
Jonathan Miranda
65c20f4a91 Merge "Folder preview polish." into sc-dev 2021-06-10 23:11:06 +00:00
Cyrus Boadway
2668e731a0 Add activity-start/return animation to widget configuration
When launching the configuration activity for a widget, use the
activity transition animation.

Test: manual
Bug: 190487998

Change-Id: Ife84e86eec74f81fecddce07c833356a7962fd4b
2021-06-10 21:37:04 +00:00
Cyrus Boadway
9f06168692 Use the splash screen background color as the fallback background color
For the widget transition animation fallback background color, use either
the splash screen background color if a task is starting or the task
description-attached background color.

With a background in place, allow the window to fully fade out before
fading in the widget, by moving the window alpha math into an animation
factory-specific implementation.

Bug: 187706750
Test: Manual
Change-Id: I2b5a7783b0585d447ad60534bc48d2e2176877ed
2021-06-10 21:03:24 +00:00
Alina Zaidi
1fbf9200f1 Merge changes I5d1c9e4b,I08154c94 into sc-dev
* changes:
  Flip ArrowTipView when it goes beyond screen height.
  Add more education tips for widgets. (3/3)
2021-06-10 20:46:20 +00:00
Santhosh Thangaraj
192924459b Fix the page number based Seen impression.
Test: On device.
Bug: 183117427
Change-Id: Ic1b11fb7630f60f11387951749420653aa3f0c8a
2021-06-10 20:44:09 +00:00
Jon Miranda
32ff76cb4e Adding color back to popup container.
For Color exctraction now occurs in groups:
- System shortcuts
- Deep shortcuts
- Notifications

For home setting popup, each DeepShortcutView will have its own
extracted color.

Bug: 188095443
Test: manual
Change-Id: I7e209f863ff180b8f017aeb2a73c6f1a51842e68
2021-06-10 19:15:24 +00:00
Steven Ng
d4bae086d3 Merge "Fix height estimation of the widgets recommendation table" into sc-dev 2021-06-10 18:11:45 +00:00
Steven Ng
bc5099e9a6 Fix height estimation of the widgets recommendation table
There are two vertical paddings
1. Table padding
2. Widget cell padding

We haven't taken account the widget cells padding

Test: Manual
Bug: 189814077
Change-Id: I9b1dc9e880d4402b9c461d0024a0748c0afc408a
2021-06-10 16:57:40 +01:00
Stevie Kideckel
1059c30f3a Account for header margin depending on which header is selected
This removes jitter from incorrectly counting or not the margins for the
headers near the top of the widget picker list.

Bug: 189956230
Test: verified locally
Change-Id: I3eeddbf8a1fb7cca31fe2a12c28b0eb444de631b
2021-06-10 15:29:46 +00:00
Alina Zaidi
dca47432fc Flip ArrowTipView when it goes beyond screen height.
Bug: 185354491
Test: Manually tested tips in widget picker, all apps, and
reconfigurable widgets tip.

Change-Id: I5d1c9e4b8bc3ae89834bc198016ffa409a2b28ad
2021-06-10 15:43:30 +01:00
Alina Zaidi
ecdf6575ec Add more education tips for widgets. (3/3)
Show tip on reconfigurable widget in launcher.

Bug: 185354491
Test: Manually tested tips in widget picker, all apps, and
reconfigurable widgets tip.

Change-Id: I08154c944285cac6a21c3ef4aafd878bbbccf44b
2021-06-10 14:23:47 +01:00
Takeshi Hagikura
43d53432aa Update the colors of the tabs of work profile pagination
Update the tab colors based on the discussion in the bug and the
design mock.
Rename the color/all_apps_tab_bg to
color/all_apps_tab_background_selected to make the usage of the color
explicit.
(Confirmed it's only used for the color of the selected tab)

Bug: 189488670
Test: Visual inspection
Change-Id: I6ac38f71a8dd8852e1ab2e70f2f8434e9101daa1
2021-06-10 18:55:59 +09:00
Hyunyoung Song
8f3d9eba02 Merge "Revert the squish translate from all apps" into sc-dev 2021-06-10 03:53:33 +00:00
Samuel Fufa
08cca82eca [AllApps][Work] Introduce work toggle Fab
Screenshot: https://screenshot.googleplex.com/C4r7kKPxv3PKdyN
Bug: 186856928
Test: on-device
Change-Id: I69ffa0ef367b182688e69c730fc9dee1afa7cadd
2021-06-09 17:13:07 +00:00
Jon Miranda
f564b65f2a Folder preview polish.
- Fixes notification dot not aligning in 4x5 grid
- Fixes clipping issues with large folders
- Fixes clipping issues with preview item animations

Bug: 188095988
Test: manual

Change-Id: I6821b3cb3c65e5928c7be1cddd7f292a37842698
2021-06-09 10:04:39 -07:00
Hyunyoung Song
afa327d176 Revert the squish translate from all apps
Bug: 189973274
Bug: 189975416

Test: manual, attached video on the bug
Change-Id: I881a2b79462e8d420b3dcb6a6b98adbe9e8e0394
2021-06-09 09:47:29 -07:00
TreeHugger Robot
962b212c9e Merge "Fix wrong highlighted personal | work tab" into sc-dev 2021-06-09 02:41:40 +00:00
TreeHugger Robot
93e232a57b Merge "Re-enable swipe up view inflation test." into sc-dev 2021-06-09 00:47:11 +00:00